Re: [Libreoffice] [PATCH] make STR_MERGE_NOTEMPTY more understandable

2011-11-10 Thread Eike Rathke
Hi,

On Wednesday, 2011-11-09 15:15:33 -0500, Kohei Yoshida wrote:

  Isn't Should the contents of all cells be concatenated and moved into
  the merged cell? better ?
 
 I like the following better:
 
 Do you want to merge the contents of the selected cells into one cell?
 Clicking 'No' will only retain the content of the upper-left cell.

I agree with the wording of the question, but will only retain to me
sounds as if the content of other cells would be lost, which isn't the
case, it's just not displayed and hidden in the merged cells. We also
should avoid terms like upper-left, as in a right-to-left environment it
would be the top right cell instead.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgpWP3vYbRZm8.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] make STR_MERGE_NOTEMPTY more understandable

2011-11-10 Thread Maxime de Roucy
Le mercredi 09 novembre 2011 à 15:15 -0500, Kohei Yoshida a écrit :
 On Wed, 2011-11-09 at 18:40 +0100, Maxime de Roucy wrote:
 
  Summary :
  Isn't Should the contents of all cells be concatenated and moved into
  the merged cell? better ?
 
 I like the following better:
 
 Do you want to merge the contents of the selected cells into one cell?
 Clicking 'No' will only retain the content of the upper-left cell.

I like it.

The merge word could be changed to concatenate which is more
precise ... but for me both are OK.

The end of the sentence into one cell could be removed since it a bit
obvious.

Do you want to (merge or concatenate) the contents of the selected
cells (into one cell or nothing) ?
Clicking 'No' will only retain the content of the upper-left cell.

What do you think ?

-- 
Maxime de Roucy
Groupe LINAGORA - OSSA
80 rue Roque de Fillol
92800 PUTEAUX 
Tel. : 0 810 251 251


signature.asc
Description: This is a digitally signed message part
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] make STR_MERGE_NOTEMPTY more understandable

2011-11-10 Thread Regina Henschel

Hi,

Maxime de Roucy schrieb:

Le mercredi 09 novembre 2011 à 15:15 -0500, Kohei Yoshida a écrit :

On Wed, 2011-11-09 at 18:40 +0100, Maxime de Roucy wrote:


Summary :
Isn't Should the contents of all cells be concatenated and moved into
the merged cell? better ?


I like the following better:

Do you want to merge the contents of the selected cells into one cell?
Clicking 'No' will only retain the content of the upper-left cell.


I like it.

The merge word could be changed to concatenate which is more
precise ... but for me both are OK.

The end of the sentence into one cell could be removed since it a bit
obvious.

Do you want to (merge or concatenate) the contents of the selected
cells (into one cell or nothing) ?
Clicking 'No' will only retain the content of the upper-left cell.

What do you think ?


Clicking 'No' will only retain the content of the upper-left cell.

That is wrong. The content remains in the hidden cells and can still be 
used in formulas. That is a used feature, when you will show a different 
content to the user than you need for calculation.


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] make STR_MERGE_NOTEMPTY more understandable

2011-11-10 Thread Bjoern Michaelsen
Hi all,

Isnt this something for ux-advise?

Best,

Bjoern

On Thu, Nov 10, 2011 at 11:22:27AM +0100, Regina Henschel wrote:
 Hi,
 
 Maxime de Roucy schrieb:
 Le mercredi 09 novembre 2011 à 15:15 -0500, Kohei Yoshida a écrit :
 On Wed, 2011-11-09 at 18:40 +0100, Maxime de Roucy wrote:
 
 Summary :
 Isn't Should the contents of all cells be concatenated and moved into
 the merged cell? better ?
 
 I like the following better:
 
 Do you want to merge the contents of the selected cells into one cell?
 Clicking 'No' will only retain the content of the upper-left cell.
 
 I like it.
 
 The merge word could be changed to concatenate which is more
 precise ... but for me both are OK.
 
 The end of the sentence into one cell could be removed since it a bit
 obvious.
 
 Do you want to (merge or concatenate) the contents of the selected
 cells (into one cell or nothing) ?
 Clicking 'No' will only retain the content of the upper-left cell.
 
 What do you think ?
 
 Clicking 'No' will only retain the content of the upper-left cell.
 
 That is wrong. The content remains in the hidden cells and can still
 be used in formulas. That is a used feature, when you will show a
 different content to the user than you need for calculation.
 
 Kind regards
 Regina
 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] make STR_MERGE_NOTEMPTY more understandable

2011-11-10 Thread Maxime de Roucy
 I agree with the wording of the question, but will only retain to me
 sounds as if the content of other cells would be lost, which isn't the
 case, it's just not displayed and hidden in the merged cells. We also
 should avoid terms like upper-left, as in a right-to-left environment
it
 would be the top right cell instead.

 The content remains in the hidden cells and can still be 
 used in formulas. That is a used feature, when you will show a different 
 content to the user than you need for calculation.

I didn't know that.. sorry, now I understand.

Then what do you think about :
Should the contents of all cells be concatenated and moved into the
first cell ?
When clicking 'No' the contents of the hidden cells will remains and can
still be used in formulas.

-- 
Maxime de Roucy
Groupe LINAGORA - OSSA
80 rue Roque de Fillol
92800 PUTEAUX 
Tel. : 0 810 251 251


signature.asc
Description: This is a digitally signed message part
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] make STR_MERGE_NOTEMPTY more understandable

2011-11-10 Thread Kevin Hunter

At 3:15pm -0500 Wed, 09 Nov 2011, Kohei Yoshida wrote:

On Wed, 2011-11-09 at 18:40 +0100, Maxime de Roucy wrote:

Summary :
Isn't Should the contents of all cells be concatenated and moved
into the merged cell? better ?


I like the following better:

Do you want to merge the contents of the selected cells into one
cell? Clicking 'No' will only retain the content of the upper-left
cell.

And I agree that the current message is very awkward.


Heh, having run into that message more than few times in the past month, 
I, too, agree about its awkwardness.  One more suggestion from the 
peanut gallery:


Don't use No and Yes, but rather something more action-oriented, 
like Merge cells and Cancel.  Jeff Waugh had an excellent 
presentation and visual (circa 2006/7) to show what the user sees, but 
of course my google is poor this evening. The summary is The entire 
dialog box is blurred/not readable, and the only visible parts are the 
buttons; the user should still be able to discern what action each 
button executes.


That said, I'm clearly not a UI fella, and it was suggested elsewhere in 
this thread that this might be a UI issue ...


Cheers,

Kevin
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [PATCH] make STR_MERGE_NOTEMPTY more understandable

2011-11-09 Thread Eike Rathke
Hi Maxime,

On Monday, 2011-11-07 10:58:13 +0100, Maxime de Roucy wrote:

 I think the STR_MERGE_NOTEMPTY (in sc/source/ui/src/globstr.src ; used
 in Calc when merging cells) is not very understandable for common
 users : Should the contents of the hidden cells be moved into the first
 cell?
 
 I think Would you like to merge the contents of all cells? would be 
 better.

I agree that the dialog's current message maybe isn't the best. A new
string however should somehow describe that when the question is
answered with yes then
* all content of to be merged cells will be removed
* all content will be concatenated
* this new concatenated content will be placed into the first cell of
  the merged cells

merge contents of all cells lacks information, my suggestion would be

Should the contents of all merged cells be concatenated and moved into the 
first cell?

What do you think?

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgpKAFkQRwhoH.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [PATCH] make STR_MERGE_NOTEMPTY more understandable

2011-11-07 Thread Maxime de Roucy
Hello

I think the STR_MERGE_NOTEMPTY (in sc/source/ui/src/globstr.src ; used
in Calc when merging cells) is not very understandable for common
users : Should the contents of the hidden cells be moved into the first
cell?

I think Would you like to merge the contents of all cells? would be 
better.

This is my first contribution to libreoffice, feel free to tell me if I
did something wrong.

Thank you in advance.

-- 
Maxime de Roucy
Groupe LINAGORA - OSSA
80 rue Roque de Fillol
92800 PUTEAUX 
Tel. : 0 810 251 251
From 4d16dac1ec999a458692336f936adf3959d93f82 Mon Sep 17 00:00:00 2001
From: Maxime de Roucy maxime.dero...@gmail.com
Date: Mon, 7 Nov 2011 10:55:08 +0100
Subject: [PATCH] Make STR_MERGE_NOTEMPTY more understandable

Change of the STR_MERGE_NOTEMPTY in sc/source/ui/src/globstr.src in
order to make the merge cells question clearer.
---
 sc/source/ui/src/globstr.src |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sc/source/ui/src/globstr.src b/sc/source/ui/src/globstr.src
index 9a1a42f..7f6f874 100644
--- a/sc/source/ui/src/globstr.src
+++ b/sc/source/ui/src/globstr.src
@@ -935,7 +935,7 @@ Resource RID_GLOBSTR
 };
 String STR_MERGE_NOTEMPTY
 {
-Text [ en-US ] = Should the contents of the hidden cells be moved into the first cell? ;
+Text [ en-US ] = Would you like to merge the contents of all cells?;
 };
 String STR_CELL_FILTER
 {
-- 
1.7.7.2



signature.asc
Description: This is a digitally signed message part
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice