Re: [Libreoffice] [PUSHED] String::CompareIngoreCaseToAscii

2011-10-24 Thread Noel Power
On 21/10/11 16:04, Michael Meeks wrote: Hi August, Well - of course, it'd be nice to have some more complex tests of StarBasic (and VBA) macros, potentially loaded from .bas files inside a unit test. Noel - do you have any really nasty syntax / built-in basic functionality

Re: [Libreoffice] [PUSHED] String::CompareIngoreCaseToAscii

2011-10-23 Thread Stephan Bergmann
On 10/21/2011 10:17 PM, Michael Meeks wrote: On Fri, 2011-10-21 at 18:16 +0200, Stephan Bergmann wrote: Unfortunately, this breaks the build, as basic now has a (missing) dependency on sfx2, which already depends on basic. Fair enough, my mistake. I dropped sfx from the link line,

[Libreoffice] [PUSHED] String::CompareIngoreCaseToAscii

2011-10-21 Thread Michael Meeks
Hi August, On Thu, 2011-10-20 at 15:01 -0400, August Sodora wrote: On Tue, Oct 18, 2011 at 3:01 PM, August Sodora aug...@gmail.com wrote: I've attached a new patch that includes some tests for the BASIC scanner. Most of the test cases are just to get an idea of how the scanner handles

Re: [Libreoffice] [PUSHED] String::CompareIngoreCaseToAscii

2011-10-21 Thread August Sodora
Thanks to all for being so patient with me! Would it be worthwhile to continue working on the mess that is scanner/tokenizer/parser (why do they inherit from eachother?!) in basic? I'm also curious about VBA support and whether there exists a grammar or similar documentation for the StarBASIC

Re: [Libreoffice] [PUSHED] String::CompareIngoreCaseToAscii

2011-10-21 Thread Michael Meeks
Hi August, On Fri, 2011-10-21 at 08:50 -0400, August Sodora wrote: Thanks to all for being so patient with me! Would it be worthwhile to continue working on the mess that is scanner/tokenizer/parser (why do they inherit from eachother?!) in basic? I'm also curious about VBA support and

Re: [Libreoffice] [PUSHED] String::CompareIngoreCaseToAscii

2011-10-21 Thread Markus Mohrhard
Hello Michael, August, 2011/10/21 Michael Meeks michael.me...@suse.com: Hi August, On Fri, 2011-10-21 at 08:50 -0400, August Sodora wrote: Thanks to all for being so patient with me! Would it be worthwhile to continue working on the mess that is scanner/tokenizer/parser (why do they inherit

Re: [Libreoffice] [PUSHED] String::CompareIngoreCaseToAscii

2011-10-21 Thread Stephan Bergmann
On 10/21/2011 11:13 AM, Michael Meeks wrote: Hi August, On Thu, 2011-10-20 at 15:01 -0400, August Sodora wrote: On Tue, Oct 18, 2011 at 3:01 PM, August Sodoraaug...@gmail.com wrote: I've attached a new patch that includes some tests for the BASIC scanner. Most of the test cases are just to

Re: [Libreoffice] [PUSHED] String::CompareIngoreCaseToAscii

2011-10-21 Thread Jan Holesovsky
Hi August, Michael, Michael Meeks píše v Pá 21. 10. 2011 v 10:13 +0100: Ooh ! :-) this is really nice. I was previously fooled by the subject into not noticing that this was some sexy code cleanup + unit testing patch. Michael - thank you a lot for pushing this, and sorry, August, that

Re: [Libreoffice] [PUSHED] String::CompareIngoreCaseToAscii

2011-10-21 Thread Michael Meeks
On Fri, 2011-10-21 at 18:16 +0200, Stephan Bergmann wrote: Unfortunately, this breaks the build, as basic now has a (missing) dependency on sfx2, which already depends on basic. Fair enough, my mistake. I dropped sfx from the link line, it's not actually required, leaving the link