Hi Kohei,
On Mon, 2011-07-18 at 16:57 -0400, Kohei Yoshida wrote:
Just to tone down this statistics a bit. The vast majority of changes
are in fact code relocations with no changes e.g. the change in
rectangle_set is purely moving code from one file to another.
:-) Any chance of a
Hi guys,
On Tue, 2011-07-19 at 10:13 +0100, Michael Meeks wrote:
Having said that - I'm not a pure PITA if there is an accurate and
complete patch of what actually changed here to review - then we can
review it - but I'm not a fan of approving big, confused, un-quantified
changes at
On Thu, 2011-07-14 at 10:31 +0200, David Tardon wrote:
Nitpick, unrelated to the review: you may want to disable operator= for
storage_filled_linear (and storage_filled_nested_array too), because its
use would cause double delete.
Good point. Done (on master for the next release). Thanks
Hi there,
On Fri, 2011-07-15 at 00:55 +0200, Markus Mohrhard wrote:
So one review needed to get it into 3.4.2. It is an quite important
fix as we got several reports where people reported they thought that
calc froze and switched back to 3.3.2.
So:
git diff --numstat 0_5_2..0_5_3 #
Hello Michael, Kohei,
I feel extremely uncomfortable (personally) introducing a couple of
thousands of LOC change between RC1 and final for 3.4.2. We're in a
triple review mode because our changes will not get much testing before
they are unleashed on tens of thousands of new people per
On Mon, 2011-07-18 at 15:53 +0100, Michael Meeks wrote:
Hi there,
On Fri, 2011-07-15 at 00:55 +0200, Markus Mohrhard wrote:
So one review needed to get it into 3.4.2. It is an quite important
fix as we got several reports where people reported they thought that
calc froze and switched
On Wed, Jul 13, 2011 at 11:15:33PM -0400, Kohei Yoshida wrote:
Hi there,
I'd like to update mdds to 0.5.3 for the -3-4 branch and preferably the
-3-4-2 branch as well. The attached patches would make that happen.
That should improve the performance issue raised in
It looks sane too me, too. I build with it and tested with some of the test
documents and had a quick look at the patches for 0.5.3. I hope that this is
enough for an external lib.
So one review needed to get it into 3.4.2. It is an quite important fix as
we got several reports where people
