[Libreoffice] Tests on release build
Hello guys, as again there is new series of lo it means more tests were added to the list of those that are run during the make phase (where normal software do only build). For developers it helps to identify issues quickly because your build crashes if you try to compile your changes but for users that try to build the lo just for themselves the crashes can get really annoying. Even that is not much of a problem as distributions usually provide binaries that were once build so they do not run the tests for each various hw/cflags/march/etc etc, sadly I am working on Gentoo, which means I do get bazilion of bugs for failing tests that are not reproducable on most machines. Small list of bugs from experimental branch after two days (meaning not much people using it and those errors will just grow as it moves to stable): https://bugs.gentoo.org/show_bug.cgi?id=394659 https://bugs.gentoo.org/show_bug.cgi?id=394615 https://bugs.gentoo.org/show_bug.cgi?id=394767 So unless you can look at one of those traces and tell me that the build should be stopped because it is obvious error in the code (not in the test, the app code) that needs to be fixed I would want you guys to rethink running the tests for release build during the make phase and just allow me to run them in designated test phase where it is allowed to fail and wont stop user from installing the office suite. (Yes those errors are logged, yes I will provide them, and yes user will be able to use his office suite and not wait on some test fixes) This is quite critical issue for packaging in Gentoo and I would love to fix it some other way than implementing cppunit hack that would return true on each test so users will be able to install their package... Cheers Tom ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tests on release build
On 12/15/2011 10:58 AM, Tomáš Chvátal wrote: So unless you can look at one of those traces and tell me that the build should be stopped because it is obvious error in the code (not in the test, the app code) that needs to be fixed I would want you Hard to tell without a backtrace. guys to rethink running the tests for release build during the make phase and just allow me to run them in designated test phase where it is allowed to fail and wont stop user from installing the office suite. (Yes those errors are logged, yes I will provide them, and yes user will be able to use his office suite and not wait on some test fixes) IIUC, make build will omit the checks (and make unitcheck will execute them). Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tests on release build
2011/12/15 Stephan Bergmann sberg...@redhat.com: On 12/15/2011 10:58 AM, Tomáš Chvátal wrote: So unless you can look at one of those traces and tell me that the build should be stopped because it is obvious error in the code (not in the test, the app code) that needs to be fixed I would want you Hard to tell without a backtrace. Thats the problem these things do not crash when run in the submodule attached to gdb. IIUC, make build will omit the checks (and make unitcheck will execute them). Stephan That would be awesome to see implemented. Tom ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tests on release build
On Thu, Dec 15, 2011 at 12:49:41PM +0100, Tomáš Chvátal wrote: IIUC, make build will omit the checks (and make unitcheck will execute them). (for gbuildified modules, build.pl modules will still run tests) Stephan That would be awesome to see implemented. It is (unless I broke it with the last major gbuild -- it should be easy to fix then). That said, I really have a bad feeling about letting end users compile distro builds without running these tests -- the last thing we need is additional bugzilla workload by builds that should never have finished/installed. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tests on release build
2011/12/15 Bjoern Michaelsen bjoern.michael...@canonical.com:
It is (unless I broke it with the last major gbuild -- it should be easy to
fix
then). That said, I really have a bad feeling about letting end users compile
distro builds without running these tests -- the last thing we need is
additional bugzilla workload by builds that should never have
finished/installed.
Looks like it is broken then :)
As the crashes are in tail-build so gbuildified and i run this in the package:
458 src_compile() {
459 # this is not a proper make script and the jobs are passed
during configure
460 make build || die
461 }
462
463 src_test() {
464 make check || die
465 }
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
