Re: [PUSHED] fdo#62096: [cleanup] Replaced some compareTo with '=='

2013-04-10 Thread Miklos Vajna
Hi Prashant, On Wed, Apr 10, 2013 at 06:04:50AM +0530, Prashant Pandey prashant3.yi...@gmail.com wrote: I've attached a patch to get it reviewed.This patch implies some cleanup in concern with bug#62096: Replace compareTo with '==' This patch breaks the build here:

Re: [PUSHED] fdo#62096: [cleanup] Replaced some compareTo with '=='

2013-04-10 Thread Prashant Pandey
Hi Miklos, Please, in the future, at least build-test your patch. Regrets for the same. This was the first time I didn't buid test as I thought I merely replaced some 'compareTo' by '==' so I 'assumed' it should not be a problem. I ensure you, this was my last time I did this mistake. For now,