Re: Gerrit supports inline edit feature now

[Chris Sherlock]

Agreed - thanks a bunch, I really appreciate the efforts you all put into 
maintaining and improving our gerrit and Jenkins experiences :-)

Chris

> On 8 Mar 2016, at 4:23 AM, Thorsten Behrens  
> wrote:
> 
> David Ostrovsky wrote:
>> Yesterday, the right Gerrit version was deployed on gerrit.l.o.
>> 
> Thanks a whole lot - to all of you for making this happen in the end.
> 
> Way cool! :)
> 
> Cheers,
> 
> -- Thorsten
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Gerrit supports inline edit feature now

[Thorsten Behrens]

David Ostrovsky wrote:
> Yesterday, the right Gerrit version was deployed on gerrit.l.o.
> 
Thanks a whole lot - to all of you for making this happen in the end.

Way cool! :)

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Gerrit supports inline edit feature now

[David Ostrovsky]

More than one year has passed since my announcement on this list: [1]
that upstream Gerrit supports inline edit feature, meant changing the
code directly in browser without clonning/fetching anything. Yesterday,
the right Gerrit version was deployed on gerrit.l.o.

Meantime, inline edit feature supports different workflows and
navigation to the integrated editor with syntax highlighting is offered
on many places in the UI. This documentation page: [2] was added to
Gerrit that is dedicated to inline edit feature. I also gave a talk
during FOSDEM 2015 and last Hamburg hackathon how to use this feature:
[3]. (Note, that not all features, mentioned in this talk are supported
on 2.11.7 version deployed on gerrit.l.o. Some of them only available
on recent released gerrit version, 2.12.1, or even master).

[1] https://lists.freedesktop.org/archives/libreoffice/2014-December/06
5326.html
[2] https://gerrit.libreoffice.org/Documentation/user-inline-edit.html
[3] http://ostrovsky.org/gerrit/gerrit-inline-edit
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Gerrit supports inline edit feature now

[Stephan Bergmann]

On 12/18/2014 12:44 PM, Michael Stahl wrote:

i disagree with your assessment of the feature.  it will make things
easier for reviewers,  because if you spot a trivial typo in a patch you
can just quickly fix it, you don't have to decide between downloading
the patch and editing it offline and pushing it manually, or adding a
comment and then waiting for the submitter to upload a new version of
the patch and get 4 email notifications about it and review it again.


...and the submitter unhelpfully rebasing the patch between uploads, so 
you can't even easily find out whether indeed only the trivial typo was 
fixed.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Gerrit supports inline edit feature now

[Michael Stahl]

On 18.12.2014 11:55, Markus Mohrhard wrote:
> Hey,
> 
> On Thu, Dec 18, 2014 at 11:47 AM, Bjoern Michaelsen
>  > wrote:
> 
> Hi,
> 
> On Thu, Dec 18, 2014 at 10:19:08AM +, Michael Meeks wrote:
> > - // that sounds like a stupid idea
> > + // actually this is really cool for small changes
> >
> >   Also - we have various solutions to allow central compilation 
> coming -
> > right.
> >
> >   ;-)
> 
> Yes, inline editing is an important and cool thing. If our workflow
> cant handle
> that, we need to adapt it (e.g. more, earlier CI and unittests) not
> the other
> way around. ;)
> 
> 
> It is not that easy. This feature shifts some of the work from the
> developer to the reviewer. IMHO our reviewers are already one of the
> weakest link in our development process as reviewing is normally only
> done by the people who have been working on the code for a long time and
> know the code quite well.
> 
> I'd like to see solutions that shift work from these people and make it
> easier for new reviewers to come in and not make their job more complex
> and more demanding.

i disagree with your assessment of the feature.  it will make things
easier for reviewers,  because if you spot a trivial typo in a patch you
can just quickly fix it, you don't have to decide between downloading
the patch and editing it offline and pushing it manually, or adding a
comment and then waiting for the submitter to upload a new version of
the patch and get 4 email notifications about it and review it again.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Gerrit supports inline edit feature now

[Bjoern Michaelsen]

Hi,

On Thu, Dec 18, 2014 at 11:55:35AM +0100, Markus Mohrhard wrote:
> IMHO our reviewers are already one of the weakest link in our development
> process as reviewing is normally only done by the people who have been
> working on the code for a long time and know the code quite well.

So, if reviewers are the bottleneck, how do we create more reviewers? Would
e.g. generating more contributors help there?

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Gerrit supports inline edit feature now

[Markus Mohrhard]

Hey,

On Thu, Dec 18, 2014 at 11:47 AM, Bjoern Michaelsen <
bjoern.michael...@canonical.com> wrote:
>
> Hi,
>
> On Thu, Dec 18, 2014 at 10:19:08AM +, Michael Meeks wrote:
> > - // that sounds like a stupid idea
> > + // actually this is really cool for small changes
> >
> >   Also - we have various solutions to allow central compilation
> coming -
> > right.
> >
> >   ;-)
>
> Yes, inline editing is an important and cool thing. If our workflow cant
> handle
> that, we need to adapt it (e.g. more, earlier CI and unittests) not the
> other
> way around. ;)
>
>
It is not that easy. This feature shifts some of the work from the
developer to the reviewer. IMHO our reviewers are already one of the
weakest link in our development process as reviewing is normally only done
by the people who have been working on the code for a long time and know
the code quite well.

I'd like to see solutions that shift work from these people and make it
easier for new reviewers to come in and not make their job more complex and
more demanding.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Gerrit supports inline edit feature now

[Bjoern Michaelsen]

Hi,

On Thu, Dec 18, 2014 at 10:19:08AM +, Michael Meeks wrote:
> - // that sounds like a stupid idea
> + // actually this is really cool for small changes
> 
>   Also - we have various solutions to allow central compilation coming -
> right.
> 
>   ;-)

Yes, inline editing is an important and cool thing. If our workflow cant handle
that, we need to adapt it (e.g. more, earlier CI and unittests) not the other
way around. ;)

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Gerrit supports inline edit feature now

[Michael Meeks]

On Thu, 2014-12-18 at 10:49 +0100, Miklos Vajna wrote:
> On Thu, Dec 18, 2014 at 09:34:24AM +0100, David Ostrovsky 
>  wrote:
> > I am looking forward to see Gerrit @ LibreOffice upgraded to upcoming
> > 2.11 release that contains inline edit feature.
> 
> We expect that contributors build their changes, test it manually and
> also run the unit tests before submitting. How the inline edit mode make
> that possible?

-   // that sounds like a stupid idea
+   // actually this is really cool for small changes

Also - we have various solutions to allow central compilation coming -
right.

;-)

Michael.

-- 
 michael.me...@collabora.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Gerrit supports inline edit feature now

[Miklos Vajna]

Hi David,

On Thu, Dec 18, 2014 at 09:34:24AM +0100, David Ostrovsky  
wrote:
> I am looking forward to see Gerrit @ LibreOffice upgraded to upcoming
> 2.11 release that contains inline edit feature.

We expect that contributors build their changes, test it manually and
also run the unit tests before submitting. How the inline edit mode make
that possible?

Regards,

Miklos


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Gerrit supports inline edit feature now

[David Ostrovsky]

I am pleased to announce that last major changes in inline edit series
were merged upstream [1]. Gerrit supports now 100% browser based
workflow.

That means you can add new empty change directly in browser (no need to
clone anything) and populate it in CodeMirror JS editor with syntax
highlighting and publish the change. Here are some screen shots for
Gerrit in edit mode (of course, Emacs key map is supported ;-) [2], [3].

Existing changes in Gerrit can be amended directly in browser:

* added files can be removed
* removed files can be restored
* existing files can be changed
* new files can be added

See also this discussion on gerrit dev ML [4].

It took almost two years to implement this feature, and i attended three
Gerrit hackathons for that, in London, Mountain View and Berlin. I
already said it in my blog, but let me repeat it here again: Big thank
to The Document Foundation for sponsoring my travel costs for Gerrit
hackathon in Mountain View!

I am looking forward to see Gerrit @ LibreOffice upgraded to upcoming
2.11 release that contains inline edit feature.

[1] https://gerrit-review.googlesource.com/#/q/status:merged
+project:gerrit+branch:master+topic:inline-3
[2] http://imgur.com/ISNreVU
[3] http://imgur.com/8wCGA8D
[4]
https://groups.google.com/d/topic/repo-discuss/20ge_59v3WI/discussion


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice