Re: Week 5 - update
On 7/16/22 18:59, Hannah Meeks wrote: One of the most useful things I did was in vcl/source/window/dialog.cxx - Dialog::ImplStartExecute - where I swapped the dialog "cancelled in silent mode" to a SAL_DEBUG so that I can see basic errors. This would be good to have on all unit tests so that when they fail randomly there is a clear reason why. In SAL_INFO( "vcl", "Dialog \"" << ImplGetDialogText(this) << "\"cancelled in silent mode"); replace the SAL_INFO with a SAL_WARN, so that it gets emitted by default (in --enable-sal-log builds)? That sounds useful.
Week 5 - update
Hi, This week I managed to finish making the framework in order to run my tests - https://gerrit.libreoffice.org/c/core/+/136943 Still had some problems with the debugger but this was resolved after moving the python warnings around - https://gerrit.libreoffice.org/c/core/+/137032 One of the most useful things I did was in vcl/source/window/dialog.cxx - Dialog::ImplStartExecute - where I swapped the dialog "cancelled in silent mode" to a SAL_DEBUG so that I can see basic errors. This would be good to have on all unit tests so that when they fail randomly there is a clear reason why. Managed to upload most of my macros tests and try these in writer, two objects - Word and Sentence are not implemented in writer so the plan is to do this at some point in the next few weeks then run the tests - https://gerrit.libreoffice.org/c/core/+/137105 Testing with ParagraphFormat lots of properties/attributes are missing so will try to add some of those next week in order for tests to pass. Had some problems with ActiveDocument.Select not working in writer so fixed this by adding the select method to the Document object - https://gerrit.libreoffice.org/c/core/+/137109 I updated XRange to include Find - https://gerrit.libreoffice.org/c/core/+/137004 Got a bit confused with what was happening with the selection on the find object so wrote some more tests to look at this in word - seemingly Selection.Find.Execute creates the selection (if nothing was selected previously) or it makes a range to do the find and replace on and then returns a new selection depending on find settings. I tried to have a look at this in sw/source/ui/vba/vbaselection.cxx but hopefully will fix it by next week. Hannah
Week #4 and Week #5 Update - Sidebar
Hi everyone, As I mentioned earlier, at the end of week 3, me and my mentors realized that our approach of adding a second panel for CharacterStyles below the panel of ParagraphStyles would make templdlg.cxx's code much more complex and less maintainable in the future. Hence we decided to introduce a StyleList control. In the middle of week 4, we had more meetings, where we discussed more about the approach, as initially it was a bit unclear to me.Then I started working on the implementation. Then at the end of week 4, a nightmare came. Due to windows updates, the project wasn't building on my laptop. Me and my mentors tried to resolve it, but it didn't work. Then I had to switch to another old laptop for the completion of my work. The old laptop wasn't fast enough to build the project in a few hours. It was built in about 1.5 days. In week 5, I totally worked on the implementation of the StyleList control. Here is a link to my project : https://gerrit.libreoffice.org/c/core/+/117918 Initially I thought that the project was not building on my laptop because the windows installation was faulty. Hence I bought a new laptop, to see if the installation succeeded on that. But it didn't succeed. This is how I came to know, that currently some windows updates are going on with which LibreOffice is incompatible. Currently, I have introduced StyleList control. Our next step will be to reuse my old patch (https://gerrit.libreoffice.org/c/core/+/116340) , to place Character Styles under Paragraph Styles. However, this time the implementation will be much more simpler due to the introduction of StyleList control. Last, but not the least, I would like to thank my mentors for supporting me throughout this whole process. Thankyou all Regards Anshu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
