[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

2018-01-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114939 Michael Stahl changed: What|Removed |Added CC||t...@libreoffice.org A

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

2018-01-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #15 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=efc06e9bb696110350ab3e14344de53db992280e tdf#11

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

2018-01-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #13 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=50382b9e9256d7361e3770daa654fb8d09448635 tdf#11

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

2018-01-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #14 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9ef1734f03a008545a01fd394dd0e979bb230a0f tdf#11

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

2018-01-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #12 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9188ea83c346fdc2f668178ae7538665a1b09c02 tdf#11

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

2018-01-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #11 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0b7c3b7d9fa71f59eed75c3e80e5e12245c5e1c5 tdf#11

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

2018-01-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114939 Michael Stahl changed: What|Removed |Added CC||mst...@redhat.com Whiteb

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

2018-01-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #10 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f66fbd947f70f6be6b22ab372facaeb9e2fb63ae tdf#11

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

2018-01-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #9 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=162ffd57de49b1f007b88fb247a592acbac0aaf7 (relate

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

2018-01-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114939 Commit Notification changed: What|Removed |Added Whiteboard||target:6.1.0 -- You are r

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

2018-01-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #8 from JimF --- I am not able to write a review, but I too (as did Michael Stahl) would fail the code review. The code is fine, BUT since this function is used in the ODF encryption scheme, all files current users have saved

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

2018-01-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #7 from JimF --- To me, that patch looks good, and the test case is a 52 byte value, which was one of the lengths which would trigger this bug. NOTE, I am almost certain that the MD5 hash has the exact same bug. Both MD5 and

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

2018-01-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114939 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

2018-01-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #5 from JimF --- The legacy busted code on import sounds correct. As long as it is only used upon a hash failure and upon any write the correct code is used to update the file. but that is way beyond the scope of my knowledg

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

2018-01-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #4 from Mike Kaganski --- Or keep both for import, trying old code in case correct one fails, but only write correct. -- You are receiving this mail because: You are the assignee for the bug._

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

2018-01-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #3 from Mike Kaganski --- ... and that data will fail to be interoperable with other compliant suites. I suppose we should simply fix it and make a notice to use older versions in case of problematic data -- You are receivi

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

2018-01-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114939 --- Comment #2 from JimF --- Looking at the endMD5(), I am almost certain it has the same bug. the bug comes from incrementing the i variable to point past the end of the non-null data in the limb, and then comparing it to make sure ther

[Libreoffice-bugs] [Bug 114939] SHA1 code has an off by 1 bug

2018-01-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114939 Caolán McNamara changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0