[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 Stéphane Guillou (stragu) changed: What|Removed |Added See Also|

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 Xisco Faulí changed: What|Removed |Added CC||fpwerkst...@gmail.com --- Comment

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 Adolfo Jayme changed: What|Removed |Added Whiteboard|target:6.1.0 target:6.0.3

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #51 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "libreoffice-6-0-3":

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 Commit Notification changed: What|Removed |Added Whiteboard|target:6.1.0

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #50 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "libreoffice-6-0":

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #49 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "master":

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #48 from Luke --- Jan-Marek Glogowski, After the fix for this, I'm getting the following build failure with a 'make check' under windows: https://pastebin.com/iMJq68V3 after your fix for this bug, --

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 Jan-Marek Glogowski changed: What|Removed |Added Status|NEW

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #47 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "libreoffice-6-0":

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 Commit Notification changed: What|Removed |Added Whiteboard|target:6.1.0

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #46 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "master":

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 Commit Notification changed: What|Removed |Added Whiteboard|

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #45 from Jan-Marek Glogowski --- (In reply to Aron Budea from comment #44) > (In reply to Jan-Marek Glogowski from comment #43) > > Some patches based on Michaels comment #39 > >

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #44 from Aron Budea --- (In reply to Jan-Marek Glogowski from comment #43) > Some patches based on Michaels comment #39 > https://gerrit.libreoffice.org/#/c/50908 Built master with the patches, and it's

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #43 from Jan-Marek Glogowski --- Some patches based on Michaels comment #39 https://gerrit.libreoffice.org/#/c/50908 -- You are receiving this mail because: You are the assignee for the

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #42 from Jan-Marek Glogowski --- (In reply to Michael Meeks from comment #39) > Hmm - then again ... looking at the code: > > vcl/win/window/salframe.cxx > > It puzzles me: > >

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #41 from Michael Meeks --- Can you get a trace for that assertion failure ? looks odd =) thanks ! -- You are receiving this mail because: You are the assignee for the

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #40 from Aron Budea --- (In reply to Michael Meeks from comment #39) > Thoughts much appreciated; I append a blind fix in case someone can > reproduce this and can compile that. After applying the patch,

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #39 from Michael Meeks --- Hmm - then again ... looking at the code: vcl/win/window/salframe.cxx It puzzles me: WinSalFrame::~WinSalFrame() { // Release Cache DC if ( mpGraphics2 &&

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #38 from Michael Meeks --- Presumably the OpenGLSalGraphicsImpl (and other SalGraphicsImpls too) - and its associated WinSalGraphics survives longer than the SalGeometryProvider which is either a

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 Julien Nabet changed: What|Removed |Added CC|

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #36 from Michael Meeks --- Hi Mike; thanks for that - a valgrind trace would perhaps show where the data was allocated - but I guess just code reading around the lifecycle of the flush handler and

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #35 from Mike Kaganski --- Anyway it looks strange that the event objects aren't ref-counted, and not interlocked for the duration of execution. The OpenGLFlushIdle object is created in

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #34 from Mike Kaganski --- (In reply to Mike Kaganski from comment #33) > I have examined > the console output to see a number of OpenGLFlushIdle objects that got > constructed prior to the

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #33 from Mike Kaganski --- (In reply to Jan-Marek Glogowski from comment #30) > From the backtrace I guess we schedule an flush on the dialog, which is gone > at this point. The OpenGLFlushIdle

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 V Stuart Foote changed: What|Removed |Added See Also|https://bugs.documentfounda |

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 V Stuart Foote changed: What|Removed |Added See Also|https://bugs.documentfounda |

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 V Stuart Foote changed: What|Removed |Added CC|

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 Aron Budea changed: What|Removed |Added Blocks||93529 ---

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 Xisco Faulí changed: What|Removed |Added See Also|

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #30 from Jan-Marek Glogowski --- I can't reproduce this, because I'm running Windows in a KVM without OpenGL, and the crash is OpenGL related. >From the backtrace I guess we schedule an flush on the

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 Xisco Faulí changed: What|Removed |Added Priority|medium

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 Telesto changed: What|Removed |Added See Also|

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #29 from Michael Meeks --- Aron's analysis is basically right =) we invoke a virtual function call on an already deleted instance of the mpProvider - clearly the way the lifecycle of that and the

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #28 from Aron Budea --- (In reply to Julien Nabet from comment #27) > I agree with you but why you're talking about deleting an object here? > Indeed, > https://opengrok.libreoffice.org/ >

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #27 from Julien Nabet --- (In reply to Aron Budea from comment #26) > ... > Deleting an object doesn't set its pointers scattered in the code to nullptr. I agree with you but why you're talking about

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #26 from Aron Budea --- (In reply to Julien Nabet from comment #24) > (In reply to Aron Budea from comment #23) > >... > > bool IsOffscreen() const { return mpProvider == nullptr || > >

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 Aron Budea changed: What|Removed |Added Crash report or|["google_breakpad::Exceptio

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #24 from Julien Nabet --- (In reply to Aron Budea from comment #23) >... > bool IsOffscreen() const { return mpProvider == nullptr || > mpProvider->IsOffScreen(); } > > mpProvider is an invalid pointer,

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 Aron Budea changed: What|Removed |Added Keywords||bisected

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 V Stuart Foote changed: What|Removed |Added Keywords|

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #22 from V Stuart Foote --- (In reply to Xisco Faulí from comment #19) > @Telesto, @V Stuart, any change it can be bisected? Crash on "Close" button click with OpenGL enabled, bibisect from builds on

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #21 from Michael Meeks --- Oh - I was rather convinced by comment#18 =) Its great to see the trace there ! should make things much easier ... nice work. -- You are receiving this mail because:

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #20 from V Stuart Foote --- @Michael M.--See the debug trace from Comment 16, the crash here really only occurs with OpenGL rendering enabled. Why drop it from the META? -- You are receiving this

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 Michael Meeks changed: What|Removed |Added Blocks|93529 |

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog, but just with OpenGL rendering enabled

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 Xisco Faulí changed: What|Removed |Added CC|

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog, but just with OpenGL rendering enabled

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 --- Comment #18 from jorortega --- In my case the error is reproducible with opengl enabled and disabled. Only runing libreoffice in safe mode seems to work. Tested with opengl enabled -> steps to crash -> crash

[Libreoffice-bugs] [Bug 115420] Crash using "Close" button for Extension Manager -> Check for Updates dialog, but just with OpenGL rendering enabled

https://bugs.documentfoundation.org/show_bug.cgi?id=115420 V Stuart Foote changed: What|Removed |Added Summary|Crash after closing |Crash