[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #23 from Pranav Kant --- (In reply to Michael Meeks from comment #22) > Pranav - I was going to close this; but - can you look and see if this > change is necessary to make this more correct ? =) > >

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 Michael Meeks changed: What|Removed |Added Status|NEW

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #22 from Michael Meeks --- Pranav - I was going to close this; but - can you look and see if this change is necessary to make this more correct ? =) Thanks ! diff --git

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 Joel Madero changed: What|Removed |Added CC|

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 yeliz changed: What|Removed |Added Assignee|yeliztanero...@gmail.com

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 yeliz changed: What|Removed |Added Assignee|libreoffice-b...@lists.free

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 yeliz changed: What|Removed |Added QA Contact|

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #16 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Pranav Kant committed a patch related to this issue. It has been pushed to master:

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #17 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Pranav Kant committed a patch related to this issue. It has been pushed to master:

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #19 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Pranav Kant committed a patch related to this issue. It has been pushed to master:

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #20 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Stephan Bergmann committed a patch related to this issue. It has been pushed to master:

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #13 from Michael Meeks michael.me...@collabora.com --- The sw/ viewsh.cxx thing should be a stock SolarMutexGuard aGuard; I think =) rather than using this un-helpful API =) -- You are receiving this mail because: You are the

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added CC|

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #14 from Michael Meeks michael.me...@collabora.com --- Oh; and while I'm here - forget the 'friend' thing - we should just kill the crazy Application:: yielding functions, and move their implementation to non-in-line methods in

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #15 from Pranav Kant pranav...@gmail.com --- Here's the change taking care of your comments above. https://gerrit.libreoffice.org/14974 -- You are receiving this mail because: You are the assignee for the bug.

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|EasyHack

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #11 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Pranav Kant committed a patch related to this issue. It has been pushed to master:

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #7 from Gülşah Köse gulsah.1...@gmail.com --- Hi Michael I am trying to fix this bug. I sent a patch to test if I understand correctly this.

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #8 from Pranav Kant pranav...@gmail.com --- (In reply to Michael Meeks from comment #5) Ah - so you want a clearable SolarMutexReleaser ? =) do create one if so. I extended SolarMutexReleaser class, and added a clear() method

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #9 from Pranav Kant pranav...@gmail.com --- (In reply to Gülşah Köse from comment #7) Hi Michael I am trying to fix this bug. I sent a patch to test if I understand correctly this.

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #10 from Gülşah Köse gulsah.1...@gmail.com --- Sorry Pranav. I saw wrong your comment's date. -- You are receiving this mail because: You are the assignee for the bug. ___

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #4 from Pranav Kant pranav...@gmail.com --- (In reply to Michael Meeks from comment #3) However, I noticed that there are situations where we might need to call the destructor of SolarMutexReleaser explicitly. For that

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #6 from Pranav Kant pranav...@gmail.com --- (In reply to Michael Meeks from comment #5) Ah - so you want a clearable SolarMutexReleaser ? =) do create one if so. Is it necessary to create a separate class, can't I extend the

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #5 from Michael Meeks michael.me...@collabora.com --- Ah - so you want a clearable SolarMutexReleaser ? =) do create one if so. -- You are receiving this mail because: You are the assignee for the bug.

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #3 from Michael Meeks michael.me...@collabora.com --- However, I noticed that there are situations where we might need to call the destructor of SolarMutexReleaser explicitly. For that you should use: class VCL_DLLPUBLIC

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 mridul mridulgup...@gmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 mridul mridulgup...@gmail.com changed: What|Removed |Added Assignee|mridulgup...@gmail.com

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #2 from Pranav Kant pranav...@gmail.com --- However, I noticed that there are situations where we might need to call the destructor of SolarMutexReleaser explicitly. Would that be okay ? -- You are receiving this mail

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.documentfoundation.org/show_bug.cgi?id=88230 --- Comment #1 from Pranav Kant pranav...@gmail.com --- I would like to fix this. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list

[Libreoffice-bugs] [Bug 88230] cleanup solar mutex yielding ...

https://bugs.freedesktop.org/show_bug.cgi?id=88230 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever