[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #36 from László Németh  ---
Note: Also I've already tested the locking of the line and circle/rectangle
shape properties, but  it seemed, that is not relevant. I'll check it again
with the alpha release, and add to the code, if needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

László Németh  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #35 from László Németh  ---
Jan-Marek, Noel, Telesto, Xisco, Áron and Buvjaga: many thanks for your
detailed analysis, fixes, suggestions and QA! I will fix the known issues of
the new custom locking, and after that, I plan to add some latency to the
repaint, if it's possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #34 from László Németh  ---
Commit description (2):

tdf#105575 LibreLogo: hide turtle during locking

It seems painting of the selection around
the turtle is not locked completely, so
hide the turtle to lock that, too, for 20%
or more speed up.

Note: the turtle is still visible, because it is
hidden after locking (until unlocking), but there
is no nore jiggering selection around it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #33 from László Németh  ---
Commit description: 

tdf#105575 LibreLogo: speed up by lock (re)paint

Speed up program execution by default partial
locking of repaint and custom locking of paint,
using UNO lockControllers().

– Default: speed up LABEL and TEXT by locking their repaint
  during the various text operations, i.e. setting size and
  text portion formatting changes were visible, and slow.
  Locking while manipulating a shape was suggested by Noel Grandin.

– Custom: SLEEP command with negative argument calls lockControllers(),
  SLEEP command with not negative argument (and program termination)
  call unlockControllers(), so it's possible to lock program parts to
  speed up program execution e.g. 3-4 times or more. For example:

  ; lock paint until program termination
  SLEEP -1
  program

  or

  ; lock until SLEEP 0
  SLEEP -1
  commands_without_paint
  SLEEP 0 ; unlock a single level and paint/repaint everything

– Add __get_time__() command to get the elapsed time from
  program start for profiling.

Add unit tests.

Note: custom locking with SLEEP has known problems: not connected
lines, bad position of arc/pie, non-working CLEARSCREEN.

Note: The reported code is more than 32 times faster (4 sec vs 2.2 min)
with custom locking, also using the commented line to show not only
the result with 400 circle shapes, but the partial result with 100,
200 and 300 shapes, too:

SLEEP -1
REPEAT 400 [ CIRCLE 10 + REPCOUNT/10 FORWARD 5 + REPCOUNT/10 LEFT 10 ]
; IF REPCOUNT % 100 == 0 [ SLEEP 0 SLEEP -1 ] ; to show partial result
SLEEP 0
PRINT __get_time__()

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #32 from Commit Notification 
 ---
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/81ce66ab5d77b0171245e05ed609f2305ce89600

tdf#105575 LibreLogo: hide turtle during locking

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #31 from Commit Notification 
 ---
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e50f0f7342c5618196507771e5f4eb79147477b9

tdf#105575 LibreLogo: speed up by lock (re)paint

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.3.0|target:7.3.0 target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||8313

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #30 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/48c2f0b4b157e133605c99549893521775ede4da

cache access in ConfigurationWrapper (tdf#105575)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #29 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/720e4258ab5f00287098ff945a184bfb43911841

use Primitive2DDecompositionVisitor in ViewObjectContact (tdf#105575)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #28 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/60485d591882954bbec717bfc0f4ffce8c9e9d5e

reduce skia re-alloc costs (tdf#105575)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #27 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2e74c1107bc8422ee7a819722f3f0a366127330f

use visitor callback to avoid container construction (tdf#105575)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #26 from László Németh  ---
All: many thanks for the bug report and your comments and help!

Jan-Marek, Noel: many thanks for the detailed analysis and for the performance
fixes. I'm going to check/add the suggested improvements at the pyUNO/Logo
side.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #25 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f29ef71073bb31f05d6cc50f952e827134868c2d

avoid constructing OUString on hot path (tdf#105575)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #24 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/889df64fbb9534491b76140d63b4340091c763e4

reduce alloc costs for some basegfx objects (tdf#105575)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #23 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/58b2d04ddab5a678921610bf9e9a5a95ae660a17

do less copying when constructing 2d sequence (tdf#105575)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #22 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d29eb3d715a2bfd37c37e098d4f1c4600332487d

no need to lookup window if cursor has not moved (tdf#105575)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #21 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fa01f5a1feeb93a88a330daeec8177a39916e6a3

tdf#105575 Slow rendering when using a Logo command

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #20 from Noel Grandin  ---
So I have done what I can, but fundamentally what is happening is that the
python code that interprets Logo is triggering the rendering too often, and
then it ends up fighting to get access to the SolarMutex, because the main
thread is too busy rendering, and keeps the SolarMutex locked while doing so.

I think the python code can be made a lot faster by things like

(*) keeping track of the position locally, instead of calling setPosition all
the time.
(*) possibly using XMultiPropertySet interface to set multiple properties in
one call.
(*) possibly using lockController()/unlockController() while manipulating the
shape, to prevent a render/repaint from kicking in until it is done with the
current shape manipulation.

But that is someone else's problem, I don't feel like playing with that code.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #19 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e463cc0c8e2582e2cb57ab64a74a6a5cdd9b9787

less OUString construction on hot path (tdf#105575)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

Xisco Faulí  changed:

   What|Removed |Added

 CC||noelgran...@gmail.com

--- Comment #18 from Xisco Faulí  ---
(In reply to Jan-Marek Glogowski from comment #13)
> So this should have been just a quick look and turned into some hours
> analysis with multiple problems unveiled...
> 
> Just for the "fun" of it, I did throw the example into callgrind. In my
> symbol+assert build, I found that the primary problem is dynamic_cast's
> strcmp from the assert in "SwContact* GetUserCall(const SdrObject* pObj)".
> Commenting that, and running callgrind again, I found dynamic_cast still to
> be a problem, but much less ;-) Now 10% of the time is spend in
> __gnu_cxx::__normal_iterator...
> 
> SwObjectFormatter::FormatObjsAtFrame_
> SwSortedObjs::ListPosOf
> __gnu_cxx::__normal_iterator
> 
> That's one reason why the progress gets slower. The LO code iterates over
> the graphics objects vector to find the matching SwAnchoredObject. Normally
> that code is no problem, since we don't have 400 draw objects and
> "everytime" add a new one causing a relayout with several of these lookup.
> 
> And the display was never refreshed in callrind, until LibreLogo was
> finished.
> 

@Noel, I thought you might be interested in this comment from Jan-marek

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

Telesto  changed:

   What|Removed |Added

   Severity|normal  |trivial
   Priority|medium  |lowest

--- Comment #17 from Telesto  ---
(In reply to Jan-Marek Glogowski from comment #16)
> The event loop will always be very system specific. But the LO scheduler and
> the processing of LO internal events (AKA UserEvent) is definitely a good
> idea to further unify (OTOH every time I touched this low level stuff, I
> broke things, so I'm not really eager; nobody else even wants to touch it). 

No surprise, here ;-). It's good enough, is perfectly fine 


> > Not saying that economics theory being the only perspective.. The challenge
> > or fun might maybe a reason for looking into this..
> 
> I failed to parse this. 

Well in economics all is about distributing resources most efficiently. However
LibreOffice is also promoted as 'fun-project for developers'. Defeating market
logic (economics). So someone might jump into it out of curiosity/challenge [in
some utopia ...] and spend weeks on this unpaid.. [sarcasm] 

>This is nothing I will / can do in my free time, if
> that's what "economics" refer to. The city of Munich "sponsored" a lot of
> this, so even if it didn't directly help any particular of their problem, I
> could work on it to tackle some underlying problems instead of somehow
> working around them.

Is Munich still 'sponsoring' development? They are moving back to MSO, right?

> It also didn't help, that the VCL plugins did stuff
> completely or slightly different without any explanation... "Why?" is the
> most common thought when reading LO code (next to wtf, obviously), not what;
> at least for me.

Code is to me a kind of abracadabra (and coding a black art). Assessing code
quality is kind out of scope for me. Aware of lots of bug tracker references
pointing to nowhere these days.. 

Anyhow, I was more or less surprised by the analysis at comment 13 (interesting
to read though).

---
Changing priority ..

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #16 from Jan-Marek Glogowski  ---
(In reply to Telesto from comment #15)
> (In reply to Jan-Marek Glogowski from comment #13)
> > So this should have been just a quick look and turned into some hours
> > analysis with multiple problems unveiled...
> 
> Thanks for the 'quick' look (and insights). Me wondering how often logo
> being truly c.q. how much engineering time should be spent on this. It's
> kind of a trivial feature to me (personal opinion).
> 
> Or is there some overall benefit, bigger compared to logo (like harmonizing
> system loops cross platform)

There is no real problem with LibreLogo AFAIK, except that it's kind of a
non-feature which even caused security problems due its Python implementation
(I have no idea how someone thought this might be a sensible feature for
LO...). But this is a good and easy test, which is hard to find for the whole
system event loop integration, let alone unit tests.

The event loop will always be very system specific. But the LO scheduler and
the processing of LO internal events (AKA UserEvent) is definitely a good idea
to further unify (OTOH every time I touched this low level stuff, I broke
things, so I'm not really eager; nobody else even wants to touch it). 

> Not saying that economics theory being the only perspective.. The challenge
> or fun might maybe a reason for looking into this..

I failed to parse this. This is nothing I will / can do in my free time, if
that's what "economics" refer to. The city of Munich "sponsored" a lot of this,
so even if it didn't directly help any particular of their problem, I could
work on it to tackle some underlying problems instead of somehow working around
them. It also didn't help, that the VCL plugins did stuff completely or
slightly different without any explanation... "Why?" is the most common thought
when reading LO code (next to wtf, obviously), not what; at least for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #15 from Telesto  ---
(In reply to Jan-Marek Glogowski from comment #13)
> So this should have been just a quick look and turned into some hours
> analysis with multiple problems unveiled...

Thanks for the 'quick' look (and insights). Me wondering how often logo being
truly c.q. how much engineering time should be spent on this. It's kind of a
trivial feature to me (personal opinion).

Or is there some overall benefit, bigger compared to logo (like harmonizing
system loops cross platform)

Not saying that economics theory being the only perspective.. The challenge or
fun might maybe a reason for looking into this..

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #14 from Jan-Marek Glogowski  ---
std:: should have been std::function.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #13 from Jan-Marek Glogowski  ---
So this should have been just a quick look and turned into some hours analysis
with multiple problems unveiled...

Just for the "fun" of it, I did throw the example into callgrind. In my
symbol+assert build, I found that the primary problem is dynamic_cast's strcmp
from the assert in "SwContact* GetUserCall(const SdrObject* pObj)". Commenting
that, and running callgrind again, I found dynamic_cast still to be a problem,
but much less ;-) Now 10% of the time is spend in
__gnu_cxx::__normal_iterator...

SwObjectFormatter::FormatObjsAtFrame_
SwSortedObjs::ListPosOf
__gnu_cxx::__normal_iterator

That's one reason why the progress gets slower. The LO code iterates over the
graphics objects vector to find the matching SwAnchoredObject. Normally that
code is no problem, since we don't have 400 draw objects and "everytime" add a
new one causing a relayout with several of these lookup.

And the display was never refreshed in callrind, until LibreLogo was finished.

But back to the original problem:

!! 1. Make sure the document language is English !!

I had my master build with en UI, but German system, resulting in an error
message about braces and whitespace. I originally didn't even realize the error
message was German; took me, while trying to fix the logo program ;-)

master kf5 (symbols + asserts, no debug): ~40s
5.0.6.2 gtk2 (from git releases; I like that repo): ~120s to finish with
several "hiccups", i.e. the turtle speed differed (different from the general
slowdown already described above)
master gtk3: ~150s
master gen: ~4s (really; just does a single paint refresh, and I guess no
intermediate layouts; not yet analyzed...)

FWIW the "svx::SdrPaintView aComeBackIdle" has TaskPriority::REPAINT, but it
probably should be TaskPriority::RESIZE AKA just above repaint (and maybe
RESIZE should be rename PREPAINT, and REPAINT just PAINT...). It feels a bit
faster, but with kf5 at 40s + manual timing...

There are two main difference between Qt and the other system loops:
1. Qt can't process single events. You can just decide between "process all
events" and "wait for events and then process all". And it has a bit different
painting semantics, so a refresh most times get queued in the system event
loop. I'm for that approach generally...
2. gtk and win process LO events via system loop. All other process them always
before system events. That is nothing new, but it might interfere here and they
should probably get converted to the general processing via SalUserEventList
(don't ask me why it's called UserEvent...; I just introduced SalUserEventList,
not SalUserEvent).

This needs much more work; maybe we should just switch to GMainLoop, but that
would be a mayor change for all backends again...) and we have the UI in main
problem, bust that might be solvable generally with std::

And then there is the headless locking problem with UI tests too, where we
don't want to run the main loop via yield "out of order", with non-releasing
SolarMutex m_bNoYieldLock hack.

And nothing obvious and quick to fix this. I guess at least a month to convert
all VCL backends after finishing headless (which should work; it has some focus
handling problem, which are hacked around by ignoring visibility...).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #12 from Telesto  ---
still slow
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 2a151d1d5bc055d5e0011460b6ec42ea9f34f880
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (nl_NL); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #11 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #10 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #9 from Telesto  ---
Repro with
Version: 6.2.0.0.alpha0+
Build ID: 1b21ff86effe58ae368457de8fec654ba4c8edd9
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-07-30_03:13:35
Locale: en-US (nl_NL); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

Telesto  changed:

   What|Removed |Added

 Blocks||103542


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103542
[Bug 103542] [META] vcl: scheduler tracker bug.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #8 from Jan-Marek Glogowski  ---
All my Scheduler changes are just in master AKA 6.0. Those 1ms delays,
reintroduced by Miklos to fix the workaround for AutoTimers rescheduling
instantly again, don't exists anymore. So on master it's probably fixed (but
for sure you have other bugs).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

Telesto  changed:

   What|Removed |Added

 CC||glo...@fbihome.de

--- Comment #7 from Telesto  ---
@Jan-Marek: Might it be related to the scheduler?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

Telesto  changed:

   What|Removed |Added

 Blocks||104224


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104224
[Bug 104224] [META] LibreLogo bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

Aron Budea  changed:

   What|Removed |Added

 CC||ashodnakash...@yahoo.com,
   ||nem...@numbertext.org,
   ||vmik...@collabora.co.uk

--- Comment #6 from Aron Budea  ---
Originally takes about 30s on my computer, after these commits it's about
2-2.5x more (60-75s). While the amount of delay could be up for discussion,
probably something around the original runtime would be more desirable.
Ash, Laszlo, Miklos? Does this require a change in the scheduler, or in the
Logo interpreter?

https://cgit.freedesktop.org/libreoffice/core/commit/?id=3dfeae78cac187ec27f873271005c77aebafd038
author  Miklos Vajna   2015-09-09 10:30:18
(GMT)
committer   Miklos Vajna   2015-09-09 10:30:57
(GMT)

"vcl: restore lost hunk in Scheduler::ImplStartTimer()
Regression from commit 6d64d2f38d9f6c2f54e05675ecd0709eabf6d8ca (Minor
refactoring and cleanup of Scheduler and Timer., 2015-07-19), the old
Timer::ImplStartTimer() used to set nMS to at least 1, but the new
Scheduler::ImplStartTimer() didn't do that."

https://cgit.freedesktop.org/libreoffice/core/commit/?id=6d64d2f38d9f6c2f54e05675ecd0709eabf6d8ca
author  Ashod Nakashian   2015-07-19
23:40:18 (GMT)
committer   Michael Meeks  2015-09-04
18:43:41 (GMT)

"Minor refactoring and cleanup of Scheduler and Timer."

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected

--- Comment #5 from Aron Budea  ---
Bibisected using bibisect-win32-5.1.

36a773bb10d836f5c35da253337ae9245224b340 is the first bad commit
commit 36a773bb10d836f5c35da253337ae9245224b340
Author: Norbert Thiebaud 
Date:   Fri Sep 11 22:44:25 2015 -0700

source sha:3dfeae78cac187ec27f873271005c77aebafd038

# bad: [05d11632892a322664fb52bac90b2598b7fb7544] source
sha:5616d22b57a9a5e57d545e912e029162a230829b
# good: [c1efd324c6ad448ac9edb030dc9738b9e6899e4d] source
sha:ab465b90f6c6da5595393a0ba73f33a1e71a2b65
git bisect start '05d11632892a322664fb52bac90b2598b7fb7544' 'oldest'
# good: [97526ab777da7e58ce283c05498262ecdd4d6f7f] source
sha:4ea70f87f7a2b61eda6e5ab1f48debf6fcfadc1f
git bisect good 97526ab777da7e58ce283c05498262ecdd4d6f7f
# good: [97526ab777da7e58ce283c05498262ecdd4d6f7f] source
sha:4ea70f87f7a2b61eda6e5ab1f48debf6fcfadc1f
git bisect good 97526ab777da7e58ce283c05498262ecdd4d6f7f
# bad: [86fee7ded76d9c2756ccab6aef160a2d7fab0ab6] source
sha:1b62841b1859ae3443e2bf1ebe99ec3d6afb6cc2
git bisect bad 86fee7ded76d9c2756ccab6aef160a2d7fab0ab6
# bad: [ecd02a00b3cb479dcecd6a2539e2f4140cd8158f] source
sha:f45ac62a20b80033a7f5ccdef4a6c116b6fece24
git bisect bad ecd02a00b3cb479dcecd6a2539e2f4140cd8158f
# bad: [6629f1abc962685b1c83b088dff82517bb2f1691] source
sha:5496f2a3ee8e76dda6d1c393308be1e9bbb90d6e
git bisect bad 6629f1abc962685b1c83b088dff82517bb2f1691
# bad: [a5f968795bf60a73039ae687b366800b7929f17c] source
sha:6917cd98ca6b6fd2d495d0257c7fe50611982d34
git bisect bad a5f968795bf60a73039ae687b366800b7929f17c
# bad: [a5f968795bf60a73039ae687b366800b7929f17c] source
sha:6917cd98ca6b6fd2d495d0257c7fe50611982d34
git bisect bad a5f968795bf60a73039ae687b366800b7929f17c
# good: [46a5506b97ad5599ec0c27abe6d39f46de3d7360] source
sha:e126468e5dbc4ef85fc4b6146e0ba73e85281f70
git bisect good 46a5506b97ad5599ec0c27abe6d39f46de3d7360
# good: [d01a0a11debc3a5ea82fc5bd82d82763fb61074f] source
sha:a9c83ee37561e0dbf5f1ad57a4de7c179785c45b
git bisect good d01a0a11debc3a5ea82fc5bd82d82763fb61074f
# good: [d01a0a11debc3a5ea82fc5bd82d82763fb61074f] source
sha:a9c83ee37561e0dbf5f1ad57a4de7c179785c45b
git bisect good d01a0a11debc3a5ea82fc5bd82d82763fb61074f
# bad: [ddfb2eab2909fc713b4c3460feaa6a32a48049d7] source
sha:3186e2b467e84950cc3b04f33f5da1e386bc5e2a
git bisect bad ddfb2eab2909fc713b4c3460feaa6a32a48049d7
# bad: [5d94244a181c44547ce2cb6bf3d169aab7cd1f53] source
sha:1544d1257582af96bee633e2ce1ab2b39b4de7d1
git bisect bad 5d94244a181c44547ce2cb6bf3d169aab7cd1f53
# bad: [5d94244a181c44547ce2cb6bf3d169aab7cd1f53] source
sha:1544d1257582af96bee633e2ce1ab2b39b4de7d1
git bisect bad 5d94244a181c44547ce2cb6bf3d169aab7cd1f53
# good: [849f025a755ae3099a73aa5a55df7f4a04c96cbb] source
sha:5fc85f6da173fdd7c44c353de3b60d8eea4b75ae
git bisect good 849f025a755ae3099a73aa5a55df7f4a04c96cbb
# bad: [42c6af5625a1ba62444e551b03cc3cb239119dc2] source
sha:2bff291ac88ad71f258316a299771b2543f856e4
git bisect bad 42c6af5625a1ba62444e551b03cc3cb239119dc2
# good: [309ef89768ce4ef03c14944ff5825cde8e1d9bc7] source
sha:b95175cc41f96ce669d2a4d4c55034c1f80ac74b
git bisect good 309ef89768ce4ef03c14944ff5825cde8e1d9bc7
# bad: [36a773bb10d836f5c35da253337ae9245224b340] source
sha:3dfeae78cac187ec27f873271005c77aebafd038
git bisect bad 36a773bb10d836f5c35da253337ae9245224b340
# first bad commit: [36a773bb10d836f5c35da253337ae9245224b340] source
sha:3dfeae78cac187ec27f873271005c77aebafd038

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

Buovjaga  changed:

   What|Removed |Added

   Keywords||perf
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from Buovjaga  ---
Ok in 5.0.2.2 it is super fast!

Version: 5.0.2.2 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: en-US (fi_FI)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #3 from Telesto  ---
Retested it again. Still slow compared to Lib 5.0.2.2
Version: 5.4.0.0.alpha0+
Build ID: 2670ca3fc597decae78499d1397539668eb84e5e
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-01-31_05:32:46
Locale: nl-NL (nl_NL); Calc: CL

Fix for "too many or too few spaces next to parentheses":
1. Start LibreOffice
2. Go to Options -> Language Settings -> Set Local Settings to "English (USA)" 
3. Restart LibreOffice

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

Buovjaga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #2 from Buovjaga  ---
I cannot compare with 5.0.2.2, because it says "too many or too few spaces next
to parentheses". It works fine in 5.4.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105575

Telesto  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 CC||ba...@caesar.elte.hu
Version|5.3.0.0.alpha1+ |5.1.0.3 release

--- Comment #1 from Telesto  ---
Aron could you take a look at this one.

Found in
Version: 5.4.0.0.alpha0+
Build ID: b41186a2fc49e440890b8c86e5367352ffaf9cd6
CPU Threads: 4; OS Version: Windows 6.19; UI Render: GL; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-01-26_01:50:40
Locale: nl-NL (nl_NL); Calc: CL

and in
Version: 5.1.0.3
Build ID: 5e3e00a007d9b3b6efb6797a8b8e57b51ab1f737
CPU Threads: 4; OS Version: Windows 6.2; UI Render: default; 
Locale: en-US (nl_NL)

but not in
Version: 5.0.6.3
Build ID: 490fc03b25318460cfc54456516ea2519c11d1aa
Locale: en-US (nl_NL)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs