[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-06-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 Eike Rathke changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |er...@redhat.com

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-06-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 --- Comment #18 from Eike Rathke --- Without the change it was unspecified behaviour, in that it sometimes by chance "worked" under some circumstances to include a group separator in a number, and sometimes parsed a group separator away

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-05-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 --- Comment #17 from Jouni Kosonen --- (In reply to Eike Rathke from comment #16) > (In reply to Jouni Kosonen from comment #15) > > Yes, but as I understand it there isn't a single line anywhere in the > > codebase that would set the

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-05-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 --- Comment #16 from Eike Rathke --- (In reply to Jouni Kosonen from comment #15) > Yes, but as I understand it there isn't a single line anywhere in the > codebase that would set the flag That is the point. It should only be set under

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-04-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 --- Comment #15 from Jouni Kosonen --- (In reply to Eike Rathke from comment #14) > The patch is wrong. It unconditionally adds the flag for every locale no > matter what parser flags the caller set and thus eliminates the purpose of >

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-04-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 --- Comment #14 from Eike Rathke --- (In reply to Jouni Kosonen from comment #12) > Created attachment 150588 [details] > Minimal patch to restore functionality The patch is wrong. It unconditionally adds the flag for every locale no

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-04-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 --- Comment #13 from Buovjaga --- (In reply to Jouni Kosonen from comment #12) > Created attachment 150588 [details] > Minimal patch to restore functionality > > This appears to be the simplest patch. If the locale provides a decimal >

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-04-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 --- Comment #12 from Jouni Kosonen --- Created attachment 150588 --> https://bugs.documentfoundation.org/attachment.cgi?id=150588=edit Minimal patch to restore functionality This appears to be the simplest patch. If the locale

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 --- Comment #11 from Jouni Kosonen --- I think I see some of what's happening now. In i18npool/source/characterclassification/cclass_unicode_parser.cxx cclass_Unicode::initParserTable, KParseTokens::GROUP_SEPARATOR_IN_NUMBER isn't on

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-03-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 --- Comment #10 from Jouni Kosonen --- (In reply to Buovjaga from comment #9) > (In reply to Jouni Kosonen from comment #8) > > Both 6.1 and 6.2 have now been released with this behavior and I can't find > > anything related in gerrit,

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-03-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 --- Comment #9 from Buovjaga --- (In reply to Jouni Kosonen from comment #8) > Both 6.1 and 6.2 have now been released with this behavior and I can't find > anything related in gerrit, is this being worked on or should I just try to >

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-03-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 --- Comment #8 from Jouni Kosonen --- (In reply to Eike Rathke from comment #6) > What happens is that 12_345,67 (here with '_' for the no-break space) is > lexically tokenized to > > 12 > _345 > ,67 > > which then leads to three

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-03-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 Xisco FaulĂ­ changed: What|Removed |Added Keywords||bibisected -- You are receiving

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-03-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 --- Comment #7 from Jouni Kosonen --- (In reply to Buovjaga from comment #5) > Jouni: thanks for your report and investigation. For bisecting, we have > special repos that contain binaries for commits (or commit ranges in the > older

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-03-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 Buovjaga changed: What|Removed |Added Keywords|bibisectRequest |bisected -- You are receiving this

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-03-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 Xisco FaulĂ­ changed: What|Removed |Added Keywords||bibisectRequest

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 --- Comment #6 from Eike Rathke --- What happens is that 12_345,67 (here with '_' for the no-break space) is lexically tokenized to 12 _345 ,67 which then leads to three numbers 12 and 345 (because there in the number parser the

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-03-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 --- Comment #5 from Buovjaga --- Jouni: thanks for your report and investigation. For bisecting, we have special repos that contain binaries for commits (or commit ranges in the older ones):

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-03-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 --- Comment #4 from Jouni Kosonen --- (In reply to Eike Rathke from comment #3) > Entering a formula it was never guaranteed to accept group separators in > values (as in many locales the group separator also is the parameter > separator

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-03-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 --- Comment #3 from Eike Rathke --- Entering a formula it was never guaranteed to accept group separators in values (as in many locales the group separator also is the parameter separator ','). It may have worked by chance in some

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-03-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 --- Comment #2 from Laurent BP --- Same bug with new profile Same bug with more or less decimals Same bug with locale en-US No bug without '=' No bug without thousand separator So procedure can be simplified to: 1. Enter a value larger

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-03-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 Laurent BP changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0

[Libreoffice-bugs] [Bug 123752] EDITING: Regression in handling of the group separator in formula context

2019-03-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123752 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||111942,