[Libreoffice-bugs] [Bug 153704] Style Heading level label was gone in Chinese/Japanese/Korean interfaces
https://bugs.documentfoundation.org/show_bug.cgi?id=153704 --- Comment #21 from Shinji Enoki --- I confirmed that this bug has been fixed in the following versions: Thank you for your efforts. Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 1b06f35de68a555b85bceb5fc29d1a5f426f4bb7 CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: ja-JP (ja_JP.UTF-8); UI: ja-JP Calc: threaded Version: 7.5.2.2 (X86_64) / LibreOffice Community Build ID: 53bb9681a964705cf672590721dbc85eb4d0c3a2 CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: ja-JP (ja_JP.UTF-8); UI: ja-JP Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153704] Style Heading level label was gone in Chinese/Japanese/Korean interfaces
https://bugs.documentfoundation.org/show_bug.cgi?id=153704 Adolfo Jayme Barrientos changed: What|Removed |Added Whiteboard|target:7.6.0 target:7.5.3 |target:7.6.0 target:7.5.2.2 |target:7.5.2| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153704] Style Heading level label was gone in Chinese/Japanese/Korean interfaces
https://bugs.documentfoundation.org/show_bug.cgi?id=153704 Commit Notification changed: What|Removed |Added Whiteboard|target:7.6.0 target:7.5.3 |target:7.6.0 target:7.5.3 ||target:7.5.2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153704] Style Heading level label was gone in Chinese/Japanese/Korean interfaces
https://bugs.documentfoundation.org/show_bug.cgi?id=153704 --- Comment #20 from Commit Notification --- Khaled Hosny committed a patch related to this issue. It has been pushed to "libreoffice-7-5-2": https://git.libreoffice.org/core/commit/0337d29475bcf9374e58d37935408a9ba4fce3fe tdf#153704: Make sure the last script segment is also added It will be available in 7.5.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153704] Style Heading level label was gone in Chinese/Japanese/Korean interfaces
https://bugs.documentfoundation.org/show_bug.cgi?id=153704 --- Comment #19 from Commit Notification --- Khaled Hosny committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/eeacbc5a873f00e0bdd9667d4e2a963774ef63ee tdf#153704: Make sure the last script segment is also added It will be available in 7.5.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153704] Style Heading level label was gone in Chinese/Japanese/Korean interfaces
https://bugs.documentfoundation.org/show_bug.cgi?id=153704 Commit Notification changed: What|Removed |Added Whiteboard|target:7.6.0|target:7.6.0 target:7.5.3 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153704] Style Heading level label was gone in Chinese/Japanese/Korean interfaces
https://bugs.documentfoundation.org/show_bug.cgi?id=153704 --- Comment #18 from خالد حسني --- (In reply to Po-Yen Huang from comment #17) > (In reply to خالد حسني from comment #14) > > Thanks for debugging this, please check > > https://gerrit.libreoffice.org/c/core/+/148986 if you can (I don’t have the > > localized version, but I tested by making styles named using the same > > strings above). > > This commit should backport to 7.5 I think? https://gerrit.libreoffice.org/c/core/+/148970 https://gerrit.libreoffice.org/c/core/+/148971 (Need other devs to approve them) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153704] Style Heading level label was gone in Chinese/Japanese/Korean interfaces
https://bugs.documentfoundation.org/show_bug.cgi?id=153704 --- Comment #17 from Po-Yen Huang --- (In reply to خالد حسني from comment #14) > Thanks for debugging this, please check > https://gerrit.libreoffice.org/c/core/+/148986 if you can (I don’t have the > localized version, but I tested by making styles named using the same > strings above). This commit should backport to 7.5 I think? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153704] Style Heading level label was gone in Chinese/Japanese/Korean interfaces
https://bugs.documentfoundation.org/show_bug.cgi?id=153704 خالد حسني changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153704] Style Heading level label was gone in Chinese/Japanese/Korean interfaces
https://bugs.documentfoundation.org/show_bug.cgi?id=153704 --- Comment #16 from Commit Notification --- Khaled Hosny committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a8725c24fa4d89ec2efddf6f341d403abf79865a tdf#153704: Make sure the last script segment is also added It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153704] Style Heading level label was gone in Chinese/Japanese/Korean interfaces
https://bugs.documentfoundation.org/show_bug.cgi?id=153704 Commit Notification changed: What|Removed |Added Whiteboard||target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153704] Style Heading level label was gone in Chinese/Japanese/Korean interfaces
https://bugs.documentfoundation.org/show_bug.cgi?id=153704 --- Comment #15 from Franklin Weng --- (In reply to خالد حسني from comment #14) > Thanks for debugging this, please check > https://gerrit.libreoffice.org/c/core/+/148986 if you can (I don’t have the > localized version, but I tested by making styles named using the same > strings above). Yes, it solved the problem. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153704] Style Heading level label was gone in Chinese/Japanese/Korean interfaces
https://bugs.documentfoundation.org/show_bug.cgi?id=153704 --- Comment #14 from خالد حسني --- Thanks for debugging this, please check https://gerrit.libreoffice.org/c/core/+/148986 if you can (I don’t have the localized version, but I tested by making styles named using the same strings above). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153704] Style Heading level label was gone in Chinese/Japanese/Korean interfaces
https://bugs.documentfoundation.org/show_bug.cgi?id=153704
--- Comment #13 from Franklin Weng ---
(In reply to Franklin Weng from comment #12)
> @Khaled
>
> in svx/source/styles/CommonStylePreviewRenderer.cxx line 417
>
> auto aScript = aEditEngine.GetScriptType({ 0, 0, 0, 0 });
> for (sal_Int32 i = 1; i <= maScriptText.getLength(); i++)
> {
> auto aNextScript = aEditEngine.GetScriptType({ 0, i, 0, i });
> if (aNextScript != aScript)
> maScriptChanges.emplace_back(aScript, i - 1);
> else if (i == maScriptText.getLength())
> maScriptChanges.emplace_back(aScript, i);
> aScript = aNextScript;
> }
>
> If the style name is "標題 1" then when the last character '1' met
> (aNextScript != aScript) (in this case changed from LATIN to CJK), it would
Sorry, should be changed from CJK to LATIN
> be left out without pushing into maScriptChanges, i.e.
> maScriptChanges.emplace_back(aScript, i); would not be executed. That will
> explain why we add a space after the number ("標題 1 ") could reveal all the
> style name because maScriptChanges.emplace_back(aScript, i); will be
> executed in the last run of the loop.
>
> I could add another if to make sure to push everything into maScriptChanges
> if it was the last character, but I'm not sure if it would make the problem
> in tdf#152737 back.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153704] Style Heading level label was gone in Chinese/Japanese/Korean interfaces
https://bugs.documentfoundation.org/show_bug.cgi?id=153704
--- Comment #12 from Franklin Weng ---
@Khaled
in svx/source/styles/CommonStylePreviewRenderer.cxx line 417
auto aScript = aEditEngine.GetScriptType({ 0, 0, 0, 0 });
for (sal_Int32 i = 1; i <= maScriptText.getLength(); i++)
{
auto aNextScript = aEditEngine.GetScriptType({ 0, i, 0, i });
if (aNextScript != aScript)
maScriptChanges.emplace_back(aScript, i - 1);
else if (i == maScriptText.getLength())
maScriptChanges.emplace_back(aScript, i);
aScript = aNextScript;
}
If the style name is "標題 1" then when the last character '1' met (aNextScript
!= aScript) (in this case changed from LATIN to CJK), it would be left out
without pushing into maScriptChanges, i.e.
maScriptChanges.emplace_back(aScript, i); would not be executed. That will
explain why we add a space after the number ("標題 1 ") could reveal all the
style name because maScriptChanges.emplace_back(aScript, i); will be executed
in the last run of the loop.
I could add another if to make sure to push everything into maScriptChanges if
it was the last character, but I'm not sure if it would make the problem in
tdf#152737 back.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153704] Style Heading level label was gone in Chinese/Japanese/Korean interfaces
https://bugs.documentfoundation.org/show_bug.cgi?id=153704 Xisco Faulí changed: What|Removed |Added CC||kha...@aliftype.com Keywords||bibisected, bisected, ||regression See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||2737 --- Comment #11 from Xisco Faulí --- (In reply to Franklin Weng from comment #10) > 85f161ac76a07bcd1dd2080e4bda8f11a600262d is the first bad commit > commit 85f161ac76a07bcd1dd2080e4bda8f11a600262d > Author: Khaled Hosny > Date: Fri Dec 30 18:56:41 2022 +0200 > > tdf#152737: Fix off-by-one errors Adding Cc: to Khaled Hosny -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153704] Style Heading level label was gone in Chinese/Japanese/Korean interfaces
https://bugs.documentfoundation.org/show_bug.cgi?id=153704 --- Comment #10 from Franklin Weng --- 85f161ac76a07bcd1dd2080e4bda8f11a600262d is the first bad commit commit 85f161ac76a07bcd1dd2080e4bda8f11a600262d Author: Khaled Hosny Date: Fri Dec 30 18:56:41 2022 +0200 tdf#152737: Fix off-by-one errors Regressions from: commit 718af940435ae9d2ac90374e5880ecb38e96252c Author: Khaled Hosny Date: Fri Dec 16 00:10:34 2022 +0200 tdf#152533: Improve script handling in font preview and: commit bfecacb2487ba9470600e6f64056d9b1816ee96b Author: Khaled Hosny Date: Thu Dec 15 22:51:54 2022 +0200 tdf#152460: Improve script handling in style previews Change-Id: I7b12f5accbd65459d724676efb7bec947a7faaa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144880 Tested-by: Jenkins Reviewed-by: خالد حسني (cherry picked from commit 95f0dc2dc74401a097105fcfe745aba3e571d9c4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144898 Reviewed-by: Adolfo Jayme Barrientos svx/source/dialog/fntctrl.cxx| 4 +++- svx/source/styles/CommonStylePreviewRenderer.cxx | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153704] Style Heading level label was gone in Chinese/Japanese/Korean interfaces
https://bugs.documentfoundation.org/show_bug.cgi?id=153704 Franklin Weng changed: What|Removed |Added Version|7.5.0.3 release |7.5.0.2 rc --- Comment #9 from Franklin Weng --- Problem introduced in 7.5.0.2 earliest. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153704] Style Heading level label was gone in Chinese/Japanese/Korean interfaces
https://bugs.documentfoundation.org/show_bug.cgi?id=153704 Franklin Weng changed: What|Removed |Added Summary|Style Heading level label |Style Heading level label |was gone in Traditional |was gone in |Chinese interfaces |Chinese/Japanese/Korean ||interfaces -- You are receiving this mail because: You are the assignee for the bug.
