[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66813

--- Comment #17 from QA Administrators  ---
Dear Lionel Elie Mamane,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66813

Lionel Elie Mamane  changed:

   What|Removed |Added

 Whiteboard|target:7.0.5 target:7.1.1   |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66813

--- Comment #16 from Alex Thurgood  ---
(In reply to Lionel Elie Mamane from comment #11)


> 3.2) Try to run a long-standing SQL command in the "Tools/SQL" dialog, then
> try with the mouse in the UI to force execution of another SQL command
> (easiest is double-click on a query or on a table).
> 4) What happens in 3.2? The best would be that the UI just waits for the
> dialog command to finish, then does the requested thing. What might happen
> instead is that the SQL command from the dialog is aborted.


I just had a thought for why the dialog may have been made modal in the first
place.

Is there by any chance any requirement to release/get a mutex from any other
active component of the database connection or have some other form of
synchronisation ? 

For example, say I have a Form saved outside of the ODB file, pointing to a DB
instance and opened for input, and I have my SQL dialog open within an ODB
container pointing to the same DB instance at the same time - which one takes
precedence if I execute 2 SQL operations at the same or pseudo-same time ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66813

--- Comment #15 from Alex Thurgood  ---
(In reply to Julien Nabet from comment #9)


> Now should it be modal or not?
> Personally, I don't have strong opinion here.
> 
> Robert/Alex: as expert Base users, any thoughts here?

Personally, for me, it should be non-modal. If I've understood correctly, that
would allow the user to enter SQL commands and see the results of those
commands, e.g. updates, directly by refreshing or opening a table grid view
controller, which would make the whole thing a much more useful tool than in
the current production release.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66813

--- Comment #14 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/380597b1f7bad62164f36db5c9d2edf4cee52c26

Related: tdf#66813 this dialog should be modal

It will be available in 7.1.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66813

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.0.5|target:7.0.5 target:7.1.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66813

--- Comment #13 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/14e18c13e9a618e5a9c72f00a6913633acb21573

Related: tdf#66813 this dialog should be modal

It will be available in 7.0.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66813

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.0.5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66813

--- Comment #12 from Lionel Elie Mamane  ---
I meant "long-running SQL command", not "long-standing". A few ideas for that:

PostgreSQL: SELECT pg_sleep(60); -- replace 60 by another amount in seconds at
will

MySQL: SELECT sleep(60);

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66813

--- Comment #11 from Lionel Elie Mamane  ---
>From a UX perspective, non-modal would be much better. There might be technical
challenges to make it non-modal, but I never took the time to dig into it.
Mainly, as far as I understand, we open _one_ connection to the database, which
allows to do _one_ SQL command concurrently (unless we use asynchronous APIs,
which we don't). So, during execution of an SQL command, basically nothing else
can happen within (the same odb file in) Base. The modality of the dialog might
just be a work-around for (older versions of) Base not handling that correctly.

The "busy" signal is good, during execution of the SQL command _only_ (that is
between the click on "Execute" button in the dialog and having the result of
the command), _not_ during the whole time that the dialog is merely open.

If someone wants to look into it, I would recommend:

1) Make the dialog non-modal
2) For best UX, change the "busy" signal to be only while command is being
executed.
3) Test it.
3.1) Execute a SQL command in the "Tools/SQL" dialog. Wait for the result. Do
not close the dialog, but use the Base UI (e.g. double-click on a query or on a
table). Should work well. Go back to dialog. Execute another SQL command.
3.2) Try to run a long-standing SQL command in the "Tools/SQL" dialog, then try
with the mouse in the UI to force execution of another SQL command (easiest is
double-click on a query or on a table).
4) What happens in 3.2? The best would be that the UI just waits for the dialog
command to finish, then does the requested thing. What might happen instead is
that the SQL command from the dialog is aborted.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66813

--- Comment #10 from Caolán McNamara  ---
FWIW the WaitObject is there since

commit 85afff9c65f3b312c1d39f15b89536b9d33beba0
Author: Jens-Heiner Rechtien 
Date:   Mon Aug 2 14:28:39 2004 +
INTEGRATION: CWS insight01 (1.1.2); FILE ADDED

which is somewhat unhelpful. Typically a WaitObject is used when some slow task
is underway to indicate its "doing something". The use in
OApplicationController::refreshTables follows that pattern and that one makes
sense. Doing the "busy" while a dialog is open indeed unusual. Maybe its a cut
and paste from the other function, or maybe the "busy" period should only exist
until the "execute" of the dialog, though the dialog setup surely isn't so
special vs all other dialogs that it needs a "busy" pre-execute period.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66813

Julien Nabet  changed:

   What|Removed |Added

 CC||rob...@familiegrosskopf.de

--- Comment #9 from Julien Nabet  ---
(In reply to Caolán McNamara from comment #7)
> The "waiting state" is set in dbaccess/source/ui/app/AppControllerGen.cxx in
> OApplicationController::openDialog the ctor of the a WO weld::WaitObject and
> persists until its dtor.
I understand why there's this behavior and where it's located but I don't
understand what's the purpose of this "waiting state", just showing it's modal?
If yes why here and not on other modal dialogs?


> This is currently meant to be a modal dialog and it should have it modal bit
> set (https://gerrit.libreoffice.org/c/core/+/109540 to do that). In
> contemporary code if we wanted it to be a modeless dialog we'd unset its
> modal bit and instead of call Dialog::run we'd have to call runAsync instead.
With the last patch, the behavior is indeed now the same between gtk3, gen and
kf5.

Now should it be modal or not?
Personally, I don't have strong opinion here.

Robert/Alex: as expert Base users, any thoughts here?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66813

Lionel Elie Mamane  changed:

   What|Removed |Added

 Whiteboard|target:7.2.0|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66813

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66813

--- Comment #8 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/67194f944861a76cccf6a432beb3dbe8983416ef

Related: tdf#66813 this dialog should be modal

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66813

--- Comment #7 from Caolán McNamara  ---
The "waiting state" is set in dbaccess/source/ui/app/AppControllerGen.cxx in
OApplicationController::openDialog the ctor of the a WO weld::WaitObject and
persists until its dtor.

This is currently meant to be a modal dialog and it should have it modal bit
set (https://gerrit.libreoffice.org/c/core/+/109540 to do that). In
contemporary code if we wanted it to be a modeless dialog we'd unset its modal
bit and instead of call Dialog::run we'd have to call runAsync instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66813

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #6 from Julien Nabet  ---
Since directsql has been welded, see
https://cgit.freedesktop.org/libreoffice/core/commit/?id=573562e72a5fd85b75006fbc8869c73903a6e504

author  Caolán McNamara 2019-09-15 20:18:38 +0100
committer   Caolán McNamara 2019-09-17 10:04:38
+0200
commit  573562e72a5fd85b75006fbc8869c73903a6e504 (patch)
tree866cfff40b7974ab4a9541214a93c104c10f593b
parent  a944d4c2aacafdac78eabd7fb0f8909a66d935eb (diff)
weld DirectSQLDialog

I tried to reproduce this and it's still modal at least for gtk3 (I don't
reproduce this with gen rendering).
However, when moving cursor outside direct sql dialog, the cursor is in a
"waiting state".

I don't know why there's this "waiting state" or why with gen rendering it's
not modal but perhaps they're both hints.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66813

--- Comment #5 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present on a currently supported version of
LibreOffice 
(5.2.5 or 5.3.0  https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the version of
LibreOffice and 
your operating system, and any changes you see in the bug behavior

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave 
a short comment that includes your version of LibreOffice and Operating System

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3)

http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to "inherited from OOo";
4b. If the bug was not present in 3.3 - add "regression" to keyword


Feel free to come ask questions or to say hello in our QA chat:
http://webchat.freenode.net/?channels=libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug-20170306

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66813

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present on a currently supported version of
LibreOffice (5.0.4 or later)  https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the version of
LibreOffice and your operating system, and any changes you see in the bug
behavior

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a short comment that includes your version of
LibreOffice and Operating System

Please DO NOT:

- Update the version field
- Reply via email (please reply directly on the bug tracker)
- Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not appropriate in this case)

If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so: 1. Download and install oldest version of LibreOffice
(usually 3.3 unless your bug pertains to a feature added after 3.3)

http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug 3. Leave a comment with your results. 4a. If the bug was
present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not
present in 3.3 - add "regression" to keyword


Feel free to come ask questions or to say hello in our QA chat:
http://webchat.freenode.net/?channels=libreoffice-qa

Thank you for your help!

-- The LibreOffice QA Team This NEW Message was generated on: 2016-01-17

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=66813

--- Comment #3 from Alex Thurgood ipla...@yahoo.co.uk ---
Adding self to CC if not already on

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=66813

Lionel Elie Mamane lio...@mamane.lu changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=66813

--- Comment #1 from Caolán McNamara caol...@redhat.com ---
Try ModelessDialog (and make that same change in the .cxx/,hxx for the
baseclass of the dialog

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66813] Tools / SQL dialog is modal

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=66813

--- Comment #2 from Lionel Elie Mamane lio...@mamane.lu ---
(In reply to comment #1)
 Try ModelessDialog (and make that same change in the .cxx/,hxx for the
 baseclass of the dialog

That compiles, but as soon as the Base window gets focus, the dialog window
grabs focus, so in practice it is as-if it were modal.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs