[Libreoffice-bugs] [Bug 89643] report builder: function wizard segfaults as soon as a function is inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=89643 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | --- Comment #26 from Caolán McNamara caol...@redhat.com --- There are two implementations of getCategory, one (sc) returns a new one each time (hence the leak fix) and the other (reportdesign) returns a pointer to one that belongs to the manger (hence the crash). The code in formula really looks to me to expect that the getCategory return a pointer that someone else needs to look after, i.e. the reportdesign variant is the more correct and the sc gets away with it because its IFunctionCategory impl is so thin that the guts of ScFunctionCategory live on past the death of ScFunctionCategory. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89643] report builder: function wizard segfaults as soon as a function is inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=89643 --- Comment #25 from agojc ag...@free.fr --- Win7 64 bit system. Crash happens as of 4.3.2.1 version. (tested also on 4.3.2.2, 4.3.5.1, 4.3.7.2 and 4.4.3.2). Works fine up to 4.3.1.2 version (also tested on 4.3.0.4 and 4.3.1.1). In a nutshell, problem occurs since 4.3.2 versions. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89643] report builder: function wizard segfaults as soon as a function is inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=89643 rob...@familiegrosskopf.de changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=88 ||543 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89643] report builder: function wizard segfaults as soon as a function is inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=89643 rob...@familiegrosskopf.de changed: What|Removed |Added OS|Linux (All) |All --- Comment #24 from rob...@familiegrosskopf.de --- Changed the Hardware to All. Bug appears for Windows, Mac and Linux ... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89643] report builder: function wizard segfaults as soon as a function is inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=89643 rob...@familiegrosskopf.de changed: What|Removed |Added CC||bschul...@online.de --- Comment #23 from rob...@familiegrosskopf.de --- *** Bug 90880 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89643] report builder: function wizard segfaults as soon as a function is inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=89643 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added CC||khabir.tay...@frontier.com --- Comment #22 from Alex Thurgood ipla...@yahoo.co.uk --- *** Bug 90383 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89643] report builder: function wizard segfaults as soon as a function is inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=89643 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||bisected CC||fdb...@neosheffield.co.uk Whiteboard|bibisectrequest |bibisected --- Comment #21 from Matthew Francis fdb...@neosheffield.co.uk --- This seems to have been variously broken and fixed on several different occasions during 4.4 master, but the crash at issue is I think the one that started at the below commit. (Not Cc'ing Markus Mohrhard on bugs by his request) commit 3d6521280929ecacc53b7c358d29d0b5d31b3462 Author: Markus Mohrhard markus.mohrh...@googlemail.com AuthorDate: Thu Jul 31 21:43:59 2014 +0200 Commit: Markus Mohrhard markus.mohrh...@googlemail.com CommitDate: Thu Jul 31 22:14:25 2014 +0200 fix memory leak around function descriptions Found by Lsan. Change-Id: Ia443ed6eb2a20854998a615f3c2bd9fdac156a8c -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89643] report builder: function wizard segfaults as soon as a function is inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=89643 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||netti...@stackingdwarves.ne ||t --- Comment #18 from Julien Nabet serval2...@yahoo.fr --- *** Bug 89567 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89643] report builder: function wizard segfaults as soon as a function is inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=89643
--- Comment #19 from Julien Nabet serval2...@yahoo.fr ---
I noticed this function
http://opengrok.libreoffice.org/xref/core/formula/source/ui/dlg/funcpage.cxx#65
65 inline sal_uInt16 Lb2Cat( sal_uInt16 nLbPos )
66 {
67 // Category 0 == LRU, otherwise Categories == LbPos-1
68 if ( nLbPos 0 )
69 nLbPos -= 1;
70
71 return nLbPos;
72 }
whereas the only location where this function is called is this:
114 void FuncPage::UpdateFunctionList()
115 {
116 sal_Int32 nSelPos = m_pLbCategory-GetSelectEntryPos();
117 const IFunctionCategory* pCategory = static_castconst
IFunctionCategory*(m_pLbCategory-GetEntryData(nSelPos));
118 sal_Int32 nCategory = ( LISTBOX_ENTRY_NOTFOUND != nSelPos )
119 ? Lb2Cat( nSelPos ) : 0;
so shouldn't it be:
inline sal_Int32 Lb2Cat( sal_Int32 nLbPos )
to begin with?
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89643] report builder: function wizard segfaults as soon as a function is inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=89643 --- Comment #20 from Julien Nabet serval2...@yahoo.fr --- Just noticed that nCategory isn't used, so this part + inline function could be removed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89643] report builder: function wizard segfaults as soon as a function is inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=89643 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||dapau...@gmail.com --- Comment #17 from Julien Nabet serval2...@yahoo.fr --- *** Bug 90067 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89643] report builder: function wizard segfaults as soon as a function is inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=89643 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||mfron...@muchomail.com --- Comment #16 from Julien Nabet serval2...@yahoo.fr --- *** Bug 89769 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89643] report builder: function wizard segfaults as soon as a function is inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=89643 --- Comment #13 from Julien Nabet serval2...@yahoo.fr --- Created attachment 113893 -- https://bugs.documentfoundation.org/attachment.cgi?id=113893action=edit bt with debug symbols -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89643] report builder: function wizard segfaults as soon as a function is inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=89643 --- Comment #12 from Julien Nabet serval2...@yahoo.fr --- Created attachment 113892 -- https://bugs.documentfoundation.org/attachment.cgi?id=113892action=edit Valgrind trace with master sources -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89643] report builder: function wizard segfaults as soon as a function is inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=89643 --- Comment #14 from Julien Nabet serval2...@yahoo.fr --- I noticed these logs during tests: warn:i18nlangtag:14851:1:i18nlangtag/source/languagetag/languagetag.cxx:1380: LanguageTagImpl::convertLocaleToLang: with bAllowOnTheFlyID invalid 'de-' warn:legacy.osl:14851:1:reportdesign/source/core/sdr/RptObject.cxx:368: OUnoObject::EndListening: not listening currently! warn:legacy.osl:14851:1:reportdesign/source/core/sdr/RptObject.cxx:351: OUnoObject::StartListening: already listening! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89643] report builder: function wizard segfaults as soon as a function is inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=89643 Lionel Elie Mamane lio...@mamane.lu changed: What|Removed |Added CC||er...@redhat.com, ||markus.mohrhard@googlemail. ||com --- Comment #15 from Lionel Elie Mamane lio...@mamane.lu --- Since that formula module is shared with Calc, would our Calc FindTheExperts have some clue on what change could have caused this? In the backtrace, the problematic line is: if( pFuncPage-GetCategory() != static_castsal_Int32(pFuncDesc-getCategory()-getNumber() + 1) ) The problem is that pFuncDesc-getCategory() returns some kind of smart pointer that contains a null raw pointer, so -getNumber() segfaults. IFunctionCategory seems to be an abstract class with two implementations: reportdesign/source/ui/inc/FunctionHelper.hxx: class FunctionCategory sc/inc/funcdesc.hxx: class ScFunctionCategory To chase this I suppose we should follow how/when these are created and filled out, or maybe how/when a meaningful category member is filled in pFuncDesc. What strikes me is that just before the crash, the display of the formula is e.g. =COUNT( ) ) instead of =COUNT( ) Maybe that's linked... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89643] report builder: function wizard segfaults as soon as a function is inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=89643 Lionel Elie Mamane lio...@mamane.lu changed: What|Removed |Added Whiteboard||bibisectrequest -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89643] report builder: function wizard segfaults as soon as a function is inserted
https://bugs.documentfoundation.org/show_bug.cgi?id=89643 Lionel Elie Mamane lio...@mamane.lu changed: What|Removed |Added Summary|When writing COUNT () the |report builder: function |program closes |wizard segfaults as soon as ||a function is inserted --- Comment #11 from Lionel Elie Mamane lio...@mamane.lu --- Seems not specific to COUNT(), happens with all functions. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
