[Libreoffice-bugs] [Bug 89829] Updating character style to match selection does not remove direct formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89829

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 89829] Updating character style to match selection does not remove direct formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89829

Heiko Tietze  changed:

   What|Removed |Added

 CC|heiko.tietze@documentfounda |mikekagan...@hotmail.com
   |tion.org|

--- Comment #9 from Heiko Tietze  ---
(In reply to Yousuf Philips (jay) (retired) from comment #3)
> In this case, where it is using the currently selected text to apply the
> formatting to the rest of text, it should remove the direct formatting, just
> like it does for the updation of paragraph styles.

Two paragraphs, both using Text Body. Set font name for P1 to "Foo" and change
the style. P1 will overwrite via direct formatting the "Foo" font name with
"Foo".

(In reply to mahfiaz from comment #0)
> On the other hand this might be a pandora box and open another can of bugs,
> as how it should behave when the whole word is marked red, but when updating
> the character style only two letters are selected or even none at all.

Good example to resolve NAB/WF.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 89829] Updating character style to match selection does not remove direct formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89829

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

--- Comment #8 from sdc.bla...@youmail.dk ---
repro

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 98f0dd5e15733ac7f1d929d06ab230b5f04121d5
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: da-DK (da_DK); UI: en-US
Calc: CL threaded

But as noted in OP, comment 2, comment 3, maybe the expected behavior needs to
be considered. Perhaps this case is NAB? Adding UXEval

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 89829] Updating character style to match selection does not remove direct formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89829

--- Comment #7 from QA Administrators  ---
Dear mahfiaz,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 89829] Updating character style to match selection does not remove direct formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89829

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 CC||sdc.bla...@youmail.dk

--- Comment #6 from sdc.bla...@youmail.dk ---
Repro steps 1-6 in OP

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 4041c68ea59181f1c4774c356809066d2051db41

As noted in step 6 and comment 3, the direct character formatting is not
removed when the second "update style" is conducted.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89829] Updating character style to match selection does not remove direct formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89829

--- Comment #5 from QA Administrators  ---
Dear mahfiaz,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89829] Updating character style to match selection does not remove direct formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89829

--- Comment #4 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89829] Updating character style to match selection does not remove direct formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89829

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks|107326  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107326
[Bug 107326] [META] Writer style bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89829] Updating character style to match selection does not remove direct formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89829

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||108014


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108014
[Bug 108014] [META] Writer character style bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89829] Updating character style to match selection does not remove direct formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89829

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks|102946  |107325, 107326


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102946
[Bug 102946] [META] Styles bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107325
[Bug 107325] [META] Style management commands bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107326
[Bug 107326] [META] Writer style bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89829] Updating character style to match selection does not remove direct formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89829

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||c...@nouenoff.nl,
   ||philip...@hotmail.com,
   ||tietze.he...@gmail.com,
   ||vstuart.fo...@utsa.edu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=85
   ||131
 Blocks||102946
 Ever confirmed|0   |1

--- Comment #3 from Yousuf Philips (jay)  ---
(In reply to mahfiaz from comment #0)
> 1) Mark a few words with a character style
> 2) Select one word, change its color to e.g red
> 3) while word still selected update the character style (one would have to
> have character styles open in styles and formatting dialog and pick "update
> style" from the rightmost button in the dialog)
> 4) select another word, change its color to e.g blue
> 5) repeat 3
> 6) see that the first word is still red, since the local formatting was not
> removed (which works just fine with paragraph styles)

In this case, where it is using the currently selected text to apply the
formatting to the rest of text, it should remove the direct formatting, just
like it does for the updation of paragraph styles.

> On the other hand this might be a pandora box and open another can of bugs,
> as how it should behave when the whole word is marked red, but when updating
> the character style only two letters are selected or even none at all.
> Should it expand the selection before removing properties? What if there are
> nonmatching regions, e.g
> this is bold this is bold italic this is
> italic
> Right now it would only update to bold, as the whole selection happens to be
> bold, but not whole it is italic.

Yes this issue needs some deep thought and research to find out what the best
default option should be and likely we should have option dialog options to
tweak its behavior to user preference, like

1) Clear all direct formatting on character styled text when updating style

from this is some text and some more
to this is some text and some more

2) Clear direct formatting that covers the entire text when updating style

from this is some text and some more
to this is some text and some more

3) Dont remove direct formatting when updating style (what we do now)

This issue is related to bug 85131 which talks about similar updation problems
with paragraph styles.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102946
[Bug 102946] [META] Styles bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89829] Updating character style to match selection does not remove direct formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89829

Owen Genat owen.ge...@gmail.com changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=89
   ||960
Summary|Updating character style to |Updating character style to
   |match selection does not|match selection does not
   |remove local formatting |remove direct formatting

--- Comment #2 from Owen Genat owen.ge...@gmail.com ---
Similar underlying issue as reported in bug 89960 (added to See Also list)
i.e., directly applied formatting overrides/XORs all styles. Also changed
local to direct in summary.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs