[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

--- Comment #16 from Caolán McNamara  ---
Created attachment 129120
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129120=edit
gtk2 screenshot dark adwaita theme

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

--- Comment #15 from Caolán McNamara  ---
Created attachment 129119
  --> https://bugs.documentfoundation.org/attachment.cgi?id=129119=edit
gtk3 screenshot dark adwaita theme

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

--- Comment #14 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8114a779143a7f0042d7e15b476037315ed2b4c3=libreoffice-5-3

Resolves: tdf#90214 set gtk[2|3] lightshadow halfway between darkshadow and bg

It will be available in 5.3.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

--- Comment #13 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=308b0fcd2081e2a2665b572d62f7f07de85e2b45

Resolves: tdf#90214 set gtk[2|3] lightshadow halfway between darkshadow and bg

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

--- Comment #12 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9a1e401c082e66ca4d66218e61e2690f89340762=libreoffice-5-3

Related: tdf#90214 gtk2 use a darkcolor based on the theme

It will be available in 5.3.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.4.0|target:5.4.0 target:5.3.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

--- Comment #11 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f50270ea5cb20c589edc2111e924124734ca

Related: tdf#90214 gtk2 use a darkcolor based on the theme

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

Luke  changed:

   What|Removed |Added

 Blocks||103182


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103182
[Bug 103182] [META] GTK3-specific bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

Björn Michaelsen  changed:

   What|Removed |Added

  Component|Writer  |graphics stack

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

Yousuf (Jay) Philips  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=94
   ||632

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

Joel Madero  changed:

   What|Removed |Added

   Severity|enhancement |minor

--- Comment #10 from Joel Madero  ---
Version: 5.3.0.0.alpha0+
Build ID: d1c0a77ed1ba96b29e9b260b9ea1696634a9a094
CPU Threads: 2; OS Version: Linux 3.16; UI Render: default; 
Locale: en-US (en_US.UTF-8); Calc: group

Still an issue.


Moving to a bug since it's a regression - makes no sense to have it as an
enhancement.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

--- Comment #8 from V Stuart Foote  ---
(In reply to Joel Madero from comment #7)
> Be my guest - saying "do more" is not sufficient to hold back a patch. As it
> stands the color scheme is horrible for dark themes. This resolves that
> issue. If you want to do more though, I'm not going to stop you. Absent
> that, I hope that a patch isn't held back because there should be a larger
> change (done at some unknown time at some point in the future by a yet
> unknown developer).

No, I'm only questioning doing something overly simplistic now, when correct
handling should really not be that much more complicated.

IIUC the issue only manifests when defaults for the colorscheme are not being
overloaded when using an OS/DE with dark theme. Why is that? Is it simply not
defined in the theme(s), or just not being mapped onto the element colors
defined in app/settings.cxx?

There are a few ways to tackle this, but a one off change in color assignment
is probably not the best way. It muddles the default colors and those of and
any lighter theme, and I am not so sure it fully corrects things for the Dark
themes.

I suspect we need to fix the methods for passing settings from OS/DE theme ->
colorscheme mapping, especially for the dark themes.

And as suggested, another way would be to expose these color controls to the
GUI and to the Expert Config dialogs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #6 from V Stuart Foote  ---
Joel M. has proposed a patch for this

https://gerrit.libreoffice.org/#/c/20644/

Solution may need to be more ambitious. Either expose elements of the Ruler UI
in Application Colors or possibly look at why the OS theme in use (dark or
light) is not also populating the colorscheme elements that the Ruler pulls
from.

=-ref-=
http://opengrok.libreoffice.org/xref/core/svtools/source/control/ruler.cxx
http://opengrok.libreoffice.org/xref/core/vcl/source/app/settings.cxx

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

--- Comment #7 from Joel Madero  ---
Be my guest - saying "do more" is not sufficient to hold back a patch. As it
stands the color scheme is horrible for dark themes. This resolves that issue.
If you want to do more though, I'm not going to stop you. Absent that, I hope
that a patch isn't held back because there should be a larger change (done at
some unknown time at some point in the future by a yet unknown developer).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

Joel Madero  changed:

   What|Removed |Added

 CC||momonas...@gmail.com

--- Comment #5 from Joel Madero  ---
@Maxim - you interested in this one?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

Luke lukebe...@hotmail.com changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=92
   ||776

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

Joel Madero jmadero@gmail.com changed:

   What|Removed |Added

 CC||jmadero@gmail.com
 Whiteboard|bibisectRequest |bibisected

--- Comment #4 from Joel Madero jmadero@gmail.com ---
So it's not entirely a regression - although under 4.0 it's worse. Under 3.x it
seems like at least the numbers are white but the stop markers are still dark
so it's still quite hard to manage.

Anyways - below if the bibisect for at least the numbering:

7cbcdae3f616c42e345dc92dfd17c957eecdccb9 is the first bad commit
commit 7cbcdae3f616c42e345dc92dfd17c957eecdccb9
Author: Bjoern Michaelsen bjoern.michael...@canonical.com
Date:   Sun Dec 9 04:38:55 2012 +

source-hash-bb36072c92687a954a38aeca7fb9945f8e7cca13

commit bb36072c92687a954a38aeca7fb9945f8e7cca13
Author: Caolán McNamara caol...@redhat.com
AuthorDate: Mon Apr 30 13:54:01 2012 +0100
Commit: Caolán McNamara caol...@redhat.com
CommitDate: Mon Apr 30 13:54:01 2012 +0100

g_source_get_current_time has been deprecated since version 2.28

g_source_get_current_time has been deprecated since version 2.28 and
should not
be used in newly-written code. ... This function ignores source and is
otherwise the same as g_get_current_time()

not using g_source_get_time seeing as our baseline isn't there yet

Change-Id: I9f389cbb8d23353c0a12eacb215d61256b28f643

:100644 100644 de536c71a2831ff44383cfc3d71fb50c892e5bc0
41c483e77a9ca1d1a9f17b23671e79f31eddbc1d Mccache.log
:100644 100644 8e253cb7bef7938ce138ac5e9173dcc7b765746f
5a86afbe393645c87d7b8752740f045519c22f7e Mcommitmsg
:100644 100644 a4708c68a86047fa937cf12d02235ab96a237915
b504bb9611fde69ccaa95f5bc54d0115b7367b11 Mdev-install.log
:100644 100644 760439c021441d95c64e40f76b80dbdbf3c99d11
f7887d14a9d386832bc75eee4091f7f444d604ad Mmake.log
:04 04 fc84d55fcc5d105bf2f3b3a890d1918a45a5105e
08bf3836f0f2a7efebb3fcf10e8683a905e9b194 Mopt
:100644 00 65c9a5f2ed3e153aaef732af2b65b93c0477843f
 Dpatch.log


# bad: [423a84c4f7068853974887d98442bc2a2d0cc91b]
source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e
# good: [65fd30f5cb4cdd37995a33420ed8273c0a29bf00]
source-hash-d6cde02dbce8c28c6af836e2dc1120f8a6ef9932
git bisect start 'latest' 'oldest'
# bad: [e02439a3d6297a1f5334fa558ddec5ef4212c574]
source-hash-6b8393474974d2af7a2cb3c47b3d5c081b550bdb
git bisect bad e02439a3d6297a1f5334fa558ddec5ef4212c574
# bad: [8f4aeaad2f65d656328a451154142bb82efa4327]
source-hash-1885266f274575327cdeee9852945a3e91f32f15
git bisect bad 8f4aeaad2f65d656328a451154142bb82efa4327
# good: [369369915d3582924b3d01c9b01167268ed38f3b]
source-hash-45295f3cdceb4c289553791071b5d7f4962d2ec4
git bisect good 369369915d3582924b3d01c9b01167268ed38f3b
# bad: [6fce03a944bf50e90cd31e2d559fe8705ccc993e]
source-hash-47e4a33a6405eb1b5186027f55bd9cb99b0c1fe7
git bisect bad 6fce03a944bf50e90cd31e2d559fe8705ccc993e
# bad: [8a39227e344637eb7154a10ac825d211e64d584c]
source-hash-f5080ebb7022c9f5d7d7fdca4fe9d19f9bb8cabf
git bisect bad 8a39227e344637eb7154a10ac825d211e64d584c
# good: [e8bc60acad752e284db73fc4d8ad383ac055361c]
source-hash-7e6e16ba6de2d3ef2b130d1ad5ffeabfdb37918e
git bisect good e8bc60acad752e284db73fc4d8ad383ac055361c
# good: [e1ec404400a4c6531a5d49d89631d1acc599071d]
source-hash-5708f2bfa70db0479ddbf9b454329cd81e0f509d
git bisect good e1ec404400a4c6531a5d49d89631d1acc599071d
# good: [09b0c68ed3c0cb7a96ac98146a67e9540df994c8]
source-hash-d50f02bec4a70bd26a518e4e76f4a876454ab937
git bisect good 09b0c68ed3c0cb7a96ac98146a67e9540df994c8
# bad: [7cbcdae3f616c42e345dc92dfd17c957eecdccb9]
source-hash-bb36072c92687a954a38aeca7fb9945f8e7cca13
git bisect bad 7cbcdae3f616c42e345dc92dfd17c957eecdccb9
# good: [b119645386363b75d60215f91775cba82c1c6126]
source-hash-3b328186706e6819acfea7b3a6dc8c9d3b6f9693
git bisect good b119645386363b75d60215f91775cba82c1c6126
# first bad commit: [7cbcdae3f616c42e345dc92dfd17c957eecdccb9]
source-hash-bb36072c92687a954a38aeca7fb9945f8e7cca13

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

Joel Madero jmadero@gmail.com changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=86
   ||617

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

Jay Philips philip...@hotmail.com changed:

   What|Removed |Added

   Keywords||regression
 CC|libreoffice-ux-advise@lists |philip...@hotmail.com
   |.freedesktop.org|
  Component|ux-advise   |Writer
 Whiteboard||bibisectRequest

--- Comment #3 from Jay Philips philip...@hotmail.com ---
Likely a duplicate of bug 86617.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90214] Ruler Should be White When Dark Themes Used

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90214

Jay Philips philip...@hotmail.com changed:

   What|Removed |Added

Summary|Rule Should be White When   |Ruler Should be White When
   |Dark Themes Used|Dark Themes Used

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs