[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Tor Lillqvist  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |t...@iki.fi
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #62 from Martin Srebotnjak  ---
Great, waiting for any new daily or pre-release builds available for macOS,
will report back.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.1.0|target:6.1.0 target:6.0.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #61 from Commit Notification 
 ---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f99b91ab0a67ce23f1c11bdb67370c0773813d15&h=libreoffice-6-0

tdf#103571: Avoid spurious heavy SalEvent::DisplayChanged callbacks

It will be available in 6.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #60 from Tor Lillqvist  ---
Would be great if you who have been able to reproduce the problem (using any
approach) could check whether it is fixed now in master. At least the way I
could reproduce this is definitely fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #59 from Martin Srebotnjak  ---
Sorry, meant 6.0.2 (6.0.2.1 was already built two days ago).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #58 from Martin Srebotnjak  ---
Could this patch make it into 6.0.1? Please?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #57 from Michael Meeks  ---
Patch looks good - although some comments in the gerrit back-port =)

I'd really like us to fix the cross-platform issue that this shows up though:

svx/source/tbxctrls/tbcontrl.cxx 's:
// HACK: Comparing is incomplete

Code seems bad to me - spending all this time doing ~nothing when we plug a
remote display in (and on every platform) also seems like a really poor use of
time =)

I'd like to investigate why this FontList comparison says the font list has
changed when this event occurs - triggering the expensive re-build of the
font-list - when it has not =)

Perhaps more interestingly - if that work is done at startup - before we create
a new top-level frame ;-) [ as it may well be ] can we do something to speed up
new window creation here by eg. deferring that work: just dirtying the
combo-box, or having a single item in it which is the current font, and
populating it only on first-click ? =) or somesuch clever.

Would be good to get a faster experience on all platforms from this if possible
=)

Would also be good to test changing the LCD font rendering settings [ if indeed
such settings exist ;-] on Linux which -should- cause the UI to completely
refresh - including these fonts: almost certainly it's not an issue because the
actual rendering (vs. measuring etc. in that list) should occur at a very low
level; but worth a check.

Thanks Tor ! =)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #56 from Commit Notification 
 ---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=715b7b6f346fdd9c856db268dcd66334b58c273c

tdf#103571: Avoid spurious heavy SalEvent::DisplayChanged callbacks

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #55 from Tor Lillqvist  ---
FYI, here is some timing debugging output from when just one Writer document
was open and I changed the Dock size:

> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen]
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen] took 0.06 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen]
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.027414 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen] took 0.027461 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen]
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.023375 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen] took 0.023460 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen]
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.023808 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen] took 0.023851 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen]
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.021801 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen] took 0.021874 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen]
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.008783 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen] took 0.008825 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen]
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.010233 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen] took 0.010275 s
> debug:90663:6971042: -[VCL_NSApplication screenParametersChanged]
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.022160 s
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.010850 s
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.023778 s
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.021911 s
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.024892 s
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.021507 s
> debug:90663:6971042: -[VCL_NSApplication screenParametersChanged] took 
> 0.125439 s

and here with three documents open:

> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen]
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen] took 0.07 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen]
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.074095 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen] took 0.074144 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen]
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.069474 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen] took 0.069551 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen]
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.068246 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen] took 0.068291 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen]
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.066944 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen] took 0.066994 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen]
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.024242 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen] took 0.024287 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen]
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.067261 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen] took 0.067301 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen]
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.066743 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen] took 0.066820 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen]
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.023351 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen] took 0.023382 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen]
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.025091 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen] took 0.025230 s
> debug:90663:6971042: -[SalFrameWindow windowDidChangeScreen]
> debug:90663:6971042:   AquaSalFrame::screenParametersChanged: CallCallback 
> took 0.026617 s
>

[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #54 from Tor Lillqvist  ---
Suggested fix at https://gerrit.libreoffice.org/50249

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #53 from Michael Meeks  ---
Nice trace - so; I imagine that DisplayChanged is presumably the right thing to
emit only when something changed - eg. the space available for the app (does
that happen when the dock re-sizes ?

Also - I'm suspicious of:

svx/source/tbxctrls/tbcontrl.cxx-else if ( ( rDCEvt.GetType() ==
DataChangedEventType::FONTS ) ||
svx/source/tbxctrls/tbcontrl.cxx:  ( rDCEvt.GetType() ==
DataChangedEventType::DISPLAY ) )

I guess this is perhaps to handle things like font-hint changes on Linux
(perhaps) - and I imagine that this particular font combo box is -very-
expensive to setup & re-render.

Might be nice to just use FONTS for that - and try to detect if any display
settings affect font rendering - and emit a FONTS changed if they do (?) =)

The:
// HACK: Comparing is incomplete

comment in lcl_GetDocFontList looks particularly interesting to investigate I
guess =) if we can avoid re-building it I imagine life is far better.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #52 from Tor Lillqvist  ---
Here is a sample stack trace from Xcode while it is doing something for very
long... Horror, horror.

#0  0x00010a9ca9b2 in CommonSalLayout::CommonSalLayout(CoreTextStyle
const&) at /Users/tml/lo/osx/vcl/source/gdi/CommonSalLayout.cxx:243
#1  0x00010a9caedd in CommonSalLayout::CommonSalLayout(CoreTextStyle
const&) at /Users/tml/lo/osx/vcl/source/gdi/CommonSalLayout.cxx:243
#2  0x00010abeafa0 in AquaSalGraphics::GetTextLayout(ImplLayoutArgs&,
int) at /Users/tml/lo/osx/vcl/quartz/salgdi.cxx:518
#3  0x00010a632f3b in OutputDevice::ImplLayout(rtl::OUString const&,
int, int, Point const&, long, long const*, SalLayoutFlags, vcl::TextLayoutCache
const*) const at /Users/tml/lo/osx/vcl/source/outdev/text.cxx:1335
#4  0x00010a634cb6 in OutputDevice::GetTextArray(rtl::OUString const&,
long*, int, int, vcl::TextLayoutCache const*, SalLayout const*) const at
/Users/tml/lo/osx/vcl/source/outdev/text.cxx:992
#5  0x00010a634a76 in OutputDevice::GetTextWidth(rtl::OUString const&,
int, int, vcl::TextLayoutCache const*, SalLayout const*) const at
/Users/tml/lo/osx/vcl/source/outdev/text.cxx:912
#6  0x00010a521f7b in
ImplListBoxWindow::ImplUpdateEntryMetrics(ImplEntryType&) at
/Users/tml/lo/osx/vcl/source/control/imp_listbox.cxx:640
#7  0x00010a5211d6 in ImplListBoxWindow::ImplCalcMetrics() at
/Users/tml/lo/osx/vcl/source/control/imp_listbox.cxx:556
#8  0x00010a522685 in ImplListBoxWindow::SetUserItemSize(Size const&)
at /Users/tml/lo/osx/vcl/source/control/imp_listbox.cxx:590
#9  0x00010a4be236 in ComboBox::SetUserItemSize(Size const&) at
/Users/tml/lo/osx/vcl/source/control/combobox.cxx:1256
#10 0x000109072f68 in FontNameBox::ImplCalcUserItemSize() at
/Users/tml/lo/osx/svtools/source/control/ctrlbox.cxx:826
#11 0x000109071ed1 in FontNameBox::Fill(FontList const*) at
/Users/tml/lo/osx/svtools/source/control/ctrlbox.cxx:800
#12 0x000107c01ac7 in SvxFontNameBox_Impl::Fill(FontList const*) at
/Users/tml/lo/osx/svx/source/tbxctrls/tbcontrl.cxx:227
#13 0x000107bdee68 in lcl_GetDocFontList(FontList const**,
SvxFontNameBox_Impl*) at /Users/tml/lo/osx/svx/source/tbxctrls/tbcontrl.cxx:958
#14 0x000107bdf89e in SvxFontNameBox_Impl::DataChanged(DataChangedEvent
const&) at /Users/tml/lo/osx/svx/source/tbxctrls/tbcontrl.cxx:1120
#15 0x0001820d72b0 in
framework::ToolBarManager::DataChanged(DataChangedEvent const*) at
/Users/tml/lo/osx/framework/source/uielement/toolbarmanager.cxx:1823
#16 0x0001820c0448 in
framework::ToolBarManager::LinkStubDataChanged(void*, DataChangedEvent const*)
at /Users/tml/lo/osx/framework/source/uielement/toolbarmanager.cxx:1807
#17 0x00010a41cca8 in Link::Call(DataChangedEvent const*) const at
/Users/tml/lo/osx/include/tools/link.hxx:84
#18 0x00010a41cc40 in ToolBox::DataChanged(DataChangedEvent const&) at
/Users/tml/lo/osx/vcl/source/window/toolbox.cxx:4081
#19 0x00010a460322 in vcl::Window::CompatDataChanged(DataChangedEvent
const&) at /Users/tml/lo/osx/vcl/source/window/window.cxx:3801
#20 0x00010a2df29f in vcl::Window::NotifyAllChildren(DataChangedEvent&)
at /Users/tml/lo/osx/vcl/source/window/event.cxx:43
#21 0x00010a2df2ec in vcl::Window::NotifyAllChildren(DataChangedEvent&)
at /Users/tml/lo/osx/vcl/source/window/event.cxx:48
#22 0x00010a2df2ec in vcl::Window::NotifyAllChildren(DataChangedEvent&)
at /Users/tml/lo/osx/vcl/source/window/event.cxx:48
#23 0x00010a2df2ec in vcl::Window::NotifyAllChildren(DataChangedEvent&)
at /Users/tml/lo/osx/vcl/source/window/event.cxx:48
#24 0x00010aa94443 in Application::NotifyAllWindows(DataChangedEvent&)
at /Users/tml/lo/osx/vcl/source/app/svapp.cxx:762
#25 0x00010a47cede in ImplHandleSalSettings(SalEvent) at
/Users/tml/lo/osx/vcl/source/window/winproc.cxx:2128
#26 0x00010a479be8 in ImplWindowFrameProc(vcl::Window*, SalEvent, void
const*) at /Users/tml/lo/osx/vcl/source/window/winproc.cxx:2474
#27 0x00010abfab55 in SalFrame::CallCallback(SalEvent, void const*)
const at /Users/tml/lo/osx/vcl/inc/salframe.hxx:279
#28 0x00010ac86c2f in AquaSalFrame::screenParametersChanged() at
/Users/tml/lo/osx/vcl/osx/salframe.cxx:271
#29 0x00010ad5b42d in ::-[VCL_NSApplication
screenParametersChanged:](NSNotification *) at
/Users/tml/lo/osx/vcl/osx/vclnsapp.mm:367

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #51 from Tor Lillqvist  ---
I wonder if a good fix would be to modify
AquaSalFrame::screenParametersChanged() so that if nothing actually has changed
(but we got the NSApplicationDidChangeScreenParametersNotification notification
because of something unessential like the Dock size changing), then don't call
CallCallback(SalEvent::DisplayChanged, nullptr).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #50 from Michael Meeks  ---
Hokay - so, lets compare it with the gtk3 backend which we know works; that
pulls events from the gdk event queue - and stuffs them back without processing
any =)

It also first calls gdk_events_pending() - which does the underlying socket I/O
to the X server (when using X) - via 'XPending()' -> XEventsQueued with
QueuedAfterFlush - but I don't see any event processing; particularly of the
glib mainloop which handles timeouts =)

Hence the "I don't expect that" really =)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #49 from Tor Lillqvist  ---
Ah yes, now I think I can reproduce it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #48 from Tor Lillqvist  ---
In fact, the documentation for the Win32 PeekMessage()
https://msdn.microsoft.com/en-us/library/windows/desktop/ms644943(v=vs.85).aspx
does describe that it is not as trivial as one might hope. "During this call,
the system delivers pending, nonqueued messages, that is, messages sent to
windows owned by the calling thread using the SendMessage, SendMessageCallback,
SendMessageTimeout, or SendNotifyMessage function. Then the first queued
message that matches the specified filter is retrieved. The system may also
process internal events."

And about SendMessage(), "The SendMessage function calls the window procedure
for the specified window and does not return until the window procedure has
processed the message".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #47 from Michael Meeks  ---
One thing that is ~obviously wrong is this:


frame #38: 0x0001150cbd8a
libvcllo.dylib`SalTimer::CallCallback(this=0x6001b630, idle=true) + 58
at saltimer.hxx:55
...
libvcllo.dylib`AquaSalInstance::AnyInput(this=0x608b9aa0,
nType=KEYBOARD) + 603 at salinst.cxx:786
frame #52: 0x000114f58ef6
libvcllo.dylib`Application::AnyInput(nType=KEYBOARD) + 38 at svapp.cxx:631

The windows impl of AnyInput doesn't look like it processes timers or events -
it is a real 'Peek' method - not expected to re-enter in a weird way:

vcl/win/app/salinst.cxx (WinSalInstance::AnyInput)

packed with this sort of thing:

if ( PeekMessageW( &aMsg, nullptr, 0, 0, PM_NOREMOVE | PM_NOYIELD ) )

vs.

vcl/osx/salinst.cxx (AquaSalInstance::AnyInput)

which does:

NSEvent* pEvent = [NSApp nextEventMatchingMask: nEventMask untilDate: nil
inMode: NSDefaultRunLoopMode dequeue: NO];

Which looks like a go-wild "run the loop" crazy thing ;-) which may be a wider
systemic problem highlighted here (?)

Are we adding timers to the wrong mode for that loop ? or do we need a custom
mode so we can exclude ~everything from running and just peek ? or perhaps a
different method call ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Martin Srebotnjak  changed:

   What|Removed |Added

   Severity|major   |critical

--- Comment #46 from Martin Srebotnjak  ---
Upping the importance to raise visibility of this bug.

Thanks to all who try to fix this one, it is really a painful one!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3690

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-02-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5422

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-01-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #45 from Telesto  ---
(In reply to Telesto from comment #44)
> Sorry, that's my eyeball estimation :-). Everything is working fine as long
> as the dock responds to the Dock Size slider. The issue starts when the Dock
> stops growing, while the slider is suggestion room for a larger one. It's
> probably set to the middle by default (and that's already to much for my 11"
> screen)

Dammit, this still isn't the whole story. The issue (also) arises with to many
windows minimised to the dock. At the point where the icons are shrinking.. :( 

1) Opened 15 blank documents
2) Minimise them all to the dock
2) Restore a minimised Writer document.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-01-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #44 from Telesto  ---
(In reply to Tor Lillqvist from comment #42)
> I don't see any percentage scale in the System Preferences > Dock > Size
> slider. When you talk about 50% or 40%, is that just an eyeballed
> estimation? After touching it, how do I get it back to the default? (Not
> that it matters much to me how big it is, I practically never use the Dock
> for anything, and of course I have it to auto-hide.)

Sorry, that's my eyeball estimation :-). Everything is working fine as long as
the dock responds to the Dock Size slider. The issue starts when the Dock stops
growing, while the slider is suggestion room for a larger one. It's probably
set to the middle by default (and that's already to much for my 11" screen)

My experience with Macs is very limited. So it might not be reproducible on
no-retina Macs and/or Macs with a smaller screen dimension.

Btw, no clue how the set it back to the default setting. Except for a new user
profile, or guessing the middle of the slider.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-01-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #43 from Martin Srebotnjak  ---
Probably he meant the zoom slider as shown in the status bar ...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-01-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #42 from Tor Lillqvist  ---
I don't see any percentage scale in the System Preferences > Dock > Size
slider. When you talk about 50% or 40%, is that just an eyeballed estimation?
After touching it, how do I get it back to the default? (Not that it matters
much to me how big it is, I practically never use the Dock for anything, and of
course I have it to auto-hide.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-01-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #41 from Alex Thurgood  ---

(In reply to Telesto from comment #39)
> Argh.. I probably found the cause. The dock size slider in System
> Preferences -> Dock is set halfway by default. However, the slider range is
> totally wrong. The dock size only changes between 0-40%. Setting the slider
> to 50% will cause a mismatch, triggering NSApplication notifications...


Yep. Confirming with

Version: 6.1.0.0.alpha0+
Build ID: 44e9bbc29cc37d2bac089b8f051478f62f7d5d31
CPU threads: 4; OS: Mac OS X 10.13.2; UI render: default; 
Locale: fr-FR (fr_FR.UTF-8); Calc: group threaded

I've managed to freeze LO completely just by opening up 20 new Writer documents
and then reducing one window, after setting the Dock to 50% with the slider. I
didn't need to send LO to sleep.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-01-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #40 from Telesto  ---
*** Bug 103126 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #39 from Telesto  ---
Argh.. I probably found the cause. The dock size slider in System Preferences
-> Dock is set halfway by default. However, the slider range is totally wrong.
The dock size only changes between 0-40%. Setting the slider to 50% will cause
a mismatch, triggering NSApplication notifications...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #38 from Telesto  ---
Odd, I still repro it with
Version: 6.1.0.0.alpha0+
Build ID: 6fc9d4a482ab50a1bf8fefb1dae2a6ded3c7e3dd
CPU threads: 4; OS: Mac OS X 10.13.3; UI render: default; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2018-01-24_04:46:24
Locale: nl-NL (nl_US.UTF-8); Calc: group threaded

with a regular daily build and with my own symbol only build..

*No special settings or applications or fonts
*No external monitor attached
*Java disabled

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #37 from Alex Thurgood  ---
I tested on Macmini 2014, 2,6 GHz Intel Core i5, 8 Go 1600 MHz DDR3, Intel Iris
1536 Mo.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #36 from Alex Thurgood  ---
No repro for me either now with

Version: 6.1.0.0.alpha0+
Build ID: 44e9bbc29cc37d2bac089b8f051478f62f7d5d31
CPU threads: 4; OS: Mac OS X 10.13.2; UI render: default; 
Locale: fr-FR (fr_FR.UTF-8); Calc: group threaded

Debug enabled build

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-01-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #35 from Telesto  ---
I still reproduce this, using the steps in comment 6
1) Opened 15 blank documents
2) Minimized three of the document windows.


Another way
1. Open System Preferences from the Apple menu and choose “Dock”
2. Check the box for “Automatically hide and show the Dock” by clicking the
checkbox next to it
3. Start Libreoffice Writer
4. Create 12-20 blank documents
5. Put your computer to sleep (by choosing Sleep from the Apple menu)
6. Wake Mac again
7. Create a new document (CMD + N)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #34 from Tor Lillqvist  ---
I can't seem to reproduce this, with a debugging build of current master on
High Sierra, on an iMac, with 20 empty Writer documents. Has the bug gone away
in master, or does it not happen in High Sierra, or is my machine so powerful
that I don't see it? Or what am I missing?

(I don't really think the last, this machine is not *that* much more powerful
than a 2014 MacBook Air, I should see some short amount of unresponsiveness if
the problem was there, I think. And anyway, this is a debugging (not optimised)
build, so performance problems should be more obvious than with a production
build.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2018-01-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #33 from Telesto  ---
(In reply to Michael Meeks from comment #13)
> Interesting trace - quite possibly we get 'screenParametersChanged' called
> when windows are minimized / maximised etc.

[...]

> Having said that 'DisplayChanged' - is really an event that should only get
> emitted when the physical display and/or monitor size changes - like
> plugging in a remote display etc.

"When changing the dock position Cocoa is firing a
NSApplicationDidChangeScreenParametersNotification:

The problem is that as for Apple Docs, it should be raised only when
Posted when the configuration of the displays attached to the computer is
changed. The configuration change can be made either programmatically or when
the user changes settings in the Displays control panel. The notification
object is sharedApplication. This notification does not contain a userInfo
dictionary.

So if you want to update your application windows when attach a new display
(e.g. changing/moving the frame of some HUD window/etc), you will have a fake
notification coming the dock."

Source:
https://stackoverflow.com/questions/7901826/cocoa-dock-fires-nsapplicationdidchangescreenparametersnotification

Also related: https://codereview.chromium.org/635363002

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-11-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #32 from Telesto  ---
For what it's worth:
The problem seems to starts with screenParametersChanged which leads to a
DisplayChanged event which leads to a DataChangedEventType::DISPLAY event
ending up refreshing all fonts (or something like that)

The screenParametersChanged 'broadcast' will happen even when I remove the
screenParametersChanged stuff here
https://opengrok.libreoffice.org/xref/core/vcl/osx/salinst.cxx#166
because of
https://opengrok.libreoffice.org/xref/core/vcl/osx/salframeview.mm#304

ScreenParametersChanged 'broadcast' will also happen when I comment out
https://opengrok.libreoffice.org/xref/core/vcl/osx/salframeview.mm#304
and letting salinst.cxx#166 intact.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-11-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #31 from Alex Thurgood  ---
@David : any thoughts on whether we can revert the commit in question or
whether it can be changed somehow to avoid the huge penalty it causes on MacOS
?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-11-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Alex Thurgood  changed:

   What|Removed |Added

 CC||jrk1231...@nym.hush.com

--- Comment #30 from Alex Thurgood  ---
*** Bug 113467 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-10-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||3468

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-10-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Korrawit Pruegsanusak  changed:

   What|Removed |Added

 Attachment #130356|application/octet-stream|application/zip
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-10-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Telesto  changed:

   What|Removed |Added

 Blocks||113023


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113023
[Bug 113023] [META] MacOS performance issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-10-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Telesto  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=10 |
   |4589|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Julien Nabet  changed:

   What|Removed |Added

 CC||dtar...@redhat.com

--- Comment #29 from Julien Nabet  ---
(In reply to Telesto from comment #28)
> (In reply to Julien Nabet from comment #27)
>...
> I most likely found the culprit. Things are back to normal after reverting:
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=0497864bd4f603605997938d504ef9598623e713

Good catch!

David: Thought you might be interested in this one. In comment 26, I found a
recursive loop which call the indicated function. Any idea how to fix this?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-10-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #28 from Telesto  ---
(In reply to Julien Nabet from comment #27)
> Argh, my suggestion is wrong since recursive loop would be useless.
> I thought we may transmit nLevel to CompatDataChanged and so towards all the
> DataChanged methods or adding a Datachanged method with 2 arguments for some
> cases?

I most likely found the culprit. Things are back to normal after reverting:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=0497864bd4f603605997938d504ef9598623e713

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-09-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #27 from Julien Nabet  ---
Argh, my suggestion is wrong since recursive loop would be useless.
I thought we may transmit nLevel to CompatDataChanged and so towards all the
DataChanged methods or adding a Datachanged method with 2 arguments for some
cases?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-09-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #26 from Julien Nabet  ---
Michael:
the pb seems to be in this part:
  7 libswlo.dylib SwEditWin::DataChanged(DataChangedEvent const&)
/Users/demo/lode/dev/core/sw/source/uibase/docvw/edtwin3.cxx:166
  8 libvcllo.dylib vcl::Window::CompatDataChanged(DataChangedEvent const&)
/Users/demo/lode/dev/core/vcl/source/window/window.cxx:3709
  9 libvcllo.dylib vcl::Window::NotifyAllChildren(DataChangedEvent&)
/Users/demo/lode/dev/core/vcl/source/window/event.cxx:43
  10 libvcllo.dylib vcl::Window::NotifyAllChildren(DataChangedEvent&)
/Users/demo/lode/dev/core/vcl/source/window/event.cxx:48

If I interpret this correctly, there's a recursive loop here:
41  void Window::NotifyAllChildren( DataChangedEvent& rDCEvt )
42  {
43  CompatDataChanged( rDCEvt );
44 
45  vcl::Window* pChild = mpWindowImpl->mpFirstChild;
46  while ( pChild )
47  {
48  pChild->NotifyAllChildren( rDCEvt ); <- recursive loop
49  pChild = pChild->mpWindowImpl->mpNext;
50  }
51  }

because of this CompatDataChanged is called many times, so fonts are reloaded
many times.

I thought about adding a "level" argument to NotifyAllChildren so we could
distinguish initial call of NotifyAllChildren with the recursive one.
CompatDataChanged should be called only by initial calls.

It would give:

if nLevel
CompatDataChanged( rDCEvt );
41  void Window::NotifyAllChildren( DataChangedEvent& rDCEvt, int nLevel /* by
default value = 0 */  )
42  {
43  if (nLevel) 
44  CompatDataChanged( rDCEvt );
45  vcl::Window* pChild = mpWindowImpl->mpFirstChild;
46  while ( pChild )
47  {
48  pChild->NotifyAllChildren( rDCEvt, nLevel+1 );
49  pChild = pChild->mpWindowImpl->mpNext;
50  }
51  }
what do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-09-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #25 from Telesto  ---
Created attachment 136089
  --> https://bugs.documentfoundation.org/attachment.cgi?id=136089&action=edit
Xcode instruments screenshots and BT

As requested in comment 9 a Xcode trace and some screenshots

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-05-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Alex Thurgood  changed:

   What|Removed |Added

 CC||mi...@filmsi.net

--- Comment #24 from Alex Thurgood  ---
*** Bug 107578 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-04-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6958

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-03-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6703

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-03-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6576

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-01-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #23 from Telesto  ---
@Meeks,
It seems to me that this one has a lot in common with bug 99784. The 'errors
and warnings' in the unwind report are nearly the same as in previous traces
for bug 99784. Noel Grandin and Caolán McNamara did a great job fixing them.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-01-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #22 from Michael Meeks  ---
Hey there - the good news is, I finally have an old 2nd hand Mac; but of
course, still -very- limited time - so, when I get a build hopefully can
reproduce & look into some of these issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-01-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Telesto  changed:

   What|Removed |Added

 Attachment #128655|0   |1
is obsolete||
 Attachment #130165|0   |1
is obsolete||

--- Comment #21 from Telesto  ---
Created attachment 130356
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130356&action=edit
LLDB Backtrace, Build Log

New backtrace
Version: 5.4.0.0.alpha0+
Build ID: 88f561204d7cee25633df8117cc8d7e1ebd8e9ad
CPU Threads: 4; OS Version: Mac OS X 10.12.2; UI Render: default; 
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-01-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #20 from Telesto  ---
Terminal output when launching Writer:
demos-MacBook-Air:~ demo$
/Applications/LibreOfficeDev2017.app/Contents/MacOS/soffice --writer
warn:sfx.control:531:1:sfx2/source/control/dispatch.cxx:562: Unflushed
dispatcher!
warn:unotools.config:531:1:unotools/source/config/configitem.cxx:426: ignoring
XHierarchicalNameAccess to /org.openoffice.Office.Compatibility// Exception: 
warn:unotools.config:531:1:unotools/source/config/configitem.cxx:426: ignoring
XHierarchicalNameAccess to /org.openoffice.Office.Compatibility// Exception: 
warn:sfx.control:531:1:sfx2/source/control/dispatch.cxx:562: Unflushed
dispatcher!
warn:sfx.control:531:1:sfx2/source/control/dispatch.cxx:562: Unflushed
dispatcher!
warn:sfx.control:531:1:sfx2/source/control/dispatch.cxx:562: Unflushed
dispatcher!

Version: 5.4.0.0.alpha0+
Build ID: 2d54ffbf18d461c846535d539d704d45aff059b1
CPU Threads: 4; OS Version: Mac OS X 10.12.2; UI Render: default; 
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-01-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Telesto  changed:

   What|Removed |Added

 Attachment #128344|0   |1
is obsolete||
 Attachment #128345|0   |1
is obsolete||
 Attachment #128463|0   |1
is obsolete||
 Attachment #128570|0   |1
is obsolete||
 Attachment #128576|0   |1
is obsolete||

--- Comment #19 from Telesto  ---
Created attachment 130165
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130165&action=edit
LLDB Backtrace, Build Log, Instruments Time Profile

An updated LLDB backtrace:
Version: 5.4.0.0.alpha0+
Build ID: 2d54ffbf18d461c846535d539d704d45aff059b1
CPU Threads: 4; OS Version: Mac OS X 10.12.2; UI Render: default; 
Locale: en-US (en_US.UTF-8); Calc: group

I also added an addition trace related to strange behavior while trying to
create a File Activity profile (but probably worthless)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2017-01-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Alex Thurgood  changed:

   What|Removed |Added

 CC||wiraw...@gmail.com

--- Comment #18 from Alex Thurgood  ---
*** Bug 105068 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2016-12-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4589

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2016-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

--- Comment #17 from Telesto  ---
Within the backtrace I noticed the following errors:

- “cannot write pidfile "
- @"AppKit cannot convert carbon event class '%.4s' to CGEventRef."
- @"AppKit cannot convert carbon mouse event of kind '%ld' to CGEventRef."
- @"AppKit cannot convert carbon mouse events of button '%ld' to CGEventRef."
- @"WARNING: nextEventMatchingMask should only be called from the Main Thread!
This will throw an exception in the future."
-
THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 103571] macOS 100% CPU usage when minimizing screen if multiple documents are opened

2016-11-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103571

Telesto  changed:

   What|Removed |Added

Summary|100% CPU usage when |macOS 100% CPU usage when
   |minimizing screen if|minimizing screen if
   |multiple documents are  |multiple documents are
   |opened  |opened

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs