[Libreoffice-bugs] [Bug 82402] START CENTER: Missing PPTX thumbnails

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82402

--- Comment #16 from Yousuf (Jay) Philips  ---
(In reply to Maxim Monastirsky from comment #15)
> (In reply to Yousuf (Jay) Philips from comment #14)
> > I would assume saving a more recent version of the thumbnail to the ODF
> Saving to ODF isn't affected by this, we're talking only about the thumbnail
> that's stored in the user profile. (And the actual file shouldn't change
> anyway, unless the user decides to save it.)

Yes correct.

> > This issue came to mind again when i saw a screenshot of the start center
> > with missing thumbnails in a review of 5.0
> Maybe those are for password protected files? I'm usually testing a lot of
> files from bugzilla, and never saw such thing except in this bug.

Just happened to me today that if i open any file in calc which has a chart, it
will ask me to save on exit even if i do not modify it. So i assume that is
what happened in that same screenshot.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82402] START CENTER: Missing PPTX thumbnails

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82402

--- Comment #15 from Maxim Monastirsky  ---
(In reply to Yousuf (Jay) Philips from comment #14)
> I would assume saving a more recent version of the thumbnail to the ODF
Saving to ODF isn't affected by this, we're talking only about the thumbnail
that's stored in the user profile. (And the actual file shouldn't change
anyway, unless the user decides to save it.)

> This issue came to mind again when i saw a screenshot of the start center
> with missing thumbnails in a review of 5.0
Maybe those are for password protected files? I'm usually testing a lot of
files from bugzilla, and never saw such thing except in this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82402] START CENTER: Missing PPTX thumbnails

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82402

--- Comment #14 from Yousuf (Jay) Philips philip...@hotmail.com ---
(In reply to Maxim Monastirsky from comment #13)
 [Sorry for the long post]

Thanks for the detailed explanation. :D

 1. This check seems to be needed only at file close, i.e. a user is closing
 the file, while rejecting the changes he made to it. But I wonder why do we
 need to refresh the recent list at all at this stage? In order to close a
 file, one first needs to open it, isn't it? So the recent item is *already
 exists*.

I would assume saving a more recent version of the thumbnail to the ODF file,
so that new preview could appear in something like a file manager preview would
be the intent here, as there wouldnt be a benefit for the start center.

 2. At least when the thumbnail creation method is called upon file open, why
 should we care whether the document is flagged as modified (for some
 reason), given that we know for sure that the document is just opened, and
 the user hadn't a chance to make any manual changes to it?

Yep that doesnt make sense to check if the modified flag is set right after LO
opens the doc.

 1. The real bug here is that documents are flagged as modified while they're
 not. (BTW I looked at SfxObjectShell::IsModified, and it seems that the
 modified state comes from the embedded charts. I commented there the code
 that checks the status of embedded objects, and this caused all of those
 files to show thumbnails in the start center.)

Yep this does seem to be the root of the problem (bug 82402).

 2. I don't like the idea of changing a working code (which is always a
 recipe for regressions), just to workaround some uncommon cases. We should
 consider this only if we'll see a critical mass of documents that won't show
 in the start center. We're still not there.

This issue came to mind again when i saw a screenshot of the start center with
missing thumbnails in a review of 5.0 (
http://me.pcmag.com/libreoffice-50/3008/review/libreoffice-50 ), though it was
for calc openable files.

http://im.ziffdavisinternational.com/t/pcmag_me/review/l/libreoffic/libreoffice-50_q6rn.320.jpg

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82402] START CENTER: Missing PPTX thumbnails

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82402

Yousuf (Jay) Philips philip...@hotmail.com changed:

   What|Removed |Added

 CC||momonas...@gmail.com
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=82
   ||400

--- Comment #10 from Yousuf (Jay) Philips philip...@hotmail.com ---
(In reply to Jan Holesovsky from comment #6)
 Turned out that the core of the issue here was something else; with some of
 the files, even with no change, LibreOffice asked for saving the file - and
 when you dismiss that, the thumbnail is not updated (which is correct
 behavior).

The issue of the undos is in bug 82400, but if dismissing changes doesnt update
the thumbnail, why wasnt a thumbnail added when i first opened the file, as
stuart states below.

(In reply to V Stuart Foote from comment #8)
 Although you do not save it, you have recently used it. So it gets added to
 the history of recent documents--and a thumbnail view is generated and
 displayed on the backing window of the Start Center in the thumbnail views
 panel. The same happens for any document, ODF, OOXML, MS, etc., that
 LibreOffice can fully open. That all works correctly.
 
...
 
 A new thumbnail view is generated when any document is opened, and is
 immediately added to the recent documents listing (per user in the
 registrymodifications.xcu configuration file)

@Maxim: Can you enlighten me on this, as it never sat well with me since kendy
closed it as invalid.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82402] START CENTER: Missing PPTX thumbnails

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82402

--- Comment #12 from Yousuf (Jay) Philips philip...@hotmail.com ---
(In reply to V Stuart Foote from comment #11)
 @Jay, not sure how Maxim will respond, but I just verified that a .PPTX
 simply opened and closed into Impress does generate a thumbnail view
 recorded into the per-user registrymodification.xcu routinely.

Well i was asking Maxim to look into the code as kendy is on holiday and was
quick to dismiss this issue, when there is an issue.

I can verify that opening (
http://cgit.freedesktop.org/libreoffice/core/plain/chart2/qa/extras/data/pptx/chart.pptx
) and xkill'ing LO will not generate a thumbnail, but doing the same with a
docx will generate a thumbnail. So your statement, A new thumbnail view is
generated when any document is opened, is not correct.

 Not sure, but expect if it were password protected the document would not
 receive a Thumbnail view--just its generic 128px Impress icon placeholder.

Well we werent talking about password protected documents, as they are not
supposed to have thumbnails.

What this boils down to is that LO has inconsistent behaviour for generating
thumbnails when opening a document (of course xkill'ing LO after the file is
open to see if the thumbnail is in the start center).

* Open some pptx - thumbnail generated
(http://cgit.freedesktop.org/libreoffice/core/plain/chart2/qa/extras/data/pptx/percentage-number-formats.pptx)

* Open some pptx - no thumbnail generated (
http://cgit.freedesktop.org/libreoffice/core/plain/chart2/qa/extras/data/pptx/chart.pptx
)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82402] START CENTER: Missing PPTX thumbnails

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82402

--- Comment #13 from Maxim Monastirsky momonas...@gmail.com ---
[Sorry for the long post]

We create/refresh saved thumbnail at different times, like file open/save/close
(see Bug 37775). But we do this only if the document is flagged as
non-modified, otherwise a generic icon is used, or a previously saved thumbnail
if there is any. In this bug a document is erroneously flagged as modified
right upon opening, so no valid thumbnail will be created.

The reason for this behavior (I guess) is that if a document is modified but
not saved, we don't want the unsaved modifications to be shown in the
thumbnail. What's not clear to me is:

1. This check seems to be needed only at file close, i.e. a user is closing the
file, while rejecting the changes he made to it. But I wonder why do we need to
refresh the recent list at all at this stage? In order to close a file, one
first needs to open it, isn't it? So the recent item is *already exists*. And
if modifications were made and were saved - then again, the thumbnail will be
updated already at this stage. The only uncovered case is when a user clears
the recent list using the Clear List menu item, while the document is open.
But I wonder whether it's a good idea to re-add the document to the list upon
closing, even though the user clearly showed his intention to keep the list
clear for now.

In case all of the above is correct - it means that the thumbnail creation
doesn't have to depend on whether the document was modified or not, and it will
solve this bug.

2. At least when the thumbnail creation method is called upon file open, why
should we care whether the document is flagged as modified (for some reason),
given that we know for sure that the document is just opened, and the user
hadn't a chance to make any manual changes to it?

As kendy is the one who introduced this is-modified check, would be great to
hear his opinion on this, and in particular what were the reasons for
introducing this check in the first place.



But I must clarify 2 things:

1. The real bug here is that documents are flagged as modified while they're
not. (BTW I looked at SfxObjectShell::IsModified, and it seems that the
modified state comes from the embedded charts. I commented there the code that
checks the status of embedded objects, and this caused all of those files to
show thumbnails in the start center.)

2. I don't like the idea of changing a working code (which is always a recipe
for regressions), just to workaround some uncommon cases. We should consider
this only if we'll see a critical mass of documents that won't show in the
start center. We're still not there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82402] START CENTER: Missing PPTX thumbnails

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82402

--- Comment #11 from V Stuart Foote vstuart.fo...@utsa.edu ---
(In reply to Yousuf (Jay) Philips from comment #10)

@Jay, not sure how Maxim will respond, but I just verified that a .PPTX simply
opened and closed into Impress does generate a thumbnail view recorded into the
per-user registrymodification.xcu routinely.

Not sure, but expect if it were password protected the document would not
receive a Thumbnail view--just its generic 128px Impress icon placeholder.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82402] START CENTER: Missing PPTX thumbnails

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=82402

Jay Philips philip...@hotmail.com changed:

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|WORKSFORME  |---

--- Comment #7 from Jay Philips philip...@hotmail.com ---
When i open a odt file and i make changes to it and when the close the doc and
tell it not to save changes, a thumbnail is still created, so how is this
behaviour any different here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82402] START CENTER: Missing PPTX thumbnails

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=82402

V Stuart Foote vstuart.fo...@utsa.edu changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |INVALID

--- Comment #8 from V Stuart Foote vstuart.fo...@utsa.edu ---
Jay, *,
(In reply to Jay Philips from comment #7)
 When i open a odt file and i make changes to it and when the close the doc
 and tell it not to save changes, a thumbnail is still created, so how is
 this behaviour any different here.

Although you do not save it, you have recently used it. So it gets added to the
history of recent documents--and a thumbnail view is generated and displayed on
the backing window of the Start Center in the thumbnail views panel. The same
happens for any document, ODF, OOXML, MS, etc., that LibreOffice can fully
open. That all works correctly.

The source of the thumbnail view is the same--it is regenerated when opening
any ODF document, and is only refreshed when/if document is saved.

Thumbnail views can be recorded into two locations--inside any ODF document
when it is saved, and always into the per-user configuration file holding the
recent documents list.

A thumbnail preview that is associated with an ODF document is recorded into
its zip'd archive Thumbnails folder as thumbnail.png -- but only when the
document is saved.  OOXML also have a facility to save thumbnails but I don't
believe we exploit it (e.g. in docProps as thumbnail.jpeg)--that would be in
the ww8 export filter.

A new thumbnail view is generated when any document is opened, and is
immediately added to the recent documents listing (per user in the
registrymodifications.xcu configuration file)

The thumbnail view obviously can not be written back to document formats that
don't support it. So those thumbnails will only exist with their recent
documents list entry per-user in registrymodifications.xcu.

The thumbnail view recorded into registrymodifications.xcu will be the initial
page view of any document when opened. Or--only if password protected--the
generic LibreOffice icon for the ODF type. 

Finally, if no preview thumbnail can be generated, the Start Center thumbnail
views panel displays the LibreOffice icon associated with the component that
can open it. A Base project for example.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82402] START CENTER: Missing PPTX thumbnails

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=82402

--- Comment #9 from Jay Philips philip...@hotmail.com ---
Thanks for the explanation Stuart, but that doesnt solve the issue. If i open
the pptx files and then close it and click save changes though i didnt make any
changes to the file, a thumbnail appears for the document in the start center.
If i open the pptx files and then close it without saving changes, no thumbnail
appears in the start center. This is the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82402] START CENTER: Missing PPTX thumbnails

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=82402

--- Comment #5 from Jan Holesovsky ke...@collabora.com ---
OK, so I've tested the bnc882383.pptx that is a slide with only a chart.

The problem here is that the chart is not visible in the thumbnail.  When I
insert a new slide as the 1st slide, with some text inside that, it gets a
thumbnail with the text etc.

So now it is not that pptx'es wouldn't get any thumbnails, it is that the exact
chart here is not thumbnailed...

Unfortunately this is a rather low priority for me, so cannot commit to fixing
this any time soon, so I am not sure it makes sense to keep the bug open; I'd
suggest to re-open if we get more reports of missing elements in the pptx (or
Impress in general) thumbnails.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82402] START CENTER: Missing PPTX thumbnails

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=82402

Jan Holesovsky ke...@collabora.com changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

--- Comment #6 from Jan Holesovsky ke...@collabora.com ---
Turned out that the core of the issue here was something else; with some of the
files, even with no change, LibreOffice asked for saving the file - and when
you dismiss that, the thumbnail is not updated (which is correct behavior).

So closing this bug is the correct thing to do, all works fine when confirming
that the file should be saved.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82402] START CENTER: Missing PPTX thumbnails

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=82402

--- Comment #4 from Jay Philips philip...@hotmail.com ---
Hi Stuart,

Kohei was the one who added these files and stated that libO opens them fine,
which is why i went ahead and tested them. It is possible that most of them are
not rendered correctly, but bnc882383.pptx is rendered correctly and still
shows a blank thumbnail in the start center. Or am i still mistaken?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82402] START CENTER: Missing PPTX thumbnails

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=82402

Jay Philips philip...@hotmail.com changed:

   What|Removed |Added

 Blocks||61914

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82402] START CENTER: Missing PPTX thumbnails

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=82402

V Stuart Foote vstuart.fo...@utsa.edu changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |WORKSFORME

--- Comment #3 from V Stuart Foote vstuart.fo...@utsa.edu ---
Each of these are problem OOXML .PPTX files that LibreOffice has issues with
opening and rendering. So, in reality they are not representative of the
handling of Thumbnail views in the StartCenter. 

On Windows 7 sp1, 64-bit en-US with
Version: 4.3.2.2
Build ID: edfb5295ba211bd31ad47d0bad0118690f76407d

A .PPTX or .PPT file opened correctly in LibreOffice records a Thumbnail image
into the users' registrymodifications.xcu as a recent document entry. That
image is parsed and rendered in the Thumbnail view panel of the Start Center.

That all functions correctly.

Closing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82402] START CENTER: Missing PPTX thumbnails

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=82402

Foss f...@openmailbox.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Foss f...@openmailbox.org ---
OK thumbnails are really odd for most of these files on OSX and win as well.
also tested linux and while I see a thumbnail it is not what the file looks
like: http://cl.ly/image/2B2w0w1x323W

NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82402] START CENTER: Missing PPTX thumbnails

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=82402

Jay Philips philip...@hotmail.com changed:

   What|Removed |Added

 Whiteboard||filter:pptx

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82402] START CENTER: Missing PPTX thumbnails

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=82402

--- Comment #1 from Jay Philips philip...@hotmail.com ---
Also of note is that bnc882383.pptx has a blank thumbnail, when the first slide
has a pie chart on it, similar to percentage-number-formats.pptx.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs