Re: [Libreoffice] [Libreoffice-ux-advise] Styles cleanup removing option page std fonts

2011-10-20 Thread Khaled Hosny
On Thu, Oct 20, 2011 at 12:41:36PM +0200, Astron wrote: Hi. On the whole, I like your plans, but... One of the ideas I think would be great, is having a small LibreOffice logo on the default document somewhere on the lower-right of the page. Or in the default footer. The logo is

Re: [Libreoffice] Reducing duplicating strings

2011-11-07 Thread Khaled Hosny
On Mon, Nov 07, 2011 at 10:35:41PM +0100, Lior Kaplan wrote: Hi, One of the things I noticed while working about LibO translation is the strong deja-vu feeling. I keep thinking - wait, I've already translated this string. I went to check the code, and found out there are actually a lot of

[Libreoffice] [PATCH] Fix Kashida justification when there is no Kashida glyph

2011-11-26 Thread Khaled Hosny
If the font has no Kashida glyph (or if its width is = 0) no Kashida gets inserted but the place of Kashida would still be filled with blank space (intercharacter) which is wrong. This patch removes the reasonable default value of mnMinKashida which makes no sense at all; either the font have a

Re: [Libreoffice] [PUSHED] [PATCH] Fix Kashida justification when there is no Kashida glyph

2011-11-28 Thread Khaled Hosny
Hi Thorsten, On Mon, Nov 28, 2011 at 11:57:04AM +0100, Thorsten Behrens wrote: Khaled Hosny wrote: This patch removes the reasonable default value of mnMinKashida which makes no sense at all; either the font have a Kashida glyph and mnMinKashida is set to its width or it doesn't

Re: [Libreoffice] Remember the RTL interface

2011-11-29 Thread Khaled Hosny
On Tue, Nov 29, 2011 at 11:12:36AM +0100, Matteo Casalin wrote: 2) Mirroring of checkmarks: in decoview there's a strange bug-related comment which says roughly don't mirror checkmarks in RTL, following by code that actually mirrors them. My questions are then: should they be mirrored or not,

[Libreoffice] [PATCH] Fix rendering of GTK combobox in RTL

2011-11-29 Thread Khaled Hosny
), would it be more rideable/save a few microsocends to have a bool isLayoutRTL = Application::GetSettings().GetLayoutRTL() (or something like that) on the top of the file? Regards, Khaled From a8fd7c4a5dbf57003339af883ae795eefe093f90 Mon Sep 17 00:00:00 2001 From: Khaled Hosny khaledho

Re: [Libreoffice] Remember the RTL interface

2011-11-29 Thread Khaled Hosny
On Tue, Nov 29, 2011 at 02:18:41AM +0200, Lior Kaplan wrote: Hi Guys, As 3.5.0 enters the first beta (ok, ok - beta0), I'd like to remind you on the RTL stuff from the conference last month. This isn't a mail for what about bug X, just taking the opportunity to send a general reminder...

Re: [Libreoffice] [PATCH] Fix rendering of GTK combobox in RTL

2011-12-02 Thread Khaled Hosny
On Wed, Nov 30, 2011 at 01:12:08PM +, Michael Meeks wrote: Hi Khaled, Thanks for your patch ! :-) On Wed, 2011-11-30 at 09:11 +0200, Khaled Hosny wrote: Here is a little patch that fixes a rendering buglet that annoyed me since ever. Native GTK applications swap the position

Re: [Libreoffice] [PATCH] Fix rendering of GTK combobox in RTL

2011-12-02 Thread Khaled Hosny
Oops, the patches :) On Fri, Dec 02, 2011 at 11:43:37PM +0200, Khaled Hosny wrote: On Wed, Nov 30, 2011 at 01:12:08PM +, Michael Meeks wrote: Hi Khaled, Thanks for your patch ! :-) On Wed, 2011-11-30 at 09:11 +0200, Khaled Hosny wrote: Here is a little patch that fixes

Re: [Libreoffice] Tell me Easy Hack 42782 remove a dog ! is a joke !

2011-12-15 Thread Khaled Hosny
Hi Julien, On Wed, Dec 14, 2011 at 11:03:15PM -0800, julien2412 wrote: Hello, This morning I'm still angry about this tracker. I read it yesterday and spoke my mind on IRC dev channel. I was glad I wasn't alone to think this easyhack is nonsense. I put a quick comment on this tracker but

Re: [Libreoffice] Tell me Easy Hack 42782 remove a dog ! is a joke !

2011-12-15 Thread Khaled Hosny
On Thu, Dec 15, 2011 at 11:58:52AM +, Michael Meeks wrote: On Thu, 2011-12-15 at 13:14 +0200, Khaled Hosny wrote: I'm really offended by ... This is a software project, if you have some political, cultural or religious agenda, please take it somewhere else. I'm sorry you're

Re: [Libreoffice] Tell me Easy Hack 42782 remove a dog ! is a joke !

2011-12-15 Thread Khaled Hosny
On Thu, Dec 15, 2011 at 05:05:34AM -0800, julien2412 wrote: I don't know if it's a French ideal, it's just the fact that an image of dog should'nt possibly offend anyone. True, if you consider only one culture, the fact is that the world is vastly different and what can't possibly offend anyone

Re: [Libreoffice] Remember the RTL interface

2011-12-16 Thread Khaled Hosny
On Wed, Dec 14, 2011 at 02:45:27AM +0200, Lior Kaplan wrote: On Wed, Nov 30, 2011 at 9:25 AM, Khaled Hosny khaledho...@eglug.org wrote: On Tue, Nov 29, 2011 at 02:18:41AM +0200, Lior Kaplan wrote: Hi Guys, As 3.5.0 enters the first beta (ok, ok - beta0), I'd like

[Libreoffice] [PATCH] Drop XLFD support from fontmanager

2012-01-13 Thread Khaled Hosny
XLFD support was removed in commit 269f91c (#i110171) except for parsing fonts.dir and fonts.alias. I don't think this makes much sense in fontconfig era, and dropping it simplifies the font manager a bit (I don't even think we use server fonts at all). --- vcl/generic/fontmanager/fontconfig.cxx

Re: [Libreoffice] [PATCH] Drop XLFD support from fontmanager

2012-01-13 Thread Khaled Hosny
On Fri, Jan 13, 2012 at 01:26:20PM +0200, Tor Lillqvist wrote: I don't even think we use server fonts at all). Funnily enough, we have a type called ServerFont... vcl/inc/generic/glyphcache.hxx , but that name is probably historical, and what it actually means nowadays is the exact

Re: [Libreoffice] [PATCH] Drop XLFD support from fontmanager

2012-01-13 Thread Khaled Hosny
On Fri, Jan 13, 2012 at 01:42:03PM +, Caolán McNamara wrote: On Fri, 2012-01-13 at 13:19 +0200, Khaled Hosny wrote: XLFD support was removed in commit 269f91c (#i110171) except for parsing fonts.dir and fonts.alias. I don't think this makes much sense in fontconfig era, and dropping

[Libreoffice] Horizontal glyph adjustments are ignored with ICU layout

2011-01-05 Thread Khaled Hosny
-- Khaled Hosny Arabic localiser and member of Arabeyes.org team Free font developer diff --git a/vcl/source/glyphs/gcach_layout.cxx b/vcl/source/glyphs/gcach_layout.cxx index cda8749..7531d2b 100644 --- a/vcl/source/glyphs/gcach_layout.cxx +++ b/vcl/source/glyphs/gcach_layout.cxx @@ -534,12 +534,35

Re: [Libreoffice] Horizontal glyph adjustments are ignored with ICU layout

2011-01-08 Thread Khaled Hosny
On Fri, Jan 07, 2011 at 11:25:33PM +0100, Thorsten Behrens wrote: Khaled Hosny wrote: Anyway, it turned out that the issue is not specific to kerning nor Arabic, but affects all horizontal glyph positioning in the ICU layout path; the problem does not show on Windows nor with Graphite fonts

Re: [Libreoffice] Oracle wordbook in LibO

2011-01-08 Thread Khaled Hosny
more technical terms than Italian do! For language not written in Latin script they are likely to get transliterated, we certainly do that in Arabic. Regards, Khaled -- Khaled Hosny Arabic localiser and member of Arabeyes.org team Free font developer

Re: [Libreoffice] Horizontal glyph adjustments are ignored with ICU layout

2011-01-11 Thread Khaled Hosny
width of fallback glyphs seems to be miscalculated when followed by kerned glyphs but I'm yet to understand what is going on with fallback. Testing with scripts that require glyph reordering still needed, but I don't speak any. Regards, Khaled -- Khaled Hosny Arabic localiser and member

Re: [Libreoffice] [FIXED] Re: debug build fails because graphite ./configure not up to date

2011-01-15 Thread Khaled Hosny
and then just upgrade to the latest graphite. BTW, Graphite engine is being re-written into a more stable engine (the current engine is crashy, or so I read), so it might be a good time to consider switching over to the new engine. Regards, Khaled -- Khaled Hosny Arabic localiser and member

Re: [Libreoffice] [libreoffice-users] Re: Which Unicode Standard LibreOffice uses...?

2011-01-25 Thread Khaled Hosny
...@openoffice.org (cc e...@openoffice.org, Eike Rathke), will help. Sorry, but I don't see what the issue being discussed here? And Arabic Presentation Forms have been in Unicode since version 2 or something. Regards, Khaled -- Khaled Hosny Arabic localiser and member of Arabeyes.org team Free

Re: [Libreoffice] [PUSHED] Re: Horizontal glyph adjustments are ignored with ICU layout

2011-02-03 Thread Khaled Hosny
On Fri, Jan 28, 2011 at 02:17:44PM +, Caolán McNamara wrote: Can we take it that your submission is under our recommended LGPLv3+/MPL licence ? Sure, this and any future submissions are LGPLv3+/MPL licensed. -- Khaled Hosny Egyptian

Re: [Libreoffice] [PUSHED] Re: Horizontal glyph adjustments are ignored with ICU layout

2011-02-03 Thread Khaled Hosny
-- Khaled Hosny Egyptian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Re: Horizontal glyph adjustments are ignored with ICU layout

2011-02-04 Thread Khaled Hosny
On Fri, Feb 04, 2011 at 11:00:34AM +, Michael Meeks wrote: On Thu, 2011-02-03 at 23:27 +0200, Khaled Hosny wrote: Indeed. A real long term fix is to drop ICU layout engine altogether and switch to HarfBuzz, however HarfBuzz lacks Indic shaper right now (promised to be there by March

[Libreoffice] No full justification in master?

2011-03-01 Thread Khaled Hosny
In locally built libreoffice master I can't get full justification; text is kept left aligned. I tested with the distro packaged 3.3.1 and justification is fine. Can anyone confirm this, or it is just me? Regards, Khaled -- Khaled Hosny Egyptian Arab

Re: [Libreoffice] No full justification in master?

2011-03-02 Thread Khaled Hosny
On Tue, Mar 01, 2011 at 05:19:36PM +0100, Thomas Arnhold wrote: Hi Khaled, On 03/01/2011 05:10 PM, Khaled Hosny wrote: In locally built libreoffice master I can't get full justification; text is kept left aligned. I tested with the distro packaged 3.3.1 and justification is fine. Can

Re: [Libreoffice] fixing kashida insertion

2011-03-15 Thread Khaled Hosny
of OOo/LO for Arabic users, I was planing to play with it but unfortunately I'll not be able to put much effort into this. Regards, Khaled -- Khaled Hosny Egyptian Arab ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

Re: Modern font features, hacky patch

2012-07-20 Thread Khaled Hosny
On Fri, Mar 30, 2012 at 03:27:39PM +0100, Caolán McNamara wrote: On Fri, 2012-03-30 at 16:13 +0200, Khaled Hosny wrote: If there is interest in this, I can try implementing optional HarfBuzz support next to ICU so we can experiment more with this (though I'm not the best person to do

Re: Modern font features, hacky patch

2012-07-21 Thread Khaled Hosny
On Sat, Jul 21, 2012 at 03:08:20AM +0200, Khaled Hosny wrote: On Fri, Mar 30, 2012 at 03:27:39PM +0100, Caolán McNamara wrote: On Fri, 2012-03-30 at 16:13 +0200, Khaled Hosny wrote: If there is interest in this, I can try implementing optional HarfBuzz support next to ICU so we can

Re: Modern font features, hacky patch

2012-07-21 Thread Khaled Hosny
On Sat, Jul 21, 2012 at 09:51:09PM +0200, Matúš Kukan wrote: On 21 July 2012 18:20, Khaled Hosny khaledho...@eglug.org wrote: Here is a very crude, WIP patch. It adds --enable-harfbuzz configure option, plus some (very broken) harfbuzz layout code, but I can't get the ENABLE_HARFBUZZ

Re: Enable CTL for Default?

2012-06-19 Thread Khaled Hosny
On Tue, Jun 19, 2012 at 12:52:24PM -0500, Norbert Thiebaud wrote: On Tue, Jun 19, 2012 at 8:41 AM, Christian Lohmaier * not treating CTL/Asian scripts as second class (quotenot to mention that Asian is a so ignorant orientalistic term in this context/quote)

Re: [Libreoffice-ux-advise] Enable CTL for Default?

2012-06-28 Thread Khaled Hosny
On Thu, Jun 28, 2012 at 10:21:57AM +0200, Stefan Knorr (Astron) wrote: * I am not sure about Cursor Movement, but I've tried the options and visual seems to behave rather buggy – if it weren't it would likely be the best option I always set it to visual, logical seems very unprediuctable to me

Re: On SSL library support

2012-05-04 Thread Khaled Hosny
On Fri, May 04, 2012 at 03:16:59PM +0200, Enrico Weigelt wrote: Otherwise it's practical use is limited to pure desktop-only environments. Of course, given that LibreOffice is not a desktop application, oh wait... ___ LibreOffice mailing list

Re: On SSL library support

2012-05-04 Thread Khaled Hosny
On Fri, May 04, 2012 at 03:57:49PM +0200, Enrico Weigelt wrote: On Fri, May 04, 2012 at 03:16:59PM +0200, Enrico Weigelt wrote: Otherwise it's practical use is limited to pure desktop-only environments. Of course, given that LibreOffice is not a desktop application, oh wait...

Re: Modern font features, hacky patch

2012-09-07 Thread Khaled Hosny
On Fri, Sep 07, 2012 at 05:18:46PM +0100, Caolán McNamara wrote: On Sat, 2012-07-21 at 18:20 +0200, Khaled Hosny wrote: Here is a very crude, WIP patch. It adds --enable-harfbuzz configure option, plus some (very broken) harfbuzz layout code, but I can't get the ENABLE_HARFBUZZ to propagate

Re: [Libreoffice] Need help to generate patch with git

2011-08-30 Thread Khaled Hosny
-patch' has produced two files, one for each commit. Is there a way, to get _one_ patch file? For the second commit use `git commit --ammend`. Regards, Khaled -- Khaled Hosny Egyptian Arab ___ LibreOffice mailing list LibreOffice

Re: [Libreoffice] Need help to generate patch with git

2011-08-30 Thread Khaled Hosny
On Wed, Aug 31, 2011 at 03:11:58AM +0200, Eike Rathke wrote: Hi Khaled, On Wednesday, 2011-08-31 02:05:10 +0200, Khaled Hosny wrote: Now the command 'format-patch' has produced two files, one for each commit. Is there a way, to get _one_ patch file? For the second commit use `git

[Libreoffice] [PATCH] some cleanup of Kashida justification code

2011-08-31 Thread Khaled Hosny
Hello all, While trying to fix the eternal brokenness of Kashida justification code, I found some low hanging cleanups. See attached patches. Regards, Khaled -- Khaled Hosny Egyptian Arab From 7c237af83055a9b892e7349ee08af92b7202b09c Mon Sep 17 00:00:00 2001 From: Khaled Hosny khaledho

Re: [Libreoffice] [PUSHED] Bringing some sanity to interline spacing

2011-08-31 Thread Khaled Hosny
On Thu, Sep 01, 2011 at 02:13:34AM +0200, Eike Rathke wrote: Hi Khaled, On Monday, 2011-08-29 20:21:47 +0200, Khaled Hosny wrote: Wow, way cool stuff! :-) :) #38683[5] is another example of problems caused by this. I'll set that bug to fixed with a remark to verify as I don't have

Re: [Libreoffice] [PUSHED] some cleanup of Kashida justification code

2011-08-31 Thread Khaled Hosny
, Khaled -- Khaled Hosny Egyptian Arab signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] some cleanup of Kashida justification code

2011-08-31 Thread Khaled Hosny
On Wed, Aug 31, 2011 at 10:32:35PM -0400, Kohei Yoshida wrote: On Thu, 2011-09-01 at 03:15 +0200, Khaled Hosny wrote: BTW, I see you merged the three patches in one commit, though I thought splitting them into more confined changes would be preferred. Is there any general policy

Re: [Libreoffice] Bringing some sanity to interline spacing

2011-09-01 Thread Khaled Hosny
even be desirable to keep Mac as is. Lastly, can you confirm that your patch is licensed under LGPLv3+ and MPL1.1? Like my previous patches, all are LGPLv3+ and MPL1.1 licensed (though the patch have been already committed :) ) Regards, Khaled -- Khaled Hosny Egyptian Arab

Re: [Libreoffice] Bringing some sanity to interline spacing

2011-09-01 Thread Khaled Hosny
24 to 22 after applying the patch, a quite a drastic change I think :( One the bright side, I'm no longer getting oversized buttons and combo boxes. Regards, Khaled -- Khaled Hosny Egyptian Arab ___ LibreOffice mailing list LibreOffice

Re: [Libreoffice] Bringing some sanity to interline spacing

2011-09-01 Thread Khaled Hosny
On Thu, Sep 01, 2011 at 02:43:53PM +0100, Caolán McNamara wrote: On Thu, 2011-09-01 at 11:47 +0200, Khaled Hosny wrote: I just tested with a simple lorem ipsum document with Liberation Serif; page count went down from 24 to 22 after applying the patch Comparison with MSWord will be good

Re: [Libreoffice] Bringing some sanity to interline spacing

2011-09-01 Thread Khaled Hosny
, file a bug asking for that, is that still the correct procedure?) Thanks for the offer, but I feel more comfortable this way knowing that another pair of eyes will, hopefully :), check the code before committing it. Regards, Khaled -- Khaled Hosny Egyptian Arab

Re: [Libreoffice] Bringing some sanity to interline spacing

2011-09-01 Thread Khaled Hosny
not support Indic scripts in their OpenType implementation, while FOSS font stack does). It also means less code to maintain and debug. But I'm still far from understanding the current text layout code to seriously propose this. Mozilla is moving into this direction as well. Regards, Khaled -- Khaled

Re: [Libreoffice] Bringing some sanity to interline spacing

2011-09-02 Thread Khaled Hosny
On Thu, Sep 01, 2011 at 10:31:14AM +0200, Khaled Hosny wrote: It shouldn't be hard to adapt GetFontMetric implementation in vcl/win/source/gdi/salgdi3.cxx to use the new function and have the same logic as the unix code. Here is a patch that, hopefully, does this, but I couldn't test

Re: [Libreoffice] Bringing some sanity to interline spacing

2011-09-02 Thread Khaled Hosny
On Fri, Sep 02, 2011 at 11:23:14AM +0100, Caolán McNamara wrote: On Thu, 2011-09-01 at 23:31 +0200, Khaled Hosny wrote: On Thu, Sep 01, 2011 at 02:43:53PM +0100, Caolán McNamara wrote: On Thu, 2011-09-01 at 11:47 +0200, Khaled Hosny wrote: I just tested with a simple lorem ipsum document

Re: [Libreoffice] Bringing some sanity to interline spacing

2011-09-04 Thread Khaled Hosny
that there are probably many areas in several applications to be adapted to the new behavior. Maybe best we make that an option until necessary changes are done. Opinions? That fine with me, even having the new algorithm as an off by default option would be fine. Regards, Khaled -- Khaled Hosny

Re: [Libreoffice] Bringing some sanity to interline spacing

2011-09-09 Thread Khaled Hosny
On Fri, Sep 09, 2011 at 06:39:52PM +0200, Eike Rathke wrote: Hi Khaled, On Friday, 2011-09-02 18:21:50 +0200, Khaled Hosny wrote: MSWord is not known for its sane handling of font metrics, and I have been told recent (2007-) broke it even further. Hum, ending up with .docs

Re: [Libreoffice] Need to add Arabic Math Symbols to LibreOffice Math

2011-09-15 Thread Khaled Hosny
-- Khaled Hosny Egyptian Arab ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [ANNOUNCE] Changes to the build system: Env.Host.sh is dead so is the need to source the environment

2012-02-06 Thread Khaled Hosny
On Sun, Feb 05, 2012 at 07:42:14PM -0600, Norbert Thiebaud wrote: HI all, I have pushed a series of commit that completely remove set_soenv.in and the creation of Env.Host.sh/Env.Build.sh Great! However, running git `grep set_soenv1`, shows many remnants of set_soenv.*, just in case someone

Re: OK to merge the fw? libraries in framework?

2012-02-08 Thread Khaled Hosny
On Wed, Feb 08, 2012 at 06:39:05PM +0100, Michael Stahl wrote: On 08/02/12 18:10, Tor Lillqvist wrote: While trying to find easy ways to lower the number of (shared) libraries, which is more or less on the critical path for the Android work (the stupid run-time linker on Android has a low

Wrong screenshot in 3.5 features page

2012-02-14 Thread Khaled Hosny
Not sure to which mailing list should I report this, so I'm sending to the one I'm subscribed to :) In http://www.libreoffice.org/download/3-5-new-features-and-fixes/, the screenshot under The Insert Movie and Sound dialog... actually is the one for Several GTK+ right-to-left interface

Re: Wrong screenshot in 3.5 features page

2012-02-14 Thread Khaled Hosny
On Tue, Feb 14, 2012 at 02:37:32PM +0100, Andras Timar wrote: Hi Khaled, 2012/2/14 Khaled Hosny khaledho...@eglug.org: Not sure to which mailing list should I report this, so I'm sending to the one I'm subscribed to :) In http://www.libreoffice.org/download/3-5-new-features-and-fixes

Re: Ligatures in arabic fonts

2012-02-27 Thread Khaled Hosny
On Mon, Feb 27, 2012 at 01:11:03PM +0100, Tomáš Chvátal wrote: Hello guys, I have bug reported at gentoo [1] which I am not entirely sure how to sort out. I suspected graphite2 to be the culprit but it is indeed broken with both system and internal one. Also if I build the libreoffice on

Re: A Desugn Suggestion

2012-03-01 Thread Khaled Hosny
On Thu, Mar 01, 2012 at 11:06:41AM +, Arnold Bailson wrote: I realize that this may not be the right place for this suggestion. If that is so, my apologies: please pass it on to the correct place. I now have macular degeneration in my second eye. I find it convenient when reading to use

Re: Question about less-than and greater-than in Arabic

2012-03-19 Thread Khaled Hosny
Hi Kendy, On Mon, Mar 19, 2012 at 09:51:24AM +0100, Jan Holesovsky wrote: Hi Khaled, I've got the following report: - 8 - The Arabic keyboard layout in X11 has the less-than sign () on the same position as the left curly bracket ({) in the English keyboard layout. Same for and

Re: Modern font features, hacky patch

2012-03-30 Thread Khaled Hosny
On Fri, Mar 30, 2012 at 01:11:59PM +0100, Caolán McNamara wrote: On Fri, 2012-03-30 at 11:39 +0200, Steve White wrote: Basic features == (Background reading: search for typographic features, font feature registry, layout tag registry.) Some features that really ought to

Re: Mirroring gtk buttons

2013-03-06 Thread Khaled Hosny
On Wed, Mar 06, 2013 at 05:45:57AM +, Issa Alkurtass wrote: Hello world, Any idea how to mirror gtk buttons in vcl? I need to mirror the combo box buttons in vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx for the RTL interface. (screenshot: http://i.imgur.com/XAnvum8.png) I thought this

Re: Mirroring gtk buttons

2013-03-06 Thread Khaled Hosny
On Wed, Mar 06, 2013 at 11:38:14AM +, Issa Alkurtass wrote: Michael Meeks wrote on March 06, 2013 2:13 PM: Urk - so - then I guess it is a matter of persuading each of our captive gtk2 widgets to have the right RTL setting via: void gtk_widget_set_direction (GtkWidget

Re: Mirroring gtk buttons

2013-03-06 Thread Khaled Hosny
On Wed, Mar 06, 2013 at 12:05:23PM +, Michael Meeks wrote: On Wed, 2013-03-06 at 11:38 +, Issa Alkurtass wrote: Something like that yes, but this function is only concerned with text direction and ordering of items, not graphical orientation. We need something that flips or

Re: A little info about ligatures and e.g. Calibri

2013-02-03 Thread Khaled Hosny
On Sun, Feb 03, 2013 at 03:39:36PM +, Caolán McNamara wrote: FWIW, as it came up as a question in the main track FOSDEM LibreOffice talk, in vcl/generic/glyphs/gcach_layout.cxx see IcuLayoutEngine::layout and... if (rArgs.mnFlags SAL_LAYOUT_ENABLE_LIGATURES) nLayoutFlags |=

Re: A little info about ligatures and e.g. Calibri

2013-02-03 Thread Khaled Hosny
On Sun, Feb 03, 2013 at 04:15:00PM +, Caolán McNamara wrote: On Sun, 2013-02-03 at 17:58 +0200, Khaled Hosny wrote: I see Calibri only, no etc's :), so blocking ligature support (which is so 80s, even MS Office now supports OpenType features for Latin) because is of a bug in a single

Re: [PATCH] Add HarfBuzz support to the build system

2013-04-21 Thread Khaled Hosny
, 2013 at 08:19:15AM +, Khaled Hosny (via Code Review) wrote: Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3517 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/3517/1 Add HarfBuzz support to the build

[Libreoffice-commits] core.git: config_host/config_harfbuzz.h.in config_host.mk.in configure.ac download.lst harfbuzz/ExternalPackage_harfbuzz.mk harfbuzz/ExternalProject_harfbuzz.mk harfbuzz/harfbuzz

2013-04-23 Thread Khaled Hosny
7e389f4def1964ee38bb93b575926a089e84bae6 Author: Khaled Hosny khaledho...@eglug.org Date: Sat Apr 20 13:00:56 2013 +0200 Add HarfBuzz support to the build system To be used in the next commit. Change-Id: I6ee286d0c050a5ca650e7fb3692b0facccb5f0c0 Reviewed-on: https

[Libreoffice-commits] core.git: vcl/generic

2013-04-23 Thread Khaled Hosny
vcl/generic/glyphs/gcach_layout.cxx | 395 ++-- 1 file changed, 379 insertions(+), 16 deletions(-) New commits: commit b760eff8cb65aba99b4527232140926bb4e11e82 Author: Khaled Hosny khaledho...@eglug.org Date: Sat Apr 20 19:16:54 2013 +0200 Add support

[Libreoffice-commits] core.git: vcl/generic

2013-04-23 Thread Khaled Hosny
vcl/generic/glyphs/gcach_layout.cxx | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit 9d4395540a10916d471579618d7bf3b60cd49140 Author: Khaled Hosny khaledho...@eglug.org Date: Tue Apr 23 12:39:07 2013 +0200 Fix glyph width calculation in HarfBuzz

Re: [PATCH] fdo#35320 A fix for Arabic justification problem caused by k...

2013-04-28 Thread Khaled Hosny
On Sun, Apr 28, 2013 at 06:04:04AM +, Ahmad Harthi (via Code Review) wrote: Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3644 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/3644/1 fdo#35320 A fix for

[Libreoffice-commits] core.git: 9 commits - vcl/generic vcl/inc

2013-04-29 Thread Khaled Hosny
: Khaled Hosny khaledho...@eglug.org Date: Sun Apr 28 15:56:26 2013 +0200 [harfbuzz] Re-enable text justification It turned out that ApplyDXArray() is need to apply advance width adjustments after justification, so we can't just bypass it. So I just copied GenericSalLayout

[Libreoffice-commits] core.git: vcl/generic

2013-04-29 Thread Khaled Hosny
vcl/generic/glyphs/gcach_layout.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3719396649c8c944727f89c517a8191cd37b2499 Author: Khaled Hosny khaledho...@eglug.org Date: Mon Apr 29 22:13:44 2013 +0200 [harfbuzz] Don't crash when closing LibreOffice

[Libreoffice-commits] core.git: vcl/generic

2013-05-01 Thread Khaled Hosny
vcl/generic/glyphs/gcach_layout.cxx | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) New commits: commit 84a8f817e174855ef72f0bafc734847690c5d736 Author: Khaled Hosny khaledho...@eglug.org Date: Tue Apr 30 17:16:17 2013 +0200 [harfbuzz] Simplify cluster detection

[Libreoffice-commits] core.git: 2 commits - vcl/generic

2013-05-01 Thread Khaled Hosny
vcl/generic/glyphs/gcach_layout.cxx | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) New commits: commit 76abedd3bd1c91cac9b239f746243df00a58d060 Author: Khaled Hosny khaledho...@eglug.org Date: Thu May 2 06:19:38 2013 +0200 [harfbuzz] Fix shaping across text runs

[Libreoffice-commits] core.git: vcl/generic

2013-05-03 Thread Khaled Hosny
vcl/generic/glyphs/gcach_layout.cxx | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) New commits: commit 405dc9d241f617853c77e60b0b0d41c36b5af33d Author: Khaled Hosny khaledho...@eglug.org Date: Fri May 3 23:39:19 2013 +0200 [harfbuzz] Fix placement of multi-glyph

Use of markup in .ui strings

2012-10-20 Thread Khaled Hosny
Hi all, Commit 8274df8 seems to have introduced the use of markup in .ui files to set text in bold, however this is not really a good idea l10n-wise as it is very error-prone, Gnome is actually moving away from using markup in translatable strings[1], which I think something LibreOffice should

Re: Use of markup in .ui strings

2012-10-25 Thread Khaled Hosny
On Thu, Oct 25, 2012 at 03:33:34PM +0100, Caolán McNamara wrote: On Mon, 2012-10-22 at 14:14 +0100, Caolán McNamara wrote: On Sun, 2012-10-21 at 00:47 +0200, Khaled Hosny wrote: Hi all, Commit 8274df8 seems to have introduced the use of markup in .ui files to set text in bold

Re: Modern font features, hacky patch

2012-10-27 Thread Khaled Hosny
On Fri, Sep 07, 2012 at 06:43:26PM +0200, Khaled Hosny wrote: On Fri, Sep 07, 2012 at 05:18:46PM +0100, Caolán McNamara wrote: On Sat, 2012-07-21 at 18:20 +0200, Khaled Hosny wrote: Here is a very crude, WIP patch. It adds --enable-harfbuzz configure option, plus some (very broken

Re: Modern font features, hacky patch

2012-11-03 Thread Khaled Hosny
On Sun, Oct 28, 2012 at 09:37:05AM +0100, Matúš Kukan wrote: On 28 October 2012 02:59, Khaled Hosny khaledho...@eglug.org wrote: Realizing that I might not get around fixing basic issues with HarfBuzz integration anytime soon, I'm attaching preliminary patches I've for any one interested

[Libreoffice-commits] core.git: vcl/generic

2013-05-05 Thread Khaled Hosny
vcl/generic/glyphs/gcach_layout.cxx |9 + 1 file changed, 9 insertions(+) New commits: commit 784cd10c31e4378e5b9d03791154e01d23867120 Author: Khaled Hosny khaledho...@eglug.org Date: Sun May 5 21:10:52 2013 +0200 [harfbuzz] Fix vertical text layout Fixed in the sense

[Libreoffice-commits] core.git: 2 commits - vcl/generic vcl/inc vcl/source

2013-05-05 Thread Khaled Hosny
9a8f125fa7e63b829471a6722dae3006bb1f57d2 Author: Khaled Hosny khaledho...@eglug.org Date: Mon May 6 01:40:06 2013 +0200 [harfbuzz] Support Unicode variation selectors Change-Id: I8c56f45505327857613c39b28da3ae7cc3ad201c diff --git a/vcl/generic/glyphs/gcach_ftyp.cxx b/vcl/generic

[Libreoffice-commits] core.git: 3 commits - config_host/config_harfbuzz.h.in configure.ac vcl/generic vcl/inc vcl/source

2013-05-06 Thread Khaled Hosny
/sallayout.hxx | 11 +++ vcl/source/gdi/sallayout.cxx|2 +- 7 files changed, 17 insertions(+), 50 deletions(-) New commits: commit bff8fa97e16f0f06fddc5545ea36c8bd2b18a580 Author: Khaled Hosny khaledho...@eglug.org Date: Mon May 6 11:08:29 2013 +0200 Enable HarfBuzz

[Libreoffice-commits] core.git: vcl/source

2013-05-06 Thread Khaled Hosny
vcl/source/gdi/outdev3.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7556ba312ff3a7409b7da55f220d3ff877505a3b Author: Khaled Hosny khaledho...@eglug.org Date: Mon May 6 21:41:14 2013 +0200 Surely the intent was to check for !pFallback here

[Libreoffice-commits] core.git: 2 commits - vcl/coretext

2013-05-09 Thread Khaled Hosny
vcl/coretext/salgdi.cxx |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) New commits: commit 543ac5596d0ef3a052973c1ec89a9329d1073dc8 Author: Khaled Hosny khaledho...@eglug.org Date: Thu May 9 23:49:45 2013 +0200 Minor Change-Id

[Libreoffice-commits] core.git: vcl/coretext

2013-05-10 Thread Khaled Hosny
vcl/coretext/salcoretextlayout.cxx | 47 + 1 file changed, 38 insertions(+), 9 deletions(-) New commits: commit f2b92a9ab5d1b0c7d3d01db675268b0e1925cdc6 Author: Khaled Hosny khaledho...@eglug.org Date: Fri May 10 17:05:24 2013 +0200 [coretext] Fix

[Libreoffice-commits] core.git: 5 commits - config_host.mk.in configure.ac vcl/generic

2013-05-11 Thread Khaled Hosny
: Khaled Hosny khaledho...@eglug.org Date: Sat May 11 08:44:11 2013 +0200 USE_FT_EMBOLDEN has never been used Change-Id: Idd30f6fcf9d1e4d2af5f49caffa91d6ce30bb196 diff --git a/config_host.mk.in b/config_host.mk.in index cfe407c..76ac1a7 100644 --- a/config_host.mk.in +++ b

[Libreoffice-commits] core.git: vcl/coretext

2013-05-11 Thread Khaled Hosny
vcl/coretext/salcoretextlayout.cxx | 62 + 1 file changed, 30 insertions(+), 32 deletions(-) New commits: commit c049df6fdd14fdfd88ded76ac9396efa8877f2c5 Author: Khaled Hosny khaledho...@eglug.org Date: Sat May 11 21:04:45 2013 +0200 [coretext

[Libreoffice-commits] core.git: vcl/generic

2013-05-12 Thread Khaled Hosny
vcl/generic/glyphs/gcach_layout.cxx | 32 +--- 1 file changed, 29 insertions(+), 3 deletions(-) New commits: commit 2ede6c95e6481c92cc199e7d74fd36c841636304 Author: Khaled Hosny khaledho...@eglug.org Date: Sun May 12 17:59:50 2013 +0200 Some logging

[Libreoffice-commits] core.git: vcl/generic

2013-05-12 Thread Khaled Hosny
vcl/generic/glyphs/gcach_ftyp.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c0417e82174297ace604c68fc577c831929f3573 Author: Khaled Hosny khaledho...@eglug.org Date: Mon May 13 02:33:14 2013 +0200 Typo Change-Id

[Libreoffice-commits] core.git: vcl/generic

2013-05-13 Thread Khaled Hosny
vcl/generic/glyphs/gcach_ftyp.cxx | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) New commits: commit dd5b15ebd868e21b4c948ccb7978136a91a7992c Author: Khaled Hosny khaledho...@eglug.org Date: Mon May 13 16:32:20 2013 +0200 Handle fonts without hhea or OS/2 table

[Libreoffice-commits] core.git: 4 commits - vcl/coretext

2013-05-17 Thread Khaled Hosny
vcl/coretext/salcoretextlayout.cxx | 107 +++-- 1 file changed, 46 insertions(+), 61 deletions(-) New commits: commit e4088a68aa3d69da60f5a1e93c06ca8be3ff764f Author: Khaled Hosny khaledho...@eglug.org Date: Fri May 17 23:23:02 2013 +0200 Drop unused

[Libreoffice-commits] core.git: sw/source

2013-05-20 Thread Khaled Hosny
sw/source/ui/docvw/HeaderFooterWin.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c761fcfd7ec95090cde2fb2b6b9b891f3e1337ab Author: Khaled Hosny khaledho...@eglug.org Date: Mon May 20 15:58:47 2013 +0200 Fix fdo#64751 – Header footer blue tags empty

[Libreoffice-commits] core.git: download.lst harfbuzz/harfbuzz.configure.patch.1

2013-05-21 Thread Khaled Hosny
download.lst|2 +- harfbuzz/harfbuzz.configure.patch.1 |8 +--- 2 files changed, 2 insertions(+), 8 deletions(-) New commits: commit b1167d96bd70a9e820525a3e6189772cf1b7852a Author: Khaled Hosny khaledho...@eglug.org Date: Tue May 21 19:46:06 2013 +0200

[Libreoffice-commits] core.git: harfbuzz/harfbuzz.configure.patch.1

2013-05-22 Thread Khaled Hosny
harfbuzz/harfbuzz.configure.patch.1 |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) New commits: commit a2e3f7786f78234a5b5d0fe19ea715c2ad2f3ad7 Author: Khaled Hosny khaledho...@eglug.org Date: Wed May 22 12:04:22 2013 +0200 Blind attempt to fix HarfBuzz build

[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - 2 commits - download.lst harfbuzz/harfbuzz.configure.patch.1

2013-05-22 Thread Khaled Hosny
download.lst|2 +- harfbuzz/harfbuzz.configure.patch.1 |8 2 files changed, 5 insertions(+), 5 deletions(-) New commits: commit 0ba159e33bb8f47250f57f377af40f7ca941c89c Author: Khaled Hosny khaledho...@eglug.org Date: Wed May 22 12:04:22 2013 +0200

[Libreoffice-commits] core.git: vcl/generic vcl/inc vcl/source

2013-05-23 Thread Khaled Hosny
: Khaled Hosny khaledho...@eglug.org Date: Thu May 23 09:34:27 2013 +0200 Fix left to right full justification I was overloading ApplyDXArray() with a HarfBuzz specific implementation because the GenericSalLayout one was screwing right to left kerning, but it seems to have broken

[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - vcl/generic vcl/inc vcl/source

2013-05-23 Thread Khaled Hosny
: Khaled Hosny khaledho...@eglug.org Date: Thu May 23 09:34:27 2013 +0200 Fix left to right full justification I was overloading ApplyDXArray() with a HarfBuzz specific implementation because the GenericSalLayout one was screwing right to left kerning, but it seems to have broken

[Libreoffice-commits] core.git: vcl/source

2013-05-23 Thread Khaled Hosny
vcl/source/gdi/sallayout.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 989225a89b109ca1497021dd4855a2450d13e8b9 Author: Khaled Hosny khaledho...@eglug.org Date: Thu May 23 22:32:14 2013 +0200 Fix improper glyph positioning with old fonts

[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - vcl/source

2013-05-23 Thread Khaled Hosny
vcl/source/gdi/sallayout.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit cef3f3aac2f7a372e796deac4ee3e8155c5eb697 Author: Khaled Hosny khaledho...@eglug.org Date: Thu May 23 22:32:14 2013 +0200 Fix improper glyph positioning with old fonts

Re: Line height depending on characters in that line

2012-11-20 Thread Khaled Hosny
On Tue, Nov 20, 2012 at 05:57:12PM +0100, Lubos Lunak wrote: Hello, I'd need a little help from somebody who knows how exactly line height is computed. Specifically, create a new document, create a bullet list (2-3 items), and change it from bullets to 1. style (RMB-Bullets and

  1   2   3   4   5   6   7   8   9   10   >