[Libreoffice-commits] core.git: 2 commits - libreofficekit/README

libreofficekit/README | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit eddd7646d672ea9b0561dacb09da224d098e531e Author: Khaled Hosny Date: Fri Jul 18 08:09:31 2014 +0200 Try to make some sense out of that sentence Change-Id

Re: Harbuzz requirements clarification

On Fri, Jun 20, 2014 at 01:32:24PM +0200, Tomáš Chvátal wrote: > Hello guys, > > When trying to build 4.3 on openSUSE-12.3 I get this error: > > > /home/abuild/rpmbuild/BUILD/libreoffice-4.3.0.0.beta2-buildfix1/vcl/generic/glyphs/gcach_layout.cxx: > In member function 'virtual bool HbLayoutEngi

[Libreoffice] Horizontal glyph adjustments are ignored with ICU layout

cgi?id=31016 Regards, Khaled -- Khaled Hosny Arabic localiser and member of Arabeyes.org team Free font developer diff --git a/vcl/source/glyphs/gcach_layout.cxx b/vcl/source/glyphs/gcach_layout.cxx index cda8749..7531d2b 100644 --- a/vcl/source/glyphs/gcach_layout.cxx +++ b/vcl/source/glyphs/gcach

Re: [Libreoffice] Horizontal glyph adjustments are ignored with ICU layout

On Fri, Jan 07, 2011 at 11:25:33PM +0100, Thorsten Behrens wrote: > Khaled Hosny wrote: > > Anyway, it turned out that the issue is not specific to kerning nor > > Arabic, but affects all horizontal glyph positioning in the ICU layout > > path; the problem does not sho

Re: [Libreoffice] Oracle wordbook in LibO

or 3.x. But it's good to check with Sophie, French tend to translate > much more technical terms than Italian do! For language not written in Latin script they are likely to get transliterated, we certainly do that in Arabic. Regards, Khaled -- Khaled Hosny Arabi

Re: [Libreoffice] Horizontal glyph adjustments are ignored with ICU layout

e previous one). > It should be tested with some CTL scripts including reordering and > lots of diacritics to check the edge cases are covered. The width > will also affect font fallback (calls from MultiSalLayout), so that > needs to be tested as well. I've tested with fonts th

Re: [Libreoffice] [FIXED] Re: debug build fails because graphite ./configure not up to date

avoid it. The ideal place to send patches to graphite would be to the > upstream graphite project and poke them to release a new update at some > stage and then just upgrade to the latest graphite. BTW, Graphite engine is being re-written into a more stable engine (the current engine is crashy

Re: [Libreoffice] [libreoffice-users] Re: Which Unicode Standard LibreOffice uses...?

likely is that LibO provides what OOo has in this area. > Therefore I cc the dev-list. > If necessary, a request at d...@openoffice.org (cc e...@openoffice.org, > Eike Rathke), will help. Sorry, but I don't see what the issue being discussed here? And Arabic Presentation Forms have

Re: [Libreoffice] [PUSHED] Re: Horizontal glyph adjustments are ignored with ICU layout

On Fri, Jan 28, 2011 at 02:17:44PM +, Caolán McNamara wrote: > Can we take it that your submission is under our recommended LGPLv3+/MPL > licence ? Sure, this and any future submissions are LGPLv3+/MPL licensed. -- Khaled Hosny Eg

Re: [Libreoffice] [PUSHED] Re: Horizontal glyph adjustments are ignored with ICU layout

rk on Indic languages, Arabic is probably the > one in worst shape. Next on the list is the horribly broken Kashida justification and make it optional. Regards, Khaled -- Khaled Hosny Egyptian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Re: Horizontal glyph adjustments are ignored with ICU layout

On Fri, Feb 04, 2011 at 11:00:34AM +, Michael Meeks wrote: > > On Thu, 2011-02-03 at 23:27 +0200, Khaled Hosny wrote: > > Indeed. A real long term "fix" is to drop ICU layout engine altogether > > and switch to HarfBuzz, however HarfBuzz lacks Indic shaper right n

[Libreoffice] No full justification in master?

In locally built libreoffice master I can't get full justification; text is kept left aligned. I tested with the distro packaged 3.3.1 and justification is fine. Can anyone confirm this, or it is just me? Regards, Khaled -- Khaled Hosny Egyptian

Re: [Libreoffice] No full justification in master?

On Tue, Mar 01, 2011 at 05:19:36PM +0100, Thomas Arnhold wrote: > Hi Khaled, > > On 03/01/2011 05:10 PM, Khaled Hosny wrote: > > In locally built libreoffice master I can't get full justification; text > > is kept left aligned. I tested with the distro packaged 3.3.1 and

Re: [Libreoffice] fixing kashida insertion

akes it very accessible IMO), but it is up to who will actually right the code. This is one of the most broken aspects of OOo/LO for Arabic users, I was planing to play with it but unfortunately I'll not be able to put much effort into this. Regards, Khaled -- Khaled Hosny

Re: A little info about ligatures and e.g. Calibri

On Sun, Feb 03, 2013 at 03:39:36PM +, Caolán McNamara wrote: > FWIW, as it came up as a question in the main track FOSDEM LibreOffice > talk, in vcl/generic/glyphs/gcach_layout.cxx see IcuLayoutEngine::layout > and... > if (rArgs.mnFlags & SAL_LAYOUT_ENABLE_LIGATURES) > nLayoutFlags |= Layo

Re: A little info about ligatures and e.g. Calibri

On Sun, Feb 03, 2013 at 04:15:00PM +, Caolán McNamara wrote: > On Sun, 2013-02-03 at 17:58 +0200, Khaled Hosny wrote: > > I see Calibri only, no etc's :), so blocking ligature support (which is > > so 80s, even MS Office now supports OpenType features for Latin) because

Re: A little info about ligatures and e.g. Calibri

On Tue, Feb 05, 2013 at 10:36:38AM +, Caolán McNamara wrote: > On Sun, 2013-02-03 at 18:26 +0200, Khaled Hosny wrote: > > GTK have been enabling ligatures and other default OpenType features > > since ages (since before I started using computers :p), so probably the > >

[Libreoffice-commits] core.git: 4 commits - vcl/coretext

vcl/coretext/salcoretextlayout.cxx | 107 +++-- 1 file changed, 46 insertions(+), 61 deletions(-) New commits: commit e4088a68aa3d69da60f5a1e93c06ca8be3ff764f Author: Khaled Hosny Date: Fri May 17 23:23:02 2013 +0200 Drop unused mpGlyphPositions array

[Libreoffice-commits] core.git: sw/source

sw/source/ui/docvw/HeaderFooterWin.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c761fcfd7ec95090cde2fb2b6b9b891f3e1337ab Author: Khaled Hosny Date: Mon May 20 15:58:47 2013 +0200 Fix fdo#64751 – Header & footer blue tags empty No

[Libreoffice-commits] core.git: download.lst harfbuzz/harfbuzz.configure.patch.1

download.lst|2 +- harfbuzz/harfbuzz.configure.patch.1 |8 +--- 2 files changed, 2 insertions(+), 8 deletions(-) New commits: commit b1167d96bd70a9e820525a3e6189772cf1b7852a Author: Khaled Hosny Date: Tue May 21 19:46:06 2013 +0200 Update HarfBuzz to

[Libreoffice-commits] core.git: harfbuzz/harfbuzz.configure.patch.1

harfbuzz/harfbuzz.configure.patch.1 |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) New commits: commit a2e3f7786f78234a5b5d0fe19ea715c2ad2f3ad7 Author: Khaled Hosny Date: Wed May 22 12:04:22 2013 +0200 Blind attempt to fix HarfBuzz build Change-Id

[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - 2 commits - download.lst harfbuzz/harfbuzz.configure.patch.1

download.lst|2 +- harfbuzz/harfbuzz.configure.patch.1 |8 2 files changed, 5 insertions(+), 5 deletions(-) New commits: commit 0ba159e33bb8f47250f57f377af40f7ca941c89c Author: Khaled Hosny Date: Wed May 22 12:04:22 2013 +0200 Blind attempt to fix

[Libreoffice-commits] core.git: vcl/generic vcl/inc vcl/source

: Khaled Hosny Date: Thu May 23 09:34:27 2013 +0200 Fix left to right full justification I was overloading ApplyDXArray() with a HarfBuzz specific implementation because the GenericSalLayout one was screwing right to left kerning, but it seems to have broken left to right full

[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - vcl/generic vcl/inc vcl/source

: Khaled Hosny Date: Thu May 23 09:34:27 2013 +0200 Fix left to right full justification I was overloading ApplyDXArray() with a HarfBuzz specific implementation because the GenericSalLayout one was screwing right to left kerning, but it seems to have broken left to right full

[Libreoffice-commits] core.git: vcl/source

vcl/source/gdi/sallayout.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 989225a89b109ca1497021dd4855a2450d13e8b9 Author: Khaled Hosny Date: Thu May 23 22:32:14 2013 +0200 Fix improper glyph positioning with old fonts Apparently this second

[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - vcl/source

vcl/source/gdi/sallayout.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit cef3f3aac2f7a372e796deac4ee3e8155c5eb697 Author: Khaled Hosny Date: Thu May 23 22:32:14 2013 +0200 Fix improper glyph positioning with old fonts Apparently this second

[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - 2 commits - vcl/generic vcl/source

vcl/generic/glyphs/gcach_layout.cxx | 20 +++- vcl/source/gdi/sallayout.cxx|2 +- 2 files changed, 20 insertions(+), 2 deletions(-) New commits: commit c72955bcb196574f7bc682e7aa301264a8a54635 Author: Khaled Hosny Date: Sat May 25 11:12:56 2013 +0200 Revert

[Libreoffice-commits] core.git: 2 commits - vcl/generic vcl/source

vcl/generic/glyphs/gcach_layout.cxx | 20 +++- vcl/source/gdi/sallayout.cxx|2 +- 2 files changed, 20 insertions(+), 2 deletions(-) New commits: commit 0e533770125d57d38e8b5505027ac5359abe40b2 Author: Khaled Hosny Date: Sat May 25 11:12:56 2013 +0200 Revert

[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - vcl/generic

vcl/generic/glyphs/gcach_ftyp.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 5e2d59e4b910631c802d5c7c42b7411e5a8b8db6 Author: Khaled Hosny Date: Sat May 25 13:14:59 2013 +0200 Fix fdo#64972 - strikethrough displays too high I was calculating

[Libreoffice-commits] core.git: vcl/generic

vcl/generic/glyphs/gcach_ftyp.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 753f5721970805224e8bdfc5b9fdb2611ba9aa34 Author: Khaled Hosny Date: Sat May 25 13:14:59 2013 +0200 Fix fdo#64972 - strikethrough displays too high I was calculating

[Libreoffice-commits] core.git: sw/source

sw/source/core/txtnode/swfont.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 6e6b028164176e39219dccbe1b84380b10b6e64f Author: Khaled Hosny Date: Sat May 25 14:33:46 2013 +0200 Fix fdo#64685 - Superscript broken in master After

[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - sw/source

sw/source/core/txtnode/swfont.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 0c0e7f1bd48d1a89ccdba3f5e773186123943e43 Author: Khaled Hosny Date: Sat May 25 14:33:46 2013 +0200 Fix fdo#64685 - Superscript broken in master After

Re: On which platforms is graphite not supported ?

On Wed, May 29, 2013 at 09:43:29AM +0200, Francois Tigeot wrote: > On which platform(s) can't we use graphite ? Mac OS X ? Yes, AFAICT, that is the only platform where VCL does not has a Graphite-enabled layout. ___ LibreOffice mailing list LibreOffice@l

[Libreoffice-commits] core.git: Changes to 'feature/dematurize01'

New branch 'feature/dematurize01' available with the following commits: commit 8ae39ee1f49ee86b01e3a5d36f236a22b1c1d95c Author: Khaled Hosny Date: Sun Jun 2 15:20:47 2013 +0200 WaE: -Wunused-parameter Change-Id: I9e14a245d75943750678441210374f9259c5b6

[Libreoffice-commits] core.git: cui/uiconfig

cui/uiconfig/ui/paragalignpage.ui |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit cfd41ac7e7084e1eacfec9fa08a099510058791b Author: Khaled Hosny Date: Mon Jun 3 14:18:19 2013 +0200 Fix typo after conversion to .ui The last item in the list was

[Libreoffice-commits] core.git: 2 commits - vcl/coretext

vcl/coretext/salgdi2.cxx | 87 +-- 1 file changed, 17 insertions(+), 70 deletions(-) New commits: commit 5e33f1c09b5dcfaa9cabdf1711c9a173514a1c7b Author: Khaled Hosny Date: Mon Jun 3 23:55:58 2013 +0200 Use Core Text font manager instead of

[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - 2 commits - vcl/coretext

vcl/coretext/salgdi2.cxx | 87 +-- 1 file changed, 17 insertions(+), 70 deletions(-) New commits: commit eddf277c992b80282e0b49325b3138de5a3a2509 Author: Khaled Hosny Date: Mon Jun 3 23:01:56 2013 +0200 Drop ENABLE_CORETEXT This file

[Libreoffice-commits] core.git: vcl/aqua vcl/coretext vcl/inc

commits: commit a3e97576aa0a7d7c5d51a8ca2f9d220e7d342d87 Author: Khaled Hosny Date: Tue Jun 4 00:16:06 2013 +0200 Drop "CJK extra leading" crack It have been unused on Mac OS X since since 2008 (commit da4d070d9d2d563f6e1401496957b22b51c81ff9).

[Libreoffice-commits] core.git: vcl/coretext

vcl/coretext/ctlayout.cxx | 27 +++ 1 file changed, 3 insertions(+), 24 deletions(-) New commits: commit 46c4e2463d517a7e4f74ee1759d837c799140fc7 Author: Khaled Hosny Date: Tue Jun 4 12:05:33 2013 +0200 Drop the trailing white space crack Whatever this

[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - vcl/coretext

vcl/coretext/ctlayout.cxx | 27 +++ 1 file changed, 3 insertions(+), 24 deletions(-) New commits: commit 2132e8e2145562499f31bfad5e3997cea4042b52 Author: Khaled Hosny Date: Tue Jun 4 12:05:33 2013 +0200 Drop the trailing white space crack Whatever this

Re: [PATCH] Add HarfBuzz support to the build system

On Sun, Apr 21, 2013 at 08:19:15AM +0000, Khaled Hosny (via Code Review) wrote: > Hi, > > I have submitted a patch for review: > > https://gerrit.libreoffice.org/3517 > > To pull it, you can do: > > git pull ssh://gerrit.libreoffice.org:29418/core refs/chan

[Libreoffice-commits] core.git: config_host/config_harfbuzz.h.in config_host.mk.in configure.ac download.lst harfbuzz/ExternalPackage_harfbuzz.mk harfbuzz/ExternalProject_harfbuzz.mk harfbuzz/harfbuzz

7e389f4def1964ee38bb93b575926a089e84bae6 Author: Khaled Hosny Date: Sat Apr 20 13:00:56 2013 +0200 Add HarfBuzz support to the build system To be used in the next commit. Change-Id: I6ee286d0c050a5ca650e7fb3692b0facccb5f0c0 Reviewed-on: https://gerrit.libreoffice.org/3517

[Libreoffice-commits] core.git: vcl/generic

vcl/generic/glyphs/gcach_layout.cxx | 395 ++-- 1 file changed, 379 insertions(+), 16 deletions(-) New commits: commit b760eff8cb65aba99b4527232140926bb4e11e82 Author: Khaled Hosny Date: Sat Apr 20 19:16:54 2013 +0200 Add support for using HarfBuzz

[Libreoffice-commits] core.git: vcl/generic

vcl/generic/glyphs/gcach_layout.cxx | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit 9d4395540a10916d471579618d7bf3b60cd49140 Author: Khaled Hosny Date: Tue Apr 23 12:39:07 2013 +0200 Fix glyph width calculation in HarfBuzz Make sure

Re: Mirroring gtk buttons

On Wed, Mar 06, 2013 at 05:45:57AM +, Issa Alkurtass wrote: > Hello world, > > Any idea how to mirror gtk buttons in vcl? I need to mirror the combo > box buttons in vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx for the RTL > interface. (screenshot: http://i.imgur.com/XAnvum8.png) I thought this

Re: Mirroring gtk buttons

On Wed, Mar 06, 2013 at 11:38:14AM +, Issa Alkurtass wrote: > Michael Meeks wrote on March 06, 2013 2:13 PM: > >Urk - so - then I guess it is a matter of persuading each of our > >captive gtk2 widgets to have the right RTL setting via: > > > > void gtk_widget_set_direction (GtkWidget

Re: Mirroring gtk buttons

On Wed, Mar 06, 2013 at 12:05:23PM +, Michael Meeks wrote: > > On Wed, 2013-03-06 at 11:38 +, Issa Alkurtass wrote: > > Something like that yes, but this function is only concerned with text > > direction and ordering of items, not "graphical orientation." We need > > something that flips

Re: [PATCH] fdo#35320 A fix for Arabic justification problem caused by k...

On Sun, Apr 28, 2013 at 06:04:04AM +, Ahmad Harthi (via Code Review) wrote: > Hi, > > I have submitted a patch for review: > > https://gerrit.libreoffice.org/3644 > > To pull it, you can do: > > git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/3644/1 > > fdo#35320 A

[Libreoffice-commits] core.git: 9 commits - vcl/generic vcl/inc

: Khaled Hosny Date: Sun Apr 28 15:56:26 2013 +0200 [harfbuzz] Re-enable text justification It turned out that ApplyDXArray() is need to apply advance width adjustments after justification, so we can't just bypass it. So I just copied GenericSalLayout::ApplyDXArray(

[Libreoffice-commits] core.git: vcl/generic

vcl/generic/glyphs/gcach_layout.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3719396649c8c944727f89c517a8191cd37b2499 Author: Khaled Hosny Date: Mon Apr 29 22:13:44 2013 +0200 [harfbuzz] Don't crash when closing LibreOffice We shouldn

[Libreoffice-commits] core.git: vcl/generic

vcl/generic/glyphs/gcach_layout.cxx | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) New commits: commit 84a8f817e174855ef72f0bafc734847690c5d736 Author: Khaled Hosny Date: Tue Apr 30 17:16:17 2013 +0200 [harfbuzz] Simplify cluster detection Change-Id

[Libreoffice-commits] core.git: 2 commits - vcl/generic

vcl/generic/glyphs/gcach_layout.cxx | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) New commits: commit 76abedd3bd1c91cac9b239f746243df00a58d060 Author: Khaled Hosny Date: Thu May 2 06:19:38 2013 +0200 [harfbuzz] Fix shaping across text runs, take 2 The

[Libreoffice-commits] core.git: vcl/generic

vcl/generic/glyphs/gcach_layout.cxx | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) New commits: commit 405dc9d241f617853c77e60b0b0d41c36b5af33d Author: Khaled Hosny Date: Fri May 3 23:39:19 2013 +0200 [harfbuzz] Fix placement of multi-glyph clusters

[Libreoffice-commits] core.git: vcl/generic

vcl/generic/glyphs/gcach_layout.cxx |9 + 1 file changed, 9 insertions(+) New commits: commit 784cd10c31e4378e5b9d03791154e01d23867120 Author: Khaled Hosny Date: Sun May 5 21:10:52 2013 +0200 [harfbuzz] Fix vertical text layout "Fixed" in the sense tha

[Libreoffice-commits] core.git: 2 commits - vcl/generic vcl/inc vcl/source

9a8f125fa7e63b829471a6722dae3006bb1f57d2 Author: Khaled Hosny Date: Mon May 6 01:40:06 2013 +0200 [harfbuzz] Support Unicode variation selectors Change-Id: I8c56f45505327857613c39b28da3ae7cc3ad201c diff --git a/vcl/generic/glyphs/gcach_ftyp.cxx b/vcl/generic/glyphs/gcach_ftyp.cxx

[Libreoffice-commits] core.git: 3 commits - config_host/config_harfbuzz.h.in configure.ac vcl/generic vcl/inc vcl/source

/sallayout.hxx | 11 +++ vcl/source/gdi/sallayout.cxx|2 +- 7 files changed, 17 insertions(+), 50 deletions(-) New commits: commit bff8fa97e16f0f06fddc5545ea36c8bd2b18a580 Author: Khaled Hosny Date: Mon May 6 11:08:29 2013 +0200 Enable HarfBuzz by default

[Libreoffice-commits] core.git: vcl/source

vcl/source/gdi/outdev3.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7556ba312ff3a7409b7da55f220d3ff877505a3b Author: Khaled Hosny Date: Mon May 6 21:41:14 2013 +0200 Surely the intent was to check for !pFallback here Change-Id

[Libreoffice-commits] core.git: 2 commits - vcl/coretext

vcl/coretext/salgdi.cxx |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) New commits: commit 543ac5596d0ef3a052973c1ec89a9329d1073dc8 Author: Khaled Hosny Date: Thu May 9 23:49:45 2013 +0200 Minor Change-Id: I31b95844234135d14f117ae74124350eedf7d20a diff --git a

[Libreoffice-commits] core.git: vcl/coretext

vcl/coretext/salcoretextlayout.cxx | 47 + 1 file changed, 38 insertions(+), 9 deletions(-) New commits: commit f2b92a9ab5d1b0c7d3d01db675268b0e1925cdc6 Author: Khaled Hosny Date: Fri May 10 17:05:24 2013 +0200 [coretext] Fix drawing fallback fonts

[Libreoffice-commits] core.git: 5 commits - config_host.mk.in configure.ac vcl/generic

: Khaled Hosny Date: Sat May 11 08:44:11 2013 +0200 USE_FT_EMBOLDEN has never been used Change-Id: Idd30f6fcf9d1e4d2af5f49caffa91d6ce30bb196 diff --git a/config_host.mk.in b/config_host.mk.in index cfe407c..76ac1a7 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -540,7 +540,6

[Libreoffice-commits] core.git: vcl/coretext

vcl/coretext/salcoretextlayout.cxx | 62 + 1 file changed, 30 insertions(+), 32 deletions(-) New commits: commit c049df6fdd14fdfd88ded76ac9396efa8877f2c5 Author: Khaled Hosny Date: Sat May 11 21:04:45 2013 +0200 [coretext] Attempt to fix jumping

[Libreoffice-commits] core.git: vcl/generic

vcl/generic/glyphs/gcach_layout.cxx | 32 +--- 1 file changed, 29 insertions(+), 3 deletions(-) New commits: commit 2ede6c95e6481c92cc199e7d74fd36c841636304 Author: Khaled Hosny Date: Sun May 12 17:59:50 2013 +0200 Some logging Change-Id

[Libreoffice-commits] core.git: vcl/generic

vcl/generic/glyphs/gcach_ftyp.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c0417e82174297ace604c68fc577c831929f3573 Author: Khaled Hosny Date: Mon May 13 02:33:14 2013 +0200 Typo Change-Id: I28ea63722f542a79aef904f9be40645baac191e4 diff --git

[Libreoffice-commits] core.git: vcl/generic

vcl/generic/glyphs/gcach_ftyp.cxx | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) New commits: commit dd5b15ebd868e21b4c948ccb7978136a91a7992c Author: Khaled Hosny Date: Mon May 13 16:32:20 2013 +0200 Handle fonts without hhea or OS/2 table e.g. Type1

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 2 commits - vcl/inc vcl/source

vcl/inc/CommonSalLayout.hxx|2 vcl/source/gdi/CommonSalLayout.cxx | 107 +++-- 2 files changed, 92 insertions(+), 17 deletions(-) New commits: commit 7a897b1d181ad23c3d2249c05c9047ced4ace11b Author: Khaled Hosny Date: Mon Oct 10 00:54:00 2016

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 13 commits - config_host.mk.in configure.ac external/harfbuzz RepositoryExternal.mk vcl/CppunitTest_vcl_wmf_test.mk vcl/inc vcl/Libra

Rebased ref, commits from common ancestor: commit c74ddf0d07c34dc5b20853be752508bce7a67578 Author: Khaled Hosny Date: Mon Oct 10 00:54:00 2016 +0200 Validate Kashida positions in CommonSalLayout Currently checks only for ligatures, but that is a big improvement over al code

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/source

vcl/source/gdi/CommonSalLayout.cxx | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit 7710affe4b15fd6ba6f79a69fa2521e08881e23f Author: Khaled Hosny Date: Mon Oct 10 01:36:45 2016 +0200 Just call ICU directly and cut the middle layers Change

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 392 commits - accessibility/inc accessibility/source apple_remote/source avmedia/inc avmedia/source basctl/source basegfx/source base

Rebased ref, commits from common ancestor: commit c81fb933b89bbba18a1197f67b9325bbfb44648d Author: Khaled Hosny Date: Mon Oct 10 01:36:45 2016 +0200 Just call ICU directly and cut the middle layers Change-Id: I7603d03fef8ca227c3e6fe25239281d18801522a diff --git a/vcl/source/gdi

[Libreoffice-commits] core.git: 2 commits - vcl/source vcl/unx

vcl/source/gdi/sallayout.cxx|4 vcl/unx/generic/glyphs/gcach_layout.cxx | 30 +++--- 2 files changed, 11 insertions(+), 23 deletions(-) New commits: commit f48cbaac0a2a7278f366a3b0118b399c0a938a44 Author: Khaled Hosny Date: Tue Oct 11 14:53:06

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - vcl/unx

vcl/unx/generic/glyphs/gcach_layout.cxx | 30 +++--- 1 file changed, 11 insertions(+), 19 deletions(-) New commits: commit ed761146be3a274e0f24ab2c02c68e4e6c33e8b4 Author: Khaled Hosny Date: Tue Oct 11 18:38:57 2016 +0200 tdf#103103: Many Arabic fonts dont

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 30 commits - config_host.mk.in configure.ac external/harfbuzz RepositoryExternal.mk vcl/CppunitTest_vcl_wmf_test.mk vcl/headless vcl/

Rebased ref, commits from common ancestor: commit 4f0fede6364bac10705a4bde325e9ab35ad5b5fd Author: Khaled Hosny Date: Thu Oct 13 22:46:28 2016 +0200 Check SAL_USE_COMMON_LAYOUT envar in one place Makes it easier to flip the switch in the future (or even do something more fancy

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/quartz

vcl/quartz/salgdi.cxx | 42 ++ 1 file changed, 42 insertions(+) New commits: commit 28bfc0984b1728b5a82c6b630277646b4c0a2794 Author: Khaled Hosny Date: Fri Oct 14 02:19:32 2016 +0200 Untested first part of macOS font fallback Change-Id

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/inc vcl/quartz

Rebased ref, commits from common ancestor: commit 8a4aba454b3c3bb657b837cc6b2296313e28d7b0 Author: Khaled Hosny Date: Fri Oct 14 02:50:27 2016 -0700 Support font fallback on macOS for CommonSalLayout Change-Id: Ifd26b7f14ed77a3aa2a38e5961cac5f9bbb6d796 diff --git a/vcl/inc/quartz

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/inc vcl/quartz

Rebased ref, commits from common ancestor: commit 06971a9d9a17e73c8f589df1f9a0402c8ce8cab7 Author: Khaled Hosny Date: Fri Oct 14 02:50:27 2016 -0700 Support font fallback on macOS for CommonSalLayout Change-Id: Ifd26b7f14ed77a3aa2a38e5961cac5f9bbb6d796 diff --git a/vcl/inc/quartz

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/inc vcl/quartz

Rebased ref, commits from common ancestor: commit 7ea4cca3d3a1912e59e113d756ed3fe1662f96fb Author: Khaled Hosny Date: Fri Oct 14 02:50:27 2016 -0700 Support font fallback on macOS for CommonSalLayout Change-Id: Ifd26b7f14ed77a3aa2a38e5961cac5f9bbb6d796 diff --git a/vcl/inc/quartz

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 7 commits - vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

Rebased ref, commits from common ancestor: commit c8e0298987f12f732c686f3ccd2ee4e342d8f89c Author: Khaled Hosny Date: Fri Oct 14 02:50:27 2016 -0700 Support font fallback on macOS for CommonSalLayout Change-Id: Ifd26b7f14ed77a3aa2a38e5961cac5f9bbb6d796 diff --git a/vcl/inc/quartz

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/source vcl/unx

vcl/source/gdi/CommonSalLayout.cxx | 92 vcl/unx/generic/gdi/cairotextrender.cxx |5 + 2 files changed, 86 insertions(+), 11 deletions(-) New commits: commit b2fef34ef91b155d21b07cd6c0a0233810b80db9 Author: Khaled Hosny Date: Mon Sep 26 19:09:52

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/quartz

vcl/quartz/salgdi.cxx | 85 +- 1 file changed, 63 insertions(+), 22 deletions(-) New commits: commit d557cae6d36faa6bde6a66c085ae009e7a276eeb Author: Khaled Hosny Date: Sat Oct 15 06:11:26 2016 -0700 Rewrite AquaSalGraphics::DrawSalLayout

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 404 commits - accessibility/inc accessibility/source avmedia/Module_avmedia.mk basctl/inc basctl/source basctl/uiconfig basegfx/sourc

Rebased ref, commits from common ancestor: commit 23c9ccfd1b6fc5cdee4913e96cd02e04c68459fe Author: Khaled Hosny Date: Sat Oct 15 06:11:26 2016 -0700 Rewrite AquaSalGraphics::DrawSalLayout() Slightly cleaner code and now handles glyph rotation for vertical text. Change-Id

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 7 commits - vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

Rebased ref, commits from common ancestor: commit bf7119d9217ba08c716af4f080623d2d167b989a Author: Khaled Hosny Date: Sat Oct 15 06:11:26 2016 -0700 Rewrite AquaSalGraphics::DrawSalLayout() Slightly cleaner code and now handles glyph rotation for vertical text. Change-Id

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 24 commits - config_host.mk.in configure.ac external/harfbuzz RepositoryExternal.mk vcl/CppunitTest_vcl_wmf_test.mk vcl/inc vcl/Libra

Rebased ref, commits from common ancestor: commit f0fdd3d62700040b32347b4637b1520ce9113903 Author: Khaled Hosny Date: Sat Oct 15 06:11:26 2016 -0700 Rewrite AquaSalGraphics::DrawSalLayout() Slightly cleaner code and now handles glyph rotation for vertical text. Change-Id

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 83 commits - avmedia/source basic/qa basic/source bean/native bridges/inc bridges/source canvas/source codemaker/source comphelper/so

Rebased ref, commits from common ancestor: commit 9f6be93b1d9013dbdc84c46466d0fa6a4ed10dec Author: Khaled Hosny Date: Sat Oct 15 06:11:26 2016 -0700 Rewrite AquaSalGraphics::DrawSalLayout() Slightly cleaner code and now handles glyph rotation for vertical text. Change-Id

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/inc vcl/source

vcl/inc/CommonSalLayout.hxx|8 vcl/source/gdi/CommonSalLayout.cxx | 34 -- 2 files changed, 20 insertions(+), 22 deletions(-) New commits: commit 754fcf66f203f33840cfe08707a740db956fca12 Author: Khaled Hosny Date: Mon Oct 17 19:59:23 2016

Merging feature/commonsallayout branch

I believe that feature/commonsallayout (AKA unified text layout) is now feature complete with no known major bugs, and should be ready to be merged on master. I’ll try merge it tomorrow night and hope for the best, unless someone objects loudly. Currently the new layout is off by default and can b

Re: Merging feature/commonsallayout branch

is on my mind that I was meaning to ask before: Is issue > tdf#66819 "Setting additional spacing between characters does not > prevent automatic ligature substitution." solved in this branch? > > Greetings, > > Stephan > > 2016-10-17 21:30 GMT+02:00 Khaled Hosny :

Re: Merging feature/commonsallayout branch

On Tue, Oct 18, 2016 at 09:06:42AM +0200, Milos Sramek wrote: > Dear Khaled, > > do you think that extensive comparison of rendering of numerous > documents with and without the new layout engine makes sense? > If yes, I can run my tests in such a way to see if there are any > differences. This w

Re: Merging feature/commonsallayout branch

On Tue, Oct 18, 2016 at 12:05:14PM +0200, 'Christian Lohmaier' via Khaled Hosny wrote: > On Mon, Oct 17, 2016 at 9:30 PM, Khaled Hosny wrote: > > I believe that feature/commonsallayout (AKA unified text layout) is now > > feature complete with no known major bugs,

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - 130 commits - accessibility/source basctl/source basegfx/source basic/source compilerplugins/clang config_host.mk.in configure.ac con

Rebased ref, commits from common ancestor: commit d0b5e1536983dbc1d4eb1b34d9864a0cd6dc1406 Author: Khaled Hosny Date: Mon Oct 17 19:59:23 2016 +0200 Fix debug build and few cleanups Change-Id: I805962667c3ef2dcaf07a0acebeacca74c74892a diff --git a/vcl/inc/CommonSalLayout.hxx b

[Libreoffice-commits] core.git: 33 commits - config_host.mk.in configure.ac external/harfbuzz RepositoryExternal.mk vcl/CppunitTest_vcl_wmf_test.mk vcl/headless vcl/inc vcl/Library_vcl.mk vcl/quartz v

Author: Khaled Hosny Date: Mon Oct 17 19:59:23 2016 +0200 Fix debug build and few cleanups Change-Id: I805962667c3ef2dcaf07a0acebeacca74c74892a diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx index abc5ea7..cd43bec 100644 --- a/vcl/inc/CommonSalLayout.hxx

Re: Merging feature/commonsallayout branch

On Mon, Oct 17, 2016 at 09:30:14PM +0200, Khaled Hosny wrote: > I believe that feature/commonsallayout (AKA unified text layout) is now > feature complete with no known major bugs, and should be ready to be > merged on master. I’ll try merge it tomorrow night and hope for the >

[Libreoffice-commits] core.git: vcl/Library_vclplug_gen.mk

vcl/Library_vclplug_gen.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 66b3aa76b161c4d08e87fbdb19c2b72cc15153cd Author: Khaled Hosny Date: Wed Oct 19 10:50:18 2016 +0200 Add missing icu_headers dependency Apparently this was working before by accident since most

Re: Merging feature/commonsallayout branch

On Wed, Oct 19, 2016 at 03:11:25PM -0700, yphilips wrote: > So cloph asked in QA about testing SAL_USE_COMMON_LAYOUT on windows XP and i > did and it crashed on startup, so unless we want to alienate XP users from > running 5.3, we'd likely need to put in a flag to disable it for XP. So that is no

[Libreoffice-commits] core.git: 2 commits - vcl/source

vcl/source/gdi/CommonSalLayout.cxx | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) New commits: commit d5424208a5b63a9d5ac658279c3f9824aa38a2d6 Author: Khaled Hosny Date: Thu Oct 20 16:37:22 2016 +0200 Reuse the HarfBuzz buffer as much as

[Libreoffice-commits] core.git: 2 commits - vcl/source

vcl/source/gdi/CommonSalLayout.cxx | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) New commits: commit 66c1ae50e43f9a738f089356e8225022f776f90b Author: Khaled Hosny Date: Thu Oct 20 23:22:56 2016 +0200 Typo in commented-out code Change-Id

[Libreoffice-commits] core.git: vcl/inc vcl/source

vcl/inc/CommonSalLayout.hxx|2 ++ vcl/source/gdi/CommonSalLayout.cxx |2 ++ 2 files changed, 4 insertions(+) New commits: commit da8357463ca088c81774ab6c3ffc6f8b3903ffe7 Author: Khaled Hosny Date: Fri Oct 21 02:30:27 2016 +0200 Add vim modeline to new files

Re: Merging feature/commonsallayout branch

On Fri, Oct 21, 2016 at 06:40:08AM -0700, V Stuart Foote wrote: > On Windows 8.1 & 10 builds (32-bit master TB62) and the Alpha1 build, > HARFBUZZ unified text is having some issues with OpenGL rendering. With > default GPU rendering it is doing pretty well. > > See tdf#103365 - Text isn't showi

[Libreoffice-commits] core.git: vcl/inc vcl/win

vcl/inc/win/salgdi.h |2 + vcl/win/gdi/winlayout.cxx | 88 -- 2 files changed, 87 insertions(+), 3 deletions(-) New commits: commit 36bafd3d4ad7fa75649eeab0c9cd1b3d6f53d8e8 Author: Khaled Hosny Date: Fri Oct 21 03:01:43 2016 +0200

[Libreoffice-commits] core.git: vcl/inc vcl/source vcl/win

insertions(+), 73 deletions(-) New commits: commit 2148c853b0d0deea92b97a810950f4d9f0cbb152 Author: Khaled Hosny Date: Fri Oct 21 21:00:21 2016 -0700 Simplify CommonSalLayout constructor on Windows We can use GDI to load the font tables after all, no need for all the complications to

Re: Merging feature/commonsallayout branch

On Mon, Oct 17, 2016 at 09:30:14PM +0200, Khaled Hosny wrote: > - We use a bit of DirectWrite to load fonts on Windows, so Windows XP is > not supported as well. Again it can be fixed with some effort, but I > don’t think anyone will miss XP. Ideally we should do a full

Re: testing commonsallayout branch

ied by > environment variable - I can test that too. > > Is there a way how to install multiple versions in parallel on MAC? I > can install only production and development one. > > best > Milos > > > On 2016-10-18 18:36, Khaled Hosny wrote: > > On Tue, O

  1   2   3   4   5   6   7   8   9   10   >