Re: [Libreoffice] Merge changes from OOO330_m9

2010-10-07 Thread Thorsten Behrens
Michael Meeks wrote: Yes, good idea. But why bail out - can't we just ./download from the makefile? Urk - not an ideal solution IMHO ;-) I would prefer a clean exit, rather than having the build need a network connection to download things personally. Hm - but we need the download

Re: [Libreoffice] auto-download during make ...

2010-10-07 Thread Thorsten Behrens
Michael Meeks wrote: And do so later on inside rawbuild potentially ? Urk ? surely not. and In general it is so dangerous for repeatability for packagers to have the build randomly downloading things, and is so unexpected for users that I don't believe we should do it ;-)

Re: [Libreoffice] [PATCH] README annoyances

2010-10-11 Thread Thorsten Behrens
Donald Johnson wrote: The README file in en-US/readmes from the 3.3.0 64-bit download is a tad annoying. First, there's no line wrap to 80 col (good for terminals). Second, smart quotes are in the file, which appear badly on a terminal and many text editors. Attached are three patches to

Re: [Libreoffice] [SCRIPT, EASYHACK] add-modelines, a script to add modelines to source files

2010-10-11 Thread Thorsten Behrens
Caolán McNamara wrote: Aha, what it boils down to, right, is that the emacs mode lines in that sw/source/filter/ww8/ww8atr.cxx and friends won't be used by emacs seeing as its neither pattern. So let's remove them - added to the list of EasyHack topics. Cheers, -- Thorsten

Re: [Libreoffice] [testscripts] Guidance and project management

2010-10-11 Thread Thorsten Behrens
some...@boldandbusted.com wrote: Howdy. I was asked to post a message here to kick off a discussion of test script coordination. I'm volunteering to help with them because a) it's simple, and b) I'm simple. I know shell, as you can see from the add-modelines script I just submitted, and I'm

Re: [Libreoffice] [PATCH] ure/offapi/com/sun/star/document: Fix some typos in documentation

2010-10-11 Thread Thorsten Behrens
Noel Power wrote: who should update http://www.openoffice.org/issues/show_bug.cgi?id=112563 but, should it be updated ? This is an excellent question ( and one I have asked myself about a different situation ) Unfortunately I don't have the answer. As I see it issuezilla is Oracles bug

Re: [Libreoffice] coding style

2010-10-11 Thread Thorsten Behrens
Tor Lillqvist wrote: No, there is no coding style yet, but we will start to work on one soon Well, much (most?) of the existing code, inherited from OpenOffice.org, clearly uses some amount of consistent style conventions, and when editing such files, one should, IMHO, follow the style

Re: [Libreoffice] [PATCH] ure/offapi/com/sun/star/document: Fix some typos in documentation

2010-10-11 Thread Thorsten Behrens
Noel Power wrote: who should update http://www.openoffice.org/issues/show_bug.cgi?id=112563 but, should it be updated ? This is an excellent question ( and one I have asked myself about a different situation ) Unfortunately I don't have the answer. As I see it issuezilla is Oracles bug

[Libreoffice] 2nd week development summary

2010-10-11 Thread Thorsten Behrens
__XKeyboardExtension__. Thomas Klausner: Improve NetBSD platform strings, and add x86_64. Thomas Klausner: Support NetBSD better. Thomas Klausner: Use more portable sed construct for quoting expressions. Thomas Klausner: Use standard '=' comparison operator for test(1). Thorsten Behrens: Fix broken win32

[Libreoffice] LibreOffice config migration

2010-10-11 Thread Thorsten Behrens
Hi, Mechtilde thankfully reported a problem with old OOo 2.x user installations, which get migrated over to LibreOffice automatically - problem is, the OOo code we inherit here has several bugs. So we talked a bit on IRC tonight, and we somehow figured it would be a good idea to keep migrating

Re: [Libreoffice] LibreOffice config migration

2010-10-12 Thread Thorsten Behrens
Noel Power wrote: Mechtilde thankfully reported a problem with old OOo 2.x user installations, which get migrated over to LibreOffice automatically - problem is, the OOo code we inherit here has several bugs. Aha, coincidentally I was looking at something similar ( and found myself looking

Re: [Libreoffice] Mac OS X 10.6.4 Build

2010-10-13 Thread Thorsten Behrens
Joseph Powers wrote: Ok, I got a build that seams to work... Hi Joseph, cool - thanks for the perseverance, I admit the OSX build experience could be better - There are the following resources around Mac building around already:

Re: [Libreoffice] LibO Tirderbox: where to find doc?

2010-10-13 Thread Thorsten Behrens
Giuseppe Castagno wrote: More specifically: Is there documentation on Tinderbox for LibO? Or if there aren't Tibox as of now, what is it needed to implement them? Question coming from someone who has no idea how to implement one... Hi Giuseppe, there's a script inside the

Re: [Libreoffice] LibreOffice config migration

2010-10-14 Thread Thorsten Behrens
Mechtilde wrote: please don't take any user information from older version without any agreemaent of the user If you do so you haven't the possibilityy to start *office with a new user directory e.g in case you destroy something yourself. If you don't want a dialog then create a user

[Libreoffice] [PATCH] More URLs to OOo sites

2010-10-14 Thread Thorsten Behrens
Hi, just found out that beta2 has a few more links to OOo servers - patch eliding those attached. Do we want to redirect those from documentfoundation.org, or disable the functionality? (and after that, there's the story around helpcontent, and sdk) Cheers, -- Thorsten diff --git

Re: [Libreoffice] LibreOffice config migration

2010-10-14 Thread Thorsten Behrens
André Schnabel wrote: well, this is surely not an easy decision to make - but there's definitely a way to have LibO use a clean user dir, if you need it: -env:UserInstallation=file:///path/to/config and this will prevent, that LibO will migrate any old userconfig when this path is

Re: [Libreoffice] NEEDINFO in the FreeDesktop bugzilla

2010-10-14 Thread Thorsten Behrens
Jan Holesovsky wrote: On 2010-10-14 at 13:17 +0200, Jan Holesovsky wrote: - 8 - Whiteboard: addr...@of.the.info.provider Whiteboard: infoprovider:addr...@of.the.info.provider might be actually better; no strong opinion though ;-) Yes, I like that better - there may be other

Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

2010-10-18 Thread Thorsten Behrens
Michael Meeks wrote: Everything except the 'filters' patch has been either pushed, or sent to the component maintainer for review. libs-gui parts (basebmp basegfx) just pushed. Kept a few useful bits in the */test, */workben subdirs, those are often playgrounds / staging areas for code.

[Libreoffice] Short reminder: OOo HackFest 6./7. November in Hamburg

2010-10-20 Thread Thorsten Behrens
Hi folks, a short reminder that there's an OpenOffice.org HackFest taking place in Hamburg, Germany two weeks from now - if you're around, or can make it there, it's a great opportunity to meet hackers from OOo/LibO in person. More details here:

Re: [Libreoffice] how can we import/export .cbz/.cbr files on LibreOffice Impress?

2010-10-20 Thread Thorsten Behrens
Paulo Silva wrote: A missing awesome feature on LibreOffice Impress would be the possibility on importing/exporting .cbz and .cbr files on LibreOffice Impress. Hi Paulo, hm, that almost sound like a useful thing to have outside LibO - you can reasonably easily synthesize odf files - there are

Re: [Libreoffice] howto for getting non-trivial cppunit tests up and running

2010-10-20 Thread Thorsten Behrens
Caolan McNamara wrote: sc/qa/unit had an existing cppunit test to ensure that calc can do =SUM(A1:A2) correctly but it was currently disabled seeing as it didn't work, mostly due to miserable bootstrapping problems. I've fixed that test (I think), so I hope it can now provide a basis for

Re: [Libreoffice] [PATCH] - change default KDE from 3 to 4

2010-10-25 Thread Thorsten Behrens
Wols Lists wrote: Resubmit with brackets in subject - I think I need them for the patchmeister to pick up? Thanks a lot for the fix, pushed! -- Thorsten pgpvML4yXRas7.pgp Description: PGP signature ___ LibreOffice mailing list

Re: [Libreoffice] howto for getting non-trivial cppunit tests up and running

2010-10-26 Thread Thorsten Behrens
Caolan McNamara wrote: Righteo, re-enabled again and lets have another go. Right away I see it detected a new bug introduced with the vos removalstuff, which I've now fixed :-). Tests are good. Hi Caolan, sorry - breaks for me on at least two platforms consistently. Error log snippet: rm -f

Re: [Libreoffice] howto for getting non-trivial cppunit tests up and running

2010-10-27 Thread Thorsten Behrens
Michael Meeks wrote: On Wed, 2010-10-27 at 01:15 +0200, Thorsten Behrens wrote: I've for the while reverted the commit, will look into this tomorrow. Ah ! - better to add a prefix to the prj/build.lst dep. or something to the makefile.mk so it still build on (only) Linux

Re: [Libreoffice] howto for getting non-trivial cppunit tests up and running

2010-10-28 Thread Thorsten Behrens
Caolan McNamara wrote: register component 'configmgr.uno.so' in registry '../../unxlngx6.pro/misc/qa_unit/services.rdb' failed! error (CannotRegisterImplementationException): loading component library failed: configmgr.uno.so Can you (git pull bootstrap) and try export DEBUGREGCOMP=1

Re: [Libreoffice] LibreOffice config migration

2010-10-29 Thread Thorsten Behrens
Michael Meeks wrote: Speaking of which - I notice that neither us, nor up-stream register the migrationoo3.uno.so - so the migrate from 3.x code is never executed :-) we only migrate from 2.x - any ideas why that is ? (Thorsten?). I will push a fix to enable that in scp2 over the weekend

Re: [Libreoffice] Help concerning code style and documentation

2010-11-01 Thread Thorsten Behrens
Regina Henschel wrote: There is no mathematical problem, but I'm uncertain about coding style. The algorithms work on matrices. They have a lot of parts which are nearly identical but the matrices are transposed. How to handle that? Hi Regina, I'd suggest using templates to achieve that -

Re: [Libreoffice] SW_DLLPUBLIC limitations ...

2010-11-01 Thread Thorsten Behrens
Cedric Bosdonnat wrote: I finally got it working with SAL_DLLPUBLIC_EXPORT as michael suggested. If there is any possible trouble, let me know ;) Hi - oh wow, dynamic_casting on interfaces is really nasty - we should truly put up a bunch of big red warning signs around that. FWIW, if you try

Re: [Libreoffice] OpenBSD patch #1

2010-11-01 Thread Thorsten Behrens
Michael Meeks wrote: As for the csh .Set file - hopefully we can bin that in a gnumake world, by having a single set of makefile variables generated instead of whacking them all in the environment via a given shell. Please - bin both .Set and .Set.sh then - since this

Re: [Libreoffice] Export OLE objects as PDF / graphics

2010-11-01 Thread Thorsten Behrens
gertfal...@aliceadsl.fr wrote: in draw : easy rotate, crop, resize and right click 'save as...' in impress : same features and same toolbars in calc : easy resize, right click 'rotate', but no crop nor 'save as...' in writer : no 'rotate', easy resize, right click 'crop', right click 'save

Re: [Libreoffice] [Review Request] remove a confusing use of GetMutex() when a SolarMutexGuard is really meant

2010-11-01 Thread Thorsten Behrens
Norbert Thiebaud wrote: The attached patches are pending... I am submitting them to the list for comments or objections before pushing them. Hi Norbert - patches seem to be pushed - many thanks for the cleanup! Cheers, -- Thorsten pgp52GbxTjXhW.pgp Description: PGP signature

Re: [Libreoffice] Bug Triage Process

2010-11-02 Thread Thorsten Behrens
Muthu Subramanian wrote: - who is our expert for Base? hmm...as far as I know: nobody as of now, Any volunteers? Let's have a special fdo mail alias then, for the while - Kendy, could you create one, like libreoffice-base-bugs? Cheers, -- Thorsten pgpX4TsiMQTnq.pgp Description: PGP

Re: [Libreoffice] ./download doesn't work behind a proxy

2010-11-03 Thread Thorsten Behrens
Marc-Oliver Straub wrote: Setting http_proxy doesn't help (since git:// is used and not http://). Hi Marc-Oliver, sorry, freedesktop git is only available via native git protocol - if there's no way to forward that port on your proxy, please either use the source tarballs, or clone the repos

Re: [Libreoffice] Mac OS X Build issues.

2010-11-03 Thread Thorsten Behrens
Joseph Powers wrote: Not sure if this is the correct patch Looks good, works for me - pushed. Many thanks! -- Thorsten pgpqYWy9gIFCd.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] OpenBSD patches for ure

2010-11-04 Thread Thorsten Behrens
Robert Nagy wrote: Patches for ure, neeed by OpenBSD Looks good, pushed. Many thanks! -- Thorsten pgp9JXE5g3YQR.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] build problem in instsetoo_native module on linux x86-64

2010-11-04 Thread Thorsten Behrens
Mattias Johnsson wrote: Unfortunately, LO no longer builds. I get the following error when I try to build in the instsetoo_native directory. ERROR: The following files could not be found: ERROR: File not found: libmsworkslx.so ERROR: File not found: libwpgimportlx.so ERROR: File not found:

[Libreoffice] [PUSHED] SAL_N_ELEMENTS for clone/components directory

2010-11-04 Thread Thorsten Behrens
julien wrote: Here is a patch for clone/components (i think there's no more in it). Many thanks, pushed! -- Thorsten pgp55ia6O6aPE.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[Libreoffice] [PUSHED] SAL_N_ELEMENTS for clone/sdk directory

2010-11-04 Thread Thorsten Behrens
julien wrote: Here is a patch for clone/sdk (here again i think there's no more in it). Pushed as well, thanks muchly! -- Thorsten pgpq8Useg2gUc.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

[Libreoffice] [PUSHED] Easy hack patches, remove non-compiled code

2010-11-04 Thread Thorsten Behrens
Kevin Hunter wrote: Patches against calc/.../miscdlgs/ to remove non-compiled code and other minor refactors. Pushed the non-compiled code removals. Many thanks! -- Thorsten pgpQHn4IKZJMI.pgp Description: PGP signature ___ LibreOffice mailing list

Re: [Libreoffice] [PATCH] Easy hack patches, remove non-compiled code

2010-11-04 Thread Thorsten Behrens
Kevin Hunter wrote: Further (with exceptions, of course), automagic tools provide a much more consistent and at least acceptable-by-all metric for how code should look. (And I would argue that how code looks via the squint-test is very *much* pertinent for longer term gathering of new

Re: [Libreoffice] [PATCH] Renaming extension options

2010-11-04 Thread Thorsten Behrens
Niko Rönkkö wrote: Also: We don't want to break builders scripts (as Michael Meeks said) so deprecated old options not removed but commented instead. Hm, since we've now branched off 3.3 - I wouldn't mind changing it completely. I think it's better to get nice hard errors once, instead of a

[Libreoffice] [PUSHED] Elide all SO: and OOo: prefixes

2010-11-04 Thread Thorsten Behrens
Hi Niko, thanks a lot, pushed - slightly tweaked, the SO:... prefixed dependencies can go entirely. -- Thorsten pgpkNbl6RexSP.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [Libreoffice] Changing mailing list behavior

2010-11-04 Thread Thorsten Behrens
Regina Henschel wrote: I often get mails two times, one over the list and the other directly. The other way round, I fall into the trap not the answer to the list but to the poster directly. Is it possible to organize the list as the lists are organized for OOo? There all posts go to the

Re: [Libreoffice] New credits page up (and linked from TDF)

2010-11-08 Thread Thorsten Behrens
Sebastian Spaeth wrote: What would be super-nice, would be if we could have a patch a little like the Help-License info one - cf. sfx2/source/appl/appserv.cxx - that would load a nice ODF document containing the output of your work - so that we cna ship that with the binaries, and make it

Re: [Libreoffice] [PATCH] More URLs to OOo sites

2010-11-09 Thread Thorsten Behrens
Hi Flo, all, recent changes to url strings in LibO, for completeness sake - and no need for any setup here, server-side. Cheers, -- Thorsten From da9762a0da84a061fd2adadfdb51295357d5e270 Mon Sep 17 00:00:00 2001 From: Thorsten Behrens tbehr...@novell.com Date: Wed, 3 Nov 2010 11:48:47 +0100

Re: [Libreoffice] How to build for 3.3

2010-11-09 Thread Thorsten Behrens
Miklos Vajna wrote: 2) I'm attaching two patches: a) Avoid the usage of git-branch (usual problem: git-branch is a git porcelain command so its output may change any time without notice). b) Don't check if master is checkout out, check if the branch is the same as the branch of build.git,

[Libreoffice] [PUSHED] RTL patches for canvas and chart2

2010-11-09 Thread Thorsten Behrens
Kevin Hunter wrote: My last contribution of the day, with two RTL patches for canvas/ and chart2/ . Seems the basebmp parts were already applied - used the canvas ones. Many thanks for the cleanup - as per the discussion around trailing whitespace changes, did not commit those. Cheers, --

Re: [Libreoffice] UX opportunity ... / Easy Hacks

2010-11-10 Thread Thorsten Behrens
Sebastian Spaeth wrote: Apparently our Mac OSX gui gets very little love. One person has repeatedly asked to remove the pinstripes in the dialogs too. Perhaps this is something to get involved with? Quite. So to not forget this, logged a bug attached a (not yet working) patch to it. That

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-11-10 Thread Thorsten Behrens
surensp...@gmail.com wrote: I current way I am implementing is that I save the Graphic a temporary file,then to create a new thread ( using osl_createThread from osl/thread.h ) and from within the new thread execute the external application to open the temp ( using osl_executeProcess from

[Libreoffice] [QA] Existing practice open questions

2010-11-11 Thread Thorsten Behrens
Hi, following is a list of current QA practices I'm aware of: Current === New bugs come in, get assigned to the libreoffice-b...@lists.freedesktop.org bug alias (throw me a mail if you want to be added there), and then get triaged / assigned to developers. Here's the list of people

Re: [Libreoffice] [QA] Existing practice open questions

2010-11-11 Thread Thorsten Behrens
Miklos Vajna wrote: Not sure if such a small area worths mentioning, but I try to take care of RTF export bugs (as my time permits) + git-specific issues. Hi Miklos, many thanks for volunteering - added you to the list. -- Thorsten pgpjMe0IYiq24.pgp Description: PGP signature

Re: [Libreoffice] Minutes technical group call

2010-11-12 Thread Thorsten Behrens
Andrea Pescetti wrote: Is this a typo, or you really mean a .doc file in the old Microsoft Word format? Nah, should have been .odt - like the license file. Good catch! ;) -- Thorsten pgprKQNWkSJMq.pgp Description: PGP signature ___ LibreOffice

Re: [Libreoffice] Menos de R$ 0,50 por Recarga

2010-11-12 Thread Thorsten Behrens
Jonathan Aquilina wrote: does this mailing list have some sort of spam filtering? Yes. Mailman catches most of the spam, I've up to now only seen some 3 or so mails making it through. Posting is currently open to non-subscribers, too - I've no real strong opinion on this, you have drawbacks on

Re: [Libreoffice] Menos de R$ 0,50 por Recarga

2010-11-12 Thread Thorsten Behrens
Jonathan Aquilina wrote: does mailmain auto black list spam email addresses? Haven't looked deeper into the config options there - currently, recognized spam ends up in the mod queue, and I make it a habit of adding the sender address to the dispose list. So effectively, they're blacklisted

Re: [Libreoffice] compile-time trickery to detect misuse of SAL_N_ELEMENTS, RTL_CONSTASCII_USTRINGPARAM, etc.

2010-11-12 Thread Thorsten Behrens
Caolan McNamara wrote: So, with a bit more poking around I discovered the template trick to force a compile time error if the argument is not an array, and to calculate at compile time the length of the array. Clever hack! :) Along those lines, any reason not to use boost in sal / udk? I've

Re: [Libreoffice] compile-time trickery to detect misuse of SAL_N_ELEMENTS, RTL_CONSTASCII_USTRINGPARAM, etc.

2010-11-13 Thread Thorsten Behrens
Caolan McNamara wrote: Was there a policy against using boost in sal/cppu/etc ? I somehow forgot the rationale, but yeah: http://www.openoffice.org/servlets/ReadMsg?list=interface-discussmsgNo=869 -- Thorsten pgpCyQLOPmvfW.pgp Description: PGP signature

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-11-15 Thread Thorsten Behrens
surensp...@gmail.com wrote: 1) Making it work in all OS/platforms: [...] Hi Suren, wow, great progress! For the editing, one easy way out would be to use the SystemShellExecute service, which will pick an app registered for the file type at hand. You can e.g. find a usage example in

Re: [Libreoffice] [PATCH] More patches for Base

2010-11-15 Thread Thorsten Behrens
Wols Lists wrote: By the way, is there an easy git command to squash two patches together? If you realize that your last commit was incomplete - use git commit --amend. That lumps your uncommitted changes into the last commit. Cheers, -- Thorsten pgpIIfl39x6mf.pgp Description: PGP signature

Re: [Libreoffice] [PUSHED Fix typo in Impress (i105883 and i102212)

2010-11-15 Thread Thorsten Behrens
Mattias Johnsson wrote: Rename the custom animation Put on the Breaks to Put on the Brakes. So here's a question - what do I do when I fix an OO.o issue that's in the OO.o issue tracker, but not in the LO bugzilla? I suppose I can't really comment there and say it's fixed, since they're not

[Libreoffice] More links inherited from OOo

2010-11-15 Thread Thorsten Behrens
Hi folks, after some more grepping, also adapted the readmes to only reference documentfoundation/libreoffice links. File is attached, would be cool if you could review it for correctness, language - and whether the links as such make sense. Thanks, -- Thorsten ?xml version=1.0 encoding=UTF-8?

Re: [Libreoffice] presenterconsole in writer ? ...

2010-11-17 Thread Thorsten Behrens
Michael Meeks wrote: Any volunteer interesting in debugging that ? one good way would be to put a breakpoint in osl_psz_loadModule - and just stepping through until we hit the one that pulls it in, grabbing a backtrace and posting it for this module ;-) There's an initial patch for

[Libreoffice] [UX] Progress bars - convey this make take some time, dunno how long

2010-11-17 Thread Thorsten Behrens
Hi, chatting with some folks yesterday at the OOo congress for business and administration, and two users approached me with a problem most prevalent when saving to network volumes: LibO save progress bars are basically driven by the xml export code (when saving to odf, of course), but there's

Re: [Libreoffice] crash report and Oracle url

2010-11-19 Thread Thorsten Behrens
Jean-Baptiste Faure wrote: Yesterday I got the crash report in LibO after a test of docking the navigator on the right edge of the LibO window. It contained a link to the privacy policy of Oracle. I did not sent the crash report because it was no clear for me who is the recipient of this

Re: [Libreoffice] Windows installer: what languages in multi/all_lang? - SDK: Why different version number?

2010-11-23 Thread Thorsten Behrens
Christian Lohmaier wrote: * What languages does the windows installer contain? * Which ones are included in multi and which ones in all_lang? Hi Christian, all_lang is built --with-lang=ALL, multi includes the same set as you see for Mac. * Is it correct that help in both packages is only

Re: [Libreoffice] Windows installer: what languages in multi/all_lang? - SDK: Why different version number?

2010-11-23 Thread Thorsten Behrens
Christian Lohmaier wrote: * Version of the SDK: Why is the version 3.3.0 for Windows, but 315 for all others? Gah. My bad. Last minute renaming script gone wrong. So 315 is correct or 3.3.0? 3.3.0 Ah, So I can take (for beta3 at least) the difference between Mac Intel as reference

Re: [Libreoffice] More links inherited from OOo

2010-11-23 Thread Thorsten Behrens
Sophie Gautier wrote: - the paragraph about changes on BerkeleyDB engine and extensions database incompatiliby seems strange when speaking about [for ${PRODUCTNAME} versions prior to 3.2]. May be we should namely speaks about OpenOffice.org. Removed completely, LibO uses its own config dir

Re: [Libreoffice] Building problem, DEBUG_ELEMENT when DEBUG is off

2010-11-23 Thread Thorsten Behrens
Joost Eekhoorn wrote: I had a problem in writerfilter, building without DEBUG. Should be fixed on master, please pull latest changes. Cheers, -- Thorsten pgplJkZmzhzbu.pgp Description: PGP signature ___ LibreOffice mailing list

[Libreoffice] Auto-detection of toolbar icon size (well, kinda)

2010-11-24 Thread Thorsten Behrens
Hi, prompted by some complaints on too large icons on Mac, switched the icon size from 'large' to 'auto' for 3.3. Added code to all vcl native widget implementations to pick a preferred icon size (or auto-size them - this was already in place for windows, added similar code for Mac). Gnome/KDE

Re: [Libreoffice] Auto-detection of toolbar icon size (well, kinda)

2010-11-25 Thread Thorsten Behrens
Michael Meeks wrote: prompted by some complaints on too large icons on Mac, switched the icon size from 'large' to 'auto' for 3.3. Did we ever get some screenshots of the perceived problem ? I asked in some bug, but never got that back AFAIR. Hi Michael, take my word for it, it

Re: [Libreoffice] compilation of LO on mac

2010-11-25 Thread Thorsten Behrens
Jonathan Aquilina wrote: hey guys is it possible to compile LO on mac osx? if so what dependencies does one need to satisfy before compiling it. Hi Jonathan, sure - please read up here for details: http://wiki.documentfoundation.org/Development/How_to_build#Mac_OS_X Don't hesitate to ask,

Re: [Libreoffice] installation on mac doesnt require read me or licenses

2010-11-25 Thread Thorsten Behrens
Jonathan Aquilina wrote: hey guys i'm noticing something interesting. wouldn't it be better to use an installer to make sure the read me's as well as the licenses get installed in the LO directory. currently the way it is i don't have to drag either of them into the application directory. Hi

Re: [Libreoffice] main.xdg 2 largest sections not needed on startup?

2010-11-26 Thread Thorsten Behrens
Sebastian Spaeth wrote: The 2 biggest sections are: Labels 14345 + 11 lines (defining label sizes for printing envelope labels) TableWizard 8666 + 26 lines These make 1/3 of main.xdg, are both needed on startup or can those be put into a different file that is only read when it is really

Re: [Libreoffice] Image Compression Patch

2010-11-26 Thread Thorsten Behrens
Hi Andrew, sorry, a few of those nasty odf-branded icons slipped past me, had to revert a bunch of your optimized icons in default_images - do we have a script / documentation somewhere, so this can be re-optimized? Cheers, -- Thorsten pgpX8CKqmowyF.pgp Description: PGP signature

Re: [Libreoffice] [Crazy Ideas] Discuss Replace regexp parser with std library

2010-11-29 Thread Thorsten Behrens
Joe Smith wrote: I've looked at the code a bit, and it seems like there is indeed only one point of contact with the rest of the suite, textsearch.cxx, which handles all types of text searches (normal, regexp fuzzy), and calls Regexpr::re_search(), which calls re_match2() to run the

[Libreoffice] Updated artwork for RC

2010-11-29 Thread Thorsten Behrens
Hi, since we decided to label the next release RC1 (http://lists.freedesktop.org/archives/libreoffice/2010-November/003452.html), just updated our artwork from http://wiki.documentfoundation.org/File:LibreOffice-Initial-Artwork-Package.zip (differences: removed beta text, text / paper is

Re: [Libreoffice] Updated artwork for RC

2010-11-29 Thread Thorsten Behrens
Hi Chris, you wrote: Just to be sure - did you also update the position of the progress bars? Yep. And, looking at the files list below, it seems that the original filenames (picked from the OOo UI project) changed a bit. Would it be helpful to rename the icons within the artwork package?

Re: [Libreoffice] [UX] LO status bar annoyances

2010-11-30 Thread Thorsten Behrens
Sebastian Spaeth wrote: Am I the only one finding the current status bar pretty much useless? Nope. I hear you, pretty much unconditionally. Adding UX tag Cc-ing my favourite UX homie. :) Cheers, -- Thorsten pgphW56AvlvY5.pgp Description: PGP signature

Re: [Libreoffice] Script to find undocumented classes

2010-11-30 Thread Thorsten Behrens
Miklos Vajna wrote: Does the idea sounds sane, OK to push? Totally! Would you maybe also be interested to work on an improved start page / index, e.g. like this here: http://www.informatik.uni-hamburg.de/~meine/hg/vigra/file/bf402d01f821/docsrc/index.dxx (see

Re: [Libreoffice] Script to find undocumented classes

2010-11-30 Thread Thorsten Behrens
Lubos Lunak wrote: On Tuesday 30 of November 2010, Thorsten Behrens wrote: Additionally, I think most classes don't necessarily need detailed docs for all methods in the first place (which may also hurt later merging from OOo), but would already benefit from a two-line mission statement

Re: [Libreoffice] Script to find undocumented classes

2010-12-01 Thread Thorsten Behrens
Sebastian Spaeth wrote: What does bFull mean? Not so quick? What portions will be formatted if this is FALSE? Looking at the function it either calls pImpEditEngine-FormatFullDoc(); or pImpEditEngine-FormatDoc(); What the heck is the difference between those functions? Now I have to

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-12-01 Thread Thorsten Behrens
surensp...@gmail.com wrote: After few sleepless nights spent grokking and with quite a big deal help from IRC and the list, have come up with the first cuts working version of the External Edit functionality[1]. Have attached the patches rebased against the latest master. Hi Suren, I had

Re: [Libreoffice] Script to find undocumented classes

2010-12-02 Thread Thorsten Behrens
Hi Lubos, you wrote: I'm not asking for anything ridiculous like having a paragraph explaining every line, I'm saying that everything non-trivial should have at least some documentation Good, then we're mostly on the same page. Then we're both talking about mission statements, higher-level

Re: [Libreoffice] [PUSHED] patch review for commit 67be5829944758dec070710521cd86ae49e00aa9

2010-12-02 Thread Thorsten Behrens
Radek Doulík wrote: would you please review my patch in vcl/source/canvastools? I would like to push it to 3-3 branch. Done, thanks for that fix - nasty temporary of a temporary bug. Signed-off pushed. Cheers, -- Thorsten pgpq0Y33Rt6xE.pgp Description: PGP signature

Re: [Libreoffice] [PUSHED] patch review for commit 67be5829944758dec070710521cd86ae49e00aa9

2010-12-02 Thread Thorsten Behrens
Radek Doulík wrote: would you please review my patch in vcl/source/canvastools? I would like to push it to 3-3 branch. Done, thanks for that fix - nasty temporary of a temporary bug. Signed-off pushed. Cheers, -- Thorsten pgpV2bJa5WSSs.pgp Description: PGP signature

Re: [Libreoffice] [PUSHED] Clean code at impress

2010-12-02 Thread Thorsten Behrens
Kayo Hamid wrote: Covering impress/animations/source/animcore/ and impress/sd/source/core/*, sending for review. Hi Kayo, many thanks, looks good, committed - two minor tweaks: turned the first XCommend... hunk into a better comment, and did not remove the inbetween parts of

Re: [Libreoffice] [For Review] --enable-opengl impact on MacOS build (and other platform)

2010-12-03 Thread Thorsten Behrens
Norbert Thiebaud wrote: --with-openl is now on be default for MacOS in the bootstrap configure.in. This actually break on MacOS. There is a patch in dev300/. that seems to address this problem. The attach patches integrate this patch. Since I have no expertise in this part of the code, I'd

Re: [Libreoffice] defaulting to --without-java ... (?)

2010-12-03 Thread Thorsten Behrens
Kálmán „KAMI” Szalai wrote: I agree. However can we see what we lose with java enabled builds (diskspace, performance, startup time)? Random facts - here, java-1_6_0-sun-1.6.0.u22 is a major offender in powertop, with apparently some GC timer running very frequently. Cheers, -- Thorsten

Re: [Libreoffice] Script to find undocumented classes

2010-12-03 Thread Thorsten Behrens
Jan Holesovsky wrote: As a conclusion, what about to combine Miklos' check for the missing documentation with a commit hook, so that it does not allow you to commit _new_ files without (at least the high level) documentation? ;-) Hi Kendy, I find it surprising me actually saying this, but -

[Libreoffice] Fix for fdo#31243 needs review

2010-12-03 Thread Thorsten Behrens
Hi Caolan, took your patch, handled one more case - could you please review commit to libreoffice-3-3 if ok? Cheers, -- Thorsten From 25ae4e3bf1632150aa54769ed5b3235cbfa2af2f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= caol...@redhat.com Date: Fri, 3 Dec 2010 11:15:24

Re: [Libreoffice] Suggestion needed for External Edit functionality.

2010-12-03 Thread Thorsten Behrens
surensp...@gmail.com wrote: I shall touch base with you on the IRC and will implement all the tweaks as you suggest. If there are any best practices wiki link, please guide me to that :) There are one or two other things that could benefit from looking into, e.g. the usage of the worker

Re: [Libreoffice] Script to find undocumented classes

2010-12-03 Thread Thorsten Behrens
Jan Holesovsky wrote: As to the crossing the line - the first time it won't let you commit, and you'll be angry, the second time it won't let you commit, and you'll just fix that, and the third time you'll comment just naturally, and won't even hit the check :-) This worked with the warnings

Re: [Libreoffice] LibreOffice-3.3-rc1 git tag and fixes reviewing

2010-12-03 Thread Thorsten Behrens
Petr Mladek wrote: libreoffice-3-3 git branch is still opened for fixes. Just please, send your patches for review to this mailing list before you commit. You might ask a particular person for review via CC or on the irc channel #libreoffice. Hi Petr, all, it would then be nice if the

Re: [Libreoffice] de-emphasisig java ... - summary so far ...

2010-12-05 Thread Thorsten Behrens
Christian Lohmaier wrote: But it is more than clear that those users will then get the This function requires a JRE notification. This hasn't been a problem in OOo-land, so why should it be a problem for LO? Because the default OOo install does include a JRE. Otherwise, I'm rather indifferent

Re: [Libreoffice] Build environment MacOSX - autoconf / automake version problems

2010-12-10 Thread Thorsten Behrens
Alexander Thurgood wrote: to getting the build environment up and running on my Mac OSX Snow Leopard, but I've hit a snag with automake. When I go to configure automake 1.11.1, I get this error message and obviously configure bombs out : configure: error: Autoconf 2.61a-341 or better is

Re: [Libreoffice] pdf import extention

2010-12-13 Thread Thorsten Behrens
Lior Kaplan wrote: Could we import changes made in the PDF import extension ? See http://hg.services.openoffice.org/cws/pdfextfix04 Yep, makes sense - if someone could second this, I'll commit it to -3-3. Cheers, -- Thorsten pgpe1Z2XnBMLJ.pgp Description: PGP signature

Re: [Libreoffice] [PUSHED] Grey as default color for native tables in Impress

2010-12-13 Thread Thorsten Behrens
camille wrote: Please find attached a tentative patch for my own Easy Hack described below. Thanks camille, looks good is a sensible approach. Committed to -3-3. Keep the patches coming! :) Cheers, -- Thorsten pgpd77dGGctLp.pgp Description: PGP signature

Re: [Libreoffice] Feature list for upcoming version

2010-12-13 Thread Thorsten Behrens
Marc Paré wrote: I'm helping out with the Features list for the upcoming LibreOffice v. 3.3 as found on this page: http://wiki.documentfoundation.org/Marketing/LibOReleaseEvents/LOPressKit/FeatureList3.3 . Sophie was kind enough to help with the initial list. Is there a place where a list of

Re: [Libreoffice] De-Java-ise flat XML export

2010-12-14 Thread Thorsten Behrens
Michael Meeks wrote: Riight; interesting. Ultimately XSLT requires a DOM to operate on, so I suppose if we get SAX events from OO.o, we will need to map these to libxml's nodes. I believe we already have code to do this in xmlsecurity/source/xmlsec/saxhelper.cxx / .hxx - which

[Libreoffice] Fix for pdfimport (fdo#32330) needs review

2010-12-14 Thread Thorsten Behrens
Hi, could someone quickly review attached patch - a fairly safe fix I'd like to include in -3-3, since it quite spectacularly break graphics on PDF import. Thanks, -- Thorsten From e455af833b31e3d5e8f7fa32a24ea44e53126baa Mon Sep 17 00:00:00 2001 From: Thorsten Behrens tbehr...@novell.com Date

Re: [Libreoffice] Need review of the ooo/OOO330_m18 changes

2010-12-15 Thread Thorsten Behrens
Jan Holesovsky wrote: impress Reviewed cherry-picked the i#107568 fixes Cheers, -- Thorsten pgpLzIalt3kyB.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

  1   2   3   4   5   6   7   8   9   10   >