Re: additional dictionaries

JE G wrote > ... > What are the requirements to get a word list like this into a specialized > spelling dictionary? Is there software to do it or a special format? Hello, There's this https://wiki.documentfoundation.org/Development/Dictionaries about dictionaries but I don't think it would help i

Re: Some dialogs don't work in OS X (master branch)

I could reproduce this with master sources updated today and MacOs 10.9.4. Would it be possible you submit a new bugtracker by using this link: https://www.libreoffice.org/get-help/bug/ ? Julien -- View this message in context: http://nabble.documentfoundation.org/Some-dialogs-don-t-work-in-OS

Re: Suspicious attribute style:repeat="scale"

After some Googling, I only found this: https://wiki.openoffice.org/wiki/User:Frank_Sch%C3%B6nheit/ODF_Proposals/Image_Control_Scale -- View this message in context: http://nabble.documentfoundation.org/Suspicious-attribute-style-repeat-scale-tp4117240p4117258.html Sent from the Dev mailing lis

Re: Questions about getCppuType

As you may have seen, I've begun to replace occurences. Just to be sure, is "Sequence" always a shortcut of "css::uno::Sequence" or could it be something else sometimes? (I mean something not related to css::uno) Idem for "Reference", could it be something else that "css::uno::Reference"? Julien

[SOLVED] Re: About removing macros

About "DECL_PROP1IMPL", "DECL_PROP0" and others, patches pushed on master (eg: http://cgit.freedesktop.org/libreoffice/core/commit/?id=aa214079b4e9df493b57fbf815460b7164225f2b http://cgit.freedesktop.org/libreoffice/core/commit/?id=0fadbdbbdbd55cf60f9a202f1cf7b1d60517078c) Julien -- View this m

Question unoType for getXmlToken (dbaccess/reportdesign module)

Hello, I noticed this: s_aTypeNameMap[GetXMLToken( XML_FLOAT)] = ::cppu::UnoType::get(); present at 2 locations: See http://opengrok.libreoffice.org/search?q=%22GetXMLToken%28+XML_FLOAT%29%22&project=core&defs=&refs=&path=&hist= Why shouldn't be this: s_aTypeNameMap[GetXMLToken( XML_FLOAT)] = ::c

Wrong copy paste in ucbcmds.cxx? (ucb module)

Hello, I noticed this part: 236 CommandProcessorInfo::CommandProcessorInfo() 237 { 238 m_pInfo = new uno::Sequence< ucb::CommandInfo >( 2 ); 239 240 (*m_pInfo)[ 0 ] 241 = ucb::CommandInfo( 242 OUString( GETCOMMANDINFO_NAME ), // Name 243

Re: Questions about getCppuType

I noticed that if I did this: diff --git a/cppu/qa/test_unotype.cxx b/cppu/qa/test_unotype.cxx index bbea200..f0d2b03 100644 --- a/cppu/qa/test_unotype.cxx +++ b/cppu/qa/test_unotype.cxx @@ -271,8 +271,8 @@ void Test::testUnoType() { void Test::testGetTypeFavourUnsigned() { CPPUNIT_ASSERT(typ

[SOLVED] Re: Question unoType for getXmlToken (dbaccess/reportdesign module)

Thank you Lionel for your detailed feedback! I quoted you for the comment, see http://cgit.freedesktop.org/libreoffice/core/commit/?id=f62de9113a4866f7152acbe0e8221c594b7a7b68 Julien -- View this message in context: http://nabble.documentfoundation.org/Question-unoType-for-getXmlToken-dbacces

Re: Questions about getCppuType

I noticed there are a lot of "Reference" without prefix. Is there a way to be sure it's ok to replace these occurences by cppu::UnoType... ? -- View this message in context: http://nabble.documentfoundation.org/Questions-about-getCppuType-tp4106361p4109226.html Sent from the Dev mailing list ar

Re: Questions about getCppuType

Athomas: indeed, I hope there's another way because I'm running a simple regexp to replace the occurences:-) -- View this message in context: http://nabble.documentfoundation.org/Questions-about-getCppuType-tp4106361p4109260.html Sent from the Dev mailing list archive at Nabble.com. ___

[SOLVED] Re: Wrong copy paste in ucbcmds.cxx? (ucb module)

sberg wrote > ... >> I wonder if line 254 could be a wrong copy paste and should be: >> cppu::UnoType > > ::get() ); > > Yes, that's wrong. (See UniversalContentBroker::execute in > ucb/source/core/ucb.cxx, where CHECKIN_HANDLE/CHECKIN_NAME expects to > get a CheckinArgument, not a GlobalTrans

Re: Questions about getCppuType

After lots of changes, there are still Sequence cases + things like: ::getCppuType(&m_sFilter)); just to be sure, should it replaced by "cppu::UnoType< type of m_sFilter >::get();" ? Also, are there special cases to take into account for these? Julien -- View this message in context: http://

About removing Browser Plugin

Hello, Following https://bugs.freedesktop.org/show_bug.cgi?id=45071, it seems "Browser plugin" can be removed from 4.4 To do this, I thought git removing core/extensions/source/plugin/, + tune some mk file in core/extensions and finally core/configure.ac should be ok. 1) Is it ok? Am I forgettin

LibreOffice, about avoiding "attempt to erase from container with a past-the-end iterator"

Hello, I noticed this interesting change http://cgit.freedesktop.org/libreoffice/core/commit/?id=72827968e606adcdf8c16e5381b887180975ae46 ("Try to avoid "attempt to erase from container with a past-the-end iterator") I tried to search similar cases in Opengrok and found some of them (because quite

[SOLVED] Re: LibreOffice, about avoiding "attempt to erase from container with a past-the-end iterator"

Thank you Stephan for your feedback, so I'll let this as it is. Julien -- View this message in context: http://nabble.documentfoundation.org/LibreOffice-about-avoiding-attempt-to-erase-from-container-with-a-past-the-end-iterator-tp4110615p4110679.html Sent from the Dev mailing list archive at

Strange part in connectivity/source/drivers/jdbc/tools.cxx

Hello, I noticed this part: 113 // this is a special property to find the jdbc driver 114 if ( pBegin->Name.compareToAscii( "JavaDriverClass" ) 115 && pBegin->Name.compareToAscii( "JavaDriverClassPath" ) 116 && pBegin->Name.compareToAsci

Re: [SOLVED] Re: Strange part in connectivity/source/drivers/jdbc/tools.cxx

Lionel Elie Mamane wrote >> ...or, of course, even better yet, > >> pBegin->Name != "JavaDriverClass" ... > > Yes, Julien, this one is IMHO worth doing. It makes the code that much > more readable :) Done now on master, see http://cgit.freedesktop.org/libreoffice/core/commit/?id=6cc359f8d739a9

Re: avoiding cppunit zerodiv correction

Matteo Casalin-3 wrote > ... > I don't have any comment about your proposal, but just would like to > add that unless we know for sure that nHeight!=0 at that point, in > both codes the check should be > > if( nHeight <= 0 ) > > in order to solve the division by 0 completely. You're right of cou

Some checkings related to

Hello, Taking a look at https://bugs.freedesktop.org/show_bug.cgi?id=79499, I opengroked xub_StrLen and found some references. Most of them are just comments but there are associated checks See http://opengrok.libreoffice.org/search?q=xub_StrLen&project=core&defs=&refs=&path=&hist= I wonder if the

Build fail with MacOs in connectivity part

Hello, I gave a try to a MacOs build and had this error: [build CXX] connectivity/source/drivers/odbc/OTools.cxx /lo/core/connectivity/source/drivers/odbc/OPreparedStatement.cxx:338:9: error: static_assert failed "sizeof(SQLWCHAR) == 2" BOOST_STATIC_ASSERT( sizeof(SQLWCHAR)== 2 );

Re: Build fail with MacOs in connectivity part

Trying to unwind, I found this: http://opengrok.libreoffice.org/xref/core/external/unixODBC/inc/odbc/sqltypes.h#112 112 #ifdef SQL_WCHART_CONVERT 113 typedef wchar_t WCHAR; 114 #else 115 typedef unsigned short WCHAR; 116 #endif After a test, I confirm that unsi

Re: Build fail with MacOs in connectivity part

Sorry Lionel, I had just checked my emails, not the forum. I'll take a look Julien -- View this message in context: http://nabble.documentfoundation.org/Build-fail-with-MacOs-in-connectivity-part-tp4111804p4111817.html Sent from the Dev mailing list archive at Nabble.com. _

Re: Build fail with MacOs in connectivity part

Indeed Norbert is right, I got this: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk/usr/include/odbcinst.h and SQLWCHAR is defined as Norbert indicated. I suppose it's 64 bits since config.log displays this: build='x86_64-apple-darwin13.2.0' buil

Re: Build fail with MacOs in connectivity part

Thank you Tor for these advice, I removed them. About Ant, Autoconf and Automake, I used brew. Concerning Junit, I disabled it. About 64 bits, indeed I hadn't put --enable-64-bits, I added it. Finally about Windows, I'm aware there's a pb with 64 build. I did try 1 or 2 years ago to build (just si

Re: Access2Base - New release

Hi, I read the whole thread and tried to understand, "tried" because I'm not enough "fluent" in these technical/internal LO part. Why A2B must be quickly (I mean without waiting for next LO version) "upgradable"? Either it's stable and so we don't absolutely need to upgrade it quickly or it's uns

Build fails on CppunitTest_svl_qa_cppunit

Hello, With master sources updated today, the build fails with this console logs: /home/julien/compile-libreoffice/libreoffice/svl/qa/unit/svl.cxx:403:(anonymous namespace)::Test::testFdo44286 equality assertion failed - Expected: 1902-04-22 - Actual : -04-DD svl.cxx:403:Assertion Test name:

[SOLVED] Re: Build fails on CppunitTest_svl_qa_cppunit

Solved thanks to Lionel and Isamu (see http://nabble.documentfoundation.org/fdo-44286-unittest-fails-in-non-English-locale-td4112845.html) -- View this message in context: http://nabble.documentfoundation.org/Build-fails-on-CppunitTest-svl-qa-cppunit-tp4112827p4112855.html Sent from the Dev mai

Re: I need to better understand our css::uno::Reference

Hello, Sorry for this certainly naive and humble (because I wouldn't be able at all to help here) question, but just by curiosity, is there some plan to rewrite partly/clean UNO in order to: - not depend on vtables implementation - avoid to use of reinterpret_cast (and therefore possibly detect er

Cppcheck:"Logical disjunction always evaluates to true" in svdotextdecomposition.cxx (svx module)

Hello, Cppcheck reported this: 1237incorrectLogicOperator style Logical disjunction always evaluates to true: nRepeat||!nRepeat. in svx/source/svdraw/svdotextdecomposition.cxx Indeed, we've got this: 1236 // loop. In loop, move through 1237 if(nRepeat || 0L == nRepeat) 1238

Re: Missing image warning

Hello Chris, You might be interested in this bugtracker: https://bugs.freedesktop.org/show_bug.cgi?id=83315 Other: could not load image http://nabble.documentfoundation.org/Missing-image-warning-tp4121972p4122004.html Sent from the Dev mailing list archive at Nabble.com. __

About recent commits for C++11 building

Hello, Following last commits for MacOs which increases compatibility with C++11, I'd like to know if: 1) we can replace all the workaround about the erase iterator management for some containers (with a temp iterator) and directly use for every case for eg: it = itcontainer.erase(it); 2) we can

[ABANDONNED] Re: About recent commits for C++11 building

Ok we're still not compatible C++11, see http://ci.libreoffice.org/job/buildbot/2477/ Sorry for the noise. Julien -- View this message in context: http://nabble.documentfoundation.org/About-recent-commits-for-C-11-building-tp4122219p413.html Sent from the Dev mailing list archive at Nabble

Building pb OTools.cxx in MacOs (connectivity part)

Hello, On Mac OS 10.9 and master sources updated about 2 days ago, I've got this building problem: lo/core/connectivity/source/drivers/odbc/OTools.cxx:462:23: error: no matching member function for call to 'append' aData.append(waCharArray, nReadChars); ~~^~

Should we use boost::math::log1p/expm1 instead of rtl_math_log1p/expm1 ?

Hello, Following http://cgit.freedesktop.org/libreoffice/core/commit/?id=a3ad01dc1e07da21182077bd899094fd73f57714, should it worth it to replace rtl_math_log1p/rtl_math_expm1 and related by boost::math::log1p/expm1 ? Or should we let the code as it is right now? Since we already use Boost, I tho

Re: Should we use boost::math::log1p/expm1 instead of rtl_math_log1p/expm1 ?

Andrew Douglas Pitonyak wrote > Julien, I am curious if you have done any testing. > ... Hi Andrew, First thank you for your feedback. I must recognize that no, I didn't made any tests. Andrew Douglas Pitonyak wrote > No differences were found in this little test. Then again, on Fedora, > Boos

[SOLVED] Re: Build fails (-Werror=deprecated-declarations), vcl module

Thank you Stephan for your patch. Julien -- View this message in context: http://nabble.documentfoundation.org/Build-fails-Werror-deprecated-declarations-vcl-module-tp4104605p4104688.html Sent from the Dev mailing list archive at Nabble.com. ___ Libr

Re: Searching help to build LibreOffice

Hi, Here's the main page for developpers: https://wiki.documentfoundation.org/Development and for LO building on Linux: https://wiki.documentfoundation.org/Development/BuildingOnLinux Now which sources are you trying to build? (master, 4.2 branch, ...) Julien -- View this message in context:

What encoding is used?

Hello, The use of cppcheck-htmlreport to convert raw cppcheck reports errors to html fails for some files because of the encodings. Here's an example message: cppcheck/htmlreport/cppcheck-htmlreport", line 287, in content = input_file.read() File "/usr/lib/python2.7/codecs.py", line 296, in

Re: HarfBuzz performance problem

Hi, Just taking a look to Harfbuzz releases, I noticed there was a 0.9.27 version, current download.lst indicates 0.9.23 (see http://opengrok.libreoffice.org/xref/core/download.lst). Even if changelog indicates only micro optim, perhaps it could be interesting to give it a try. If it doesn't work,

Build fail on master

Hi, On pc Debian x86-64 with master sources updated today + make clean, I've got this: In file included from /home/julien/compile-libreoffice/libo/basic/source/runtime/methods1.cxx:41:0: /home/julien/compile-libreoffice/libo/basic/source/inc/runtime.hxx: In function ‘void SbRtl_CallByName(StarBASI

Äbout cpplint

Hi, I gave a try to cpplint (http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py) with some changes so it scan subdirectories. Except pure formatting warnings, it reports things like this: 1) ./drawinglayer/source/primitive2d/polygonprimitive2d.cxx:274: Consider using rand_r(...)

[SOLVED] Re: About cpplint

Thank you Stephan for your feedback, so let's drop it. Julien -- View this message in context: http://nabble.documentfoundation.org/About-cpplint-tp4105821p4106051.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing lis

Dead code in escherex.cxx (filter module)

Hello, Taking a look to this part: 4442 if ( nErrCode == ERRCODE_NONE ) 4443 { p_EscherBlibEntry->meBlibType = ( eGraphicType == GRAPHIC_BITMAP ) ? PNG : EMF; 4445 aStream.Seek( STREAM_SEEK_TO_END ); 4446

Questions about getCppuType

Hello, Seeing the number of times getCppuType is used, I've got several questions about this: - what's the use of it? It resembles at the first look to "typeid" but I suppose it's not this. - could there be an alternative? (eg a more "native"/straightforward C++ way)? - if it still must be used, c

Re: Questions about getCppuType

sberg wrote > ... > getCppuType is not without flaws though, and cppu::UnoType should be > used instead. > ... > What cast are you talking about? The one in the typical usage like > getCppuType((T*)0)? Sure, nothing keeps you from writing that as > getCppuType(static_cast(0)), or better ye

Re: Questions about getCppuType

I've begun to replace some parts and had this when I've changed this: else if ( pType == ::getCppuType((const sal_uInt16*)0) ) into this: else if ( pType == cppu::UnoType::get() ) : cd /home/julien/compile-libreoffice/libreoffice/sfx2 && make -j 4 -rs [build CXX] sfx2/source/toolbox/tbxitem.cxx [bu

About ANIMATIONMODE_VIEW in slideshow module

Hello, Just taking a look at slideshow module, I searched about ANIMATIONMODE_VIEW to understand the difference between it and ANIMATIONMODE_SHOW. Here is the result: - once in the enum - once in a test so it seems no var can have this value see http://opengrok.libreoffice.org/search?q=ANIMATIONMO

Cppcheck reports "Deallocation of an auto-variable results in undefined behaviour" in vcl part

Hello, Cppcheck reported this: [vcl/source/gdi/bitmap4.cxx:229]: (error) Deallocation of an auto-variable results in undefined behaviour 137 long(*pKoeff)[ 256 ] = new long[ 9 ][ 256 ]; ... 229 delete[] pKoeff; See http://opengrok.libreoffice.org/xref/core/vcl/s

[SOLVED] Re: About ANIMATIONMODE_VIEW in slideshow module

Thorsten Behrens wrote > Julien Nabet wrote: >> Ok to remove ANIMATIONMODE_VIEW or did I miss something? >> > Yep, looks fine to me. Thank you Thorsten for your feedback, I pushed the patch on master (see http://cgit.freedesktop.org/libreoffice/core/commit/?id=916cbd94d1c848bc69166915b96ff89ac380

About removing macros

Hello, I noticed the use of macros like "DECL_PROP1IMPL", "DECL_PROP0" (see http://opengrok.libreoffice.org/search?q=DECL_PROP1IMPL&project=core&defs=&refs=&path=&hist=). Does it worth it to remove them? More generally, what macros could/should be removed? Julien -- View this message in conte

About Svgreader

Hello, Reading bugtrackers about SVG, I noticed there were 2 locations with svgreader: - filter/source/svg/svgreader.cxx - svgio/source/svgreader (there's also svgio/source/svguno) There's no README for svgio/ and the README of filter isn't detailed. Someone to explain (perhaps update/add README

[SOLVED] Re: About Svgreader

Thank you Christina for your feedback, I used it for http://cgit.freedesktop.org/libreoffice/core/commit/?id=1cb924de8a6f03827ae34aa2d66137b6b5e34112 Julien -- View this message in context: http://nabble.documentfoundation.org/About-Svgreader-tp4107050p4107174.html Sent from the Dev mailing li

About "glyph fallback" message (vcl module)

Hello, On pc Debian x86-64 with master source updated yesterday, I've got this message on console when going to Options/Language Settings/Languages: warn:vcl:26860:1:vcl/generic/fontmanager/fontconfig.cxx:868: In glyph fallback throwing away the language property of en because the detected script

Question about debugging cppunit tests

Hello, I'm trying to run gdb on cppunit failing by following this: to rerun just this failed test without all others, run: make JunitTest_chart2_unoapi cd into the module dir to run the tests faster Or to do interactive debugging (non-Windows), run two shells with: make debugrun mak

[SOLVED] Re: Questions about getCppuType

sberg wrote > ... > With cppu::UnoType, instead use cppu::UnoUnsignedShortType and > cppu::UnoCharType as template arguments, respectively. (And do get rid > of the useless "const" in the template arguments.) Thank you Stephan for your feedback, I'll use these and remove const for all the repl

Re: [patch] [solved] build failure

Sorry Terrence, my fault here :-( Thanks to Kohei, I could fix these at the beginning of the morning (UTC+2) It could be useful to force building in C++98 or at least put an option in autogen.input. Julien -- View this message in context: http://nabble.documentfoundation.org/patch-solved-buil

Re: Questions about getCppuType

Thank you Stephan for these information. In fact, my primary goal was to clean this use of getCppuType because it was reported by cppcheck (when they were used in if/else if blocks) Then I wanted to remove all of them. The problem is there are 33 Opengrok pages of these and I don't know enough abo

Re: [Libreoffice] problem of master build cannot launch.

Yifan J wrote: > > Firstly, I found smoketest fails on the HEAD (with error > officeconnection.cxx:140), then I tried to launch soffice.bin in > solver/350 > manually, but soffice.bin crashes immedialy even before splash screen > appears. > I came back yesterday and made from scratch a new local

Re: [Libreoffice] Make dev-install without running smoketests

Lionel Elie Mamane wrote: > > On Wed, Aug 03, 2011 at 04:51:13PM +0100, Caolán McNamara wrote: > >> What are your configure options for me to see if I can replicate this ? >> Looks like evilness which should be fixed. > > I'm in a similar situation on master branch, but for me the smoketest > f

Re: [Libreoffice] SfxItemSet reimplementation (was: va_start without va_end)

Bjoern Michaelsen wrote: > > Hi Norbert, all, > > On Thu, 4 Aug 2011 20:47:43 -0500 > Norbert Thiebaud > wrote: > >> The va_end manpage, on linux says: >> "Each invocation of va_start() must be matched by a corresponding >> invocation of va_end() in the _same function_" >>

Re: [Libreoffice] va_start without va_end

I commited and pushed the first and second case. I let the third case for the moment. Julien. -- View this message in context: http://nabble.documentfoundation.org/va-start-without-va-end-tp3223648p3236981.html Sent from the Dev mailing list archive at Nabble.com. ___

Re: [Libreoffice] build error in tail_build

Cor Nouws wrote: > > ... > But hey, better then summing up more reasons: > what command(s) do I use to move to the new master? > ...___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreo

Re: [Libreoffice] http://libreoffice.boldandbusted.com/ cppcheck report jobs stalled

Excellent ! Even if I would have preferred a git version, it's great to see this report updated again. Cppcheck is a really good tool to detect problems. Julien. -- View this message in context: http://nabble.documentfoundation.org/http-libreoffice-boldandbusted-com-cppcheck-report-jobs-stalled-

[Libreoffice] Throwing exception in destructor

Hello, cppcheck has detected 1 Throwing exception in destructor" line 88 of core/bridges/test/java_uno/acquire/testacquire.cxx (sorry I mentionned 2 locations on IRC cause I forgot about the new git repo : it was in core and old ure repo) Could it be replaced by just a log (which function should b

Re: [Libreoffice] http://libreoffice.boldandbusted.com/ cppcheck report jobs stalled... no longer! :)

I noticed that cppcheck made its report on the old repositories too, is it possible to remove the cppcheck scan on these ? Julien. -- View this message in context: http://nabble.documentfoundation.org/http-libreoffice-boldandbusted-com-cppcheck-report-jobs-stalled-tp2745270p3244910.html Sent fro

Re: [Libreoffice] Throwing exception in destructor

Stephan Bergmann wrote: > > On Aug 10, 2011, at 11:22 PM, julien2412 wrote: > ... >> Could it be replaced by just a log (which function should be used for >> this >> kind of case ?) or something since a throw in destructor should be >> avoided ? > Given that

Re: [Libreoffice] [PUSHED] [PATCH] SAL_ALLOW_LINKOO_SYMLINKS, libreoffice-3-4 sal module with dbglevel=2: init test fails

Lionel Elie Mamane wrote: > > ... > You mean I can just run "build" in a module and > ./install/program/soffice will use it, without rerunning "make > dev-install"? Ah yes, it works, you just increased my productivity! > ... > Hello, Unless it has changed or I forget/misunderstand something but

Re: [Libreoffice] Rebuild LO

swagat sharma wrote: > > Hi, > > I have successfully built LibreOffice and also installed it.. by make > install. > > Now I have modified the source and want to rebuild it. I want to make the > whole build again. > I did 'make clean', > Then changed some configure options, but its not building

[Libreoffice] java LO part with Eclipse

Hello, I asked on the IRC but I had to leave so I certainly haven't let enough time to people to respond. I'd like to know if there's a wiki page or something which describes how to manage Java specific parts of LO in Eclipse. I found these 2 pages : - http://cedric.bosdonnat.free.fr/wordpress/?p=

Re: [Libreoffice] java LO part with Eclipse

Jenei Gábor wrote: > > Hello Julien, > > I had this problem less than a week ago, if you read Cédric's website > you should find there the right way. First you have to set LO's JVM > setting. you have to set to listen on a port for remote debugger(in the > example it was 8000) and you have to

Re: [Libreoffice-commits] core.git: use startsWith() instead of compareToAscii()

Lionel Elie Mamane wrote > Thanks Stephan, good catch! > > Short version: this was, and should remain, an equality test and not a > "string begins with, but can continue with anything" test. > ... Lionel, could this point explain these logs I had put in https://bugs.freedesktop.org/show_bug.cgi?i

About coverity 704144 (XSLTFilter)

Hello, Scan coverity detected this: Resource leak in object (CTOR_DTOR_LEAK)1. alloc_fn: Calling allocation function "osl_createCondition()". [show details] (see http://opengrok.libreoffice.org/xref/core/filter/source/xsltfilter/XSLTFilter.cxx#164) osl_createCondition in unx part calls a malloc f

About coverity 705665 (javaunohelper.cxx)

Hello, Scan coverity detected this: leaked_storage: Variable "lib" going out of scope leaks the storage it points to. line 236 (see http://opengrok.libreoffice.org/xref/core/javaunohelper/source/javaunohelper.cxx#236) I just thought adding osl_unloadModule(lib) just before line 235, so last line

Re: About coverity 705665 (javaunohelper.cxx)

The following discussion is interesting but shows that it's not a quick and/or easy fix for casual contributor like me. So I let the experts keep on about this and determine if there's something to change or not. Thank you for your feedback about this Michael, Tor and Matúš Julien -- View this

About coverity 705732 (svdundo.cxx from svx module)

Hello, Scan coverity reported this: leaked_storage: Variable "pText1" going out of scope leaks the storage it points to. See http://opengrok.libreoffice.org/xref/core/svx/source/svdraw/svdundo.cxx#1137 1137 void SdrUndoObjSetText::Redo() 1138 { 1139 // copy text for Undo, because the

Re: About coverity 705732 (svdundo.cxx from svx module)

Thorsten, Caolán, Following your respective feedback about this, thank you for this, I thought about "gerrit submitting" on master as it is since Caolán seems quite confident and it may allow an easier review. In general, in bug triaging, cppcheck and very recently scan coverity, my purpose is to

About coverity 705746 (pormulti.cxx from sw module)

Hello, Scan coverity detected this: 27. overwrite_var: Overwriting "pMarg" in "pMarg = new SwMarginPortion(0)" leaks the storage that "pMarg" points to (http://opengrok.libreoffice.org/xref/core/sw/source/core/text/pormulti.cxx#738) 738 if( nLeft || nRight ) 739 { 740

Re: About coverity 705746 (pormulti.cxx from sw module)

Noel Grandin wrote > I would guess that someone meant to move line 742 inside the first "if" > statement, but only did half the job. Hello Noël, Perhaps I'm too sleepy this morning but I don't see the interest to duplicate the "new" part. Any hint? Julien -- View this message in context: h

Re: About coverity 705746 (pormulti.cxx from sw module)

Oups, I was wrong , if they're not exclusive, "new" line is required for each block Sorry Noël and Riccardo for the noise. Can you push a patch about this and update coverity? If not, I'll do it but only during week-end because I won't have much time. Thank you for having very patiently answered t

Re: [RESOLVED] About coverity 705746 (pormulti.cxx from sw module)

Caolán McNamara wrote > Pushed the agreed fix (I agree too) and updated coverity. Thank you Caolán! One additional fix on LO and one coverity scan report less to deal :-) Julien -- View this message in context: http://nabble.documentfoundation.org/About-coverity-705746-pormulti-cxx-from-sw-mo

About coverity 738980 (ssfrm.cxx from sw module)

Hello, Scan coverity detected this: 22. pass_freed_arg: Passing freed pointer "pAnchoredObj" as an argument to function "SwSortedObjs::Remove(SwAnchoredObject &)". This problem appears twice in the file: 576 SwAnchoredObject* pAnchoredObj = (*pFrm->GetDrawObjs())[0]; 577

cppcheck: Variables reassigned before the old one has been used (vcl/kde4 part)

Hello, Cppcheck reported this: [KDESalFrame.cxx:301] -> [KDESalFrame.cxx:304]: (performance) Variable 'aMenuFore' is reassigned a value before the old one has been used. [KDESalFrame.cxx:302] -> [KDESalFrame.cxx:305]: (performance) Variable 'aMenuBack' is reassigned a value before the old one has

About coverity 988424 (svdfppt.cxx from filter module)

Hello, Scan coverity detected this: CID 988424 (#1 of 1): Logically dead code (DEADCODE)dead_error_line: Execution cannot reach this expression "nExtBuInd + nExtParaNibble < aStyleTextProp9->size()" inside statement "if (nExtParaNibble && nExtB...". Indeed, we have these lines: 5026 if (

Re: cppcheck: Variables reassigned before the old one has been used (vcl/kde4 part)

Hi Lubos, But which ones are the useless? QPalette::WindowText and QPalette::Window or QPalette::ButtonText and QPalette::Button Julien -- View this message in context: http://nabble.documentfoundation.org/cppcheck-Variables-reassigned-before-the-old-one-has-been-used-vcl-kde4-part-tp4044235p

Re: cppcheck: Variables reassigned before the old one has been used (vcl/kde4 part)

All of the sudden my 2 neurons connected :-) I pushed the patch on master. See http://cgit.freedesktop.org/libreoffice/core/commit/?id=91c8b357ee2a27e50da0e99386e53d351e55cfda Thank you Lubos! Julien -- View this message in context: http://nabble.documentfoundation.org/cppcheck-Variables-rea

[SOLVED] Re: cppcheck: Variables reassigned before the old one has been used (vcl/kde4 part)

grr, forgot to mark this as "solved". -- View this message in context: http://nabble.documentfoundation.org/cppcheck-Variables-reassigned-before-the-old-one-has-been-used-vcl-kde4-part-tp4044235p4044604.html Sent from the Dev mailing list archive at Nabble.com. _

About coverity 440107 (keyimpl.cxx in registry)

Hello, Scan coverity reported this: dead_error_begin: Execution cannot reach this statement "case 5:" dead_error_begin: Execution cannot reach this statement "case 6:" dead_error_begin: Execution cannot reach this statement "case 7:" See http://opengrok.libreoffice.org/xref/core/registry/source/k

Re: About coverity 440107 (keyimpl.cxx in registry)

Thank you Stephan for your feedback. If I remove these cases in the switch, I've got this: /home/julien/compile-libreoffice/libo/registry/source/keyimpl.cxx: In member function ‘RegError ORegKey::getValue(const rtl::OUString&, RegValue) const’: /home/julien/compile-libreoffice/libo/registry/source

[PATCH for 3.6] Lacking "/" with .icedove prevents to use Icedove addressbook

Hello, Reading https://bugs.freedesktop.org/show_bug.cgi?id=57419, I found there was a missing "/" at the end of ".icedove" in connectivity/source/drivers/mork/MNSFolders.cxx, line 88 It's my fault (see http://cgit.freedesktop.org/libreoffice/core/commit/?id=8d7e1a6e13008bd7d35896e676796196038f1

About numbertext

Hello, By trying to reproduce an fdo, I got a lot of these on console: Python exception: : inconsistent use of tabs and spaces in indentation (__init__.py, line 70), traceback follows /home/julien/compile-libreoffice/libo/solver/unxlngx6/installation/opt/program/uno.py:265 in function _uno_impor

Build failure on master on mysqlc module

Hello, On pc Debian x86-64 with master sources updated today (commit 6858182d246f21c5b06af09d8ff0e6fd04ef26c3) and following a make clean, I've got this: Entering /home/julien/compile-libreoffice/libo/mysqlc/source Compiling: mysqlc/source/mysqlc_driver.cxx Compiling: mysqlc/source/mysqlc_servic

Re: Build failure on master on mysqlc module

Lubos Lunak wrote >> Entering /home/julien/compile-libreoffice/libo/mysqlc/source > ... >> /home/julien/compile-libreoffice/libo/mysqlc/source/mysqlc_services.cxx:20: >> /home/julien/compile-libreoffice/libo/solver/unxlngx6/inc/rtl/stringutils.h >>xx:34:27: fatal error: config_global.h: No such fil

Re: intending to join as a developer

Hello, Welcome here! You must know that the main language of LO is C++. These are used too: C, Python, Java (even assembly). SCM is Git and Gerrit is used too. If you want to contribute as a dev, the first thing is to build from sources by following this: http://wiki.documentfoundation.org/Develo

[REVIEW for 4.0] Missing breaks in connectivity/source/drivers/odbcbase/OTools.cxx

Hello, Could someone check commit 44b0bf91df1af9920b1c22a2f54bd70c9c44231b for cherry-picking in 4.0? --- connectivity/source/drivers/odbcbase/OTools.cxx --- index a868b0b..290aa61 100644 @@ -682,8 +682,10 @@ SQLSMALLINT OTools::jdbcTypeToOdbc(sal_Int32 jdbcType) // O

Re: recent git master branch : crash instead of error popup

Hi Olivier, First, you must know that it's the dev mailing list here and not user mailing list. Dev mailing list is for discussing about patches, building process of LO, etc. About the bug, you didn't quote info like Java version, platform for example. Moreover, try to be a little more precise a

Question about sc/source/core/data/colorscale.cxx

Hello, I noticed these lines in file sc/source/core/data/colorscale.cxx (because cppcheck report indicates that bNeedUpdate is reassigned before to be used line 641) 637 void ScDataBarFormat::DataChanged(const ScRange& rRange) 638 { 639 bool bNeedUpdate = false; 640 641

Question about sc/source/ui/view/cellsh.cxx

Hello, In sc/source/ui/view/cellsh.cxx, we have these lines: 150 case FID_FILL_TO_RIGHT: // fill to left / right 151 { 152 bDisable = !bSimpleArea || (nCol1 == 0 && nCol2 == 0); 153 bDisable = pDoc->HasSelectedBlockMatrixF

Question about vcl/source/window/builder.cxx

Hello, Keeping on with cppcheck, I found this on vcl/source/window/builder.cxx 1892 else if (sKey == "pack-type") 1893 { 1894 VclPackType ePackType = (sValue[0] == 'e' || sValue[0] == 'e') ? VCL_PACK_END : VCL_PACK_START; 1895 pCu

About fdo#58026, Localization problem for GoogleDocs extension

Hello, I opened fdo#58026 (https://bugs.freedesktop.org/show_bug.cgi?id=58026), so I'll just quote what I put. With Google docs extension 2a64b8e6f185a7f6c19d00fb8bb4cf64-gdocs_3.0.1_modified.oxt, and with English localization, one of the option isn't translated. In fact, the problem is just her

  1   2   3   4   5   6   7   8   9   10   >