Re: [Libreoffice] Kill Dtwm/CDE
So I removed this Property checks for various vendors with commit
http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=6b344d2654eb6a87f6e759376e7ee988f1a52761
If someone needs this back, feel free to do so (only jobset.{h,c}xx was
a mis-merge, sorry for that).
Thomas
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Kill Dtwm/CDE
On Fri, 2011-07-22 at 01:36 +0200, Thomas Arnhold wrote: > On 07/21/2011 09:49 PM, Francois Tigeot wrote: > > Why does LO tinker with window managers in the first place ? > > Maybe from times where you had to do so (various X servers and > implementations) and the idea of StarOffice as all-in-one desktop tool ;) The floating toolbar thingies are one example of a real curse to get working right with different window managers. We ended up poking at what the window manager is in a few places :-( I always wanted to move the odd bits into a libbrokenwm.so to isolate them off into one place with some test-cases to demo the issues to let blame get assigned correctly to them or us. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Kill Dtwm/CDE
On Thu, 2011-07-21 at 21:49 +0200, Francois Tigeot wrote: > Why does LO tinker with window managers in the first place ? It wants to get its way with them :-) so - eg. we do a lot of explicit window manager interactions that we should not really be doing - stacking our floating windows, forcing our position on the screen force flipping desktops etc. The flip side of that is that old window managers were probably not used to an app that wants our degree of consistency across platforms & user-experiences etc. so we had to hack around them. Consider the joys of manually positioning the table toolbar window with twm each time it pops up as you navigate through a document eg. ;-) It is of course good to dung out all these legacy hacks, and if someone screams and wants them back in in future, they can maintain it :-) ATB, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Kill Dtwm/CDE
On Fri, Jul 22, 2011 at 01:34:46AM +0200, Thomas Arnhold wrote: > So I let the enums untouched. It's all pushed to master. > > There is a strange vendor list at saldisp.cxx. I think some stuff is > very outdated, but I have no possibility to check it on Sun etc. > > http://opengrok.libreoffice.org/xref/libs-gui/vcl/unx/generic/app/saldisp.cxx#362 > > This vendor stuff is used to set some properties on X: > > http://opengrok.libreoffice.org/xref/libs-gui/vcl/unx/generic/app/saldisp.cxx#883 > > Comments like "Solaris 2.5.1" should say all ;) If someone has some > hardware to check a removal do it! I have already killed the XFree86 checks; I didn't take the time to investigate the other products/vendors yet. If you are sure some of them are no longer used these days, feel free to remove the associated code. -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Kill Dtwm/CDE
On 07/21/2011 09:49 PM, Francois Tigeot wrote: Why does LO tinker with window managers in the first place ? Maybe from times where you had to do so (various X servers and implementations) and the idea of StarOffice as all-in-one desktop tool ;) Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Kill Dtwm/CDE
So I let the enums untouched. It's all pushed to master. There is a strange vendor list at saldisp.cxx. I think some stuff is very outdated, but I have no possibility to check it on Sun etc. http://opengrok.libreoffice.org/xref/libs-gui/vcl/unx/generic/app/saldisp.cxx#362 This vendor stuff is used to set some properties on X: http://opengrok.libreoffice.org/xref/libs-gui/vcl/unx/generic/app/saldisp.cxx#883 Comments like "Solaris 2.5.1" should say all ;) If someone has some hardware to check a removal do it! Thomas On 07/21/2011 11:02 AM, Tor Lillqvist wrote: I noticed you removed the "dtwm" from an enum in saldisp.hxx, are you sure that enum is not part of our stable API/ABI? If it isn't, then you presumably can remove "vuewm" from the enum, too, wasn't VUE some even older HP-UX-specific window manager and/or desktop environment? (I should know; I used HP-UX machines back then... but I have forgotten;) And "FourDwm" (SGI's 4DWM) and "olwm" (the OpenLook WM) (and their uses)...? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Kill Dtwm/CDE
On Thu, Jul 21, 2011 at 03:02:09AM -0600, Tor Lillqvist wrote: > I noticed you removed the "dtwm" from an enum in saldisp.hxx, are you sure > that enum is not part of our stable API/ABI? > > If it isn't, then you presumably can remove "vuewm" from the enum, too, > wasn't VUE some even older HP-UX-specific window manager and/or desktop > environment? (I should know; I used HP-UX machines back then... but I have > forgotten;) > > And "FourDwm" (SGI's 4DWM) and "olwm" (the OpenLook WM) (and their uses)...? The Irix bits have been removed from the tree and last time I saw olwm it was on a version of Slackware from the 1990s. Both can be killed IMHO. Why does LO tinker with window managers in the first place ? -- Francois Tigeot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Kill Dtwm/CDE
On Thu, 2011-07-21 at 03:02 -0600, Tor Lillqvist wrote: > I noticed you removed the "dtwm" from an enum in saldisp.hxx, are you > sure that enum is not part of our stable API/ABI? Its not, the only things you can link to that form the public abi are the libs in ure/lib whose headers are in the sdk, its a really small set actually. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Kill Dtwm/CDE
> So maybe I let the enums untouched and only remove the uses of dtwm, > olwm, fourdwm and vuewm. Would this be ok? Sounds good to me, yes. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Kill Dtwm/CDE
Here is the output of PrintInfo(): Environment $XENVIRONMENT "" $DISPLAY":0.0" $SAL_VISUAL "" $SAL_FONTPATH "" $SAL_NOSEGV "" $SAL_IGNOREXERRORS "" $SAL_PROPERTIES "" $SAL_WM "" $SAL_SYNCHRONIZE"" Client Host"acer" Display Host":0.0" Vendor (Release)"The X.Org Foundation (11003000)" Protocol11.0 Screen (count,def) 0 (1,0) shift ctrl alt Shift_L (0xFFE1) Control_L (0xFFE3) Alt_L (0xFFE9) XMaxRequestSize 262140 16777212 [bytes] Properties 0x1000FCB Windowmanager 0 WMName Mutter Screen Resolution/Size 96*96 1366*768 16.3" Black&White 0 65535 RGB 0xf800 0x7e0 0x1f Visual 16-bit TrueColor ID=0x21 Thomas On 07/21/2011 11:02 AM, Tor Lillqvist wrote: I noticed you removed the "dtwm" from an enum in saldisp.hxx, are you sure that enum is not part of our stable API/ABI? If it isn't, then you presumably can remove "vuewm" from the enum, too, wasn't VUE some even older HP-UX-specific window manager and/or desktop environment? (I should know; I used HP-UX machines back then... but I have forgotten;) And "FourDwm" (SGI's 4DWM) and "olwm" (the OpenLook WM) (and their uses)...? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Kill Dtwm/CDE
I'm not really sure. I could bring those enum values back. This enum is only used once at: http://opengrok.libreoffice.org/xref/libs-gui/vcl/unx/generic/app/saldisp.cxx#871 Strangely SAL_WM is empty on my PC (gnome). So maybe I let the enums untouched and only remove the uses of dtwm, olwm, fourdwm and vuewm. Would this be ok? Thomas On 07/21/2011 11:02 AM, Tor Lillqvist wrote: I noticed you removed the "dtwm" from an enum in saldisp.hxx, are you sure that enum is not part of our stable API/ABI? If it isn't, then you presumably can remove "vuewm" from the enum, too, wasn't VUE some even older HP-UX-specific window manager and/or desktop environment? (I should know; I used HP-UX machines back then... but I have forgotten;) And "FourDwm" (SGI's 4DWM) and "olwm" (the OpenLook WM) (and their uses)...? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Kill Dtwm/CDE
I noticed you removed the "dtwm" from an enum in saldisp.hxx, are you sure that enum is not part of our stable API/ABI? If it isn't, then you presumably can remove "vuewm" from the enum, too, wasn't VUE some even older HP-UX-specific window manager and/or desktop environment? (I should know; I used HP-UX machines back then... but I have forgotten;) And "FourDwm" (SGI's 4DWM) and "olwm" (the OpenLook WM) (and their uses)...? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
