Re: fdo#41572 Making it possible to add custom animation to master slides

2013-05-24 Thread Janit Anjaria
Hey! This seems to be a long awaited question i have been having in mind. As Tor mentioned the name i dont think is a big deal for the header here,but what i think is i need to understand the thing i asked earlier ,regarding the matter at Line #148 . So it would be great if someone can help me out

Re: fdo#41572 Making it possible to add custom animation to master slides

2013-05-14 Thread Tor Lillqvist
If you just would have made it so in your patches from the start that your code is at least compiled (and thus by necessity free from syntax and language errors), it would have been easier to understand that it is a work in progress. Sure, of course it should be OK to submit work on a bigger task

Re: fdo#41572 Making it possible to add custom animation to master slides

2013-05-14 Thread Janit Anjaria
Hey Tor! It is good to know that even you have been taking interest in this pretty important task which i have been working on. -- Regarding the compiling of the code , i bet i did compile it on my machine as well,but as you said you have been getting some errors i would be happy to look back

Re: fdo#41572 Making it possible to add custom animation to master slides

2013-05-14 Thread Tor Lillqvist
By the way, I now notice that this bug is not listen as an Easy Hack, but is an actual GSoC task? So no wonder it is a lot of work and you are just in the very early beginning of it;) There seems to be some misunderstanding here... the intent is that GSoC applicants do a relatively limited (but

Re: fdo#41572 Making it possible to add custom animation to master slides

2013-05-14 Thread Janit Anjaria
Hey Tor! Yeah you got that right. It is actually a GSoC Task and i know it is a little early but Thorsten thinks starting a little early would surely help because this feature is something we dont want to compromise and more the time,better it is ( so we can always keep enhancing and that is why

Re: fdo#41572 Making it possible to add custom animation to master slides

2013-05-14 Thread Thorsten Behrens
Janit Anjaria wrote: It is actually a GSoC Task and i know it is a little early but Thorsten thinks starting a little early would surely help because this feature is something we dont want to compromise and more the time,better it is... Hi Janit, all, just to make one thing very clear - GSoC

Re: fdo#41572 Making it possible to add custom animation to master slides

2013-05-14 Thread Janit Anjaria
Hey Thorsten!!! I obviously know that my work is solely based on self-interestit was just a way to answer Tor,and hence I am sure you know the way we have been working out this project since some time :) . This email is basically intended to let you know the progress of my work for the

Re: fdo#41572 Making it possible to add custom animation to master slides

2013-05-12 Thread Janit Anjaria
Hey! I am hereby attaching my patch which is a work in progress. Thorsten : Check out *Line number 148* in sd/source/core/sdtool.cxx where i have mentioned(i.e. in the form of comment) the query i have in mind ,and the question i had asked you on IRC. I hope the surrounding code would make things

Re: fdo#41572 Making it possible to add custom animation to master slides

2013-05-08 Thread Janit Anjaria
Hey Miklos! I suppose i have used the correct header now ,and regarding the identation i dont think there is any need of it here as the header file just declares the functions used.I have made all the changes to the way the comments have to be used and i am sure this learning process is going to

Re: fdo#41572 Making it possible to add custom animation to master slides

2013-05-07 Thread Janit Anjaria
Hey ! I am hereby attaching a patch for the same fdo#41572 and have made the changes according Thorsten's advise and i am sure the comments would help out in the understanding of what this header file will do. :) Any further help and guidance would surely be helpful and great (in terms of the

Re: fdo#41572 Making it possible to add custom animation to master slides

2013-05-07 Thread Miklos Vajna
Hi Janit, On Tue, May 07, 2013 at 10:55:53AM +0530, Janit Anjaria jani...@gmail.com wrote: +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the

Re: fdo#41572 Making it possible to add custom animation to master slides

2013-05-06 Thread Thorsten Behrens
Janit Anjaria wrote: it would be great if someone can guide if i am going swrong somewhere. Hi Janit, a bit hard to tell without further explanations to the intended use of the code. A few comments in the header would already go a long way. Also, I suggest to make it a habit for new files to