Re: gtk3, wayland, opengl, glew and epoxy

[Tor Lillqvist]

>
> So https://gerrit.libreoffice.org/#/c/31465/ is the patch to move
> libgltf from glew to libepoxy. If we can get that in first, then we can
> require libgltf >= 0.1.0 rather than 0.0.0 to head off system-libgltf
> incompatibilities
>

Or, we could, dare I say it, conclude that this gltf and collada stuff was
a fun demo but nobody is really interested any more and drop it, *before*
somebody actually starts using it and we need to "support" it?

TOTALLY just my PERSONAL opinion. On a FRIDAY, no less.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: gtk3, wayland, opengl, glew and epoxy

[Caolán McNamara]

On Tue, 2016-11-29 at 14:48 +0100, Markus Mohrhard wrote:
> Sadly I don't recall why I chose glew instead of libepoxy back then.
> However looking at it now it seems like libepoxy is the smarter
> choice as long as it works correctly on Mac.
> 
> For gltf as we control the code we can of course also switch from
> glew to libepoxy.

So https://gerrit.libreoffice.org/#/c/31465/ is the patch to move
libgltf from glew to libepoxy. If we can get that in first, then we can
require libgltf >= 0.1.0 rather than 0.0.0 to head off system-libgltf
incompatibilities

C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: gtk3, wayland, opengl, glew and epoxy

[Michael Meeks]

Hi Caolan,

On 29/11/16 12:20, Caolán McNamara wrote:
> locally I have our opengl slideshow transitions working[1] under gtk3
> on wayland and I'd like to merge this to master.

Nice work =)

> Is there any objection to the principle of dropping glew in favour of
> epoxy, or do I need to go down a more complicated conditional approach.

I think quite the opposite; from what I recall in contrast to glew
libepoxy is a full de-coupling of the OGL-ness on all platforms; ie. it
is not necessary to link libGL-ness into any of our binaries.

That is great news for removing much of:

commit 96c1ae1d8e78ae8b9bd7d4001645cad24d62b720
Author: Oliver Specht 
Date:   Wed Mar 23 13:40:13 2016 +0100

fix headless build

disables OpenGL and glew usage, lets --without-gui do what
--without-x did before and disables X related test


Into cleaner run-time checks; and removing that whole conditional
compilation thing for GL - which would be a nice cleanup.

Good stuff,

Michael.

-- 
michael.me...@collabora.com <><, Pseudo Engineer, itinerant idiot
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: gtk3, wayland, opengl, glew and epoxy

[Tomaž Vajngerl]

Hi,

On Tue, Nov 29, 2016 at 1:20 PM, Caolán McNamara  wrote:
> locally I have our opengl slideshow transitions working[1] under gtk3
> on wayland and I'd like to merge this to master. The gtk3 part is
> fairly trivial as it turns out. But glew doesn't work under wayland.
> epoxy does however (and it's what gtk3 itself uses). epoxy claims to
> support all of our platforms. One little snag is that libgltf uses glew
> in its headers, so I had to patch it to port it over to epoxy.
>
> Is there any objection to the principle of dropping glew in favour of
> epoxy, or do I need to go down a more complicated conditional approach.
> Or any other snags I haven't considered ?
>
> C.
>
> [1] well some of them anyway

I don't have objections and I can help with testing the VCL OpenGL code.

Regards, Tomaž
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: gtk3, wayland, opengl, glew and epoxy

[Markus Mohrhard]

Hey,

On Tue, Nov 29, 2016 at 1:20 PM, Caolán McNamara  wrote:

> locally I have our opengl slideshow transitions working[1] under gtk3
> on wayland and I'd like to merge this to master. The gtk3 part is
> fairly trivial as it turns out. But glew doesn't work under wayland.
> epoxy does however (and it's what gtk3 itself uses). epoxy claims to
> support all of our platforms. One little snag is that libgltf uses glew
> in its headers, so I had to patch it to port it over to epoxy.
>
> Is there any objection to the principle of dropping glew in favour of
> epoxy, or do I need to go down a more complicated conditional approach.
> Or any other snags I haven't considered ?
>
>

Sadly I don't recall why I chose glew instead of libepoxy back then.
However looking at it now it seems like libepoxy is the smarter choice as
long as it works correctly on Mac.

For gltf as we control the code we can of course also switch from glew to
libepoxy. I would need to check what collada2gltf is using.

One thing to check is whether our windows code suffers from
https://github.com/anholt/libepoxy#windows-issues as well as actually
testing all the OpenGL features on all 3 platforms. Based on experience
working OpenGL code on one system does not mean that it is not going to
break somewhere else. As this change affects all the OpenGL code in our
codebase this requires testing at least the OGL transitions, chart OGL (if
it is still working in master), 3D models in impress (if they are still
working), OGL canvas and the normal OpenGL rendering.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

gtk3, wayland, opengl, glew and epoxy

[Caolán McNamara]

locally I have our opengl slideshow transitions working[1] under gtk3
on wayland and I'd like to merge this to master. The gtk3 part is
fairly trivial as it turns out. But glew doesn't work under wayland.
epoxy does however (and it's what gtk3 itself uses). epoxy claims to
support all of our platforms. One little snag is that libgltf uses glew
in its headers, so I had to patch it to port it over to epoxy.

Is there any objection to the principle of dropping glew in favour of
epoxy, or do I need to go down a more complicated conditional approach.
Or any other snags I haven't considered ?

C.

[1] well some of them anyway
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice