Hi,
Sorry I did not follow the thread for a while. That's perfectly ok. If
we can have the list thing with the option SSH_BIND_OPTIONS_HOSTKEY that
would be nice to have too :)
Aris
Le 5/03/14 20:58, Andreas Schneider a écrit :
> On Wednesday 05 March 2014 11:30:06 Alan Dunn wrote:
>> One more t
On Wednesday 05 March 2014 11:30:06 Alan Dunn wrote:
> One more thought here while I'm thinking about it:
>
> It did sound like Aris at least agreed to me adding
> SSH_BIND_OPTIONS_ECDSAKEY, so I think we could make forward progress
> by adding that option, which allows the testing of my other pat
One more thought here while I'm thinking about it:
It did sound like Aris at least agreed to me adding
SSH_BIND_OPTIONS_ECDSAKEY, so I think we could make forward progress
by adding that option, which allows the testing of my other patches,
and adding whatever other option when we all come to agre
On Wednesday 26 February 2014 05:28:00 Alan Dunn wrote:
> Aris/Andreas:
Hi,
> I thought I'd say if there's anything I can do to make it easier for
> you to evaluate my ECDSA host key patches (e.g. I could reformat the
> work as a patch set that has the bug fixes, the changes to add ECDSA
> as an
Aris/Andreas:
I thought I'd say if there's anything I can do to make it easier for
you to evaluate my ECDSA host key patches (e.g. I could reformat the
work as a patch set that has the bug fixes, the changes to add ECDSA
as an option for binds, and the option to use ECDSA keys in one of the
libssh
On Wednesday 26 February 2014 02:29:32 Dustin Oprea wrote:
> On Wed, Feb 26, 2014 at 2:22 AM, Andreas Schneider
wrote:
> > On Tuesday 25 February 2014 22:19:49 Dustin Oprea wrote:
> > > Alan/Andreas:
> > Hi Dustin,
> >
> > > I'm guessing that the value assigned to ssh_key_struct.type
> > > (ssh_k
On Wed, Feb 26, 2014 at 2:22 AM, Andreas Schneider wrote:
> On Tuesday 25 February 2014 22:19:49 Dustin Oprea wrote:
> > Alan/Andreas:
>
> Hi Dustin,
>
> > I'm guessing that the value assigned to ssh_key_struct.type
> > (ssh_keytypes_e) comes directly from the client. Is this true?
>
> no, It is a
On Tuesday 25 February 2014 22:19:49 Dustin Oprea wrote:
> Alan/Andreas:
Hi Dustin,
> I'm guessing that the value assigned to ssh_key_struct.type
> (ssh_keytypes_e) comes directly from the client. Is this true?
no, It is a string. :)
http://git.libssh.org/projects/libssh.git/tree/src/pki.c#n85
Alan/Andreas:
I'm guessing that the value assigned to ssh_key_struct.type
(ssh_keytypes_e) comes directly from the client. Is this true?
If so, the ssh_keytypes_e enum is incorrectly defined.
The definition in libssh is:
enum ssh_keytypes_e{
SSH_KEYTYPE_UNKNOWN=0,
SSH_KEYTYPE_DSS=1,
SSH_K
These issues are just the way Andreas wanted me to report the problems
I found. The patches contained in those issues are just the original
patch in this thread broken into two smaller patches. So it's
perfectly fine to just apply the initial patch in this thread for
testing (though you'll need t
On Feb 17, 2014 11:10 AM, "Alan Dunn" wrote:
>
> Done:
>
> https://red.libssh.org/issues/147
> https://red.libssh.org/issues/148
>
> Thanks,
> - Alan
>
Do the issues have to be fixed prior to trying your patch out, or does your
patch account for them?
Dustin
Done:
https://red.libssh.org/issues/147
https://red.libssh.org/issues/148
Thanks,
- Alan
On Sun, Feb 16, 2014 at 11:08 AM, Andreas Schneider wrote:
> On Saturday 15 February 2014 13:17:30 Alan Dunn wrote:
>> Hi folks,
>
> Hi,
>
> thanks for fixing this.
>
>> There were two issues:
>> - ecdsa_ni
On Saturday 15 February 2014 13:17:30 Alan Dunn wrote:
> Hi folks,
Hi,
thanks for fixing this.
> There were two issues:
> - ecdsa_nid was not copied to duplicated ECDSA private keys
> - SHA-2 hashing was not used for sessionid generation for ECDSA keys
> (instead SHA-1 was being used)
could you
Hi Aris,
On Sat, Feb 15, 2014 at 1:52 PM, Aris Adamantiadis wrote:
> Hi Alan,
>
> Thanks for your patch. I did not review your patch but there's already
> something that needs change. You use EVP_* functions in pki.c which is
> supposed to be crypto backend independant. I think your code will not
Hi Alan,
Thanks for your patch. I did not review your patch but there's already
something that needs change. You use EVP_* functions in pki.c which is
supposed to be crypto backend independant. I think your code will not
compile on libgcrypt builds.
On your last question if we should add the opti
With this patch and my prior, and minor changes to samplesshd to use
ECDSA keys (which I have not yet submitted), samplesshd can use ECDSA
keys successfully in my environment.
On Sat, Feb 15, 2014 at 1:25 PM, Dustin Oprea wrote:
> The host-keys and authentication now work, in your environment?
>
The host-keys and authentication now work, in your environment?
Dustin
On Feb 15, 2014 2:17 PM, "Alan Dunn" wrote:
> Hi folks,
>
> After our previous discussion on the inability to enable ECDSA keys, I
> found some bugs in how they are actually used in libssh (even if one
> were able to enable t
Hi folks,
After our previous discussion on the inability to enable ECDSA keys, I
found some bugs in how they are actually used in libssh (even if one
were able to enable them). With these changes, and some version of
changes to allow ECDSA host keys to be enabled (I used my prior patch
for testin
18 matches
Mail list logo
