Re: [libssh2] Wrap up a release!

2009-03-26 Thread Daniel Stenberg
On Thu, 26 Mar 2009, Borey wrote: > Seems that release date is moving. When we can expect 1.1 ? I already mentioned this: http://daniel.haxx.se/projects/libssh2/mail/libssh2-devel-archive-2009-03/0069.shtml But I can't promise anything. It depends on how much sleep I can skip, and how my block

Re: [libssh2] Wrap up a release!

2009-03-26 Thread Borey
Hi Daniel. Seems that release date is moving. When we can expect 1.1 ? Thanks and regards. 2009/3/17 Daniel Stenberg > Hey > > This is just a note that I plan to put together a libssh2 1.1 release in > exactly week. I aim at March 24th for release day, but if something pops up > I > can move i

Re: [libssh2] Wrap up a release!

2009-03-22 Thread Daniel Stenberg
On Tue, 17 Mar 2009, Daniel Stenberg wrote: > And yeah, whatever you want in the release (or not), now is a good time to > speak up! Okay, so I'd like to get Heiner Steven's problems with non-blocking use properly researched and hopefully fixed first, to feel sufficiently sure that libssh2 doe

Re: [libssh2] Wrap up a release!

2009-03-21 Thread Eric Sproul
Mikhail Gusarov wrote: > Twas brillig at 17:24:34 21.03.2009 UTC-04 when e...@nanobyte.org did gyre > and gimble: > > ES> From a quick read of this excerpt from "C in a Nutshell" > > Erm. Not quite a respectable source. Please provide another one: C99, > POSIX, SUS - nearly anything will be ok.

Re: [libssh2] Wrap up a release!

2009-03-21 Thread Mikhail Gusarov
Twas brillig at 17:24:34 21.03.2009 UTC-04 when e...@nanobyte.org did gyre and gimble: ES> From a quick read of this excerpt from "C in a Nutshell" Erm. Not quite a respectable source. Please provide another one: C99, POSIX, SUS - nearly anything will be ok. ES> The attached patch against th

Re: [libssh2] Wrap up a release!

2009-03-21 Thread Eric Sproul
Daniel Stenberg wrote: On Tue, 17 Mar 2009, Dan Fandrich wrote: In the spirit of being pedantic, names beginning with a single underscore are supposed to be reserved for the OS and libraries. Although, since libssh2 is a library that ships with lots of Linux-derived OSes, it could probably fa

Re: [libssh2] Wrap up a release!

2009-03-18 Thread Daniel Stenberg
On Tue, 17 Mar 2009, Dan Fandrich wrote: > In the spirit of being pedantic, names beginning with a single underscore > are supposed to be reserved for the OS and libraries. Although, since > libssh2 is a library that ships with lots of Linux-derived OSes, it could > probably fall under that loo

Re: [libssh2] Wrap up a release!

2009-03-17 Thread Dan Fandrich
On Tue, Mar 17, 2009 at 02:55:28PM +0100, Daniel Stenberg wrote: > In the same spirit, I've just run over a lot of functions in libssh2 and > renamed them to use the _libssh2_ prefix properly for library-wide internal > functions, as only the ones using libssh2_ are meant to be externally present

Re: [libssh2] Wrap up a release!

2009-03-17 Thread E L
> > Should we perhaps make a local wrapper for send() and recv() so that we could > put this logic only at a single spot? >> > Like into _libssh2_recv() and _libssh2_send() functions that sets errno? I like that idea. --

Re: [libssh2] Wrap up a release!

2009-03-17 Thread Daniel Stenberg
On Tue, 17 Mar 2009, E L wrote: > The past thread got sidetracked, so forgot about it. Is the bug clear? > libssh2 uses errno, but win32 recv() and send() do not set errno, so libssh2 > code needs to set errno based on WSAGetLastError() after calling send() or > recv(). Should we perhaps make

Re: [libssh2] Wrap up a release!

2009-03-17 Thread E L
> >> Socket errors are not properly handled for win32.  If the call to recv() or >> send() fails, then WSAGetLastError() needs to be called to get the error. >> In two spots this is mostly done: session.c:116 and transport.c:370. >> However, not all errors are covered in the switch and there is no

Re: [libssh2] Wrap up a release!

2009-03-17 Thread Daniel Stenberg
On Tue, 17 Mar 2009, E L wrote: > Socket errors are not properly handled for win32. If the call to recv() or > send() fails, then WSAGetLastError() needs to be called to get the error. > In two spots this is mostly done: session.c:116 and transport.c:370. > However, not all errors are covered

Re: [libssh2] Wrap up a release!

2009-03-17 Thread Daniel Stenberg
On Tue, 17 Mar 2009, Daniel Stenberg wrote: >> I believe the patch is good, and it has been tested in Debian by Mikhail. >> Ok to commit? > > Sure, go ahead! In the same spirit, I've just run over a lot of functions in libssh2 and renamed them to use the _libssh2_ prefix properly for library-wi

Re: [libssh2] Wrap up a release!

2009-03-17 Thread E L
> And yeah, whatever you want in the release (or not), now is a good time to > speak up! I mentioned this before, here: http://sourceforge.net/mailarchive/forum.php?thread_name=20080929190548.5551c6db%40gideon&forum_name=libssh2-devel Socket errors are not properly handled for win32. If the cal

Re: [libssh2] Wrap up a release!

2009-03-17 Thread Peter Stuge
Daniel Stenberg wrote: > I wrote up a blog entry It sounds like SFTP builds on SCP at one point in that post. I would like to clarify that that is not the case, however it is of course correct that SFTP adds another layer of protocol on top of the channels used by SCP. (This because SCP is just a

Re: [libssh2] Wrap up a release!

2009-03-17 Thread Daniel Stenberg
On Tue, 17 Mar 2009, Simon Josefsson wrote: > http://sourceforge.net/mailarchive/forum.php?thread_name=87ab8mnkya.fsf%40vertex.dottedmag.net&forum_name=libssh2-devel > > I believe the patch is good, and it has been tested in Debian by Mikhail. > Ok to commit? Sure, go ahead! -- / daniel.hax

Re: [libssh2] Wrap up a release!

2009-03-17 Thread Mikhail Gusarov
Twas brillig at 11:02:43 17.03.2009 UTC+01 when si...@josefsson.org did gyre and gimble: SJ> How about reducing the number of exported symbols? SJ> Ok to commit? ack -- pgpGcrvxNFLIU.pgp Description: PGP signature --

Re: [libssh2] Wrap up a release!

2009-03-17 Thread Simon Josefsson
Daniel Stenberg writes: > Hey > > This is just a note that I plan to put together a libssh2 1.1 release in > exactly week. I aim at March 24th for release day, but if something pops up I > can move it a bit. > > I also won't commit any feature changes or anything before the release, but > I'll

[libssh2] Wrap up a release!

2009-03-17 Thread Daniel Stenberg
Hey This is just a note that I plan to put together a libssh2 1.1 release in exactly week. I aim at March 24th for release day, but if something pops up I can move it a bit. I also won't commit any feature changes or anything before the release, but I'll be more than happy to work on bugs if y