Re: cwrapper generates long strings.

2010-10-04 Thread Ralf Wildenhues
* Peter Rosin wrote on Sun, Oct 03, 2010 at 08:28:47PM CEST: Den 2010-10-03 09:01 skrev Ralf Wildenhues: +for i in 25 50 75 100 125 150 175 200 225 250 +do + PATH=$PATH$PATH_SEPARATOR/somewhere-that-eksists-not Does $LIBTOOL or the autotest machinery ever intentionally try to run

Re: cwrapper generates long strings.

2010-10-04 Thread Peter Rosin
Den 2010-10-04 07:00 skrev Ralf Wildenhues: * Peter Rosin wrote on Sun, Oct 03, 2010 at 08:28:47PM CEST: Den 2010-10-03 09:01 skrev Ralf Wildenhues: +for i in 25 50 75 100 125 150 175 200 225 250 +do + PATH=$PATH$PATH_SEPARATOR/somewhere-that-eksists-not Does $LIBTOOL or the autotest

Re: [PATCH] msvc: handle symbols from different files independently.

2010-10-04 Thread Peter Rosin
Den 2010-10-04 13:25 skrev Peter Rosin: +AT_CHECK([eval cat dumpbin-output | $global_symbol_pipe], [], [stdout]) Oops, forgot one nit, I'm going with +AT_CHECK([ dumpbin-output eval $global_symbol_pipe], [], [stdout]) instead. Cheers, Peter

Re: [PATCH] msvc: handle symbols from different files independently.

2010-10-04 Thread Peter Rosin
Den 2010-10-02 08:40 skrev Ralf Wildenhues: Hi Peter, * Peter Rosin wrote on Fri, Oct 01, 2010 at 01:38:42PM CEST: Anyway, is this test case good enough? Should I find a better way to skip on non-dumpbin runs? How? Skip if $NM != $DUMPBIN? But then you'd need to ensure DUMPBIN is set.

Re: [PATCH] Add test case for 69e77671 (cwrapper PATH manipulation order)

2010-10-04 Thread Ralf Wildenhues
Hi Charles, * libt...@cwilson.fastmail.fm wrote on Sun, Oct 03, 2010 at 11:15:17PM CEST: * tests/cwrapper.at: Add new test 'cwrapper and installed shared libraries.' OK with nits addressed. You may want to use a ChangeLog and/or --author entry that suitably documents the main author of the

Re: cwrapper generates long strings.

2010-10-04 Thread Ralf Wildenhues
* Peter Rosin wrote on Mon, Oct 04, 2010 at 10:02:15AM CEST: I wrote a loop appending the first PATH component until the length exceeds the limit. The longest possible PATH should be 499 characters this way, which seems OK to me, and it should have no wild components. Cool. Den 2010-10-04

Re: [PATCH] msvc: handle symbols from different files independently.

2010-10-04 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Mon, Oct 04, 2010 at 01:25:42PM CEST: Den 2010-10-02 08:40 skrev Ralf Wildenhues: Skip if $NM != $DUMPBIN? But then you'd need to ensure DUMPBIN is set. It's a pest that you can have: DUMPBIN=link -dump NM=dumpbin -symbols or DUMPBIN=dumpbin

Re: [PATCH] msvc: handle symbols from different files independently.

2010-10-04 Thread Peter Rosin
Den 2010-10-04 20:07 skrev Ralf Wildenhues: Go! Pushed, thanks for reviewing! Cheers, Peter