Re: [PATCH] tests: import variables for MSVC.

2010-09-23 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Fri, Sep 24, 2010 at 12:25:14AM CEST: > Subject: [PATCH] tests: import variables for MSVC. > > * tests/depdemo/sysdep.h (EXTERN): New define, saying how to > declare variables that might need to be imported. > * tests/depdemo/l1/l1.h, tests/depdemo/l2/l2.h, > test

Re: [PATCH] msvc: don't try to export import descriptors.

2010-09-23 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Fri, Sep 24, 2010 at 12:39:13AM CEST: > With the patch posted with subject: [PATCH] tests: import variables for MSVC. > I found that libtool tries to put some bad symbols in the generated > symbol lookup table leading to errors such as this: > Ok to push? Yes, wi

Re: [PATCH] Skip need_lib_prefix.at on systems without lib prefix on libraries.

2010-09-23 Thread Ralf Wildenhues
Hello Peter, * Peter Rosin wrote on Fri, Sep 17, 2010 at 08:44:43AM CEST: > need_lib_prefix.at currently fails with MSVC. I think the test > is there to ensure that "weird" systems continue to work even > if the testsuite is running on a "normal" system. "weird" in > this case are systems with nee

Re: [PATCH v2 07/11] build: make better use of automatic variables in `Makefile.am'.

2010-09-23 Thread Ralf Wildenhues
Hi Gary, this isn't a review, I'm just adding a couple of hints that come to mind at first glance. * Gary V. Vaughan wrote on Thu, Sep 23, 2010 at 05:21:24PM CEST: > Rules are getting shorter and more readable again now. I'm assuming > there are no portability problems with "$@" and "$^" in regu

Re: [PATCH v2 06/11] build: name temporary files in `Makefile.am' consistently.

2010-09-23 Thread Ralf Wildenhues
Hi Gary, this isn't a full review, I'm just adding a couple of hints that come to mind at first glance. * Gary V. Vaughan wrote on Thu, Sep 23, 2010 at 05:21:23PM CEST: > This is another silly patch that ends up being mostly edited away > by the next couple of patches in the series... but I think

Re: [PATCH v2 02/11] maint: don't leak developer GREP, SED etc into distribution file.

2010-09-23 Thread Ralf Wildenhues
Hello Gary, * Gary V. Vaughan wrote on Thu, Sep 23, 2010 at 05:21:19PM CEST: > I've pared this down to the absolute minimum necessary to fix the > bug it is targetting. I did run this through `make distcheck' (and > it passed), but most of the others following only got a cursory > `git clean -x -

Re: [PATCH] relax -rpath argument test for Snow Leopard

2010-09-22 Thread Ralf Wildenhues
Hello, * Peter O'Gorman wrote on Thu, Sep 23, 2010 at 07:43:44AM CEST: > On 09/22/2010 09:00 PM, Leo Davis wrote: > >I had to patch libtool in order to get shared libraries to build with > >the Snow Leopard '@rpath/' syntax which stands in for the place where > >the lib gets installed. I thought

Re: [PATCH 3/4] maint: don't leak developer GREP, SED etc into distribution file.

2010-09-22 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Wed, Sep 22, 2010 at 07:05:50PM CEST: > This is the second part of the patch I've split since the last > time I posted. I added Joerg as reporter, and he is already > named in THANKS. > > Okay to push? With this patch applied, the generated libtool script sti

Re: [PATCH 4/4] maint: simplify and improve safety of bootstrap process.

2010-09-22 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Wed, Sep 22, 2010 at 07:05:51PM CEST: > I also posted this one before... this time rebased against > post-2.4 release HEAD. > > Okay to push? Assuming strongly that this patch depends upon the semantics of 3/4 applied, I will review this patch after 3/4 is fix

Re: [PATCH 1/r47] maint: help2man targets should rely on the binaries they call.

2010-09-22 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Wed, Sep 22, 2010 at 10:36:01PM CEST: > On 23 Sep 2010, at 01:22, Ralf Wildenhues wrote: > > * Eric Blake wrote on Wed, Sep 22, 2010 at 08:19:28PM CEST: > >> On 09/22/2010 12:13 PM, Ralf Wildenhues wrote: > >>>> Is it acceptable instead t

Re: [PATCH 1/r47] maint: help2man targets should rely on the binaries they call.

2010-09-22 Thread Ralf Wildenhues
Hello Gary, * Gary V. Vaughan wrote on Wed, Sep 22, 2010 at 10:29:44PM CEST: > On 23 Sep 2010, at 00:35, Ralf Wildenhues wrote: > > * Gary V. Vaughan wrote on Wed, Sep 22, 2010 at 07:05:48PM CEST: > >> * Makefile.am (doc/libtool.1, doc/libtoolize.1): Don't rely on >

Re: [PATCH 1/r47] maint: help2man targets should rely on the binaries they call.

2010-09-22 Thread Ralf Wildenhues
* Eric Blake wrote on Wed, Sep 22, 2010 at 08:30:08PM CEST: > On 09/22/2010 12:22 PM, Ralf Wildenhues wrote: > >* Eric Blake wrote on Wed, Sep 22, 2010 at 08:19:28PM CEST: > >> $(srcdir)/doc/libtool.1: $(srcdir)/$(auxdir)/ltmain.sh > >>+ $(MAKE) libtool > >

Re: [PATCH 2/4] maint: rearrange Makefile.am in preparation for a follow-up patch.

2010-09-22 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Wed, Sep 22, 2010 at 07:05:49PM CEST: > * Makefile.am (Libtool scripts.): Move this section below the > `Bootstrap.' section... > (libtoolize.in): ...except this one which is generated at > bootstrap time, and was added into the `Bootstrap.' section. > (Libltdl.

Re: [PATCH 1/r47] maint: help2man targets should rely on the binaries they call.

2010-09-22 Thread Ralf Wildenhues
* Eric Blake wrote on Wed, Sep 22, 2010 at 08:19:28PM CEST: > On 09/22/2010 12:13 PM, Ralf Wildenhues wrote: > >>Is it acceptable instead to use a nested $(MAKE) invocation prior to > >>running help2man to ensure the binary is up-to-date? > > > >Can you show a

Fix regression in command-line length computation.

2010-09-22 Thread Ralf Wildenhues
Oh brother, I just found another regression. :-( func_fallback_echo isn't even defined inside configure unless we haven't found a better $ECHO. We should be trying to fork&exec an external utility with the test string, so that we are actually testing the right limit. I'm pushing the fix below,

Re: [PATCH 1/r47] maint: help2man targets should rely on the binaries they call.

2010-09-22 Thread Ralf Wildenhues
Hi Eric, * Eric Blake wrote on Wed, Sep 22, 2010 at 07:37:58PM CEST: > On 09/22/2010 11:35 AM, Ralf Wildenhues wrote: > >* Gary V. Vaughan wrote on Wed, Sep 22, 2010 at 07:05:48PM CEST: > >>* Makefile.am (doc/libtool.1, doc/libtoolize.1): Don't rely on > >>the inte

Re: [PATCH 1/r47] maint: help2man targets should rely on the binaries they call.

2010-09-22 Thread Ralf Wildenhues
Hello Gary, * Gary V. Vaughan wrote on Wed, Sep 22, 2010 at 07:05:48PM CEST: > The start of my post-release patch queue... okay to push? > > * Makefile.am (doc/libtool.1, doc/libtoolize.1): Don't rely on > the intermediate files, since they might have changed without > giving make the opportunity

Re: [SCM] GNU Libtool branch, master, updated. v2.4-1-gf0ba93d

2010-09-22 Thread Ralf Wildenhues
Hello Gary, * Gary V. Vaughan wrote on Wed, Sep 22, 2010 at 06:27:27PM CEST: > * libltdl/Makefile.inc (LTDL_VERSION_INFO): We've added the > static libprefix interface, so new version-info is C+1:0:R+1. libprefix is a *static* local undocumented variable, not public API. There was no reas

Re: libtool-2.2.11a on AIX 5.3 current git master 2010-08-25 /status

2010-09-22 Thread Ralf Wildenhues
* Rainer Tammer wrote on Wed, Sep 22, 2010 at 09:35:38AM CEST: > --- a/README > +++ b/README > @@ -319,6 +319,17 @@ notice and this notice are preserved. This file is > offered as-is, > without warranty of any kind. > > > +6. Platform specific notes We already have doc/notes.{texi,txt}. Cheer

Re: libtool-2.2.11a on AIX 5.3 current git master 2010-08-25 /status

2010-09-21 Thread Ralf Wildenhues
Hello Rainer, * Rainer Tammer wrote on Tue, Sep 21, 2010 at 11:15:47AM CEST: > after this patch all tests from the old test suite are OK. Great! > The new test suite still shows some problems but its getting much better: Yeah. They pass fully with LDFLAGS=-Wl,-brtl. But the failures without r

Re: [PATCH] msvc: eliminate spaces in the library search path.

2010-09-21 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Tue, Sep 21, 2010 at 09:37:16AM CEST: > I know it's late for the release, but I'd like to squeeze this one in > too, if at all possible. After all, it doesn't affect anything but MSVC. I have questions: What does Charles have to say to this? What is $LIB? Is th

Re: [PATCH] maint: edit-readme-alpha shouldn't try to re-edit during dist.

2010-09-20 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Tue, Sep 21, 2010 at 08:44:41AM CEST: > With those addressed, and another successful distcheck, okay to push? Sure. Thanks, Ralf

Re: [PATCH] maint: edit-readme-alpha shouldn't try to re-edit during dist.

2010-09-20 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Tue, Sep 21, 2010 at 03:05:46AM CEST: > Well, it does at least show that the script interacts correctly with > an error for make to help catch the case where someone commits a change > to the first paragraph of README without a matching edit to the sed > express

Re: libtool-2.2.11a on AIX 5.3 current git master 2010-08-25 /status

2010-09-20 Thread Ralf Wildenhues
f grep '^FAIL: ' checklog; then > > Result: > 2fc264a8e2f7224627bb7c191a38a2dc9e7b5bcb is first bad commit > commit 2fc264a8e2f7224627bb7c191a38a2dc9e7b5bcb > Author: Ralf Wildenhues > Date: Fri Aug 6 22:03:19 2010 +0200 > > Fix AC_NO_

Re: libtool does not recognize lib64 -- Update to Olly Betts' patch

2010-09-20 Thread Ralf Wildenhues
* Toshio Kuratomi wrote on Mon, Sep 20, 2010 at 10:20:09PM CEST: > On Sat, Sep 11, 2010 at 04:04:04PM -0400, Toshio Kuratomi wrote: > > Greetings. I package software for Fedora and frequently get hit with > > /usr/lib64 being added as an rpath in builds. I found what I think is the > > last threa

Re: [PATCH] build: ship autobuild.m4, to reduce bootstrap requirement

2010-09-20 Thread Ralf Wildenhues
* Eric Blake wrote on Mon, Sep 20, 2010 at 08:13:25PM CEST: > Shipping a copy of autobuild.m4 makes it so that users need not > pre-install autobuild just for aclocal to find the macro AB_INIT. > > * libltdl/m4/.gitignore: Drop autobuild.m4. > * libltdl/m4/autobuild.m4: New file, copied from autob

Re: [PATCH 6/6] maint: use sed instead of maintaining 2 README files.

2010-09-20 Thread Ralf Wildenhues
Hello Gary, * Gary V. Vaughan wrote on Sun, Sep 19, 2010 at 05:46:25AM CEST: > On 18 Sep 2010, at 13:40, Ralf Wildenhues wrote: > > * Gary V. Vaughan wrote on Sat, Sep 18, 2010 at 07:20:18AM CEST: > >> + sed -e '/^This is GNU Libtool,/,/^interface.$/c\ > >> +Thi

Re: [PATCH] tests: Import items from liba1 for MSVC.

2010-09-19 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Sun, Sep 19, 2010 at 04:05:06PM CEST: > tests/lt_dlexit.at turned out to be trival to fix for MSVC. > Ok to push? No rush for the release though, it's only the > testsuite... Okay if the test still passes with GCC on Cygwin and MinGW. Thanks! Ralf > Subject: [PA

Re: [PATCH 2/6] maint: consolidate Introductions of README and README.alpha.

2010-09-19 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Sun, Sep 19, 2010 at 04:49:34AM CEST: > In due course, I'd rather try to encourage people to install > autobuild, and submit results there, than waste time maintaining a > parallel list in PLATFORMS manually. But I won't have time to get to > that for a while,

tests: avoid distcheck failure with --disable-ltdl-install.

2010-09-18 Thread Ralf Wildenhues
I've ran the various distcheck DISTCHECK_CONFIGURE_FLAGS=... tests required for release on my system. This is the only fixup I needed. Pushed to master. Cheers, Ralf tests: avoid distcheck failure with --disable-ltdl-install. * tests/ltdl-libdir.at (libdir of installed modules): Sk

Re: [PATCH 6/6] maint: use sed instead of maintaining 2 README files.

2010-09-17 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Sat, Sep 18, 2010 at 07:20:18AM CEST: > * README.alpha: Deleted. It was mostly identical to README. > * libltdl/config/edit-readme-alpha: New script to edit the > contents of README in the dist tree prior to tarring up. > * Makefile.am (dist-hook): Run it before rolling

Re: README cleanups

2010-09-17 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Sat, Sep 18, 2010 at 07:20:12AM CEST: > Okay to push? I'm fine with this patch series. Thanks. A minor nit: users don't really need GNU make to build Libtool from a release tarball unless they want to do VPATH builds. This was stated before your patch though

LTO: consistently accept -fwhopr* and -flto* for GCC.

2010-09-17 Thread Ralf Wildenhues
We were inconsistent in matching flags matching -flto?* or -fwhopr?* (in glob notation); GCC has more flags matching either. It seems fairly safe to allow all of these through. On the other hand, from looking at the semantics it seems like the right thing to _not_ allow through -fwhole-program fo

Re: [PATCH] Fix order of PATH manipulation in cwrapper and shwrapper

2010-09-17 Thread Ralf Wildenhues
* Charles Wilson wrote on Fri, Sep 17, 2010 at 06:23:28PM CEST: > * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src:main): Call > lt_update_exe_path before lt_update_lib_path, to ensure that the > temporary rpath values (which include the OBJDIRs of uninstalled > libtool libraries) precede in

Re: [PATCH] Document libtool variable to_host_file_cmd.

2010-09-17 Thread Ralf Wildenhues
* Charles Wilson wrote on Fri, Sep 17, 2010 at 07:37:23PM CEST: > On 9/17/2010 1:30 PM, Ralf Wildenhues wrote: > > OK. Why the s/system/platform/ changes though? I see that > > libtool.texi uses platform a lot, and also uses system quite a bit but > > not quite

Re: [PATCH] Document libtool variable to_host_file_cmd.

2010-09-17 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Fri, Sep 17, 2010 at 06:28:46PM CEST: > * doc/libtool.texi (libtool script contents:to_host_file_cmd): Document > variable. > (libtool script contents:to_tool_file_cmd): Prefer `build platform' > to `build system'; Ditto `host platform'. > OK to push? OK. W

Re: [PATCH 2/2] Move portable shell tests from the old to the new testsuite.

2010-09-17 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Fri, Sep 17, 2010 at 12:37:30PM CEST: > Subject: [PATCH 2/2] Move portable shell tests from the old to the new > testsuite. > > * tests/sh.test: Move this... > * tests/sh.at: ...to here, and adjust to the new testsuite. > * Makefile.am: Update. > --- a/Makefile.

Re: [PATCH 1/2] * tests/sh.test: Detect missing 'test' in 'if "$foo" = ...'.

2010-09-17 Thread Ralf Wildenhues
* Peter Rosin wrote on Fri, Sep 17, 2010 at 12:37:07PM CEST: > Subject: [PATCH 1/2] * tests/sh.test: Detect missing 'test' in 'if "$foo" = > ...'. OK, but I find the log entry not really explaining the change. How about this instead? tests: actually detect missing 'test' in 'if "$foo" = ...'

Re: [PATCH] Copy over DLL_EXPORT handling from C to C++ for non-GCC on w32.

2010-09-17 Thread Ralf Wildenhues
let the review sprint begin ... Hi Peter, * Peter Rosin wrote on Fri, Sep 17, 2010 at 04:18:55PM CEST: > I noticed that -DDLL_EXPORT didn't appear when I compiled C++ code > with MSVC. > > I'd like this one to go in before the release. > > Ok to push? OK, thanks. Testsuite exposure would be n

Fix darwin fat archive mode test failure

2010-09-16 Thread Ralf Wildenhues
http://autobuild.josefsson.org/libtool/log-201009131952560019000.txt The patch below fixes this failure: ../../libtool-master/tests/localization.at:43: (LANG=de_DE LANGUAGE=de_DE LC_ALL=de_DE $CC $CPPFLAGS $CFLAGS -c a.c) || exit 1 stderr: a.c:1: error: size of array 'x' is negative a.c:1: error

Re: w32 pending?

2010-09-16 Thread Ralf Wildenhues
Hello Vincent, * Vincent Torri wrote on Thu, Sep 16, 2010 at 09:52:39PM CEST: > On Thu, 16 Sep 2010, Ralf Wildenhues wrote: > > > >do I see it right that there are no pending w32 patches for before > >the next Libtool release any more (after the one I just acked)? > >

Re: w32 pending?

2010-09-16 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Thu, Sep 16, 2010 at 08:47:52PM CEST: > [cygwin|mingw] Fix order of PATH manipulation in cwrapper > > * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src:main): Call > lt_update_exe_path before lt_update_lib_path, to ensure that the local > OBJDIR(s) supe

Re: [PATCH] maint: improve README instructions for fetching latest version.

2010-09-16 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Thu, Sep 16, 2010 at 04:49:47AM CEST: > * README, README-alpha (Obtaining the Latest Sources): New > section, describing use of savannah repositories and bootstrap. > * README.alpha (Reporting Bugs): Remove git instructions in > favour of a reference to the new

Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length.

2010-09-16 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Mon, Sep 13, 2010 at 10:03:10AM CEST: > Ok to push this time? Okay. I think it ought to be possible to clean up the logic a bit further, to make it easier to follow when you read the whole paragraph of code, but such a cleanup is just as good to make alongside th

w32 pending?

2010-09-16 Thread Ralf Wildenhues
Hello Chuck and Peter, do I see it right that there are no pending w32 patches for before the next Libtool release any more (after the one I just acked)? Thanks, Ralf

Re: [PATCH] maint: ship .xz, not .lzma

2010-09-14 Thread Ralf Wildenhues
Hello Bob, * Bob Friesenhahn wrote on Tue, Sep 14, 2010 at 05:02:42PM CEST: > This sort of decision-making results in people feeling that GNU > software is excessively complex bloatware. Personal politics and > status has become more important than proper technical analysis. This is fairly grave

Re: [PATCH] maint: ship .xz, not .lzma

2010-09-14 Thread Ralf Wildenhues
* Charles Wilson wrote on Tue, Sep 14, 2010 at 07:14:06PM CEST: > If you want to start an xz-vs-lzip fight, propose the appropriate > support for dist-lzip on automake-patches and fight it there. :-) git Automake has dist-lzip support. lzma/xz support was added at the time it was because somebody

autobuild results

2010-09-13 Thread Ralf Wildenhues
I've tried to get as many coverage results as possible on Sunday. http://autobuild.josefsson.org/libtool/ lists most of them now. Feel free to add your own. Feel even more free to peruse the logs and fix remaining failures. :-) It should be noted that the "Results" column isn't completely right

Re: [PATCH] maint: ship .xz, not .lzma

2010-09-13 Thread Ralf Wildenhues
Hi Eric, * Eric Blake wrote on Mon, Sep 13, 2010 at 11:34:23PM CEST: > * configure.ac (AM_INIT_AUTOMAKE): Prefer better file format. > Any objections to this patch? xz is a more robust successor to lzma. I'm fine with, if you also adjust HACKING, .gitignore, Makefile.maint. We require new-enoug

Re: doc: wrapping, categorizing, and indexing improvements.

2010-09-13 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Mon, Sep 13, 2010 at 05:24:51AM CEST: > On 12 Sep 2010, at 21:12, Ralf Wildenhues wrote: > > OK to push? > > Okay with nits addressed. Thanks for the review. > > @cindex libtool libraries > > -...@cindex @samp{.la} files >

tests: avoid empty AT_DATA contents, for zsh.

2010-09-12 Thread Ralf Wildenhues
This fixes the remaining testsuite failures with zsh 4.3.10 on FreeBSD. cat >file

tests: work around zsh use of $options variable.

2010-09-12 Thread Ralf Wildenhues
../../libtool/tests/getopt-m4sh.at:93: $SHELL ./options -fvi + /usr/local/bin/zsh ./options -fvi --- /dev/null 2010-09-12 14:28:42.575801479 + +++ /tmp/build/tests/testsuite.dir/at-groups/1/stderr 2010-09-12 14:28:42.634930285 + @@ -0,0 +1,2 @@ +./options:950: options: attempt to set ass

Re: [PATCH] [cygwin|mingw] Correct static lib symbol extraction failure.

2010-09-12 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Sun, Sep 12, 2010 at 04:20:13PM CEST: > * Charles Wilson wrote on Sun, Sep 12, 2010 at 03:19:51PM CEST: > > * libltdl/config/ltmain.m4sh (func_mode_link): When prefer_static_libs, > > ensure old_library name is used as linklib when possible. > Why d

Re: [PATCH] [cygwin|mingw] Correct static lib symbol extraction failure.

2010-09-12 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Sun, Sep 12, 2010 at 03:19:51PM CEST: > * libltdl/config/ltmain.m4sh (func_mode_link): When prefer_static_libs, > ensure old_library name is used as linklib when possible. > --- > This patch corrects the (long-standing?) failure of mdemo-exec.test on > mingw,

doc: wrapping, categorizing, and indexing improvements.

2010-09-12 Thread Ralf Wildenhues
I paged through the PDF version of the manual looking for long lines, and went through the index looking for markup errors and wrong entries like '(void)' stemming from wrong number of arguments to @deftypefun and the like: there must be a space after } in @deftypefun {const char *}lt_dlgetsearch

Fix AC_NO_EXECUTABLES test failure on IRIX 6.5.

2010-09-12 Thread Ralf Wildenhues
I'm pushing this bugfix to fix this failure on IRIX with GCC (log already expired; Simon bumped the timeout to 24 days now): ../../libtool/tests/no-executables.at:75: : ${CONFIG_SHELL=/bin/sh}; export CONF IG_SHELL; $CONFIG_SHELL ./configure $configure_options stderr: configure: WARNING:

Re: test with old autotools

2010-09-12 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Sun, Sep 12, 2010 at 12:58:23PM CEST: > On 12 Sep 2010, at 17:47, Ralf Wildenhues wrote: > > <0001-Try-out-new-testsuite-with-old-Autoconf-and-Automake.patch> > > You forgot to `git add tests/old-autoconf.at' before you generated the > p

test with old autotools (was: [PATCH 1/6] Require Automake 1.11.1 for Libtool, enable color-tests.)

2010-09-12 Thread Ralf Wildenhues
Hello Gary, you wanted a way to test old Autoconf and Automake with a git Libtool tree: * Gary V. Vaughan wrote on Sun, Aug 22, 2010 at 05:41:52PM CEST: > On 22 Aug 2010, at 22:30, Ralf Wildenhues wrote: > > * Gary V. Vaughan wrote on Sun, Aug 22, 2010 at 05:24:05PM CEST: > >&g

Re: static FORTRAN compilation set-up in libtool.m4

2010-09-12 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Thu, Sep 02, 2010 at 07:41:25PM CEST: > That's fine. Any support for nagfor is an improvement over no support. I've pushed the patch below to git master of Libtool now. Please test as described before, if at all possible. I changed the pic flag to -PIC

Re: getopt-m4sh tests failures with autom4te 2.61

2010-09-12 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Thu, Sep 02, 2010 at 10:36:54PM CEST: > Hi Gary, > > I get testsuite failures of the first six tests with autom4te 2.61 early > in PATH (the testsuite itself has been created with 2.67). See below > for an example failure. Maybe getopt-m4sh.at really re

Re: How many spaces after a period? [WAS: Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length.]

2010-09-12 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Sun, Sep 12, 2010 at 11:23:52AM CEST: > On 12 Sep 2010, at 15:01, Ralf Wildenhues wrote: > > * Peter Rosin wrote on Sat, Sep 11, 2010 at 02:24:18PM CEST: > >> * libltdl/config/ltmain.m4sh (func_mode_link): Avoid calculating > >> the c

Re: [PATCH 0/3]: Another go at LTO support

2010-09-12 Thread Ralf Wildenhues
<http://thread.gmane.org/gmane.comp.gnu.libtool.patches/10424> * Ralf Wildenhues wrote on Sun, Aug 29, 2010 at 06:18:05PM CEST: > OK, so the issues I had with > <http://thread.gmane.org/gmane.comp.gnu.libtool.patches/9767> > was both changing output_verbose_link_cmd to some

Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length.

2010-09-12 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Sat, Sep 11, 2010 at 02:24:18PM CEST: > Subject: [PATCH 7/7] Prefer $NM @file when the toolchain isn't native to > $build. > > * libltdl/config/ltmain.m4sh (func_mode_link): Avoid calculating > the command line length and take the @file branch *if* the file > nam

approving w32 patches (was: [PATCH] Correct typo: $sharedlib_from_linklib_cmd missing '_cmd')

2010-09-11 Thread Ralf Wildenhues
Hello, * Peter O'Gorman wrote on Sat, Sep 11, 2010 at 07:37:41PM CEST: > On 09/11/2010 10:09 AM, Charles Wilson wrote: > >However...I don't have the authority to push *anything* without > >approval, so I *can't* simply say "pushed as obvious". > > It is ok for anyone with commit access to commit

Re: [PATCH] * HACKING (Maintenance Notes): Adjust to moved files.

2010-09-11 Thread Ralf Wildenhues
* Peter Rosin wrote on Sat, Sep 11, 2010 at 09:02:54PM CEST: > I noticed that HACKING referred to files that have been moved. > > Should I also add libltdl/config/compile? Yes, plase. > But that one does not > appear to be handled by "make -fMakefile.maint fetch". Shouldn't > it? It should. Th

Re: [PATCH] Correct typo: $sharedlib_from_linklib_cmd missing '_cmd'

2010-09-11 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Sat, Sep 11, 2010 at 07:02:29AM CEST: > * libltdl/config/ltmain.m4sh (func_generate_dlsyms): Fix obvious > typo, $sharedlib_from_linklib_cmd missing '_cmd'. > --- > Typo in e83da49a1faf9df1c7e351df9e9b175388d76619: there is no variable > named 'sharedlib_from_

Re: [PATCH 6/7] Convert file name to toolchain format when invoking $NM.

2010-09-10 Thread Ralf Wildenhues
* Peter Rosin wrote on Fri, Sep 10, 2010 at 03:11:39PM CEST: > Den 2010-09-05 23:29 skrev Ralf Wildenhues: > > You're gonna hate me for this, I already know, but: does this patch fix > > testsuite failures, are all code paths covered? If not, we need to > > improve the t

Re: [PATCH 6/7] Convert file name to toolchain format when invoking $NM.

2010-09-09 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Fri, Sep 10, 2010 at 12:35:59AM CEST: > Den 2010-09-09 22:05 skrev Charles Wilson: > > On 9/9/2010 3:56 PM, Ralf Wildenhues wrote: > >> Secondly, I can help with unsupervised git bisect if you need. In > >> <http://lists.gnu.org/ar

Re: [PATCH 6/7] Convert file name to toolchain format when invoking $NM.

2010-09-09 Thread Ralf Wildenhues
Peter, Charles, I understand that you're doing a difficult bug hunt here, and 6/7 is the only unapplied patch of this series (right?). I've looked at 6/7 again, and conclude that it has a low chance of regressing. If it makes things easier for you, then I'm fine with you going ahead and applying

Re: [PATCH] Fix dependency tracking for MSYS/MinGW.

2010-09-09 Thread Ralf Wildenhues
* Peter Rosin wrote on Thu, Sep 09, 2010 at 10:59:30AM CEST: > As discussed in that other thread, namely > http://lists.gnu.org/archive/html/libtool-patches/2010-09/msg00105.html > I accidentally broke MSYS/MinGW. Here's an improved version of the patch > shown in that message to fix the build issu

Re: [PATCH] Adjust naming of MSVC import libraries.

2010-09-08 Thread Ralf Wildenhues
* Peter Rosin wrote on Wed, Sep 08, 2010 at 01:42:20PM CEST: > How about the below? Sure, thanks! > Subject: [PATCH] Mention adjustment of naming of MSVC import libraries in > NEWS. > > * NEWS: Mention the change in import library naming on MSVC.

Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length.

2010-09-08 Thread Ralf Wildenhues
Hello Peter, * Peter Rosin wrote on Sun, Sep 05, 2010 at 10:02:39PM CEST: > Subject: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length. > > * libltdl/config/ltmain.m4sh (func_mode_link): Avoid calculating > the cammand line length if the name lister has @file support and s/camman

Re: [PATCH] Adjust naming of MSVC import libraries.

2010-09-07 Thread Ralf Wildenhues
* Peter Rosin wrote on Wed, Sep 08, 2010 at 12:23:17AM CEST: > Den 2010-09-07 22:24 skrev Ralf Wildenhues: > > * Ralf Wildenhues wrote on Tue, Sep 07, 2010 at 10:20:06PM CEST: > >> * Peter Rosin wrote on Tue, Sep 07, 2010 at 11:25:00AM CEST: > > Rationale: you don't,

Re: [PATCH] Adjust naming of MSVC import libraries.

2010-09-07 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Tue, Sep 07, 2010 at 10:20:06PM CEST: > * Peter Rosin wrote on Tue, Sep 07, 2010 at 11:25:00AM CEST: > > Subject: [PATCH] Adjust naming of MSVC import libraries. > > > > * libltdl/m4/libtool.m4 (_LT_SYS_DYNAMIC_LINKER) [mingw, cygwin] > > [p

Re: [PATCH] Adjust naming of MSVC import libraries.

2010-09-07 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Tue, Sep 07, 2010 at 11:25:00AM CEST: > (BTW, what's up with the strange date generated by git in the next line?) > > From baa6de02d18f99e65777dd8092e6a7fc1d734358 Mon Sep 17 00:00:00 2001 That's a git artefact, just like the sha1 isn't a real 'From' string. > F

Re: [PATCH 5/7] Convert POSIX file names to toolchain format for MSVC

2010-09-06 Thread Ralf Wildenhues
* Peter Rosin wrote on Mon, Sep 06, 2010 at 09:34:02PM CEST: > Den 2010-09-06 20:42 skrev Ralf Wildenhues: > > * Peter Rosin wrote on Mon, Sep 06, 2010 at 08:38:31PM CEST: > >> I think I want to do > >> > >> +func_to_tool_file "$out

Re: [PATCH 5/7] Convert POSIX file names to toolchain format for MSVC

2010-09-06 Thread Ralf Wildenhues
* Peter Rosin wrote on Mon, Sep 06, 2010 at 08:38:31PM CEST: > Den 2010-09-06 20:01 skrev Ralf Wildenhues: > > * Peter Rosin wrote on Mon, Sep 06, 2010 at 11:14:19AM CEST: > >> Easily? Is this something like this what you had in mind? (untested) > > > > Yes, someth

Re: [PATCH 5/7] Convert POSIX file names to toolchain format for MSVC

2010-09-06 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Mon, Sep 06, 2010 at 11:14:19AM CEST: > Den 2010-09-05 23:27 skrev Ralf Wildenhues: > > * Peter Rosin wrote on Sun, Sep 05, 2010 at 10:01:42PM CEST: > >> Subject: [PATCH 5/7] Convert POSIX file names to toolchain format for MSVC > >> &

Re: git log -> changelog

2010-09-05 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Mon, Sep 06, 2010 at 05:20:30AM CEST: > On 6 Sep 2010, at 03:44, Ralf Wildenhues wrote: > > Except that the autotools project logs contain lots of S-O-B entries > > which explicitly do not have that particular meaning. :-/ > > I sup

Re: [PATCH 1/7] Add file name conversion from $build to toolchain.

2010-09-05 Thread Ralf Wildenhues
* Charles Wilson wrote on Mon, Sep 06, 2010 at 12:13:26AM CEST: > On 9/5/2010 5:20 PM, Ralf Wildenhues wrote: > > * Peter Rosin wrote on Sun, Sep 05, 2010 at 09:58:58PM CEST: > >> Subject: [PATCH 1/7] Add file name conversion from $build to toolchain. > > OK pending the

Re: [PATCH 6/7] Convert file name to toolchain format when invoking $NM.

2010-09-05 Thread Ralf Wildenhues
* Peter Rosin wrote on Sun, Sep 05, 2010 at 10:02:11PM CEST: > Subject: [PATCH 6/7] Convert file name to toolchain format when invoking $NM. > > * libltdl/config/ltmain.m4sh (func_generate_dlsyms) > (func_win32_libid, func_cygming_gnu_implib_p) > (func_cygming_ms_implib_p): When using the name lis

Re: [PATCH 5/7] Convert POSIX file names to toolchain format for MSVC

2010-09-05 Thread Ralf Wildenhues
* Peter Rosin wrote on Sun, Sep 05, 2010 at 10:01:42PM CEST: > From 449723f9bdcad6946e098d7acf0f215f3a4c18a2 Mon Sep 17 00:00:00 2001 > From: Peter Rosin > Date: Sun, 5 Sep 2010 17:53:35 +0200 > Subject: [PATCH 5/7] Convert POSIX file names to toolchain format for MSVC > > * libltdl/m4/libtool.m4

Re: [PATCH 4/7] Use func_to_tool_file instead of fix_srcfile_path.

2010-09-05 Thread Ralf Wildenhues
2/7 and 3/7 are ok, thanks. * Peter Rosin wrote on Sun, Sep 05, 2010 at 10:01:04PM CEST: > Subject: [PATCH 4/7] Use func_to_tool_file instead of fix_srcfile_path. > > * libltdl/config/ltmain.m4sh (func_mode_compile): Replace the > fix_srcfile_path hook with a call to func_to_tool_file. > * libltd

Re: [PATCH 1/7] Add file name conversion from $build to toolchain.

2010-09-05 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Sun, Sep 05, 2010 at 09:58:58PM CEST: > Subject: [PATCH 1/7] Add file name conversion from $build to toolchain. > > * configure.ac: Ensure to_tool_file_cmd is available to Makefile. > * libltdl/m4/libtool.m4 (_LT_PATH_CONVERSION_FUNCTIONS): Add > cache variable lt

Re: git log -> changelog

2010-09-05 Thread Ralf Wildenhues
Hello, * Eric Blake wrote on Thu, Sep 02, 2010 at 11:23:57PM CEST: > The git pages are clear that S-O-B has project-dependent > interpretation. Coreutils currently doesn't even use it (the only > people with commit privileges to the master coreutils.git have FSF > copyright, and it is assumed tha

tests: avoid spurious test failure due to library mode on HP-UX.

2010-09-02 Thread Ralf Wildenhues
http://autobuild.josefsson.org/libtool/log-201008291316534087000.txt | ../../libtool/tests/help.at:164: $orig_LIBTOOL --mode=install cp liba.la libb.la $libdir | stderr: | cp: cannot create /tmp/lt/build-hppa2.0w-hp-hpux11.11/tests/testsuite.dir/023/inst/lib/liba.sl.0.0: Permission denied | std

Re: [PATCH 4/7] Use func_to_tool_file instead of fix_srcfile_path.

2010-09-02 Thread Ralf Wildenhues
* Peter Rosin wrote on Thu, Sep 02, 2010 at 09:00:13AM CEST: > Den 2010-09-01 23:30 skrev Ralf Wildenhues: > >> * libltdl/m4/libtool.m4 (_LT_LINKER_SHLIBS) [cygwin,mingw,pw32] > >> [cegcc]: Drop fix_srcfile_path. > > > > Please ask google codesearch whether

Re: [PATCH 4/7] Use func_to_tool_file instead of fix_srcfile_path.

2010-09-01 Thread Ralf Wildenhues
* Charles Wilson wrote on Wed, Sep 01, 2010 at 11:39:07PM CEST: > On 9/1/2010 5:30 PM, Ralf Wildenhues wrote: > > * Peter Rosin wrote on Wed, Sep 01, 2010 at 10:33:59PM CEST: > >> * libltdl/config/ltmain.m4sh (func_mode_compile): Replace the > >> fix_srcfi

Re: [PATCH 4/7] Use func_to_tool_file instead of fix_srcfile_path.

2010-09-01 Thread Ralf Wildenhues
* Peter Rosin wrote on Wed, Sep 01, 2010 at 10:33:59PM CEST: > From 16232cc7ddfc4bab981a2fa2d87757c68832b32e Mon Sep 17 00:00:00 2001 > From: Peter Rosin > Date: Sun, 29 Aug 2010 18:26:16 +0200 > Subject: [PATCH 4/7] Use func_to_tool_file instead of fix_srcfile_path. > > * libltdl/config/ltmain.m

tests: avoid spurious pic_flag test failure on HP-UX 10.20.

2010-09-01 Thread Ralf Wildenhues
http://autobuild.josefsson.org/libtool/log-201008291316745734000.txt | 113. pic_flag.at:24: testing override pic_flag at configure time ... | ../../libtool/tests/pic_flag.at:36: $CC $CPPFLAGS $CFLAGS $C_pic_flag -c foo.c || exit 77 | stderr: | cc: warning 422: Unknown option "f" ignored. | cc: wa

Re: [PATCH 1/6] Add --gnulib-version and --news options to announce-gen.

2010-09-01 Thread Ralf Wildenhues
Hello Gary, * Gary V. Vaughan wrote on Wed, Sep 01, 2010 at 09:49:01PM CEST: > Well, libltdl also works well enough. No, it doesn't. > I'm a good way into a complete > rewrite... are you saying that you'd rather put up with the limitations > of the current libltdl architecture than move to a cle

tests: fix localization test for GCC on HP-UX 11.00.

2010-09-01 Thread Ralf Wildenhues
dex 71cdad4..392511e 100644 --- a/tests/localization.at +++ b/tests/localization.at @@ -1,7 +1,6 @@ # localization.at -- libtool and locales-*- Autotest -*- # -# Copyright (C) 2008, 2009 Free Software Foundation, Inc. -# Written by Ralf Wildenhues, 2008 +# Copyright (C) 2

Avoid leaking make flags into testsuite results.

2010-09-01 Thread Ralf Wildenhues
I'm committing the following bug fix, with code taken from automake/tests/defs.in and adapted for Libtool. It ought to fix about a third of all the failures in all the autobuild logs; e.g., tests 107 and 109 seen in this log:

Re: [PATCH 1/6] Add --gnulib-version and --news options to announce-gen.

2010-09-01 Thread Ralf Wildenhues
Hello Gary, * Gary V. Vaughan wrote on Wed, Sep 01, 2010 at 08:09:32AM CEST: > On 1 Sep 2010, at 12:25, Ralf Wildenhues wrote: > > That didn't help to make it more readable, or cause less buggy code > > though. > > Well that's because the shared code in getopts.m

Re: [PATCH] Remove announce-gen.m4sh and mailnotify.m4sh.

2010-08-31 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Wed, Sep 01, 2010 at 07:18:12AM CEST: > From earlier discussion, there is no need to clutter the > Libtool tree with these scripts, and we can amend our release > process to use the gnulib announce-gen script in due course. > > * libltdl/config/announce-gen.m4sh: Removed

Re: [PATCH v2] Remove clcommit.m4sh.

2010-08-31 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Wed, Sep 01, 2010 at 06:50:51AM CEST: > * clcommit.m4sh: Removed. This script was written to help keep > ChangeLog and commit messages in sync when committing to CVS, > and is an anachronism now that Libtool uses git. > * Makefile.maint (commit): Target removed.

Re: [PATCH 6/6] Simplify and improve safety of bootstrap process.

2010-08-31 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Wed, Sep 01, 2010 at 04:42:52AM CEST: > On 1 Sep 2010, at 01:16, Ralf Wildenhues wrote: > > * Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:20AM CEST: > >> -test -f clcommit.m4sh && $MAKE -f Makefile.maint ./commit \ > >>

Re: [PATCH 1/6] Add --gnulib-version and --news options to announce-gen.

2010-08-31 Thread Ralf Wildenhues
Hello Gary, * Gary V. Vaughan wrote on Wed, Sep 01, 2010 at 03:59:19AM CEST: > On 1 Sep 2010, at 00:41, Ralf Wildenhues wrote: > > I personally find the M4SH_GETOPTS rather unreadable; it's a nice table, > > but I cannot make sense of the entries, or review them, except b

Re: [PATCH 6/6] Simplify and improve safety of bootstrap process.

2010-08-31 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:20AM CEST: > * Makefile.am (bootstrap_files): List files that need to be > generated at bootstrap time before `./configure && make' can > work. It turns out that this is considerably fewer files than we > had thought necessary previously. > (bo

Re: [PATCH 5/6] Don't leak developer GREP, SED etc into distribution file.

2010-08-31 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:19AM CEST: > From: Gary V. Vaughan > > * bootstrap (rebuild): Set the shell variable `revision' rather > than `correctver' for clarity. > (edit): Split into two parts... > (bootstrap_edit): ...substitutions that should happen at bootstrap > ti

<    1   2   3   4   5   6   7   8   9   10   >