Re: [PATCH] Add alias for obsoleted AC_LIBTOOL_RC macro.

2009-06-27 Thread Ralf Wildenhues
Hi Charles,

* Charles Wilson wrote on Wed, Jun 24, 2009 at 02:32:16AM CEST:
 * libltdl/m4/libtool.m4: Add alias for obsoleted
 macro AC_LIBTOOL_RC.

OK, but *really*, the project thould move to Libtool 2.2.x.
Push them, please.

 OK, with or without an additional change to lt~obsolete.m4?

No idea what you mean with this.

Thanks,
Ralf




Re: [PATCH] Add alias for obsoleted AC_LIBTOOL_RC macro.

2009-06-27 Thread Charles Wilson
Ralf Wildenhues wrote:
 * Charles Wilson wrote on Wed, Jun 24, 2009 at 02:32:16AM CEST:
 * libltdl/m4/libtool.m4: Add alias for obsoleted
 macro AC_LIBTOOL_RC.
 
 OK,

Pushed.

 but *really*, the project thould move to Libtool 2.2.x.
 Push them, please.
 
 OK, with or without an additional change to lt~obsolete.m4?
 
 No idea what you mean with this.

My previous reply seemed to go astray...

lt~obsolete.m4 supplies only empty, non-functional aliases for old,
public libtool macros that have been removed.  It currently has this:

m4_ifndef([AC_LIBTOOL_RC],  [AC_DEFUN([AC_LIBTOOL_RC])])

Can that line stay, or should it be removed, now that
libltdl/m4/libtool.m4 will provide a non-empty, functional alias for
AC_LIBTOOL_RC?  I dug thru the git log, but I really could not figure
out why this was put in lt~obsolete in the first place, instead of
treated like the other AC_LIBTOOL_{lang} macros...

If desired, I'll prepare another patch to remove that alias defn from
lt~obsolete.

--
Chuck





Re: [PATCH] Enable runtime cwrapper debugging; add tests

2009-06-27 Thread Charles Wilson
Charles Wilson wrote:
 * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src)
 [ltwrapper_debugprintf]: Renamed to...
 [lt_debugprintf]: this. Only print messages if lt_debug != 0.
 [file scope]: Add constants and variables to support new --lt-debug
 option. Remove LTWRAPPER_DEBUGPRINTF macro.
 [main]: Consolidate option parsing. Ensure first use of lt_debugprintf
 occurs after option parsing. Add stanza to parse for --lt-debug and
 set lt_debug variable.
 [all]: Use lt_debugprintf () instead of LTWRAPPER_DEBUGPRINTF (()).
 * tests/cwrapper.at: Add new tests for --lt-debug and -DLT_DEBUGWRAPPER.
 ---
 Another fragment arising from review of
 http://lists.gnu.org/archive/html/libtool-patches/2009-06/msg00031.html
 
 Lightly tested by running tests/demo-shared.test tests/demo-make.test
 tests/demo-exec.test and cwrapper.at.
 
 Ok to push?

Ping?

I'll follow up this patch with another to add support for
  --lt-debug
  --lt-dump-script
to the shell wrapper.  --lt-debug will do very little other than $ECHO
the full path to the program executable and its arguments.
--lt-dump-script will simply { cat $0  exit 0 }

Then I'll revise and retitle the remainder of
[PATCH] Document and test LT_DEBUGWRAPPER cwrapper macro
http://lists.gnu.org/archive/html/libtool-patches/2009-06/msg00031.html
as appropriate.

--
Chuck