Re: [PATCH] libtool.m4: Handle "/" as a sysroot more correctly

2024-01-16 Thread Roumen Petrov
Hi All, Mike Frysinger wrote: On 16 Jan 2024 21:47, Richard Purdie wrote: If $CC has --sysroot=/, it is a valid configuration however libtool will then set lt_sysroot to "/". This means references like $lt_sysroot$libdir become //usr/lib instead of the more normally expected /usr/lib. This

[PATCH] libtool.m4: drop AC_PROG_SED fallback

2024-01-16 Thread Mike Frysinger
We require autoconf 2.62 which includes this macro so we don't need this fallback logic anymore. * m4/libtool.m4 (AC_PROG_SED): Delete. --- m4/libtool.m4 | 67 --- 1 file changed, 67 deletions(-) diff --git a/m4/libtool.m4 b/m4/libtool.m4 index

Re: [PATCH] libtool: remove OpenBSD support for non-shared and a.out archs

2024-01-16 Thread Roumen Petrov
Hi All Mike Frysinger wrote: On 16 Jan 2024 21:11, Brad Smith wrote: libtool: remove OpenBSD support for non-shared and a.out archs OpenBSD stopped supporting the last non-shared arch 8 years ago and stopped supporting a.out 10.5 years ago. This cannot be reason to drop support. For instance

Re: [PATCH 1/3] libtool.m4: augment symcode for Solaris 11

2024-01-16 Thread Mike Frysinger
this should be fixed in git now. i merged the one posted previously: https://savannah.gnu.org/patch/?9086 -mike signature.asc Description: PGP signature

[patch #9086] Fix support for Solaris 11 build

2024-01-16 Thread Mike Frysinger
Update of patch#9086 (group libtool): Status:None => Done Open/Closed:Open => Closed ___ Follow-up Comment #1: thanks, merged now

Re: [PATCH 02/12] libtool.m4: Rename the --with-sysroot option to avoid conflict with gcc/binutils

2024-01-16 Thread Mike Frysinger
On 16 Jan 2024 12:21, Richard Purdie wrote: > On Mon, 2024-01-15 at 20:08 -0500, Mike Frysinger wrote: > > On 25 Oct 2021 15:33, Richard Purdie wrote: > > > This patch renames the --with-sysroot option to --with-libtool-sysroot > > > to avoid namespace conflict with binutils, gcc and other

Re: [PATCH] libtool: remove OpenBSD support for non-shared and a.out archs

2024-01-16 Thread Mike Frysinger
On 16 Jan 2024 21:11, Brad Smith wrote: > libtool: remove OpenBSD support for non-shared and a.out archs > > OpenBSD stopped supporting the last non-shared arch 8 years ago > and stopped supporting a.out 10.5 years ago. i'm on the fence here, and i don't know what historical guidance/policy

[PATCH] HACKING: minor formatting tweaks

2024-01-16 Thread Mike Frysinger
* HACKING: Tweak style. --- HACKING | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/HACKING b/HACKING index 92292d1d023d..664251e680a9 100644 --- a/HACKING +++ b/HACKING @@ -13,7 +13,7 @@ and is not part of a release distribution. * If you incorporate a

Re: [PATCH 2/3] ltmain.in: Parse additional clang options

2024-01-16 Thread Sam James
Richard Purdie writes: > clang uses -rtlib and --unwindlib to select proper compiler runtime in > some cases. Therefore pass these options to linker when found in > ldflags Thanks, I was planning on sending this one too. > > * build-aux/ltmain.in: Handle clang linker options > --- >

Re: pass_all for z/OS

2024-01-16 Thread Mike Frysinger
On 17 Jan 2024 02:41, Igor Todorovski wrote: > I’ve attached the git patch based on the master branch. can you write a proper git commit and send it with send-email ? or at least format it with `git format-patch` ? the first version did: openedition) the new one does:

RE: pass_all for z/OS

2024-01-16 Thread Igor Todorovski
Hi Mike, I’ve attached the git patch based on the master branch. Thanks, Igor On 2024-01-14, 1:57 AM, "Mike Frysinger" wrote: On 24 Nov 2023 15:19, Igor Todorovski wrote: > diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4 > index d812584..f959bae 100644 > --- a/libltdl/m4/libtool.m4

Re: [PATCH] libtool.m4: Handle "/" as a sysroot more correctly

2024-01-16 Thread Mike Frysinger
On 16 Jan 2024 21:47, Richard Purdie wrote: > If $CC has --sysroot=/, it is a valid configuration however libtool will > then set lt_sysroot to "/". > > This means references like $lt_sysroot$libdir become //usr/lib instead > of the more normally expected /usr/lib. This may or may not break

[PATCH] libtool: remove OpenBSD support for non-shared and a.out archs

2024-01-16 Thread Brad Smith
libtool: remove OpenBSD support for non-shared and a.out archs OpenBSD stopped supporting the last non-shared arch 8 years ago and stopped supporting a.out 10.5 years ago. * m4/libtool.m4: Remove support for a.out and non-shared archs. --- m4/libtool.m4 | 59

Re: [PATCH 05/12] ltmain.in: Don't encode RATHS which match default linker paths

2024-01-16 Thread Mike Frysinger
On 25 Oct 2021 15:33, Richard Purdie wrote: > We don't want to add RPATHS which match default linker search paths, they're > a waste of space. This patch filters libtools list of paths to encoode and > removes the ones we don't need. > > Libtool may be passed link paths of the form

Re: [PATCH] libtool: remove OpenBSD specific performance hack for ranlib

2024-01-16 Thread Mike Frysinger
On 16 Jan 2024 16:30, Brad Smith wrote: > The -t flag was used as a performance hack for ranlib. The flag was > supported by the GNU toolchain, but is a no-op with the LLVM toolchain. merged, thx -mike signature.asc Description: PGP signature

Re: [PATCH 3/3] libtool: Fix support for NIOS2 processor

2024-01-16 Thread Mike Frysinger
On 16 Jan 2024 15:14, Richard Purdie wrote: > The name of the system contains the string "nios2". This string > is caught by the some of the greedy checks for OS/2 in libtool, > in particular the *os2* branches of switch statements match for > the nios2 string, which results in incorrect behavior

Re: [PATCH 1/3] ltmain.in: Handle prefix-map compiler options correctly

2024-01-16 Thread Mike Frysinger
On 16 Jan 2024 15:14, Richard Purdie wrote: > --- a/build-aux/ltmain.in > +++ b/build-aux/ltmain.in > @@ -7,7 +7,6 @@ > # Copyright (C) 1996-2019, 2021-2024 Free Software Foundation, Inc. > # This is free software; see the source for copying conditions. There is NO > # warranty; not even for

Re: [PATCH 1/2] libtool: replace : with $PATH_SEPARATOR

2024-01-16 Thread Mike Frysinger
On 16 Jan 2024 23:44, KO Myung-Hun wrote: > Some OSes such as OS/2, uses ';' as a path separator. So using > $PATH_SEPARATOR instead of hard-coded ':' is more proper. so we're on the same page, we're talking about the separator that is used in the $PATH environment variable. it doesn't show up

[PATCH] bootstrap: sync to latest version

2024-01-16 Thread Mike Frysinger
* gl-mod/bootstrap: Update. * bootstrap: Likewise. --- bootstrap| 34 +- gl-mod/bootstrap | 2 +- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/bootstrap b/bootstrap index 8e0b5e83218d..e57ec940db68 100755 --- a/bootstrap +++ b/bootstrap

Re: [PATCH 1/3] Fix typos

2024-01-16 Thread Mike Frysinger
On 16 Jan 2024 17:59, Mike Frysinger wrote: > merged, but please write ChangeLog entries in the commit message i had to revert the changes to "bootstrap" as that isn't maintained here. you'll want to send those fixes to that upstream: https://github.com/gnulib-modules/bootstrap -mike

Re: [patch #10393] Fix shared library support on Android

2024-01-16 Thread Bruno Haible
Roumen Petrov wrote: > Android and Microsoft windows must not encode any paths. You probably mean to say: Shared libraries packaged in Android .apk files are mentioned in the Android manifest file (elements and ) [1] and therefore don't need a RUNPATH. But shared libraries created in the Termux

Re: [PATCH 1/3] Fix typos

2024-01-16 Thread Mike Frysinger
merged, but please write ChangeLog entries in the commit message -mike signature.asc Description: PGP signature

[PATCH] cfg.mk: update old NEWS hash

2024-01-16 Thread Mike Frysinger
The recent change to change http:// to https:// updated old NEWS entries. This isn't exactly against the spirit of the "don't change old NEWS", so update the hash to match. * cfg.mk (old_NEWS_hash): Update. --- cfg.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] ChangeLog.old: Convert ISO-8859-1 to UTF-8

2024-01-16 Thread Mike Frysinger
From: Antonin D??cimo This file is mostly UTF-8 already, but some old entries were using ISO-8859-1. Change them to UTF-8 entirely. * ChangeLog.old: Change ISO-8859-1 to UTF-8. Copyright-paperwork-exempt: Yes --- ChangeLog.old | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

Re: [PATCH 06/12] libtool.m4: Handle "/" as a sysroot correctly

2024-01-16 Thread Richard Purdie
On Mon, 2024-01-15 at 17:00 -0500, Mike Frysinger wrote: > On 25 Oct 2021 15:33, Richard Purdie wrote: > > Update libtool.m4 to resolve a problem with lt_sysroot not being properly > > updated if the option '--with[-libtool]-sysroot' is not provided when > > running the 'configure' script for a

[PATCH] libtool.m4: Handle "/" as a sysroot more correctly

2024-01-16 Thread Richard Purdie
If $CC has --sysroot=/, it is a valid configuration however libtool will then set lt_sysroot to "/". This means references like $lt_sysroot$libdir become //usr/lib instead of the more normally expected /usr/lib. This may or may not break something but certainly is confusing to the user and gives

[PATCH] libtool: remove OpenBSD specific performance hack for ranlib

2024-01-16 Thread Brad Smith
libtool: remove OpenBSD specific performance hack for ranlib The -t flag was used as a performance hack for ranlib. The flag was supported by the GNU toolchain, but is a no-op with the LLVM toolchain. * m4/libtool.m4: Remove use of -t flag with ranlib. --- m4/libtool.m4 | 9 + 1 file

Re: [patch #10393] Fix shared library support on Android

2024-01-16 Thread Roumen Petrov
Bruno Haible wrote: Roumen Petrov wrote: Android and Microsoft windows libraries must not use hard coded paths! Nevertheless what is supported by linker or loader. Why do you mention Microsoft Windows? The commit 47c71f61df9ace4956cc943f291480315174726b has no effect on Microsoft Windows.

Re: [patch #10393] Fix shared library support on Android

2024-01-16 Thread Bruno Haible
Roumen Petrov wrote: > Android and Microsoft windows libraries must not use hard coded paths! > Nevertheless what is supported by linker or loader. Why do you mention Microsoft Windows? The commit 47c71f61df9ace4956cc943f291480315174726b has no effect on Microsoft Windows. > When I read commit

[PATCH] use https:// with more gnu.org sites

2024-01-16 Thread Mike Frysinger
* NEWS: Change http:// to https:// for some URIs. * bootstrap.conf, build-aux/ltmain.in, configure.ac, libtoolize.in: Likewise. --- NEWS| 2 +- bootstrap.conf | 8 build-aux/ltmain.in | 2 +- configure.ac| 2 +- libtoolize.in | 2 +- 5 files changed, 8

Re: [patch #9442] Add flang (LLVM-based compiler) support

2024-01-16 Thread Roumen Petrov
Hi, Mike Frysinger wrote: Update of patch#9442 (group libtool): Status:None => Done Open/Closed:Open => Closed ___ Follow-up Comment #1: i dropped the -DPIC

Re: [PATCH 02/12] libtool.m4: Rename the --with-sysroot option to avoid conflict with gcc/binutils

2024-01-16 Thread Roumen Petrov
Hi, Richard Purdie wrote: [SNIP] FWIW gcc and binutils have gone with --with-sysroot and --with-build- sysroot to differentiate. Unfortunately that doesn't really help libtool (see below). Sure but we when use libtool argument --with-sysroot we expect to work as is designed and documented .

Re: [PATCH] libtool: remove bitrig support.

2024-01-16 Thread Mike Frysinger
On 16 Jan 2024 01:49, Brad Smith wrote: > libtool: remove bitrig support. > > Bitrig has been defunct for 7 years. pushed, thanks -mike signature.asc Description: PGP signature

Re: [PATCH 05/12] ltmain.in: Don't encode RATHS which match default linker paths

2024-01-16 Thread Roumen Petrov
Hi All Information below is not enough to understand details. Richard Purdie wrote: On Mon, 2024-01-15 at 20:10 -0500, Mike Frysinger wrote: On 25 Oct 2021 15:33, Richard Purdie wrote: We don't want to add RPATHS which match default linker search paths, they're a waste of space. This patch

Re: [patch #10393] Fix shared library support on Android

2024-01-16 Thread Roumen Petrov
Hello, When I read commit I agree that is correct do not have RUNPATH! The problem is that commit message is not so clear. Actually commit uses rpath flag! NO! NO! NO! Android and Microsoft windows libraries must not use hard coded paths! Nevertheless what is supported by linker or loader.

[patch #10417] Avoid deprecation warning with MSVC

2024-01-16 Thread Ileana Dumitrescu
Update of patch#10417 (group libtool): Status:None => Done Open/Closed:Open => Closed ___ Follow-up Comment #1: Thank you for the

[patch #10411] libtool: fix empty "-L" in compiler_lib_search_path

2024-01-16 Thread Ileana Dumitrescu
Update of patch#10411 (group libtool): Status:None => Done Open/Closed:Open => Closed ___ Follow-up Comment #1: Thanks for finding

Re: [PATCH 05/12] ltmain.in: Don't encode RATHS which match default linker paths

2024-01-16 Thread Richard Purdie
On Mon, 2024-01-15 at 20:10 -0500, Mike Frysinger wrote: > On 25 Oct 2021 15:33, Richard Purdie wrote: > > We don't want to add RPATHS which match default linker search paths, they're > > a waste of space. This patch filters libtools list of paths to encoode and > > removes the ones we don't need.

[PATCH 1/3] ltmain.in: Handle prefix-map compiler options correctly

2024-01-16 Thread Richard Purdie
If lto is enabled, we need the prefix-map variables to be passed to the linker to correctly link the objects using correctly mapped paths. Add these to the list of options libtool passes through. * build-aux/ltmain.in: Handle prefix-map compiler options --- build-aux/ltmain.in | 3 ++- 1 file

[PATCH 2/3] ltmain.in: Parse additional clang options

2024-01-16 Thread Richard Purdie
clang uses -rtlib and --unwindlib to select proper compiler runtime in some cases. Therefore pass these options to linker when found in ldflags * build-aux/ltmain.in: Handle clang linker options --- build-aux/ltmain.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 3/3] libtool: Fix support for NIOS2 processor

2024-01-16 Thread Richard Purdie
The name of the system contains the string "nios2". This string is caught by the some of the greedy checks for OS/2 in libtool, in particular the *os2* branches of switch statements match for the nios2 string, which results in incorrect behavior of libtool. Switch to use $host_os instead of $host

Re: [PATCH 1/2] libtool: replace : with $PATH_SEPARATOR

2024-01-16 Thread KO Myung-Hun
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi/2. Mike Frysinger wrote: > On 15 Jan 2024 21:15, KO Myung-Hun wrote: >> Mike Frysinger wrote: >>> On 15 Oct 2023 02:04, KO Myung-Hun wrote: Some OSes such as OS/2, uses ';' as a path separator. So using $PATH_SEPARATOR instead of

Re: [PATCH 2/3] Fix ChangeLog.old encoding

2024-01-16 Thread Antonin Décimo
Le dim. 14 janv. 2024 à 06:34, Mike Frysinger a écrit : > > On 23 Nov 2023 09:44, Antonin Décimo wrote: > > Copyright-paperwork-exempt: Yes > > --- > > ChangeLog.old | 10 +- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/ChangeLog.old b/ChangeLog.old > > index

[patch #10393] Fix shared library support on Android

2024-01-16 Thread Ileana Dumitrescu
Update of patch#10393 (group libtool): Status:None => Done Open/Closed:Open => Closed ___ Follow-up Comment #1: I went ahead and

Re: [PATCH 02/12] libtool.m4: Rename the --with-sysroot option to avoid conflict with gcc/binutils

2024-01-16 Thread Richard Purdie
Somehow my original reply ended up blank, sorry. I've retyped it from memory as best I can. On Mon, 2024-01-15 at 20:08 -0500, Mike Frysinger wrote: > On 25 Oct 2021 15:33, Richard Purdie wrote: > > This patch renames the --with-sysroot option to --with-libtool-sysroot > > to avoid namespace

Re: [PATCH 02/12] libtool.m4: Rename the --with-sysroot option to avoid conflict with gcc/binutils

2024-01-16 Thread Richard Purdie