Ralf Wildenhues wrote:
> I don't see a need to skip the test elsewhere. Here's what I'd do:
> transform $LIBTOOL to have CFLAGS and LTCFLAGS also contain -std=c89
> -Werror. (The test would be even cleaner with a re-configured libtool,
> but let's not go overboard here.)
Being a total novice wi
On Wed, 21 Jan 2009, Ralf Wildenhues wrote:
We may need to think about speeding up func_to_host_path, e.g., by not
forking for arguments that don't need conversion, or by converting
several paths with a constant amount of forks. But that can be done
separately.
There is also the possibility o
Ralf Wildenhues wrote:
> OK so it seems there are more voices for spaces.
> Can we agree to make the switch only after 2.2.8 though,
> I would like to avoid unnecessary churn ATM.
Works for me.
--
Chuck
* Charles Wilson wrote on Wed, Jan 21, 2009 at 11:11:22PM CET:
> Ralf Wildenhues wrote:
>
> > We may need to think about speeding up func_to_host_path, e.g., by not
> > forking for arguments that don't need conversion, or by converting
> > several paths with a constant amount of forks. But that c
* Charles Wilson wrote on Tue, Jan 20, 2009 at 07:29:52PM CET:
> Bob Friesenhahn wrote:
> > For many years I have had my editor configured to always use
> > spaces. This ensures WYSIWYG for everyone involved.
>
> Agree 100%. I try to manually match whatever sp/tab convention is in
> place -- usin
Ralf Wildenhues wrote:
> We may need to think about speeding up func_to_host_path, e.g., by not
> forking for arguments that don't need conversion, or by converting
> several paths with a constant amount of forks. But that can be done
> separately.
FWIW, as part of re-writing this:
[PATCH] [cygw
* Peter Rosin wrote on Tue, Jan 20, 2009 at 12:34:57AM CET:
> Den 2009-01-19 21:35 skrev Ralf Wildenhues:
>> This looks a bit hackish. We already have a handful of places which we
>> fixed up in order to avoid line ending issues. This one looks hackish
>> enough to deserve being wrapped in a macr
* Robert Millan wrote on Tue, Jan 20, 2009 at 11:09:06AM CET:
>
> Btw, do you expect a new release soon?
Hopefully in the not too distant future; we cannot promise any time
frame, though. There are a few issues to address yet.
Cheers,
Ralf
Hi Peter,
* Peter Rosin wrote on Wed, Jan 21, 2009 at 02:26:36AM CET:
> This patch together with [1] and [2] will make "Run tests with
> low max_cmd_len" on MSYS/MSVC behave the same as the individual
> tests.
>
> The patch fixes a couple more of the /abs/path issues already
> fixed in [1] and [2]
* Charles Wilson wrote on Wed, Jan 21, 2009 at 10:10:08PM CET:
> Ralf Wildenhues wrote:
> > Part (1) is easy to review: it is obvious that regressions are very
> > unlikely to be system-dependent. One does get the impression that it
> > might just be more efficient to let libtool save the cwrapper
Ralf Wildenhues wrote:
> Part (1) is easy to review: it is obvious that regressions are very
> unlikely to be system-dependent. One does get the impression that it
> might just be more efficient to let libtool save the cwrapper text
> somewhere and the program just cat that. But still, this part
Ralf Wildenhues wrote:
> * Charles Wilson wrote on Wed, Jan 21, 2009 at 08:47:42PM CET:
>> Part of my tendency to include minor -- easy to review -- changes with
>> larger ones is due to (a) see it, fix it, otherwise it'll be forgotten
>> and (b) EVERY separate patchset requires an independent full
* Charles Wilson wrote on Wed, Jan 21, 2009 at 08:47:42PM CET:
> Ralf Wildenhues wrote:
> > I am very sorry that reviewing takes so long. Mostly this is due to
> > time constraints on my side.
>
> On the plus side, your reviews are usually insightful, and lead to ideas
> for better code, like the
Charles Wilson wrote:
Reviewing my own submission...
> (func_cygming_dll_for_implib_core): New function.
This function is actually called
func_cygming_dll_for_implib_fallback_core
Need to correct log history.
> (func_cygming_implib_p): New function.
Confusing. There is already a func_win32_impli
Ralf Wildenhues wrote:
> I am very sorry that reviewing takes so long. Mostly this is due to
> time constraints on my side.
On the plus side, your reviews are usually insightful, and lead to ideas
for better code, like the libfile_$(transliterated implib name) thing.
> You can make things easier
Hello Charles,
* Charles Wilson wrote on Wed, Jan 21, 2009 at 04:21:01PM CET:
> Thanks, Peter; your validation on msvc is useful and encouraging. Now
> I'm just waiting for a go/no-go from one of the four libtool
> maintainers: Gary Vaughan, Peter O'Gorman, Ralf Wildenhues, or Bob
> Friesenhahn.
Charles Wilson wrote:
> Test suite on cygwin/native in progress. Assumming test suite passes, OK?
> Comments, Review, Discussion?
All tests pass (cygwin/native):
Old suite:
===
All 113 tests passed
(11 tests were not run)
===
New suite:
76 tests behaved as
On Tue, 20 Jan 2009, Charles Wilson wrote:
libltdl/config/ltmain.m4sh (func_generate_dlsyms): Correct
case pattern for cygwin.
---
Ok to push?
Looks fine to me.
Bob
libltdl/config/ltmain.m4sh |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libltdl/config/ltmain.m4s
Peter Rosin wrote:
> Den 2009-01-16 15:15 skrev Charles Wilson:
>> Charles Wilson wrote:
>>> Charles Wilson wrote:
* libltdl/config/ltmain.m4sh: Update copyright date.
(func_emit_wrapper_part1): move contents to...
(func_emit_wrapper_part2): move contents to...
(func_emit_wrappe
* libltdl/config/general.m4sh: Update copyright year.
(func_tr_sh): New function.
* libltdl/config/ltmain.m4sh (func_generate_dlsyms) [cygwin|mingw]:
Obtain DLL name corresponding to import library by using value
stored in unique variable libfile_$(transliterated implib name).
If that fails, use $s
Ralf Wildenhues wrote:
> * Charles Wilson wrote on Tue, Jan 20, 2009 at 11:31:43PM CET:
>> libltdl/config/ltmain.m4sh (func_generate_dlsyms): Correct
>> case pattern for cygwin.
>> ---
>> Ok to push?
>
> Yes, thanks!
Pushed.
--
Chuck
21 matches
Mail list logo
