testsuite performance (was: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.)

2009-01-22 Thread Ralf Wildenhues
* Charles Wilson wrote on Wed, Jan 21, 2009 at 08:47:42PM CET: [...] EVERY separate patchset requires an independent full testsuite run. Until recently, that was 5 hours of sitting in front of my computer waiting for popups, while that computer was completely useless for anything else (100%

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-22 Thread Charles Wilson
Charles Wilson wrote: The bits removed from this commit are attached as cygwin-cwrapper-cleanups.patch. Will start a new thread with these cleanups. -- Chuck

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-21 Thread Charles Wilson
Peter Rosin wrote: Den 2009-01-16 15:15 skrev Charles Wilson: Charles Wilson wrote: Charles Wilson wrote: * libltdl/config/ltmain.m4sh: Update copyright date. (func_emit_wrapper_part1): move contents to... (func_emit_wrapper_part2): move contents to... (func_emit_wrapper): here.

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-21 Thread Ralf Wildenhues
* Charles Wilson wrote on Wed, Jan 21, 2009 at 08:47:42PM CET: Ralf Wildenhues wrote: I am very sorry that reviewing takes so long. Mostly this is due to time constraints on my side. On the plus side, your reviews are usually insightful, and lead to ideas for better code, like the

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-21 Thread Charles Wilson
Ralf Wildenhues wrote: * Charles Wilson wrote on Wed, Jan 21, 2009 at 08:47:42PM CET: Part of my tendency to include minor -- easy to review -- changes with larger ones is due to (a) see it, fix it, otherwise it'll be forgotten and (b) EVERY separate patchset requires an independent full

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-21 Thread Charles Wilson
Ralf Wildenhues wrote: Part (1) is easy to review: it is obvious that regressions are very unlikely to be system-dependent. One does get the impression that it might just be more efficient to let libtool save the cwrapper text somewhere and the program just cat that. But still, this part is

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-21 Thread Ralf Wildenhues
* Charles Wilson wrote on Wed, Jan 21, 2009 at 10:10:08PM CET: Ralf Wildenhues wrote: Part (1) is easy to review: it is obvious that regressions are very unlikely to be system-dependent. One does get the impression that it might just be more efficient to let libtool save the cwrapper text

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-21 Thread Charles Wilson
Ralf Wildenhues wrote: I don't see a need to skip the test elsewhere. Here's what I'd do: transform $LIBTOOL to have CFLAGS and LTCFLAGS also contain -std=c89 -Werror. (The test would be even cleaner with a re-configured libtool, but let's not go overboard here.) Being a total novice with

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-16 Thread Charles Wilson
Charles Wilson wrote: Charles Wilson wrote: * libltdl/config/ltmain.m4sh: Update copyright date. (func_emit_wrapper_part1): move contents to... (func_emit_wrapper_part2): move contents to... (func_emit_wrapper): here. (func_emit_cwrapperexe_src) [file scope]: re-organized includes and

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-16 Thread Peter Rosin
Den 2009-01-16 15:15 skrev Charles Wilson: Charles Wilson wrote: Charles Wilson wrote: * libltdl/config/ltmain.m4sh: Update copyright date. (func_emit_wrapper_part1): move contents to... (func_emit_wrapper_part2): move contents to... (func_emit_wrapper): here. (func_emit_cwrapperexe_src) [file

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-08 Thread Charles Wilson
Charles Wilson wrote: * libltdl/config/ltmain.m4sh: Update copyright date. (func_emit_wrapper_part1): move contents to... (func_emit_wrapper_part2): move contents to... (func_emit_wrapper): here. (func_emit_cwrapperexe_src) [file scope]: re-organized includes and portability macros. Avoid

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-04 Thread Charles Wilson
Roumen Petrov wrote: Charles Wilson wrote: [SNIP] This patch attempts to correct the issues raised in this thread: msys/mingw warnings about string length and putenv absence with gcc -Wall -ansi http://lists.gnu.org/archive/html/bug-libtool/2008-12/msg00038.html [SNIP] Patch fail for

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-04 Thread Roumen Petrov
Charles Wilson wrote: [SNIP] This patch attempts to correct the issues raised in this thread: msys/mingw warnings about string length and putenv absence with gcc -Wall -ansi http://lists.gnu.org/archive/html/bug-libtool/2008-12/msg00038.html [SNIP] Patch fail for trunk(origin): $ patch -p1

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-04 Thread Roumen Petrov
Charles Wilson wrote: Now I get completely new working cross-environment: git show correctly modified files, patch work too :) . [SNIP] No regressions on msys/mingw from the last time I ran the testsuite on that platform (2.2.5a). IOW: Old testsuite results: [SNIP] No regression on

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-03 Thread Charles Wilson
Charles Wilson wrote: Spot checked some regression tests on cygwin (all passed). Running full regression suite on mingw. OK to push, pending testsuite results? No regressions on msys/mingw from the last time I ran the testsuite on that platform (2.2.5a). IOW: Old testsuite results:

[PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

2009-01-02 Thread Charles Wilson
* libltdl/config/ltmain.m4sh: Update copyright date. (func_emit_wrapper_part1): move contents to... (func_emit_wrapper_part2): move contents to... (func_emit_wrapper): here. (func_emit_cwrapperexe_src) [file scope]: re-organized includes and portability macros. Avoid oldnames on MINGW32 and MSVC