On Mon, 15 Oct 2012 22:58:01 -0400, Pete Batard said:
On 15 October 2012 12:15, Sean McBride s...@rogue-research.com wrote:
3) Look at how other software that uses -Wcast-align handles the same issue.
I'm not exactly sure what you're asking...
I was suggesting that, before we do anything, we
On Mon, 15 Oct 2012 20:47:01 -0700, Orin Eman said:
There is also an argument for changing the buffer parameters to
libusb_fill_control_setup() and libusb_fill_control_transfer() to struct
libusb_control_setup *, but I'm just tossing that in for the record.
Absolutely. The cast they are doing
On Fri, 12 Oct 2012 23:25:14 +0100, Pete Batard said:
On 2012.10.12 22:06, Sean McBride wrote:
3) ???
3) Look at how other software that uses -Wcast-align handles the same issue.
There's probably hardly any piece of significant C code out there that's
not going to cast a char* to struct*,
On Mon, 15 Oct 2012 09:56:29 -0700, Orin Eman said:
1) making libusb_control_transfer_get_setup not inline, so it's iffy cast
is hidden in a .c file
That should wait for the next API break as it would change the binary
interface.
By adding a new exported symbol you mean? Of course removing
On 15 October 2012 12:15, Sean McBride s...@rogue-research.com wrote:
3) Look at how other software that uses -Wcast-align handles the same issue.
I'm not exactly sure what you're asking...
I was suggesting that, before we do anything, we look at what projects that:
1. Chose to use -Wcast-align
On Mon, Oct 15, 2012 at 7:58 PM, Pete Batard p...@akeo.ie wrote:
On 15 October 2012 12:15, Sean McBride s...@rogue-research.com wrote:
3) Look at how other software that uses -Wcast-align handles the same
issue.
I'm not exactly sure what you're asking...
I was suggesting that, before we
On 2012.10.12 22:06, Sean McBride wrote:
3) ???
3) Look at how other software that uses -Wcast-align handles the same issue.
There's probably hardly any piece of significant C code out there that's
not going to cast a char* to struct*, so, if any has switched to using
-Wcast-align, we might