Re: [Libva] [PATCH] avcenc.c: use multi-slice encoding

2012-08-22 Thread Sean V Kelley
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 What are you using to test/validate? Any additional description? Sean On 08/22/2012 08:04 AM, Haitao Huang wrote: Change-Id: Ibb5e03ddb6165aeb298a2960d369cb22fa948453 Signed-off-by: Haitao Huang haitao.hu...@intel.com --- test/encode/avcenc.c |

Re: [Libva] [PATCH 0/6] VP8 decoding APIs

2014-02-20 Thread Sean V Kelley
/mailman/listinfo/libva -- Sean V. Kelley sean.v.kel...@intel.com Open Source Technology Center / SSG Intel Corp. ___ Libva mailing list Libva@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libva

Re: [Libva] [PATCH 1/2] va: User specified tiling and stride support.

2014-03-17 Thread Sean V Kelley
___ Libva mailing list Libva@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libva ___ Libva mailing list Libva@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libva -- Sean V. Kelley sean.v.kel

Re: [Libva] [PATCH] Encoding: Reinitialize CBR bit rate-control parameter to support switch of bitrate under CBR

2014-06-10 Thread Sean V Kelley
Tested-By: Sean V Kelley sean.v.kel...@intel.com Thanks Yakui for your help. Sean On Mon, Jun 9, 2014 at 11:24 PM, Zhao, Yakui yakui.z...@intel.com wrote: From: Zhao, Yakui yakui.z...@intel.com Signed-off-by: Zhao Yakui yakui.z...@intel.com --- src/gen6_mfc.h| 6 ++ src

Re: [Libva] [PATCH] Added hybrid driver to the supported list

2014-08-22 Thread Sean V Kelley
lgtm Tested-by: Sean V Kelley sean.v.kel...@intel.com On Fri, Aug 22, 2014 at 3:47 PM, Kibey, Sameer sameer.ki...@intel.com wrote: Added OTC hybrid driver to the list of supported drivers. This will be used for hybrid codecs like VP8 h-encode. Signed-off-by: Sameer Kibey sameer.ki

Re: [Libva] [PATCH 0/7] Build and symbol visibility fixes

2014-09-18 Thread Sean V Kelley
On Thursday 18 Sep 2014 at 17:30:25 (+0100), Emil Velikov writes : Hello all, Decided to give latest libva a go and then chaos... Out ot tree builds did not work and after fixing those some files were left around (spotted by 'make distcheck'). Hi Emil, Thanks for the submission. Could

Re: [Libva] [PATCH 0/7] Build and symbol visibility fixes

2014-09-18 Thread Sean V Kelley
On Thu, Sep 18, 2014 at 10:23 AM, Emil Velikov emil.l.veli...@gmail.com wrote: On 18/09/14 18:05, Sean V Kelley wrote: On Thursday 18 Sep 2014 at 17:30:25 (+0100), Emil Velikov writes : Hello all, Decided to give latest libva a go and then chaos... Out ot tree builds did not work and after

Re: [Libva] [PATCH 1/2] Use the inline CPUID assembly to obtain CPUID string instead of /proc/cpuinfo

2014-09-24 Thread Sean V Kelley
list Libva@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libva -- Sean V. Kelley sean.v.kel...@intel.com Open Source Technology Center / SSG Intel Corp. ___ Libva mailing list Libva@lists.freedesktop.org http

Re: [Libva] [PATCH 0/2] Add support for DRM Render-Nodes

2014-09-24 Thread Sean V Kelley
lgtm Much needed I might add for general enabling and debugging. Reviewed-by: Sean V Kelley sean.v.kel...@intel.com Sean On Wed, Sep 24, 2014 at 1:40 AM, Gwenole Beauchesne gb.de...@gmail.com wrote: Hi, This patch series adds support for DRM Render-Nodes through the existing

Re: [Libva] [PATCH 0/2] Add support for DRM Render-Nodes

2014-09-25 Thread Sean V Kelley
On Thursday 25 Sep 2014 at 15:48:21 (+0200), Gwenole Beauchesne writes : Hi, 2014-09-24 17:31 GMT+02:00 Sean V Kelley sean.v.kel...@intel.com: lgtm Much needed I might add for general enabling and debugging. Reviewed-by: Sean V Kelley sean.v.kel...@intel.com Now pushed to the git

Re: [Libva] [PATCH 0/7] Build and symbol visibility fixes

2014-09-29 Thread Sean V Kelley
of the internal symbols from the global namespace. Any input, suggestions and comments are appreciated. Cheers, Emil -- Sean V. Kelley sean.v.kel...@intel.com Open Source Technology Center / SSG Intel Corp. ___ Libva mailing list Libva@lists.freedesktop.org

Re: [Libva] VP8 accelerated on N2807 ?

2014-12-15 Thread Sean V Kelley
) 972308334 Mobile : +33(0) 624808051 -- 2014-07-07 21:59 GMT+02:00 Sean V Kelley sean.v.kel...@intel.com: Hi Michel, VP8 on Baytrail is not based around the GEN GPU Media pipeline

Re: [Libva] [libva][libva-intel-driver PATCH] Use VMask instead of DMask in 3DSTATE_PS on GEN8+

2015-02-02 Thread Sean V Kelley
ltgm Reviewed-by: Sean V Kelley sean.v.kel...@intel.com On Mon, Feb 2, 2015 at 12:16 AM, Xiang, Haihao haihao.xi...@intel.com wrote: Mesa uses VMask instead of DMask in 3DSTATE_PS. Initialize the execution mask with VMask. Otherwise, derivatives are incorrect for subspans where some

Re: [Libva] [libva][libva-intel-driver PATCH] Disable upper bound check for decoding on BDW+

2015-02-02 Thread Sean V Kelley
lgtm Reviewed-by: Sean V Kelley sean.v.kel...@intel.com On Mon, Feb 2, 2015 at 12:16 AM, Xiang, Haihao haihao.xi...@intel.com wrote: We saw pixel corruption in stress test with the wrong up-bound address. For simplicity, disable upper bound check in the driver. Signed-off-by: Xiang, Haihao

Re: [Libva] [PATCH] libva-intel-driver: Implement max width and height in QuerySurfaceAttributes

2015-02-03 Thread Sean V Kelley
On 02/03/2015 02:15 PM, Gwenole Beauchesne wrote: Hi, 2015-02-03 22:11 GMT+01:00 Sean V Kelley sea...@posteo.de: From: Heng-ruey Hsu henry...@chromium.org With this, we can get hardware supported resolution for video encode and decode. This CL is used to prepare GetSupportedResolution

Re: [Libva] [PATCH v2 00/12] VP8 HW encoder enabling

2015-01-14 Thread Sean V Kelley
: Alloc larger internal buffers VP8 HWEnc: Fix the coded buffer size error issue VP8 HWEnc: Check loop filter paramter VP8 HWEnc: Take num_token_partitions as log2_num lgtm, reviewed tested on BSW C0 Step Reviewed-by: Sean V Kelley sea...@posteo.de Tested-by: Sean V Kelley sea...@posteo.de

Re: [Libva] [PATCH v2 07/12] VP8 HWEnc: declare copyright and license of vp8_probs.h

2015-01-14 Thread Sean V Kelley
VP8_PROBS_H #define VP8_PROBS_H -- 1.9.1 ___ Libva mailing list Libva@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libva -- Sean V. Kelley sean.v.kel...@intel.com Open Source Technology Center / SSG Intel Corp

[Libva] [PATCH] Add support for HEVC decoding on CHV

2015-02-18 Thread Sean V Kelley
We can re-use SKL HEVC decode pipeline Signed-off-by: Sean V Kelley sea...@posteo.de Cc: haihao.xi...@intel.com Cc: focus@intel.com --- src/i965_device_info.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/i965_device_info.c b/src/i965_device_info.c index

Re: [Libva] [PATCH] vpp: use single path conversion if no scaling is required

2015-03-20 Thread Sean V Kelley
seems like a good base to handle more fast paths. Thanks, - Lionel ___ Libva mailing list Libva@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libva -- Sean V. Kelley sean.v.kel...@intel.com Open Source Technology Center

Re: [Libva] [PATCH] vpp: use single path conversion if no scaling is required

2015-03-20 Thread Sean V Kelley
= obj_surface-orig_width; in_height = obj_surface-orig_height; dri_bo_get_tiling(obj_surface-bo, tiling, swizzle); -- 2.1.4 ___ Libva mailing list Libva@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libva -- Sean V

Re: [Libva] [PATCH libva-intel-driver] gen8_mfd: free surface used by JPEG decode

2015-05-20 Thread Sean V Kelley
On May 19, 2015, at 17:36, Eoff, Ullysses A ullysses.a.e...@intel.com wrote: On Tue, 2015-05-19 at 15:30 -0700, Sean V Kelley wrote: Artie, On May 19, 2015, at 14:59, U. Artie Eoff ullysses.a.e...@intel.com wrote: This is a follow up to previous commit: commit

Re: [Libva] [PATCH libva-intel-driver] gen8_mfd: free surface used by JPEG decode

2015-05-19 Thread Sean V Kelley
Artie, On May 19, 2015, at 14:59, U. Artie Eoff ullysses.a.e...@intel.com wrote: This is a follow up to previous commit: commit 8dda0650b55c467200c34ada127b5d9b54edea5c Author: Zhao Yakui yakui.z...@intel.com Date: Tue May 5 17:56:38 2015 +0800 Please resubmit your patch, with you

Re: [Libva] [PATCH] test/decode/tinyjpeg: make sure the pointer is valid before dereferencing it

2015-06-10 Thread Sean V Kelley
On Jun 9, 2015, at 23:41, Xiang, Haihao haihao.xi...@intel.com wrote: Signed-off-by: Xiang, Haihao haihao.xi...@intel.com lgtm, thanks. Sean --- test/decode/tinyjpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/decode/tinyjpeg.c b/test/decode/tinyjpeg.c

Re: [Libva] [PATCH v4 1/9] st/va: properly defines VAImageFormat formats and improve VaCreateImage

2015-10-29 Thread Sean V Kelley
PIPE_FORMAT_B8G8R8A8_UNORM: > + return VA_FOURCC('B','G','R','A'); > + case PIPE_FORMAT_R8G8B8A8_UNORM: > + return VA_FOURCC('R','G','B','A'); > + case PIPE_FORMAT_B8G8R8X8_UNORM: > + return VA_FOURCC('B','G','R','X'); > + case PIPE_FORMAT_R8G8B8X8_UNORM: >

Re: [Libva] [PATCH v4 1/9] st/va: properly defines VAImageFormat formats and improve VaCreateImage

2015-10-29 Thread Sean V Kelley
Hi Julien, On Thu, Oct 29, 2015 at 10:34 AM, Julien Isorce <julien.iso...@gmail.com> wrote: > > > On 29 October 2015 at 17:22, Sean V Kelley <sean.v.kel...@intel.com> > wrote: > >> >> >> On Thu, Oct 29, 2015 at 9:53 AM, Julien Isorce <j.iso...@s

Re: [Libva] libva master vs staging

2015-11-10 Thread Sean V Kelley
___ > Libva mailing list > Libva@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libva > > -- Sean V. Kelley <sean.v.kel...@intel.com> Open Source Technology Center / SSG Intel Corp. ___ Libva mailing list Libva@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libva

Re: [Libva] [PATCH 5/7] vpp: gen8/9: send yuv to rgb coefs

2015-11-09 Thread Sean V Kelley
lgtm On 11/04/2015 07:27 AM, Lionel Landwerlin wrote: > --- src/gen8_post_processing.c | 8 1 file changed, 8 > insertions(+) > > diff --git a/src/gen8_post_processing.c > b/src/gen8_post_processing.c index 569232d..1fbc317 100644 --- > a/src/gen8_post_processing.c +++

Re: [Libva] [PATCH 4/7] vpp: gen7: send yuv to rgb coefs

2015-11-09 Thread Sean V Kelley
lgtm On 11/04/2015 07:27 AM, Lionel Landwerlin wrote: > --- src/i965_post_processing.c | 8 1 file changed, 8 > insertions(+) > > diff --git a/src/i965_post_processing.c > b/src/i965_post_processing.c index e1d96d4..ea3d350 100755 --- > a/src/i965_post_processing.c +++

Re: [Libva] [PATCH 6/7] shaders: vpp: gen7: use yuv to rgb matrix to compute rgb values

2015-11-09 Thread Sean V Kelley
On 11/05/2015 02:22 AM, Lionel Landwerlin wrote: > On 05/11/15 00:31, Zhao Yakui wrote: >> On 11/04/2015 11:27 PM, Lionel Landwerlin wrote: >>> --- >>> src/shaders/post_processing/gen7/YUV_to_RGB.g4a | 626 >>> -- >>> src/shaders/post_processing/gen7/pl2_to_rgbx.g75b |

Re: [Libva] [v2] Add coefficients yuv to rgb conversion

2015-11-09 Thread Sean V Kelley
On 11/04/2015 07:27 AM, Lionel Landwerlin wrote: > Just an update, > > Collapsed the 3 patches shifting registers and factorized out more > of the yuv to rgb coefficients. > Applied less the gitignore change, thanks. For Chromium, we are not going to be cutting a release right away. So I

Re: [Libva] [PATCH] shaders: gen[789]: fix Y coefficient in YUV->RGB conversion

2015-10-20 Thread Sean V Kelley
> On Oct 20, 2015, at 9:48 AM, Lionel Landwerlin > wrote: > > In the following formula for the conversion : > > R = Clamp ( 1.164(Y-16/255) + 1.596(Cr-128/255)) > G = Clamp ( 1.164(Y-16/255) - 0.813(Cr-128/255) - 0.392(Cb-128/255)) > B = Clamp ( 1.164(Y-16/255)

Re: [Libva] [PATCH 1/2] test/encode: remove unused variables and functions

2015-09-16 Thread Sean V Kelley
+Haihao, Yakui Can you comment on what appears to be code brought in from h264encode that isn't being exercised? There are two things here I want to understand: 1) Brought in from h264encode, oversight? 2) Commented out for specific manual testing or not? I want to hold off on this merge until

Re: [Libva] [PATCH] driver_name_map: add nouveau and radeon for Mesa Gallium

2015-12-03 Thread Sean V Kelley
Hi Julien, On 11/27/2015 12:53 AM, Julien Isorce wrote: > This patch allows va_getDriverName to succeed. It is useful in > vaInitialize to select the vaapi driver provided by Mesa Gallium: > lib/dri/gallium_drv_video.so > > Signed-off-by: Julien Isorce --- >

Re: [Libva] [PATCH] driver_name_map: add nouveau and radeon for Mesa Gallium

2015-12-09 Thread Sean V Kelley
ver> for some comparisons. > Christian would be able to give more details about it. But in long terms I > think this bridge will be only used by the Nvidia proprietary driver (unless > they decide to provide a vaapi backend too) I’m happy to add both to the backend, but I would like

Re: [Libva] [PATCH] st/va: retrieve size from the temporary img variable

2015-12-15 Thread Sean V Kelley
> On Dec 15, 2015, at 1:01 AM, Julien Isorce wrote: > > "image" is not ready yet since it will be set at > the end of the function by: *image = *img; > > Signed-off-by: Julien Isorce > --- > src/gallium/state_trackers/va/image.c | 2 +- > 1 file

Re: [Libva] [PATCH V1][libva] fix check NULL issues

2016-05-27 Thread Sean V Kelley
On 05/26/2016 10:16 PM, peng.chen wrote: > v2: > code clean up > > v1: > initial > > Signed-off-by: peng.chen Thanks applied. Sean > --- > va/va_trace.c | 19 --- > 1 file changed, 16 insertions(+), 3 deletions(-) > > diff --git a/va/va_trace.c

Re: [Libva] [Libva-intel-driver][PATCH] Update PCI IDs for Kabylake

2016-06-24 Thread Sean V Kelley
On 06/23/2016 07:04 PM, Xiang, Haihao wrote: > Remove unused PCI IDs and add new PCI IDs for KBL, the IDs are taken > directly from intel-gfx patches, which are under review: > > https://lists.freedesktop.org/archives/intel-gfx/2016-June/099263.html >

Re: [Libva] VAAPI issues with OpenGL 3.1 and above

2016-03-01 Thread Sean V Kelley
Could you file a bug at freedesktop.org?  You can attach your patch there too along with details on the issue. https://bugs.freedesktop.org/enter_bug.cgi?product=libva Thanks, Sean On Tue, 2016-03-01 at 09:47 -0800, Cyril Drouet wrote: > Hello, > > I successfully implemented hardware decoding

Re: [Libva] [PATCH libva 1/2] trace: Add `va_TracePrint`, `va_TraceVPrint` static functions

2016-05-22 Thread Sean V Kelley
On 05/17/2016 03:29 PM, Scott D Phillips wrote: > These functions are similar to va_TraceMsg() but without emitting > a timestamp. > > Signed-off-by: Scott D Phillips lgtm. applied, thanks. Sean > --- > va/va_trace.c | 50

Re: [Libva] [Libva-intel-driver][PATCH] Don't check WAYLAND_SCANNER if wayland isn't used or found

2016-05-04 Thread Sean V Kelley
On Thu, 2016-05-05 at 01:48 +0800, Xiang, Haihao wrote: > checking for WAYLAND... no > checking for LIBVA_WAYLAND_DEPS... no > checking for pkg-config... (cached) /usr/bin/pkg-config > checking pkg-config is at least version 0.9.0... yes > checking for WAYLAND_SCANNER... no > configure: error:

Re: [Libva] [Libva-intel-driver][PATCH] libdrm 2.4.52 is required to avoid the compiler error

2016-05-04 Thread Sean V Kelley
On Thu, 2016-05-05 at 01:48 +0800, Xiang, Haihao wrote: >   CC   i965_drv_video_la-intel_batchbuffer.lo > intel_batchbuffer.c: In function 'intel_batchbuffer_emit_reloc64': > intel_batchbuffer.c:183:24: error: 'drm_intel_bo' has no member named > 'offset64' > uint64_t offset = bo->offset64

Re: [Libva] [Libva-intel-driver][PATCH] Fix the condition used in 'else if()'

2016-07-14 Thread Sean V Kelley
gt;fourcc == VA_FOURCC_P010) { > >/* Nothing to do here */ > } else { > -- > 2.8.3 > > _______ > Libva mailing list > Libva@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/libva > -- Sean V. Kelley <sean.v.kel...@intel.com>

Re: [Libva] [Libva-intel-driver][PATCH 2/2] Encode: Set cost for MODE_CHROMA_INTRA/MODE_REFID_COST

2016-07-29 Thread Sean V Kelley
On Mon, 2016-07-25 at 16:53 +0800, Xiang, Haihao wrote: > > This fixes the remaining issues mentioned in https://bugs.freedesktop .org/show_bug.cgi?id=96703 > after applying commit 3699c14 > > > On GEN75+, driver copies vme_context->vme_state_message to VME kernel curbe buffer and > > VME kernel

Re: [Libva] [Libva-intel-driver][PATCH 1/2] Encode: Clear right and bottom border of NV12 surface to avoid run2run issue

2016-07-29 Thread Sean V Kelley
On Mon, 2016-07-25 at 16:53 +0800, Xiang, Haihao wrote: > > From: XuGuangxin > > > This fixes some issues mentioned in https://bugs.freedesktop.org/show _bug.cgi?id=96703 Reviewed, tested. Thanks applied.   > > Signed-off-by: Xu Guangxin ---

[Libva] Libyami and Libyami-utils added to Archlinux AUR

2016-07-29 Thread Sean V Kelley
/libyami/ https://aur.archlinux.org/packages/libyami-utils/ Thanks, Sean -- Sean V. Kelley <sean.v.kel...@intel.com> Open Source Technology Center / SSG Intel Corp. ___ Libva mailing list Libva@lists.freedesktop.org https://lists.freedesktop.org/m

Re: [Libva] [PATCH][libva-intel-driver] i965_encoder: return a failing status

2016-07-29 Thread Sean V Kelley
On Thu, 2016-07-28 at 17:11 -0700, Daniel Charles wrote: > VAStatus when calling vme_pipeline was silently failing > > > Signed-off-by: Daniel Charles Thanks, applied. Sean > --- src/i965_encoder.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

Re: [Libva] [PATCH] i965_device_info: add CBR and VBR rate control flags for vdenc

2016-08-11 Thread Sean V Kelley
On Thu, 2016-08-11 at 14:55 +0300, sreerenj.balachand...@intel.com wrote: > > From: Sreerenj Balachandran > > Low power encode through VDENC supports both CBR and VBR. > Make sure vaGetConfigAttribute correctly returns the supported > list of rate control modes

Re: [Libva] [PATCH] i965_device_info: add CBR and VBR rate control flags for vdenc

2016-08-12 Thread Sean V Kelley
On Fri, 2016-08-12 at 16:20 +0300, Sreerenj wrote: > > > On 12.08.2016 14:20, Sreerenj wrote: > > > > > > On 11.08.2016 19:47, Sean V Kelley wrote: > > > > > > > > > On Thu, 2016-08-11 at 14:55 +0300, sreerenj.balachand...@intel

Re: [Libva] [Libva-intel-driver][PATCH] Set cost for modes used for VP8 encoding

2016-08-04 Thread Sean V Kelley
On Wed, 2016-08-03 at 16:43 +0800, Xiang, Haihao wrote: > This is similar to what commit 1cd6795 does lgtm, applied. Thanks, Sean > > > Signed-off-by: Xiang, Haihao Tested-by: Wang, Fei W --- src/gen6_mfc_common.c | 11 +++ 1 file

Re: [Libva] [PATCH][libva-intel-driver] i965_encoder: remove double check for VAStatus result

2016-08-15 Thread Sean V Kelley
On Mon, 2016-08-15 at 10:49 -0700, Daniel Charles wrote: > after creating underlying surface there's a double check on the > VAStatus result. Removed assert as it was part of the code when > the function didn't return vaStatus > > Signed-off-by: Daniel Charles > --- >  

[Libva] Mailing list moving to a new site: https://lists.01.org/mailman/listinfo/intel-vaapi-media

2017-01-26 Thread Sean V Kelley
to the new list at your leisure. This list will remain in archive form. It will shortly become read only, and members will be mass unsubscribed with this same message suggesting to subscribe at the new site. Thanks, Sean -- Sean V. Kelley <sean.v.kel...@intel.com <https://mail.google.co

Re: [Libva] libyami 1.1.0 release

2017-01-21 Thread Sean V Kelley
On Friday, January 20, 2017 10:33:03 PM PST you wrote: > On Friday, January 20, 2017 1:32:36 AM PST Xu, Guangxin wrote: > > Hi all: > > > > Libyami 1.1.0 released. You can get the code at > > https://github.com/01org/libyami/releases/tag/libyami-1.1.0 > >

Re: [Libva] [LIBVA-INTEL-DRIVER PATCH 1/5] H264 Encoding:Free aux_batchbuffer to configure access domain correctly for PAK_OBJ command buffer

2017-01-17 Thread Sean V Kelley
On Tue, 2017-01-17 at 08:40 +0800, Zhao Yakui wrote: > The access domain is not configured correctly for PAK_OBJ command > buffer. > And it causes that the buffer content is not synchronized correctly. > > At the same time the 64-byte is aligned for the boundary between > CPU and GPU access

[Libva] [PATCH] libva-intel-driver: fix i965 encoder wrong bits shift operation

2017-01-17 Thread Sean V Kelley
result is, the position of NALU start code (0x0001) looks like overwritten by garbage value. Patch has been tested and used upstream: https://chromium-review.googlesource.com/#/c/410541/ Signed-off-by: Kuang-che Wu <k...@chromium.org> Signed-off-by: Sean V Kelley <sea...@post

Re: [Libva] [PATCH] libva-intel-driver: fix i965 encoder wrong bits shift operation

2017-01-18 Thread Sean V Kelley
On Tue, Jan 17, 2017 at 6:48 PM, Xiang, Haihao <haihao.xi...@intel.com> wrote: > On Tue, 2017-01-17 at 13:15 -0800, Sean V Kelley wrote: > > From: Kuang-che Wu <k...@chromium.org> > > > > shift uint32_t by 32 bits is undefined behavior. > > &g

[Libva] [PATCH V1] libva-intel-driver: fix i965 encoder wrong bits shift operation

2017-01-18 Thread Sean V Kelley
result is, the position of NALU start code (0x0001) looks like overwritten by garbage value. Patch has been tested and used upstream: https://chromium-review.googlesource.com/#/c/410541/ Signed-off-by: Kuang-che Wu <k...@chromium.org> Signed-off-by: Sean V Kelley <sea...@post

Re: [Libva] [Libva-intel-driver][PATCH] Set the right transform 8x8 flag for Intra macroblock in VME output on BDW+

2016-08-19 Thread Sean V Kelley
On Wed, 2016-08-17 at 09:59 +0800, Xiang, Haihao wrote: > VME message doesn't output the transform 8x8 flag, the shader > set the right flag accordingly. > > Signed-off-by: Xiang, Haihao > Tested-by: Meng, Jia lgtm, applied. thanks, Sean > --- >  

Re: [Libva] [Libva-intel-driver][PATCH 2/2] Encode/VP9: Don't use hardcoded offsets

2016-08-19 Thread Sean V Kelley
On Fri, 2016-08-19 at 10:28 +0800, Zhao Yakui wrote: > On 08/15/2016 10:46 AM, Xiang, Haihao wrote: > > > > codec_private_data in struct i965_coded_buffer_segment is used to > > store > > codec related data. Add 'struct vp9_encode_status' for the data > > that will > > be written into

Re: [Libva] [Libva-intel-driver][PATCH 1/2] Encode/VP9: turn gen9_vp9_get_coded_status() into a local function

2016-08-19 Thread Sean V Kelley
On Fri, 2016-08-19 at 10:23 +0800, Zhao Yakui wrote: > On 08/15/2016 10:46 AM, Xiang, Haihao wrote: > > > > Set encoder_context->get_status to this local function when > > initializing, > > so that we can fetch VP9 encoding status from the underlying > > context. > > > > This patch changes the

Re: [Libva] [Libva-intel-driver][PATCH] Set cost to 0 for CHROMA INTRA mode

2016-08-19 Thread Sean V Kelley
On Tue, 2016-08-16 at 12:10 +0800, Xiang, Haihao wrote: > Commit 1cd6795 causes quality drop for U/V plane. > > Reported-by: Wang, Fei W > Signed-off-by: Xiang, Haihao > Tested-by: Wang, Fei W Good catch.  lgtm. applied.

Re: [Libva] [PATCH RFC intel-driver 00/11] Automated (Unit) Test Suite

2016-09-02 Thread Sean V Kelley
Hi Yakui, As I mentioned before to Haihao who asked the same question, the focus here is on driver unit testing. The intent is not to test Libva API. That is a separate area. Gtest is intended for the driver as unit tests and a first step in getting CI in place. VA-API conformance is a

Re: [Libva] [PATCH RFC intel-driver 00/11] Automated (Unit) Test Suite

2016-09-02 Thread Sean V Kelley
Hi Yakui, As I mentioned before to Haihao who asked the same question, the focus here is on driver unit testing. The intent is not to test Libva API. That is a separate area. Gtest is intended for the driver as unit tests and a first step in getting CI in place. VA-API conformance is a

Re: [Libva] [PATCH RFC intel-driver 00/11] Automated (Unit) Test Suite

2016-09-07 Thread Sean V Kelley
On Wed, 2016-09-07 at 02:42 +, Xiang, Haihao wrote: > Hi Artie, > > First I applied your patches to the latest master branch, then build > the library and run test with the following steps: > > 1. ./autogen.sh --enable-tests --prefix=/usr -- > libdir=/usr/lib/x86_64- > linux-gnu/ > > 2.  

Re: [Libva] [PATCH 1/3] Merge and modify encoding bit-rate control per temporal layer.

2016-09-13 Thread Sean V Kelley
t; unsigned int framerate; > +union > +{ > +struct > + { > +/* > + * The temporal id the framerate parameters are specified for. > + */ > +unsigned int temporal_id : 8; > +unsi

Re: [Libva] libyami 1.0.0 release

2016-10-04 Thread Sean V Kelley
buffer hasn't been supported > yet, but > > not hard to add it. > > > > > > *From:* Zhao, Halley > *Sent:* Friday, November 28, 2014 2:26 PM > *To:* liby...@lists.01.org > *Cc:* Li, Jocelyn; Kelley, Sean V > *Subject:* libyami 0.1.4 release > > >

Re: [Libva] [PATCH intel-driver] test: add create surface test

2016-10-04 Thread Sean V Kelley
On Mon, 2016-10-03 at 13:21 -0700, U. Artie Eoff wrote: > Add test to verify correct result for create surfaces with > supported and unsupported pixel formats. > > Currently the IYUV pixel format case fails... see > https://bugs.freedesktop.org/show_bug.cgi?id=98033 I've confirmed the failure

Re: [Libva] [Libva-intel-driver][PATCH] Set default framerate to 30fps if user doesn't set the corresponding sequence parameter

2016-10-04 Thread Sean V Kelley
On Wed, 2016-09-28 at 09:04 +0800, Zhao Yakui wrote: > On 09/27/2016 10:49 PM, Xiang, Haihao wrote: > > > > User can update framerate using VAEncMiscParameterTypeFrameRate > > buffer later > > It looks good to me. > > Add: Reviewed-by: Zhao Yakui Sorry Yakui, didn't see

Re: [Libva] [Libva-intel-driver][PATCH] Set default framerate to 30fps if user doesn't set the corresponding sequence parameter

2016-10-04 Thread Sean V Kelley
On Tue, 2016-09-27 at 22:49 +0800, Xiang, Haihao wrote: > User can update framerate using VAEncMiscParameterTypeFrameRate > buffer later I am okay with this.  lgtm, applied. Thanks, Sean > > Signed-off-by: Xiang, Haihao > --- >  src/i965_encoder.c | 7 ++- >  1

Re: [Libva] problem when tiling is disabled on decoded surfaces

2016-10-07 Thread Sean V Kelley
Main:VAEntrypointVLD > VAProfileVC1Advanced:VAEntrypointVLD > VAProfileNone :VAEntrypointVideoProc > VAProfileJPEGBaseline :VAEntrypointVLD > VAProfileVP9Profile0:VAEntrypointVLD > > ___

Re: [Libva] problem when tiling is disabled on decoded surfaces

2016-10-07 Thread Sean V Kelley
On Fri, Oct 7, 2016 at 11:00 AM, Sean V Kelley <sean.v.kel...@intel.com> wrote: > On Thu, Oct 6, 2016 at 1:20 AM, Julien Isorce <julien.iso...@gmail.com> wrote: >> Hi, >> >> In intel vaapi driver I tried disabling tiling with: >> >> --- a/src/i

Re: [Libva] [PATCH intel-driver 0/4] Test Environment and some AVC Enc/Dec Tests

2016-10-06 Thread Sean V Kelley
On Wed, 2016-10-05 at 10:54 -0700, U. Artie Eoff wrote: > This patch series moves the responsibility of the VADisplay creation > and vaInitialize/vaTerminate sequence to a I965TestEnvironment > singleton class.  This environment is added to the GTest global test > environment so that those

Re: [Libva] [Libva-intel-driver][PATCH v3 00/18] Add H.264/SVC-T CBR support

2016-09-16 Thread Sean V Kelley
On Tue, 2016-09-13 at 16:02 +0800, Xiang, Haihao wrote: > VA-API adds new interface for bitrate control per temporal layer. > This patch series  > adds the support for bitrate control per temporal layer for > H.264/SVC-T in the driver. > > v2: Rename frame_width_in_mbs and frame_height_in_mbs to

Re: [Libva] [PATCH intel-driver] test: fix jpeg decode invalid indexing

2016-09-07 Thread Sean V Kelley
> On Sep 7, 2016, at 12:22 PM, U. Artie Eoff wrote: > > Use hsample and vsample factor in printComponentDataTo to > avoid invalid indexes into the data array. > > This fixes a segfault in the jpeg fourcc tests that may be > triggered during 'make check'. > >

Re: [Libva] [Libva-intel-driver][PATCH] Code cleanup for vme/mfc initializing on SKL

2016-09-07 Thread Sean V Kelley
On Wed, 2016-09-07 at 13:49 +0800, Zhao Yakui wrote: > On 09/07/2016 11:01 AM, Xiang, Haihao wrote: > > > > > > i965_encoder.c is a general file, it would be better not to include > > more HW/implementation related code in this file. > > > > Actually it is more clear if you look into the new >

Re: [Libva] [PATCH RFC intel-driver 00/11] Automated (Unit) Test Suite

2016-09-07 Thread Sean V Kelley
On Thu, 2016-09-01 at 12:59 -0700, U. Artie Eoff wrote: > The following patchset integrates the Google Test Framework > into the source tree.  This test framework provides a rich > set of features like automatic test discovery, assertion macros, > test fixtures, structured console and/or xml test

Re: [Libva] [PATCH v2][libva-intel-driver] i965_encoder: remove double check for VAStatus result

2016-08-18 Thread Sean V Kelley
status); > > if (status != VA_STATUS_SUCCESS) > return status; > You don't need this conditional with the ASSERT_RET(). Remove it too. Thanks, Sean > -- > 2.5.5 > > ___ > Libva mailing list > Libva@l

Re: [Libva] [PATCH v3][libva-intel-driver] i965_encoder: remove double check for VAStatus result

2016-08-18 Thread Sean V Kelley
On Thu, 2016-08-18 at 12:43 -0700, Daniel Charles wrote: > after creating underlying surface there's a double check on the > VAStatus result. Replace it with ASSERT_RET. > > Signed-off-by: Daniel Charles lgtm, applied. Thanks, Sean > --- >  src/i965_encoder.c | 5

Re: [Libva] [PATCH intel-driver 01/11] test: move ASSERT_NO_FAILURE macro to test.h

2016-09-28 Thread Sean V Kelley
On Wed, 2016-09-28 at 13:36 -0700, U. Artie Eoff wrote: > Both jpeg decode and encode test files use this macro. > So move it to the common test.h header to avoid duplicating > it. > Please add brief cover in the future  (patch 00/N) when you have a large series, even if they are mostly

Re: [Libva] [PATCH intel-driver 1/7] test: split jpeg test data into header and cpp

2016-09-28 Thread Sean V Kelley
On Mon, 2016-09-26 at 12:09 -0700, U. Artie Eoff wrote: > Move static definitions of JPEG TestPatternData into the .cpp > so that multiple files can include the i965_jpeg_test_data.h > header file.  Otherwise, there will be "multiple definition" > compiler errors. > > Also, change generateSolid

Re: [Libva] [PATCH intel-driver v2 7/7] test: add some jpeg encode tests

2016-09-28 Thread Sean V Kelley
On Mon, 2016-09-26 at 13:11 -0700, U. Artie Eoff wrote: > Add JPEG encode tests that encode raw I420 and NV12 data > at quality 100 and then decodes them to verify proper > encoding. > > Currently, the 7680x4320 I420 test fails because ~40-60 > Y-values (i.e. plane 0) in each line from the

Re: [Libva] [Libva-intel-driver][PATCH 1/2] Check whether there is a fully loaded HuC firmware

2016-09-28 Thread Sean V Kelley
On Wed, 2016-09-28 at 08:42 +0800, Xiang, Haihao wrote: > > Signed-off-by: Xiang, Haihao lgtm, applied. Now we just need the kernel patches merged and we should be good. Thanks, Sean > --- src/intel_driver.c | 12 src/intel_driver.h | 1 + 2 files

Re: [Libva] [PATCH intel-driver 01/11] test: move ASSERT_NO_FAILURE macro to test.h

2016-10-03 Thread Sean V Kelley
ote that the Y800 test cases expose a decode bug in the driver for > gen8+ and causes the test program to abort.  The “jpeg/dec: gen8+ set > correct fourcc for monochrome decode” driver patch will fix this and > is on the ML. lgtm, applied. Thanks, Sean >   > Thanks, > U. Artie >

Re: [Libva] [PATCH intel-driver] jpeg/dec: gen8+ set correct fourcc for monochrome decode

2016-10-03 Thread Sean V Kelley
On Wed, 2016-09-28 at 13:22 -0700, U. Artie Eoff wrote: > When the jpeg picture params have 1 component the > fourcc needs to be set to VA_FOURCC_Y800. lgtm, verified, applied. Thanks, Sean > > Signed-off-by: U. Artie Eoff > --- >  src/gen8_mfd.c | 5 +++-- >  1

Re: [Libva] problem when tiling is disabled on decoded surfaces

2016-10-27 Thread Sean V Kelley
face via > > libva > > and shares this surface between libva and camera, some cameras > > only > > support linear memory. > > > > In your case, it is the right behavior if you saw garbage > > because all > > surfaces are linear however HW requires a tiled surf

Re: [Libva] [Libva-intel-driver][PATCH] svct: hrd check per layer

2016-10-27 Thread Sean V Kelley
On Thu, 2016-10-27 at 22:41 +0800, Xiang, Haihao wrote: > Hence we can use separate parameters to estimate QP per layer and get > more > accurate QP for next frame in the same layer. > > Tested-by: Wang, Fei W > Signed-off-by: Xiang, Haihao Yes, I

Re: [Libva] How to implement a EGL or DRM display in VA-API driver

2016-10-28 Thread Sean V Kelley
On Fri, 2016-10-28 at 10:05 +0800, Randy Li wrote: > > On 10/27/2016 11:03 PM, Xiang, Haihao wrote: > > > -Original Message- > > > From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] > > > On Behalf > > > Of Randy Li > > > Sent: Monday, October 24, 2016 3:59 PM > > > To:

Re: [Libva] [Libva-intel-driver][PATCH] vdenc: Always use the 1st VCS ring

2016-10-28 Thread Sean V Kelley
On Fri, 2016-10-28 at 13:32 +0800, Xiang, Haihao wrote: > VDEnc/HuC only works with the 1st VCS ring, however SKL GT3+ has 2 > VCS rings. > To avoid executing the corresponding batch buffer from the 2nd VCS > ring in i915, we > have to specify the 1st ring in the driver. > > SKL GT1/GT2 has only

Re: [Libva] [PATCH intel-driver 0/5] JPEG Encode Test Speed Optimization

2016-10-28 Thread Sean V Kelley
On Wed, 2016-10-26 at 13:24 -0700, U. Artie Eoff wrote: > This patch series splits out the general YUV input data fields and > routines > from the ::JPEG::Encode::TestInput class into it's own class.  This > new class, > YUVImage, was then refactored to use std::valarray/std::slice to > manage the

Re: [Libva] [PATCH 0/2 v3][libva-intel-driver] report unsupported profile

2016-11-10 Thread Sean V Kelley
On Thu, 2016-11-10 at 15:08 -0800, Daniel Charles wrote: > This is a re-send of patch 1/2 and a new patch that modifies the current > unittests to properly test the unsupported profile condition. > > As mentioned in the commit messages, UNSUPPORTED_PROFILE will be returned > when a queried

Re: [Libva] Patchwork

2016-10-14 Thread Sean V Kelley
On Fri, 2016-10-14 at 20:09 +, Eoff, Ullysses A wrote: > The VAAPI project on does not > show any patches. > > Who can help to get patchwork working for the VAAPI project at ://patchwork.freedesktop.org>? > > My email client tends to mangle the patches,

Re: [Libva] [Libva-intel-driver][PATCH] Use Media Read message if possible on Gen8+

2016-10-14 Thread Sean V Kelley
On Fri, 2016-10-14 at 19:58 +, Eoff, Ullysses A wrote: > > -Original Message- > > From: Libva [mailto:libva-boun...@lists.freedesktop.org] On Behalf > > Of Sean V Kelley > > Sent: Friday, October 14, 2016 11:44 AM > > To: Zhao, Yakui <yakui.z...@intel.

Re: [Libva] [Libva-intel-driver][PATCH] Use Media Read message if possible on Gen8+

2016-10-17 Thread Sean V Kelley
ihao > > > >> On 10/15/2016 03:58 AM, Eoff, Ullysses A wrote: >> > >> > > -Original Message- >> > > From: Libva [mailto:libva-boun...@lists.freedesktop.org] On >> > > Behalf Of Sean V Kelley >> > > Sent: Friday, October 1

Re: [Libva] [PATCH] Add callbacks for error and info messages.

2016-10-24 Thread Sean V Kelley
On Wed, 2016-10-19 at 13:37 +0100, Emmanuel Gil Peyrot wrote: > This lets any application using libva choose the best way to report > info and error messages to the user, for example graphical > application > can open a popup on errors and write info messages in the toolbar. What version of

Re: [Libva] [Libva-intel-driver][PATCH 0/5] Update bitrate control per layer

2016-10-24 Thread Sean V Kelley
On Mon, 2016-10-24 at 12:49 +0800, Xiang, Haihao wrote: > This patch series updates the bitrate control per layer and makes the > bitrate per > layer is close to the setting. > > Xiang, Haihao (5): >   svct: Usa an array to store QP rounding accumulator >   svct: Save the current frame size per

Re: [Libva] libyami 1.0.1 release

2016-11-14 Thread Sean V Kelley
ma_buf, it means a dma_buf handle can be sent to > server > > for window update. Keith said mesa is using it, and on server side glamor > handle > > the dma_buf. the remaining gap is that YUV buffer hasn't been supported > yet, but > > not hard to add it. > > > > > > From: Zhao, Halley > Sent: Friday, November 28, 2014 2:26 PM > To: liby...@lists.01.org > Cc: Li, Jocelyn; Kelley, Sean V > Subject: libyami 0.1.4 release > > > > libyami 0.1.4 release > > = > > > > features update > > --- > > - Additional fixes(most are thread race condition) for v4l2 wrapper > (egl/gles) > > - Add glx support in v4l2 wrapper > > - Basic transcoding support: encoder test accepts input data from > decoder output > > - Testscript is added, it supports one-run-for-all: with a folder > including h264/vp8/jpeg/raw-ref, > > we can test them in one run. It serves as BAT (basic acceptance > test) for pull request merge. > > - Report fps in decode test, support decoding only test (skip > rendering) > > - Vp8/jpeg are supported in v4l2 decoder as well > > - Decode test can be built/run without X11 > > - Code refinement for decoder test output and encoder classes > > - dma_buf fixes, when video frame is exported as dma_buf, it renders > well as texture > > - with additional patch for chrome: > > V4L2VDA/V4L2VEA pass chrome video unit test > > video playback in browser draft ok > > - for v4l2 wrapper, see: > https://github.com/halleyzhao/yami-share/blob/master/Yami_V4L2_wrapper_for_Chrome.pdf > > > > known issues > > --- > > - this release has been fully tested by validation team > > - some jpeg file similarity <0.99 (~0.98) after decoding > > https://github.com/01org/libyami/issues/108 > > > > future release plan: > > > > Dec: v0.2 > > jpeg encoder > > vp9 decoder > > vp8 encoder (depends on driver availability) > > initial ffmpeg support > > > > Feb'15: v0.3 > > unified input/output buffer of yami > > transcoding support with unified input/output buffer > > camera dma_buf support, camera with jpeg input > > use yami in ffmpeg for hw codec > > > > Future: > > h265 decoder -- Sean V. Kelley <sean.v.kel...@intel.com> Open Source Technology Center / SSG Intel Corp. ___ Libva mailing list Libva@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libva

Re: [Libva] [PATCH] avoid asserts when color convertion fails

2016-11-14 Thread Sean V Kelley
On Mon, 2016-11-14 at 15:44 +0100, Víctor Manuel Jáquez Leal wrote: > This patch exposes the color convertion failure in this case > > gst-play-1.0 HPCAMOLQ_BRCM_B.264 --videosink=xvimagesink > > This pipeline will ask to the VPP to convert from GRAY8 to YV12, > which is the negotiated format

Re: [Libva] [PATCH intel-driver 0/5] JPEG Encode Test Speed Optimization

2016-11-21 Thread Sean V Kelley
>> > > Thanks, >> > > >> > > Sean >> > > >> > > > >> > > > U. Artie Eoff (5): >> > > > test: add a timer class >> > > > test: use C random library for random numbers >> > > > test: add YUVImage class >> > > >

Re: [Libva] BSD ring selection

2016-11-24 Thread Sean V Kelley
+Kimmo Hi Trvrko, As I mentioned in email yesterday, I would be looking into this next quarter. Why are you jumping into this now? Please work through me on these requests. Thanks, Sean > On 24 Samh 2016, at 00:07, Tvrtko Ursulin > wrote: > > > Hi all, >

Re: [Libva] [PATCH] va/x11: Require synchronisation to vblank with DRI2SwapBuffers

2016-11-16 Thread Sean V Kelley
On Thu, 2016-11-17 at 01:22 +, Xiang, Haihao wrote: > Hi, > > Someone got lockup with this patch and I don't see the issue is > resolved, please check the thread below > > https://lists.freedesktop.org/archives/intel-gfx/2015-December/083572 > .h > tml  ([Intel-gfx] vsync + vaapi question).

Re: [Libva] [PATCH] drm: remove va_drm_is_authenticated check

2016-11-16 Thread Sean V Kelley
> On 15 Samh 2016, at 09:44, Emil Velikov wrote: > > On 15 November 2016 at 15:42, David Herrmann > wrote: >> Hi >> >> On Tue, Nov 15, 2016 at 4:24 PM, Emil Velikov >

  1   2   >