Non-digit characters were accepted in --cellno resulting in
unwanted behavior: 'virsh freecell --cellno foo' wasn't
rejected.
---
This fix addresses bug 639587
tools/virsh.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index
* src/qemu/qemu_driver.c
---
src/qemu/qemu_driver.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index c581cfe..8570e67 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -4647,6 +4647,12 @@ static
Hi all:
I've solved it, add those line in gitconfig:
[sendemail]
smtpencryption = tls
smtpserver = smtp.gmail.com
smtpuser = yourn...@gmail.com
smtpserverport = 587
Thus git use gmail smtp to send the patches.
--
libvir-list mailing list
libvir-list@redhat.com
On 02/11/2011 01:31 PM, Daniel P. Berrange wrote:
This series does some cleanups to GIT and introduces support
for automated build testing
Great Daniel. Thanks!
ACK series
Michal
--
Michal Novotnyminov...@redhat.com, RHCE
Virtualization Team (xen userspace), Red Hat
--
libvir-list mailing
2011/2/15 Serge E. Hallyn serge.hal...@canonical.com:
Hi, as per the message after the tests fail, I'm reporting this on
the list. Hopefully someone has seen this before. I've not yet
tried this with the latest git snapshot. With 0.8.7, I get:
TEST: qemuxml2argvtest
On 02/15/2011 08:03 AM, Lyre wrote:
Fixed the install location of libvirt-php.ini;
Added an spec file for openSuSE Build Service.
Lyre (2):
Fixed the php configuration file
Added libvirt-php.obs.spec
Makefile.am |2 +
aclocal.m4 |4 +-
libvirt-php.obs.spec
On Tue, Feb 15, 2011 at 10:09:14AM +0100, Matthias Bolte wrote:
2011/2/15 Serge E. Hallyn serge.hal...@canonical.com:
Hi, as per the message after the tests fail, I'm reporting this on
the list. Hopefully someone has seen this before. I've not yet
tried this with the latest git snapshot.
Hi all:
These patch added the -Wall option for compiler, and eliminated all warnings.
Lyre (3):
Added -Wall option
Fixed some compilation warnings
Eliminated ununsed variables
src/Makefile.am |4 +-
src/libvirt.c | 65 +-
2
* src/Makefile.am: added -Wall option in compling linking.
---
src/Makefile.am |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 059de2c..67a0192 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -14,8 +14,8 @@ EXTRA_DIST =
* src/libvirt.c: Eliminated unused variables.
---
src/libvirt.c | 54 --
1 files changed, 4 insertions(+), 50 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index 524bb6f..54b1342 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@
2011/2/15 Osier Yang jy...@redhat.com:
于 2011年02月15日 11:32, Daniel Veillard 写道:
Thanks everybody for the testing feedback and fixes, in retrospect
I should really had done this in previous releases ! So the third
rc tarball is out, it's likely to be the last one before the release
(within
On Tue, Feb 15, 2011 at 11:00:06 +0100, Matthias Bolte wrote:
Daniel. qemuxml2argvtest outputs the capabilities, does it contain a
host/cpu element? Maybe the problem it that the CPU data decoding in
libvirt is x86 specific as it relies on the CPUID command.
I'm looking into this issue right
On Tue, Feb 15, 2011 at 11:00:06AM +0100, Matthias Bolte wrote:
2011/2/15 Daniel Veillard veill...@redhat.com:
I reproduced this on a ppc64 box (RHEL-6) and get:
122) QEMU XML-2-ARGV cpu-topology2 ...
libvir: QEMU error : unsupported configuration:
On Tue, Feb 15, 2011 at 11:10:07AM +0100, Matthias Bolte wrote:
2011/2/15 Osier Yang jy...@redhat.com:
于 2011年02月15日 11:32, Daniel Veillard 写道:
Thanks everybody for the testing feedback and fixes, in retrospect
I should really had done this in previous releases ! So the third
rc
2011/2/15 Osier Yang jy...@redhat.com:
于 2011年02月15日 11:32, Daniel Veillard 写道:
Thanks everybody for the testing feedback and fixes, in retrospect
I should really had done this in previous releases ! So the third
rc tarball is out, it's likely to be the last one before the release
(within
On Tue, Feb 15, 2011 at 03:03:52PM +0800, Lyre wrote:
* libvirt-php.obs.spec: this file should works for Fedora 14,
openSuSE 11.3, and SLES 11 SP1 on openSuSE Build Service or
localhost.
* Makefile.am: added EXTRA_DIST = libvirt-php.obs.spec
---
Makefile.am |2 +
On Tue, Feb 15, 2011 at 06:23:56PM +0800, Daniel Veillard wrote:
On Tue, Feb 15, 2011 at 11:00:06AM +0100, Matthias Bolte wrote:
2011/2/15 Daniel Veillard veill...@redhat.com:
I reproduced this on a ppc64 box (RHEL-6) and get:
122) QEMU XML-2-ARGV cpu-topology2
I pushed this one as suggested by Daniel in
https://www.redhat.com/archives/libvir-list/2011-February/msg00519.html
Matthias
From c7a6fc375a4fef01c0e47567bf44502c6f61842f Mon Sep 17 00:00:00 2001
From: Matthias Bolte matthias.bo...@googlemail.com
Date: Tue, 15 Feb 2011 11:46:16 +0100
Subject:
On Tue, Feb 15, 2011 at 6:42 PM, Daniel P. Berrange berra...@redhat.comwrote:
On Tue, Feb 15, 2011 at 03:03:52PM +0800, Lyre wrote:
* libvirt-php.obs.spec: this file should works for Fedora 14,
openSuSE 11.3, and SLES 11 SP1 on openSuSE Build Service or
localhost.
* Makefile.am:
On 15/02/2011, at 10:35 PM, Lyre wrote:
snip
The problem was, I'm not quite sure what to do with this spec file.
Currently, It may be better to name the spec file libvirt-php.spec.
This spec file contains many if...else for compatibility, some macros such as
%{php_zend_api} are not
On 15/02/2011, at 2:32 PM, Daniel Veillard wrote:
Thanks everybody for the testing feedback and fixes, in retrospect
I should really had done this in previous releases ! So the third
rc tarball is out, it's likely to be the last one before the release
(within 48 hours):
On Tue, Feb 15, 2011 at 7:48 PM, Justin Clift jcl...@redhat.com wrote:
On 15/02/2011, at 10:35 PM, Lyre wrote:
snip
The problem was, I'm not quite sure what to do with this spec file.
Currently, It may be better to name the spec file libvirt-php.spec.
This spec file contains many
On 15/02/2011, at 11:42 PM, Lyre wrote:
snip
BTW, it is my first time to be involved in an opensource project.
No worries. You're doing fine, and you'll be ok. :)
Maybe I've been accustom to that someone will make decision, not me. It
seems that I should make the decsion now, and I'll try
On 15/02/2011, at 6:08 PM, Lyre wrote:
Hi all:
I've solved it, add those line in gitconfig:
[sendemail]
smtpencryption = tls
smtpserver = smtp.gmail.com
smtpuser = yourn...@gmail.com
smtpserverport = 587
Thus git use gmail smtp to send the patches.
Yep. I also have this in mine,
On 15/02/2011, at 2:23 PM, Daniel Veillard wrote:
On Mon, Feb 14, 2011 at 09:47:32AM -0700, Eric Blake wrote:
On 02/14/2011 08:25 AM, Matthias Bolte wrote:
2011/2/14 Justin Clift jcl...@redhat.com:
---
docs/apps.html.in | 12
1 files changed, 12 insertions(+), 0 deletions(-)
Quoting Matthias Bolte (matthias.bo...@googlemail.com):
2011/2/15 Serge E. Hallyn serge.hal...@canonical.com:
Hi, as per the message after the tests fail, I'm reporting this on
the list. Hopefully someone has seen this before. I've not yet
tried this with the latest git snapshot. With
qemu command line to specify vram:
-global qxl.vram_size=uint
qemu command line to specify heads, (no need of '-device' for
the first 'head'):
-device qxl,id=qxl-N (N is natural number)
This patch is just about the command line building, still left work
on the command line parsing
于 2011年02月15日 21:47, Osier Yang 写道:
qemu command line to specify vram:
-global qxl.vram_size=uint
qemu command line to specify heads, (no need of '-device' for
the first 'head'):
-device qxl,id=qxl-N (N is natural number)
This patch is just about the command line building, still left
On Tue, Feb 15, 2011 at 07:37:37 -0600, Serge E. Hallyn wrote:
TEST: qemuxml2argvtest
QEMU driver capabilities:
capabilities
host
cpu
archarmv7l/arch
This is the problem. The code does not properly dealing with the case where
host CPU architecture as described by host
On Tue, Feb 15, 2011 at 09:47:28PM +0800, Osier Yang wrote:
qemu command line to specify vram:
-global qxl.vram_size=uint
qemu command line to specify heads, (no need of '-device' for
the first 'head'):
-device qxl,id=qxl-N (N is natural number)
This patch is just about the
On 02/14/2011 11:43 PM, Stefan Berger wrote:
One definte problem in libnl is that the 'port allocation'
(generate_local_port()) is not thread-safe, even though I think it's
the library's responsibility to lock, not libvirt introducing a lock
that we need to grab before calling into netcf and
Since we fake host CPU we should also fake host arch instead of taking
the real architecture tests are running on.
---
tests/testutilsqemu.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c
index bfac307..fbbb6c1 100644
The code expected that host CPU architecture matches the architecture on
which libvirt runs. This is normally true but not in tests, where host
CPU is faked to produce consistent results.
---
src/qemu/qemu_command.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git
This fixes the following test failures seen on some architectures:
TEST: qemuxml2argvtest
40
80
.!.! 116 FAIL
Jiri Denemark (2):
tests: Fake host capabilities properly
qemu:
Quoting Jiri Denemark (jdene...@redhat.com):
On Tue, Feb 15, 2011 at 07:37:37 -0600, Serge E. Hallyn wrote:
TEST: qemuxml2argvtest
QEMU driver capabilities:
capabilities
host
cpu
archarmv7l/arch
This is the problem. The code does not properly dealing with the case
于 2011年02月15日 22:13, Daniel P. Berrange 写道:
On Tue, Feb 15, 2011 at 09:47:28PM +0800, Osier Yang wrote:
qemu command line to specify vram:
-global qxl.vram_size=uint
qemu command line to specify heads, (no need of '-device' for
the first 'head'):
-device qxl,id=qxl-N (N is natural
Quoting Jiri Denemark (jdene...@redhat.com):
Since we fake host CPU we should also fake host arch instead of taking
the real architecture tests are running on.
---
tests/testutilsqemu.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
Tested-by: Serge Hallyn
Quoting Jiri Denemark (jdene...@redhat.com):
The code expected that host CPU architecture matches the architecture on
which libvirt runs. This is normally true but not in tests, where host
CPU is faked to produce consistent results.
---
src/qemu/qemu_command.c |8 +---
1 files
On 02/15/2011 07:53 AM, Jiri Denemark wrote:
Since we fake host CPU we should also fake host arch instead of taking
the real architecture tests are running on.
---
tests/testutilsqemu.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/tests/testutilsqemu.c
On 02/15/2011 07:54 AM, Jiri Denemark wrote:
The code expected that host CPU architecture matches the architecture on
which libvirt runs. This is normally true but not in tests, where host
CPU is faked to produce consistent results.
---
src/qemu/qemu_command.c |8 +---
1 files
* src/qemu/qemu_command.c (qemuBuildCommandLine): Don't report oom
after qemuBuildControllerDevStr, which reported its own errors.
---
src/qemu/qemu_command.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index
On 02/14/2011 05:38 PM, Laine Stump wrote:
On 02/14/2011 06:25 PM, Eric Blake wrote:
* src/libvirt.c (virDomainMemoryStats): Check domain before flags.
---
Another valid bug found by clang. User's generally should't call
virDomainMemoryStats(NULL,...), but we don't forbid it elsewhere, and
On 01/14/2011 10:07 PM, Eric Blake wrote:
On 12/29/2010 11:04 AM, Eduardo Otubo wrote:
This is the implementation of the previous patch now using virInterface*
API. Ended up this patch got much more simpler, smaller and easier to
review. Here is some details:
Finally getting around to
On 02/14/2011 08:26 PM, Daniel Veillard wrote:
On Mon, Feb 14, 2011 at 04:59:39PM -0700, Eric Blake wrote:
The processWatchdogEvent fix is real, although it can only trigger on
OOM, since bad things happen if doCoreDump is called with a NULL
pathname argument. The other fixes silence clang,
On 02/15/2011 03:33 AM, Matthias Bolte wrote:
PACKAGE_VERSION and PACKAGER are all defined as by default,
do we need to do more checking to print just the following?
configure tests --with-packager(-version) for no instead of empty
string. I think --with-packager(-version) should either
On 02/15/2011 01:09 AM, Michal Privoznik wrote:
Non-digit characters were accepted in --cellno resulting in
unwanted behavior: 'virsh freecell --cellno foo' wasn't
rejected.
---
This fix addresses bug 639587
tools/virsh.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
On 02/15/2011 11:32 AM, Eric Blake wrote:
* src/qemu/qemu_command.c (qemuBuildCommandLine): Don't report oom
after qemuBuildControllerDevStr, which reported its own errors.
---
src/qemu/qemu_command.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 02/15/11 04:32, Daniel Veillard wrote:
Thanks everybody for the testing feedback and fixes, in retrospect
I should really had done this in previous releases ! So the third
rc tarball is out, it's likely to be the last one before the release
On 02/14/2011 05:30 PM, Eric Blake wrote:
clang had 5 reports against virCommand; three were false positives
(a NULL deref in ProcessIO solved by sa_assert, and two uninitialized
memory operations solved by adding an initializer), but two were real.
* src/util/command.c (virCommandProcessIO):
Hi,
does somebody know what the following paragraph exactly means resp. what
it should mean?
The maximum bandwidth (in Mbps) that will be used to do migration can
be specified with the bandwidth parameter. *If set to 0, libvirt will
choose a suitable default*.
On 02/15/2011 10:37 AM, Laine Stump wrote:
On 02/15/2011 11:32 AM, Eric Blake wrote:
* src/qemu/qemu_command.c (qemuBuildCommandLine): Don't report oom
after qemuBuildControllerDevStr, which reported its own errors.
---
src/qemu/qemu_command.c |2 +-
1 files changed, 1 insertions(+),
On 02/15/2011 10:41 AM, Laine Stump wrote:
On 02/14/2011 05:30 PM, Eric Blake wrote:
clang had 5 reports against virCommand; three were false positives
(a NULL deref in ProcessIO solved by sa_assert, and two uninitialized
memory operations solved by adding an initializer), but two were real.
I pushed this patch already ACKed by Eric:
https://www.redhat.com/archives/libvir-list/2011-February/msg00550.html
Matthias
From 251ad3b28b2534f840549fc5837ca5f3c5993e30 Mon Sep 17 00:00:00 2001
From: Matthias Bolte matthias.bo...@googlemail.com
Date: Tue, 15 Feb 2011 19:48:44 +0100
Subject:
Daniel Veillard wrote:
Thanks everybody for the testing feedback and fixes, in retrospect
I should really had done this in previous releases ! So the third
rc tarball is out, it's likely to be the last one before the release
(within 48 hours):
* docs/drvopenvz.html.in: Spell administrator correctly.
* docs/drvuml.html.in: Likewise.
* src/qemu/qemu.conf: Likewise. Fix other typos, too.
---
Pushing under the obvious rule.
docs/drvopenvz.html.in |2 +-
docs/drvuml.html.in|2 +-
src/qemu/qemu.conf | 25
* src/util/cgroup.c (virCgroupSetValueStr, virCgroupGetValueStr)
(virCgroupRemoveRecursively): VIR_DEBUG can clobber errno.
(virCgroupRemove): Use VIR_DEBUG rather than DEBUG.
---
src/util/cgroup.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git
On 02/15/2011 05:01 PM, Eric Blake wrote:
* src/util/cgroup.c (virCgroupSetValueStr, virCgroupGetValueStr)
(virCgroupRemoveRecursively): VIR_DEBUG can clobber errno.
(virCgroupRemove): Use VIR_DEBUG rather than DEBUG.
---
rc = virFileWriteStr(keypath, value, 0);
if (rc 0) {
-
Hi all,
Just came across an ARM emulator project that seems well developed and going
decently:
http://gxemul.sourceforge.net
Kind of wondering if anyone has tried it out?
Obviously also thinking it would be interesting if someone knows of a libvirt
driver for it. :
Regards and best wishes,
I'm following up on danpb's patches to add initial audit support to
qemu actions (see around commit 8dc136b in Oct 2010). Another useful
thing to audit is all changes to the device ACL whitelist via the
cgroup device controller - namely, any time that the qemu cgroup is
altered to allow or deny
* src/qemu/qemu_cgroup.h (struct qemuCgroupData): New helper type.
(qemuSetupDiskPathAllow, qemuSetupChardevCgroup)
(qemuTeardownDiskPathDeny): Drop unneeded prototypes.
(qemuSetupDiskCgroup, qemuTeardownDiskCgroup): Adjust prototype.
* src/qemu/qemu_cgroup.c
(qemuSetupDiskPathAllow,
* src/qemu/qemu_audit.h (qemuDomainCgroupAudit): New prototype.
* src/qemu/qemu_audit.c (qemuDomainCgroupAudit): Implement it.
* src/qemu/qemu_driver.c (qemudDomainSaveFlag): Add audit.
* src/qemu/qemu_cgroup.c (qemuSetupDiskPathAllow)
(qemuSetupChardevCgroup, qemuSetupHostUsbDeviceCgroup)
On Tue, Feb 15, 2011 at 05:01:18PM -0700, Eric Blake wrote:
* src/util/cgroup.c (virCgroupSetValueStr, virCgroupGetValueStr)
(virCgroupRemoveRecursively): VIR_DEBUG can clobber errno.
(virCgroupRemove): Use VIR_DEBUG rather than DEBUG.
---
src/util/cgroup.c | 12 ++--
1 files
Merge php-libvirt.spec libvirt-php.obs.spec to libvirt-php.spec,
which will pack libvirt-php into two packages:
libvirt-php: the extension itself with the configuration file.
libvirt-php-doc: document package for libvirt-php
This spec file should works for Fedora 14, RHEL 6,
On Tue, Feb 15, 2011 at 05:33:09PM -0700, Eric Blake wrote:
On 02/15/2011 05:01 PM, Eric Blake wrote:
* src/util/cgroup.c (virCgroupSetValueStr, virCgroupGetValueStr)
(virCgroupRemoveRecursively): VIR_DEBUG can clobber errno.
(virCgroupRemove): Use VIR_DEBUG rather than DEBUG.
---
Hi All,
This series implements a new command blkiotune for virsh.
A lot of code borrows from memtune.
You are able to tune blkio cgroup tunables by this command as follows.
Show tunables
#virsh blkiotune My_guest
weight : 900
Tune tunables(Set IO weight)
#virsh blkiotune My_guest
Add virDomainSetBlkioParameters virDomainGetBlkioParameters
Signed-off-by: Gui Jianfeng guijianf...@cn.fujitsu.com
---
include/libvirt/libvirt.h.in| 67 +++
python/generator.py |2 +
python/libvirt-override-api.xml | 12 +++
Implement domainSetBlkioParamters and domainGetBlkioParamters for QEmu
Signed-off-by: Gui Jianfeng guijianf...@cn.fujitsu.com
---
src/qemu/qemu_driver.c | 164 +++-
1 files changed, 162 insertions(+), 2 deletions(-)
diff --git
Implements virDomainSetBlkioParameters and virDomainGetBlkioParameters and
initialization
Signed-off-by: Gui Jianfeng guijianf...@cn.fujitsu.com
---
src/driver.h | 14 ++
src/esx/esx_driver.c |2 +
src/libvirt.c | 108
Adding memtune command to virsh tool
Signed-off-by: Gui Jianfeng guijianf...@cn.fujitsu.com
---
tools/virsh.c | 127 +
1 files changed, 127 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 50d5e33..864900d
Remote protocol implementation of virDomainSetBlkioParameters and
virDomainGetBlkioParameters.
Signed-off-by: Gui Jianfeng guijianf...@cn.fujitsu.com
---
daemon/remote.c | 210 +++
daemon/remote_dispatch_args.h |2 +
Documents for blkiotune
Signed-off-by: Gui Jianfeng guijianf...@cn.fujitsu.com
---
tools/virsh.pod |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index a2ca384..56bf22f 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -610,6
于 2011年02月16日 12:04, Gui Jianfeng 写道:
Implement domainSetBlkioParamters and domainGetBlkioParamters for QEmu
Signed-off-by: Gui Jianfengguijianf...@cn.fujitsu.com
---
src/qemu/qemu_driver.c | 164 +++-
1 files changed, 162 insertions(+), 2
于 2011年02月16日 12:05, Gui Jianfeng 写道:
Adding memtune command to virsh tool
s/memtune/blkiotune/
Also applies to patch subject.
Signed-off-by: Gui Jianfengguijianf...@cn.fujitsu.com
---
tools/virsh.c | 127 +
1 files changed, 127
于 2011年02月16日 12:07, Gui Jianfeng 写道:
Documents for blkiotune
Signed-off-by: Gui Jianfengguijianf...@cn.fujitsu.com
---
tools/virsh.pod |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index a2ca384..56bf22f 100644
---
Osier Yang wrote:
于 2011年02月16日 12:07, Gui Jianfeng 写道:
Documents for blkiotune
Signed-off-by: Gui Jianfengguijianf...@cn.fujitsu.com
---
tools/virsh.pod |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index
75 matches
Mail list logo
