On Thu, Feb 17, 2011 at 05:39, Daniel Veillard veill...@redhat.com wrote:
As scheduled the release is out, and available from the site:
ftp://libvirt.org/libvirt/
Thanks, it's working great so far!
One minor issue:
[root@ev004 ~]# service libvirt-guests status
/etc/init.d/libvirt-guests:
As virDomainDefParseString already reported the error if it
fails, and the redundant error reports codes will override
error reported by virDomainDefParseString with some unclear
messages, removed them.
* src/qemu/qemu_driver.c
---
src/qemu/qemu_driver.c | 33 +
Eric, thanks for reply but I'm having some issues now...
I've pulled libvirt sources from upstream and I'm unable to compile it
since it keeps saying following:
CCLD libvirt_parthelper
./.libs/libvirt_util.a(libvirt_util_la-util.o): In function
`virFileOperationNoFork':
Consider this sequence of commands
$ ./configure
...
$ make
...
GENlibvirt.syms
...
$ ./configure --with-driver-modules
...
$ make
...
libvirt.syms doesn't get regenerated but it should as it should
contain virDriverLoadModule now.
make clean after a configure run doesn't help, as make
libvirt-guests invokes functions in gettext.sh, so we need to
require gettext package in spec file.
Demo with the fix:
package gettext is not installed
error: Failed dependencies:
gettext is needed by libvirt-client-0.8.8-1.fc14.x86_64
* libvirt.spec.in
---
libvirt.spec.in |1 +
1
于 2011年02月17日 17:31, Ruben Kerkhof 写道:
On Thu, Feb 17, 2011 at 05:39, Daniel Veillardveill...@redhat.com wrote:
As scheduled the release is out, and available from the site:
ftp://libvirt.org/libvirt/
Thanks, it's working great so far!
One minor issue:
[root@ev004 ~]# service
libvirt-guests invokes functions in gettext.sh, so we need to
require gettext package in spec file.
Demo with the fix:
% rpm -q gettext
package gettext is not installed
% rpm -ivh libvirt-client-0.8.8-1.fc14.x86_64.rpm
error: Failed dependencies:
gettext is needed by
于 2011年02月17日 18:02, Osier Yang 写道:
libvirt-guests invokes functions in gettext.sh, so we need to
require gettext package in spec file.
Demo with the fix:
package gettext is not installed
error: Failed dependencies:
gettext is needed by libvirt-client-0.8.8-1.fc14.x86_64
Urgh, please
Hello,
I have a problem with the following code fragment, which refreshes a directory
based storage pool:
storage_backend_fs.c#virStorageBackendFileSystemRefresh(...)
...
while ((ent = readdir(dir)) != NULL) {
...
if ((ret = virStorageBackendProbeTarget(...) 0) {
if (ret
On Wed, Feb 16, 2011 at 05:10:10PM -0700, Jim Fehlig wrote:
Jim Fehlig wrote:
Daniel Veillard wrote:
Thanks everybody for the testing feedback and fixes, in retrospect
I should really had done this in previous releases ! So the third
rc tarball is out, it's likely to be the last
Hi,
i'd like to let you know about current status of this project. There is
a wiki page http://wiki.libvirt.org/page/Libvirt-snmp which is currently
a documentation.
I am currently waiting for ACK for patch I've sent (snmp trap support) -
so if anyone's interested and have a lot of free
Followup to commit 17e19add, and would have prevented the bug
independently fixed in commit 76c57a7c.
* src/util/logging.c (virLogMessage): Preserve errno, since
logging should be as unintrusive as possible.
...
-if (fmt == NULL)
- return;
+if (fmt == NULL) {
+errno
On 17/02/2011, at 9:24 PM, Michal Prívozník wrote:
Hi,
i'd like to let you know about current status of this project. There is a
wiki page http://wiki.libvirt.org/page/Libvirt-snmp which is currently a
documentation.
This is very good work.
Nice picture!, clearly written, and explains
On Thu, Feb 17, 2011 at 02:32:49PM +0800, Hu Tao wrote:
If we don't check it, virsh users will get Disk detached successfully
even when qemuMonitorDriveDel fails.
---
src/qemu/qemu_hotplug.c | 10 --
src/qemu/qemu_monitor_json.c |2 +-
2 files changed, 9 insertions(+), 3
On Thu, Feb 17, 2011 at 05:30:23PM +0800, Osier Yang wrote:
As virDomainDefParseString already reported the error if it
fails, and the redundant error reports codes will override
error reported by virDomainDefParseString with some unclear
messages, removed them.
* src/qemu/qemu_driver.c
On Thu, Feb 17, 2011 at 11:21:26AM +0100, Philipp Hahn wrote:
Hello,
I have a problem with the following code fragment, which refreshes a
directory
based storage pool:
storage_backend_fs.c#virStorageBackendFileSystemRefresh(...)
...
while ((ent = readdir(dir)) != NULL) {
...
A new release of the Perl bindings, Sys::Virt, is now available from:
http://search.cpan.org/~danberr/Sys-Virt-0.2.6/
Direct download link:
http://search.cpan.org/CPAN/authors/id/D/DA/DANBERR/Sys-Virt-0.2.6.tar.gz
This supports all the APIs upto and including libvirt 0.8.7, with the
---
AUTHORS |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/AUTHORS b/AUTHORS
index 6ff7c14..fb42662 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -155,6 +155,7 @@ Patches have also been contributed by:
Gui Jianfeng guijianf...@cn.fujitsu.com
Michal Novotny
On Thu, Feb 17, 2011 at 01:45:42PM +0100, Markus Groß wrote:
Hi,
I refactored the XM and SEXPR parsing routines from the xen-unified
driver into a seperate directory (xenxs; x for xm and s for sexpr).
This way different xen-drivers besides xen-unified are able to
use the parsing
Parse XML from given buffer, select appropiate XPath node and return its
value as unsigned long.
---
tools/virsh.c | 49 +
1 files changed, 49 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 50d5e33..8804fc3 100644
This is fix for virsh freecell command. I was using virNodeGetInfo()
instead of virConnectGetCapabilities() which returns XML with the right
number. Therefore we need XML/XPath function to pick node values from XML
kept in buffer. Moreover, this function might be used to replace bad
practise in
as written in docs, one must parse capabilities XML to get the right
count of NUMA nodes.
---
tools/virsh.c | 27 ---
1 files changed, 16 insertions(+), 11 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index 8804fc3..1086555 100644
--- a/tools/virsh.c
+++
Hi
not that I tested this patch or the patch that followed (adding
blkiotune command) ... but the way I understand, the cgroup blkio
controller does only work for sync'd IO/queues.
quote blkio-controller.txt from 2.6.37:
Currently only sync IO queues are support. All the buffered writes are
2011/2/17 Michal Privoznik mpriv...@redhat.com:
Parse XML from given buffer, select appropiate XPath node and return its
value as unsigned long.
---
tools/virsh.c | 49 +
1 files changed, 49 insertions(+), 0 deletions(-)
diff --git
On Wed, Feb 16, 2011 at 09:50:57 -0700, Eric Blake wrote:
On 02/16/2011 09:41 AM, Eric Blake wrote:
On 02/16/2011 09:01 AM, Jiri Denemark wrote:
Even VPATH make dist succeeds now
ACK. I think this is okay for 0.8.8, since it doesn't invalidate any .c
code, and since it makes the
On Wed, Feb 16, 2011 at 09:15:43 -0700, Eric Blake wrote:
On 02/16/2011 09:01 AM, Jiri Denemark wrote:
---
docs/apibuild.py | 3194
+++---
1 files changed, 1597 insertions(+), 1597 deletions(-)
ACK; confirmed by 'git diff -b' that there
Markus Groß wrote:
Hi,
I refactored the XM and SEXPR parsing routines from the xen-unified
driver into a seperate directory (xenxs; x for xm and s for sexpr).
This way different xen-drivers besides xen-unified are able to
use the parsing functionality. For example the upcoming
XenLight
On Thu, Feb 17, 2011 at 07:46:59AM -0700, Jim Fehlig wrote:
Markus Groß wrote:
Hi,
I refactored the XM and SEXPR parsing routines from the xen-unified
driver into a seperate directory (xenxs; x for xm and s for sexpr).
This way different xen-drivers besides xen-unified are able to
use
于 2011年02月17日 19:15, Daniel P. Berrange 写道:
On Thu, Feb 17, 2011 at 05:30:23PM +0800, Osier Yang wrote:
As virDomainDefParseString already reported the error if it
fails, and the redundant error reports codes will override
error reported by virDomainDefParseString with some unclear
messages,
On 02/07/2011 11:55 AM, Eric Blake wrote:
On 02/04/2011 02:00 PM, Laine Stump wrote:
When thedriver element (and its name attribute) was added to the
domain XML's interface element, a backend enum was simply added to
the toplevel of the virDomainNetDef struct.
This patch changes
On 02/10/2011 03:35 PM, Eric Blake wrote:
On 02/10/2011 02:53 AM, Laine Stump wrote:
==
V3 changes:
0) The actual code remains untouched from V2.
1) Add txmode attribute to the domain schema, and to an xml2xml and
xml2argv test (note that the particular file
Virsh freecell --all was not olny getting wrong NUMA nodes count, but
even the NUMA nodes ids. They doesn't have to be continuous, as I've
found out during testing this. Therefore a modification of
nodeGetCellsFreeMemory() error message.
---
src/nodeinfo.c |3 +-
tools/virsh.c | 70
On 17/02/2011, at 3:39 PM, Daniel Veillard wrote:
As scheduled the release is out, and available from the site:
ftp://libvirt.org/libvirt/
Thanks everybody for the earlier testing on the release candidate series
that was I think quite useful !
This release is now available through
On 02/17/2011 02:37 AM, Michal Novotny wrote:
Eric, thanks for reply but I'm having some issues now...
I've pulled libvirt sources from upstream and I'm unable to compile it
since it keeps saying following:
CCLD libvirt_parthelper
./.libs/libvirt_util.a(libvirt_util_la-util.o): In
On 02/17/2011 03:05 AM, Osier Yang wrote:
libvirt-guests invokes functions in gettext.sh, so we need to
require gettext package in spec file.
Demo with the fix:
% rpm -q gettext
package gettext is not installed
% rpm -ivh libvirt-client-0.8.8-1.fc14.x86_64.rpm
error: Failed
$ ./configure
...
$ make
...
GENlibvirt.syms
...
$ ./configure --with-driver-modules
...
$ make
...
libvirt.syms doesn't get regenerated but it should as it should
contain virDriverLoadModule now.
* src/Makefile.am (libvirt.syms): Depend on configure changes.
Reported by Matthias Bolte.
On 18/02/2011, at 7:12 AM, Eric Blake wrote:
snip
[note to self - it might be possible to drop the nc dependency in the
future, once I finish my conversion from -migration exec: to -migration
fd:, since the spec file only targets distros with new-enough qemu
0.12.0 or newer; nc would still
On 02/17/2011 07:34 AM, Jiri Denemark wrote:
Also cfg.mk is tweaked to force this for all future changes to *.py
files.
---
cfg.mk |4 +-
docs/apibuild.py | 3194
docs/index.py | 834 +++---
On 02/16/2011 08:14 PM, Daniel Veillard wrote:
On Wed, Feb 16, 2011 at 02:39:30PM -0700, Eric Blake wrote:
* .gnulib: update to latest gnulib for maint.mk fixes
---
In testing the latest release candidate, I ran 'make syntax-check'
out of habit, and it died miserably (even hanging waiting
On 02/17/2011 04:01 AM, Jiri Denemark wrote:
Followup to commit 17e19add, and would have prevented the bug
independently fixed in commit 76c57a7c.
I would have implemented this as
if (...)
-return;
+goto out;
...
VIR_FREE(msg);
+
+out:
+errno =
On 02/16/2011 08:32 PM, Wen Congyang wrote:
When we attach a disk, but we specify a wrong format of disk image,
qemu monitor command drive_add will fail, but libvirt does not detect
this error.
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
---
src/qemu/qemu_monitor_text.c |6
---
src/util/hash.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/util/hash.c b/src/util/hash.c
index c7a52c9..ba156b1 100644
--- a/src/util/hash.c
+++ b/src/util/hash.c
@@ -190,9 +190,10 @@ virHashGrow(virHashTablePtr table, int size)
VIR_FREE(oldtable);
Hi,
This is a resend of my virHash patches. I rebased my git branch
on top of origin/master after the release, since 2 of them needed
rediffing, here they are again.
Christophe
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
The code in virHashUpdateEntry and virHashAddEntry is really
similar. However, the latter rebalances the hash table when
one of its buckets contains too many elements while the former
does not. Fix this discrepancy.
---
src/util/hash.c |7 ++-
1 files changed, 6 insertions(+), 1
The only difference between these 2 functions is that one errors
out when the entry is already present while the other modifies
the existing entry. Add an helper function with a boolean argument
indicating whether existing entries should be updated or not, and
use this helper in both functions.
virHashFree follows the convention described in HACKING that
XXXFree() functions can be called with a NULL argument.
---
src/conf/domain_conf.c |6 +---
src/datatypes.c | 51 +++---
src/qemu/qemu_process.c |4 +--
3 files changed, 20
Now that the virHash handling functions call virReportOOMError by
themselves when needed, users of the virHash API no longer need to
do it by themselves. Since users of the virHash API were not
consitently calling virReportOOMError after memory failures from
the virHash code, this has the added
Hi,
Here are 2 cleanup patches for 2 smallish issues I found when
looking at how virHash was used in libvirt.
Christophe
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
There were several occurrences of an extra space inserted between
a function name and the ( opening the argument list in
datatypes.c. This is not consistent with the coding style used in
the rest of this file so removing this extra space makes the
code slightly more readable.
---
src/datatypes.c
---
src/qemu/qemu_command.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index c9feb9b..371a7ed 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -4243,7 +4243,6 @@ qemuBuildCommandLine(virConnectPtr
libvirt-tck was failing several domain tests [1] with qemu 0.14, which
is now less tolerable of specifying 2 bootroms with the same boot index [2].
Drop the 'boot=on' param if kernel has been specfied.
[1] https://www.redhat.com/archives/libvir-list/2011-February/msg00559.html
[2]
Daniel P. Berrange wrote:
On Wed, Feb 16, 2011 at 05:10:10PM -0700, Jim Fehlig wrote:
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 05f427c..9186707 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -3112,7 +3112,7 @@
On 02/17/2011 02:38 PM, Jim Fehlig wrote:
libvirt-tck was failing several domain tests [1] with qemu 0.14, which
is now less tolerable of specifying 2 bootroms with the same boot index [2].
Drop the 'boot=on' param if kernel has been specfied.
[1]
Hi all,
This used to work on libvirt-0.8.7:
console type='pty'
target type='virtio'/
/console
Using the same configuration with libvirt-0.8.8:
[root@ev004 ~]# virsh create /data/4d5d8a24-bb70-4eff-b1b5-3d8e5bd5c355.xml
error: Failed to create domain from
On 02/17/2011 06:39 AM, Michal Privoznik wrote:
as written in docs, one must parse capabilities XML to get the right
count of NUMA nodes.
---
tools/virsh.c | 27 ---
1 files changed, 16 insertions(+), 11 deletions(-)
-if (!info.nodes) {
-
On 02/17/2011 06:14 AM, Daniel P. Berrange wrote:
On Thu, Feb 17, 2011 at 01:45:42PM +0100, Markus Groß wrote:
Hi,
I refactored the XM and SEXPR parsing routines from the xen-unified
driver into a seperate directory (xenxs; x for xm and s for sexpr).
This way different xen-drivers besides
On 02/17/2011 08:06 AM, Jiri Denemark wrote:
On Wed, Feb 16, 2011 at 16:19:38 -0700, Eric Blake wrote:
Anything distributed in the tarball should be built into srcdir.
* docs/Makefile.am (%.html): Build into srcdir.
---
This gets a VPATH build further, but things still aren't complete for
On 02/17/2011 02:14 PM, Christophe Fergeau wrote:
---
src/util/hash.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/util/hash.c b/src/util/hash.c
index c7a52c9..ba156b1 100644
--- a/src/util/hash.c
+++ b/src/util/hash.c
@@ -190,9 +190,10 @@
On 02/17/2011 02:14 PM, Christophe Fergeau wrote:
The only difference between these 2 functions is that one errors
out when the entry is already present while the other modifies
the existing entry. Add an helper function with a boolean argument
indicating whether existing entries should be
On 02/17/2011 02:14 PM, Christophe Fergeau wrote:
The code in virHashUpdateEntry and virHashAddEntry is really
similar. However, the latter rebalances the hash table when
one of its buckets contains too many elements while the former
does not. Fix this discrepancy.
---
src/util/hash.c |
On 02/17/2011 02:14 PM, Christophe Fergeau wrote:
Now that the virHash handling functions call virReportOOMError by
themselves when needed, users of the virHash API no longer need to
do it by themselves. Since users of the virHash API were not
consitently calling virReportOOMError after memory
[adding Jim to cc, as author of useless-if-before-free]
On 02/17/2011 02:14 PM, Christophe Fergeau wrote:
virHashFree follows the convention described in HACKING that
XXXFree() functions can be called with a NULL argument.
---
src/conf/domain_conf.c |6 +---
src/datatypes.c |
On 02/17/2011 02:18 PM, Christophe Fergeau wrote:
There were several occurrences of an extra space inserted between
a function name and the ( opening the argument list in
datatypes.c. This is not consistent with the coding style used in
the rest of this file so removing this extra space makes
On 02/17/2011 02:18 PM, Christophe Fergeau wrote:
---
src/qemu/qemu_command.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index c9feb9b..371a7ed 100644
--- a/src/qemu/qemu_command.c
+++
On 02/17/2011 01:19 PM, Justin Clift wrote:
On 18/02/2011, at 7:12 AM, Eric Blake wrote:
snip
[note to self - it might be possible to drop the nc dependency in the
future, once I finish my conversion from -migration exec: to -migration
fd:, since the spec file only targets distros with
Dominik Klein wrote:
Hi
not that I tested this patch or the patch that followed (adding
blkiotune command) ... but the way I understand, the cgroup blkio
controller does only work for sync'd IO/queues.
quote blkio-controller.txt from 2.6.37:
Currently only sync IO queues are support. All
Implement domainSetBlkioParamters and domainGetBlkioParamters for QEmu
v1- v2 Changes:
- Improve error message output suggested by Osier.
Signed-off-by: Gui Jianfeng guijianf...@cn.fujitsu.com
---
src/qemu/qemu_driver.c | 162 +++-
1 files changed,
Adding blkiotune command to virsh tool
v1 - v2 Changes:
- Fix some typo.
Signed-off-by: Gui Jianfeng guijianf...@cn.fujitsu.com
---
tools/virsh.c | 127 +
1 files changed, 127 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.c
Documents for blkiotune.
Signed-off-by: Gui Jianfeng guijianf...@cn.fujitsu.com
---
tools/virsh.pod |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index a2ca384..014d953 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -610,6
Eric Blake wrote:
On 02/17/2011 07:05 PM, Gui Jianfeng wrote:
Documents for blkiotune.
Signed-off-by: Gui Jianfeng guijianf...@cn.fujitsu.com
---
tools/virsh.pod |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index
Eric Blake wrote:
On 02/17/2011 07:05 PM, Gui Jianfeng wrote:
Documents for blkiotune.
Signed-off-by: Gui Jianfeng guijianf...@cn.fujitsu.com
---
tools/virsh.pod |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index
When I build libvirt without libvirtd, I receive the following errors:
GENvirsh.1
CCLD virsh
../src/.libs/libvirt.so: undefined reference to `dm_is_dm_major'
collect2: ld returned 1 exit status
make[3]: *** [virsh] Error 1
My build step:
# ./autogen.sh --without-libvirtd
# make dist
#
Eric Blake wrote:
On 02/17/2011 02:38 PM, Jim Fehlig wrote:
libvirt-tck was failing several domain tests [1] with qemu 0.14, which
is now less tolerable of specifying 2 bootroms with the same boot index [2].
Drop the 'boot=on' param if kernel has been specfied.
[1]
At 02/18/2011 05:09 AM, Eric Blake Write:
On 02/16/2011 08:32 PM, Wen Congyang wrote:
Steps to reproduce this bug:
1. virsh attach-disk domain --source diskimage --target sdb --sourcetype
file --driver qemu --subdriver qcow2
error: Failed to attach disk
error: operation failed: adding
于 2011年02月18日 04:12, Eric Blake 写道:
On 02/17/2011 03:05 AM, Osier Yang wrote:
libvirt-guests invokes functions in gettext.sh, so we need to
require gettext package in spec file.
Demo with the fix:
% rpm -q gettext
package gettext is not installed
% rpm -ivh
On 02/17/2011 11:11 PM, Eric Blake wrote:
On 02/17/2011 06:39 AM, Michal Privoznik wrote:
...
As Matthias pointed out, we already have a parse function. If you ditch
patch 1/2, then squash this into 2/2, does it all work for you (only
compile-tested here)?
I've sent the second version,
于 2011年02月18日 08:30, Eric Blake 写道:
On 02/17/2011 01:19 PM, Justin Clift wrote:
On 18/02/2011, at 7:12 AM, Eric Blake wrote:
snip
[note to self - it might be possible to drop the nc dependency in the
future, once I finish my conversion from -migration exec: to -migration
fd:, since the spec
于 2011年02月17日 23:36, Osier Yang 写道:
于 2011年02月17日 19:15, Daniel P. Berrange 写道:
On Thu, Feb 17, 2011 at 05:30:23PM +0800, Osier Yang wrote:
As virDomainDefParseString already reported the error if it
fails, and the redundant error reports codes will override
error reported by
Hi all:
This patch updeted the building system.
* Added necessary checkings in configure.ac
* Cleared up libvirt-php.spec and src/Makefile.am
BTW, I've changed my email to business address.
Lyre (2):
spec file cleanup
Added checkings for tools and libraries
aclocal.m4 | 189
* configure.ac: Added checkings for compiler, sed, install, and so on;
Added AM_PATH_XML2 to check libxml2.
* src/Makefile.am: dropped needless macros since it is done by autoconf;
Use $INSTALL to install files rather than cp.
---
aclocal.m4 | 189
80 matches
Mail list logo
