[libvirt] [PATCH] schedinfo: add missing documentation

2011-08-19 Thread Taku Izumi
This patch adds the missing documentation about the scheduler parameter vcpu_period and vcpu_quota. Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com --- tools/virsh.pod |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) Index: libvirt/tools/virsh.pod

Re: [libvirt] USB2 controllers domain XML

2011-08-19 Thread Osier Yang
于 2011年08月19日 11:32, Osier Yang 写道: 于 2011年08月18日 23:18, Marc-André Lureau 写道: Hi I have started looking at: https://bugzilla.redhat.com/show_bug.cgi?id=725670 My initial thought was to just add a new type of controller: controller type='usb2' index='0'/ But it also needs the 3 companion

[libvirt] [RFC] NUMA topology specification

2011-08-19 Thread Bharata B Rao
Hi, qemu supports specification of NUMA topology on command line using -numa option. -numa node[,mem=size][,cpus=cpu[-cpu]][,nodeid=node] I see that there is no way to specify such NUMA topology in libvirt XML. Are there plans to add support for NUMA topology specification ? Is anybody already

Re: [libvirt] [RFC] NUMA topology specification

2011-08-19 Thread Osier Yang
于 2011年08月19日 14:35, Bharata B Rao 写道: Hi, qemu supports specification of NUMA topology on command line using -numa option. -numa node[,mem=size][,cpus=cpu[-cpu]][,nodeid=node] I see that there is no way to specify such NUMA topology in libvirt XML. Are there plans to add support for NUMA

Re: [libvirt] [RFC] NUMA topology specification

2011-08-19 Thread Bharata B Rao
On Fri, Aug 19, 2011 at 12:55 PM, Osier Yang jy...@redhat.com wrote: 于 2011年08月19日 14:35, Bharata B Rao 写道: How about something like this ? (OPTION 1) cpu ... numa nodeid='node' cpus='cpu[-cpu]' mem='size' ... /cpu Libvirt already supported NUMA setting (both cpu and memory) on host

Re: [libvirt] [RFC] NUMA topology specification

2011-08-19 Thread Bharata B Rao
2011/8/19 Bharata B Rao bharata@gmail.com: Hence I am not sure if if numatune is the right place for defining host NUMA topology which btw should be independent of the host ^^guest Sorry for the typo. -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [RFC] NUMA topology specification

2011-08-19 Thread Osier Yang
于 2011年08月19日 16:09, Bharata B Rao 写道: On Fri, Aug 19, 2011 at 12:55 PM, Osier Yang jy...@redhat.com wrote: 于 2011年08月19日 14:35, Bharata B Rao 写道: How about something like this ? (OPTION 1) cpu ... numa nodeid='node' cpus='cpu[-cpu]' mem='size' ... /cpu Libvirt already supported NUMA

Re: [libvirt] [RFC] NUMA topology specification

2011-08-19 Thread Bharata B Rao
2011/8/19 Osier Yang jy...@redhat.com: Maybe something like: numatune guest .. /guest /numatune Yes, one possible solution. Let me wait and see what others say and what will be the consensus. Regards, Bharata. -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 1/3] maint: treat more libxml2 functions as free-like

2011-08-19 Thread Daniel Veillard
On Thu, Aug 18, 2011 at 03:40:47PM -0600, Eric Blake wrote: * cfg.mk (useless_free_options): Add xmlFreeDoc, xmlBufferFree. * src/esx/esx_vi.c (ESX_VI__TEMPLATE__FREE): Fix offenders. * tools/virsh.c (cmdFreecell, cmdVNCDisplay, cmdTTYConsole) (cmdDetachInterface, cmdDetachDisk,

Re: [libvirt] [PATCH 2/3] xml: add another convenience function

2011-08-19 Thread Daniel Veillard
On Thu, Aug 18, 2011 at 03:40:48PM -0600, Eric Blake wrote: Often, we want to use XPath functions on the just-parsed document; fold this into the parser function for convenience. * src/util/xml.h (virXMLParseHelper): Add argument. (virXMLParseStrHelper, virXMLParseFileHelper): Delete.

Re: [libvirt] [PATCH 3/3] maint: simplify lots of libxml2 clients

2011-08-19 Thread Daniel Veillard
On Thu, Aug 18, 2011 at 03:40:49PM -0600, Eric Blake wrote: Repetitive patterns should be factored. The sign of a good factorization is a change that kills 5x more lines than it adds :) * src/conf/domain_conf.c (virDomainDeviceDefParse) (virDomainSnapshotDefParseString): Use new convenience

Re: [libvirt] [PATCH 0/3] xml simplifications

2011-08-19 Thread Daniel Veillard
On Thu, Aug 18, 2011 at 03:46:01PM -0600, Eric Blake wrote: On 08/18/2011 03:40 PM, Eric Blake wrote: I noticed this while working on my snapshot stuff. There was lots of copy and paste going on in virsh.c, and it felt awful to not be able to represent the same idea in fewer lines, so I fixed

Re: [libvirt] [PATCH] schedinfo: add missing documentation

2011-08-19 Thread Daniel Veillard
On Fri, Aug 19, 2011 at 03:07:21PM +0900, Taku Izumi wrote: This patch adds the missing documentation about the scheduler parameter vcpu_period and vcpu_quota. Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com ACK, pushed, thanks ! Daniel -- Daniel Veillard | libxml Gnome

Re: [libvirt] [PATCH] build: fix compilation on mingw64

2011-08-19 Thread Daniel Veillard
On Wed, Aug 17, 2011 at 06:18:40PM -0600, Eric Blake wrote: * .gnulib: Update to latest, for getcwd fixes. --- Spurred by a gnulib bug report by Marc-André Lureau. Fedora currently uses the mingw32 cross-compiler, but is aiming to switch to the mingw64 cross-compiler; once that is done,

Re: [libvirt] [PATCH] storage: Flush host cache after write

2011-08-19 Thread Michal Privoznik
On 19.08.2011 11:04, Daniel Veillard wrote: On Thu, Aug 18, 2011 at 04:25:55PM +0200, Michal Privoznik wrote: On 18.08.2011 15:55, Eric Blake wrote: On 08/18/2011 07:44 AM, Michal Privoznik wrote: Although we are flushing cache after some critical writes (e.g. volume creation), after some

Re: [libvirt] [PATCH v2] daemon: initialize GnuTLS

2011-08-19 Thread Michal Privoznik
On 19.08.2011 11:03, Daniel Veillard wrote: On Thu, Aug 18, 2011 at 10:48:35AM +0200, Michal Privoznik wrote: When spice_tls is set but listen_tls is not, we don't initialize GnuTLS library. So any later gnutls call (e.g. during migration, where we initialize a certificate) will access

Re: [libvirt] [PATCH v2] daemon: initialize GnuTLS

2011-08-19 Thread Daniel Veillard
On Thu, Aug 18, 2011 at 10:48:35AM +0200, Michal Privoznik wrote: When spice_tls is set but listen_tls is not, we don't initialize GnuTLS library. So any later gnutls call (e.g. during migration, where we initialize a certificate) will access uninitialized GnuTLS internal structs and throws an

Re: [libvirt] [PATCH] storage: Flush host cache after write

2011-08-19 Thread Daniel Veillard
On Thu, Aug 18, 2011 at 04:25:55PM +0200, Michal Privoznik wrote: On 18.08.2011 15:55, Eric Blake wrote: On 08/18/2011 07:44 AM, Michal Privoznik wrote: Although we are flushing cache after some critical writes (e.g. volume creation), after some others we do not (e.g. volume cloning).

[libvirt] [PATCH v2] qemu: Get memory balloon info correctly for text monitor

2011-08-19 Thread Osier Yang
* src/qemu/qemu_monitor_text.c: BALLOON_PREFIX was defined as balloon: actual=, which cause actual= is stripped early before the real parsing. This patch changes BALLOON_PREFIX into balloon: , and modifies related functions, also renames qemuMonitorParseExtraBalloonInfo to

Re: [libvirt] USB2 controllers domain XML

2011-08-19 Thread Marc-André Lureau
Hi Osier, On Fri, Aug 19, 2011 at 8:31 AM, Osier Yang jy...@redhat.com wrote: Marc-André, I just worked out the XML nodes, and a bit codes to parse the XML, I'm fine to quit if you went further than me. I am now more or less at 5 in Daniel plan. Did you go further? 22 files changed, 512

Re: [libvirt] [RFC] Add a new feild to qemud_save_header to tell if the saved image is corrupt

2011-08-19 Thread Eric Blake
On 08/17/2011 10:01 AM, Daniel P. Berrange wrote: The downside to adding a new header field, is that old libvirt won't look for it. A slightly more evil approach is to 1. Write header, but with 'magic' set to all zerso Or even to a specific value, different from all zeros, which new

Re: [libvirt] USB2 controllers domain XML

2011-08-19 Thread Marc-André Lureau
Hi On Thu, Aug 18, 2011 at 9:42 PM, Daniel P. Berrange berra...@redhat.com wrote:  5. USB companion controllers use type='usb' too, but with an     extra 'master' attribute to associate them       controller type='usb' index='0' model='ich9-ehci'         address type='pci' domain='0'

Re: [libvirt] [RFC] Add a new feild to qemud_save_header to tell if the saved image is corrupt

2011-08-19 Thread Eric Blake
On 08/18/2011 11:42 PM, Osier Yang wrote: Remember, that 'migrate' is a long-running async job command, and can be interrupted. That is, 'service libvirtd restart' is a legal action to take during step 3, and it is not as severe as a libvirtd crash, and we have already recently added patches to

Re: [libvirt] [PATCH v2] qemu: Get memory balloon info correctly for text monitor

2011-08-19 Thread Eric Blake
On 08/19/2011 04:17 AM, Osier Yang wrote: * src/qemu/qemu_monitor_text.c: BALLOON_PREFIX was defined as balloon: actual=, which cause actual= is stripped early before the real parsing. This patch changes BALLOON_PREFIX into balloon: , and modifies related functions, also renames

[libvirt] [PATCH 4/8] qemu: Allow to undefine a running domain

2011-08-19 Thread Osier Yang
--- src/qemu/qemu_driver.c | 22 +- 1 files changed, 13 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 421a98e..81be950 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -4720,12 +4720,6 @@

[libvirt] [PATCH 3/8] openvz: Allow to undefine a running domain

2011-08-19 Thread Osier Yang
--- src/openvz/openvz_driver.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index b9dc712..69ff444 100644 --- a/src/openvz/openvz_driver.c +++ b/src/openvz/openvz_driver.c @@ -1132,19 +1132,18 @@

[libvirt] [PATCH 2/8] lxc: Allow to undefine a running domain

2011-08-19 Thread Osier Yang
--- src/lxc/lxc_driver.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index bb560b6..a596945 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -479,12 +479,6 @@ static int

[libvirt] [PATCH 8/8] xen: Allow to undefine a running domain (xm_internal)

2011-08-19 Thread Osier Yang
--- src/xen/xm_internal.c | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/xen/xm_internal.c b/src/xen/xm_internal.c index 95387c9..5c8a017 100644 --- a/src/xen/xm_internal.c +++ b/src/xen/xm_internal.c @@ -1218,8 +1218,6 @@ int

[libvirt] Allow to undefine a running domain

2011-08-19 Thread Osier Yang
Per API virDomainUndefineFlags' doc says, if a domain is running, it will be converted to transient, but keep running. However, the drivers prohibit one undefining a running domain. This patch series modify the internal domainUndefineFlags function of all drivers (except some driver don't need

[libvirt] [PATCH 7/8] vmware: Allow to undefine a running domain

2011-08-19 Thread Osier Yang
--- src/vmware/vmware_driver.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/vmware/vmware_driver.c b/src/vmware/vmware_driver.c index 5c63239..b2cfdce 100644 --- a/src/vmware/vmware_driver.c +++ b/src/vmware/vmware_driver.c @@ -639,20 +639,19 @@

[libvirt] [PATCH 1/8] libxl: Allow to undefine a running domain

2011-08-19 Thread Osier Yang
--- src/libxl/libxl_driver.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 516148f..d6e0c28 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -2802,12 +2802,6 @@

[libvirt] [PATCH 5/8] test: Allow to undefine a running domain

2011-08-19 Thread Osier Yang
--- src/test/test_driver.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index fb14b10..422486e 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -2601,18 +2601,17 @@ static int

[libvirt] [PATCH 6/8] uml: Allow to undefine a running domain

2011-08-19 Thread Osier Yang
--- src/uml/uml_driver.c | 16 +++- 1 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c index a9cb7ef..19b6c55 100644 --- a/src/uml/uml_driver.c +++ b/src/uml/uml_driver.c @@ -1806,12 +1806,6 @@ static int

Re: [libvirt] [PATCH] build: fix compilation on mingw64

2011-08-19 Thread Eric Blake
On 08/19/2011 02:54 AM, Daniel Veillard wrote: On Wed, Aug 17, 2011 at 06:18:40PM -0600, Eric Blake wrote: * .gnulib: Update to latest, for getcwd fixes. --- Spurred by a gnulib bug report by Marc-André Lureau. FYI: doing the gnulib update also pulled in a refresh to the bootstrap script.

Re: [libvirt] [PATCH v2] qemu: Get memory balloon info correctly for text monitor

2011-08-19 Thread Osier Yang
于 2011年08月19日 21:26, Eric Blake 写道: On 08/19/2011 04:17 AM, Osier Yang wrote: * src/qemu/qemu_monitor_text.c: BALLOON_PREFIX was defined as balloon: actual=, which cause actual= is stripped early before the real parsing. This patch changes BALLOON_PREFIX into balloon: , and modifies related

Re: [libvirt] Allow to undefine a running domain

2011-08-19 Thread Eric Blake
On 08/19/2011 08:03 AM, Osier Yang wrote: Per API virDomainUndefineFlags' doc says, if a domain is running, it will be converted to transient, but keep running. However, the drivers prohibit one undefining a running domain. This patch series modify the internal domainUndefineFlags function of

Re: [libvirt] [RFC] NUMA topology specification

2011-08-19 Thread Adam Litke
On 08/19/2011 01:35 AM, Bharata B Rao wrote: May be something like this: (OPTION 2) cpu ... topology sockets='1' cores='2' threads='1' nodeid='0' cpus='0-1' mem='size' topology sockets='1' cores='2' threads='1' nodeid='1' cpus='2-3' mem='size' ... /cpu This should result in a 2 node

Re: [libvirt] Allow to undefine a running domain

2011-08-19 Thread Osier Yang
于 2011年08月19日 21:39, Eric Blake 写道: On 08/19/2011 08:03 AM, Osier Yang wrote: Per API virDomainUndefineFlags' doc says, if a domain is running, it will be converted to transient, but keep running. However, the drivers prohibit one undefining a running domain. This patch series modify the

Re: [libvirt] [PATCH 1/8] libxl: Allow to undefine a running domain

2011-08-19 Thread Eric Blake
On 08/19/2011 08:03 AM, Osier Yang wrote: --- src/libxl/libxl_driver.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) ACK. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org -- libvir-list mailing list

Re: [libvirt] [PATCH 3/8] openvz: Allow to undefine a running domain

2011-08-19 Thread Eric Blake
On 08/19/2011 08:03 AM, Osier Yang wrote: --- src/openvz/openvz_driver.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) ACK. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org -- libvir-list mailing list

Re: [libvirt] [PATCH 2/8] lxc: Allow to undefine a running domain

2011-08-19 Thread Eric Blake
On 08/19/2011 08:03 AM, Osier Yang wrote: --- src/lxc/lxc_driver.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) ACK. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org -- libvir-list mailing list

Re: [libvirt] [PATCH 4/8] qemu: Allow to undefine a running domain

2011-08-19 Thread Eric Blake
On 08/19/2011 08:03 AM, Osier Yang wrote: --- src/qemu/qemu_driver.c | 22 +- 1 files changed, 13 insertions(+), 9 deletions(-) ACK with nit. VIR_INFO(Undefining domain '%s', vm-def-name); -virDomainRemoveInactive(driver-domains, -

Re: [libvirt] [PATCH 6/8] uml: Allow to undefine a running domain

2011-08-19 Thread Eric Blake
On 08/19/2011 08:03 AM, Osier Yang wrote: --- src/uml/uml_driver.c | 16 +++- 1 files changed, 7 insertions(+), 9 deletions(-) ACK. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org -- libvir-list mailing list

Re: [libvirt] [PATCH 2/8] lxc: Allow to undefine a running domain

2011-08-19 Thread Osier Yang
于 2011年08月19日 21:47, Eric Blake 写道: On 08/19/2011 08:03 AM, Osier Yang wrote: --- src/lxc/lxc_driver.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) ACK. Pushed. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/8] libxl: Allow to undefine a running domain

2011-08-19 Thread Osier Yang
于 2011年08月19日 21:46, Eric Blake 写道: On 08/19/2011 08:03 AM, Osier Yang wrote: --- src/libxl/libxl_driver.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) ACK. Pushed -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 5/8] test: Allow to undefine a running domain

2011-08-19 Thread Eric Blake
On 08/19/2011 08:03 AM, Osier Yang wrote: --- src/test/test_driver.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) ACK. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org -- libvir-list mailing list

Re: [libvirt] [PATCH 8/8] xen: Allow to undefine a running domain (xm_internal)

2011-08-19 Thread Eric Blake
On 08/19/2011 08:03 AM, Osier Yang wrote: --- src/xen/xm_internal.c | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) ACK. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org -- libvir-list mailing list

Re: [libvirt] [PATCH 7/8] vmware: Allow to undefine a running domain

2011-08-19 Thread Eric Blake
On 08/19/2011 08:03 AM, Osier Yang wrote: --- src/vmware/vmware_driver.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) ACK. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org -- libvir-list mailing list

Re: [libvirt] [PATCH 4/8] qemu: Allow to undefine a running domain

2011-08-19 Thread Osier Yang
于 2011年08月19日 21:48, Eric Blake 写道: On 08/19/2011 08:03 AM, Osier Yang wrote: --- src/qemu/qemu_driver.c | 22 +- 1 files changed, 13 insertions(+), 9 deletions(-) ACK with nit. VIR_INFO(Undefining domain '%s', vm-def-name); - virDomainRemoveInactive(driver-domains, -

Re: [libvirt] [PATCH 3/8] openvz: Allow to undefine a running domain

2011-08-19 Thread Osier Yang
于 2011年08月19日 21:47, Eric Blake 写道: On 08/19/2011 08:03 AM, Osier Yang wrote: --- src/openvz/openvz_driver.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) ACK. Pushed. -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 1/8] libxl: Allow to undefine a running domain

2011-08-19 Thread Osier Yang
于 2011年08月19日 22:03, Osier Yang 写道: --- src/libxl/libxl_driver.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 516148f..d6e0c28 100644 --- a/src/libxl/libxl_driver.c +++

Re: [libvirt] [PATCHv2 14/26] snapshot: prevent stranding snapshot data on domain destruction

2011-08-19 Thread Eric Blake
On 08/15/2011 05:33 PM, Eric Blake wrote: Just as leaving managed save metadata behind can cause problems when creating a new domain that happens to collide with the name of the just-deleted domain, the same is true of leaving any snapshot metadata behind. For safety sake, extend the semantic

Re: [libvirt] [PATCH 5/8] test: Allow to undefine a running domain

2011-08-19 Thread Eric Blake
On 08/19/2011 08:03 AM, Osier Yang wrote: --- src/test/test_driver.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index fb14b10..422486e 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] How to avoid the disk still persistent after no persistent hotplug and with restarting libvirtd then.

2011-08-19 Thread Osier Yang
Libvirt loads the domain conf from the status file (/var/run/libvirt/qemu/$dom.xml) if the domain is running, the problem if one restart libvirtd just after some changing on the domain conf, and then destroy/start the guest. libvirt will never known what the original domain conf is then.

Re: [libvirt] [PATCH 8/8] xen: Allow to undefine a running domain (xm_internal)

2011-08-19 Thread Eric Blake
On 08/19/2011 08:03 AM, Osier Yang wrote: --- src/xen/xm_internal.c | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) Aargh, again I spoke too soon. diff --git a/src/xen/xm_internal.c b/src/xen/xm_internal.c index 95387c9..5c8a017 100644 ---

Re: [libvirt] USB2 controllers domain XML

2011-08-19 Thread Hans de Goede
Hi, On 08/19/2011 06:13 AM, Marc-André Lureau wrote: Hi On Thu, Aug 18, 2011 at 9:42 PM, Daniel P. Berrangeberra...@redhat.com wrote: 5. USB companion controllers use type='usb' too, but with an extra 'master' attribute to associate them controller type='usb' index='0'

Re: [libvirt] [PATCH 5/8] test: Allow to undefine a running domain

2011-08-19 Thread Eric Blake
On 08/19/2011 08:12 AM, Eric Blake wrote: - virDomainRemoveInactive(privconn-domains, - privdom); - privdom = NULL; + if (virDomainObjIsActive(vm)) { + vm-persistent = 0; Spoke too soon. This doesn't compile. I'll be pushing this. diff --git i/src/test/test_driver.c w/src/test/test_driver.c

[libvirt] [PATCH] build: rewrite test to match change in behavior

2011-08-19 Thread Eric Blake
Test failure exposed in commit 7d3390f. * tests/undefine: Fix to match updated test driver semantics. --- Pushing under the build-breaker rule. tests/undefine | 42 -- 1 files changed, 28 insertions(+), 14 deletions(-) diff --git a/tests/undefine

Re: [libvirt] [PATCH] build: rewrite test to match change in behavior

2011-08-19 Thread Eric Blake
On 08/19/2011 08:58 AM, Eric Blake wrote: # Succeed, now: first shut down, then undefine, both via name. -$abs_top_builddir/tools/virsh -q -c test:///default 'shutdown test; undefine test' out 21 -test $? = 0 || fail=1 -cat\EOF exp || fail=1 +$abs_top_builddir/tools/virsh -q -c

Re: [libvirt] [PATCH 2/3] xml: add another convenience function

2011-08-19 Thread Eric Blake
On 08/19/2011 02:48 AM, Daniel Veillard wrote: + * Return the parsed document object, or NULL on failure. + */ +# define virXMLParseFileCtxt(filename, pctxt) \ +virXMLParseHelper(VIR_FROM_THIS, filename, NULL, NULL, pctxt) #endif /*

[libvirt] [PATCH] virsh: properly interleave shared stdout and stderr

2011-08-19 Thread Eric Blake
Without this patch, invoking 'virsh file 21' results in error messages appearing before normal output, even if they occurred later in time than the normal output (since stderr is unbuffered, but stdout waits until a full buffer). * tools/virsh.c (print_job_progress, vshError): Flush between

Re: [libvirt] [PATCH 2/2] virsh: fix snapshot-create-as to handle arbitrary names

2011-08-19 Thread Eric Blake
On 08/10/2011 10:02 PM, Eric Blake wrote: On 08/10/2011 08:33 PM, Daniel Veillard wrote: On Wed, Aug 10, 2011 at 05:02:37PM -0600, Eric Blake wrote: Found this while revising the previous patch to use xpath rather than strstr for undoing the escapse. typo, escape I adjusted the message to

[libvirt] [PATCH 21a/26] snapshot: correctly escape generated xml

2011-08-19 Thread Eric Blake
Commit 69278878 fixed one direction of arbitrarily-named snapshots, but not the round trip path. While auditing domain_conf, I found a couple other instances that weren't escaping arbitrary strings. * src/conf/domain_conf.c (virDomainFSDefFormat) (virDomainGraphicsListenDefFormat,

Re: [libvirt] [PATCH 33/26] snapshot: support extra state in snapshots

2011-08-19 Thread Eric Blake
On 08/18/2011 06:07 PM, Eric Blake wrote: In order to distinguish disk snapshots from system checkpoints, a new state value that is only valid for snapshots is helpful. * include/libvirt/libvirt.h.in (VIR_DOMAIN_LAST): New placeholder. * src/conf/domain_conf.h (virDomainSnapshotState): New enum

Re: [libvirt] How to avoid the disk still persistent after no persistent hotplug and with restarting libvirtd then.

2011-08-19 Thread Eric Blake
On 08/19/2011 08:17 AM, Osier Yang wrote: Libvirt loads the domain conf from the status file (/var/run/libvirt/qemu/$dom.xml) if the domain is running, the problem if one restart libvirtd just after some changing on the domain conf, and then destroy/start the guest. libvirt will never known what

Re: [libvirt] [PATCH] virsh: properly interleave shared stdout and stderr

2011-08-19 Thread Laine Stump
On 08/19/2011 11:23 AM, Eric Blake wrote: Without this patch, invoking 'virshfile 21' results in error messages appearing before normal output, even if they occurred later in time than the normal output (since stderr is unbuffered, but stdout waits until a full buffer). * tools/virsh.c

[libvirt] xml style?

2011-08-19 Thread Eric Blake
When writing an attribute in xml, which style is preferred? element attr='single'/ element attr=double/ We are currently rather split-brain in libvirt, among three general areas: test programs under tests/*data/*, documentation under docs/*.html.in, and RNG schemas under docs/schemas/*. In

[libvirt] virt-manager, debug error, question

2011-08-19 Thread Jason Helfman
Hi, I am getting this error when I run virt-manager in FreeBSD: [Fri, 19 Aug 2011 09:32:14 virt-manager 24762] DEBUG (engine:555) No inspection thread because libguestfs is too old, not available, or libvirt is not thread safe. libguestfs isn't ported to FreeBSD, however I was wondering about

Re: [libvirt] xml style?

2011-08-19 Thread Eric Blake
On 08/19/2011 01:25 PM, Eric Blake wrote: When writing an attribute in xml, which style is preferred? element attr='single'/ element attr=double/ We are currently rather split-brain in libvirt, among three general areas: test programs under tests/*data/*, documentation under docs/*.html.in,

Re: [libvirt] virt-manager, debug error, question

2011-08-19 Thread Eric Blake
On 08/19/2011 01:27 PM, Jason Helfman wrote: Hi, I am getting this error when I run virt-manager in FreeBSD: [Fri, 19 Aug 2011 09:32:14 virt-manager 24762] DEBUG (engine:555) No inspection thread because libguestfs is too old, not available, or libvirt is not thread safe. libguestfs isn't

[libvirt] Fwd: [virt-tools-list] virt-manager, dependency question

2011-08-19 Thread Jason Helfman
Any thoughts on this to this list? Figure I would get a quicker response here, possibly. Thanks, Jason -- Jason Helfman System Administrator experts-exchange.com http://www.experts-exchange.com/M_4830110.html E4AD 7CF1 1396 27F6 79DD 4342 5E92 AD66 8C8C FBA5 ---BeginMessage--- Hi, I am

Re: [libvirt] [PATCH] virsh: properly interleave shared stdout and stderr

2011-08-19 Thread Eric Blake
On 08/19/2011 12:34 PM, Laine Stump wrote: On 08/19/2011 11:23 AM, Eric Blake wrote: Without this patch, invoking 'virshfile 21' results in error messages appearing before normal output, even if they occurred later in time than the normal output (since stderr is unbuffered, but stdout waits

[libvirt] [PATCH 34/26] snapshot: add disks to snapshot xml

2011-08-19 Thread Eric Blake
Adds an optional element to domainsnapshot, which will be used to give user control over external snapshot filenames on input, and specify generated filenames on output. domainsnapshot ... disks disk name='vda' snapshot='no'/ disk name='vdb' snapshot='internal'/ disk name='vdc'

Re: [libvirt] RFCv2: virDomainSnapshotCreateXML enhancements

2011-08-19 Thread Eric Blake
On 08/10/2011 04:08 PM, Eric Blake wrote: The disks element has an optional number of disk subelements; at most one per disk in the devices section of domain. Each disk element has a mandatory attribute name='name', which must match the target dev='name'/ of the domain xml, as a way of getting

Re: [libvirt] [PATCHv2 1/5] hyperv: Add configure check for OpenWSMAN

2011-08-19 Thread Eric Blake
On 08/03/2011 09:00 AM, Matthias Bolte wrote: --- v2: - relax OpenWSMAN requirement to 2.2.3 - move libvirt.spec.in change from 2/5 here and fix OpenWSMAN package name - qoute all PKG_CHECK_MODULES parameters configure.ac| 38 ++ libvirt.spec.in |

Re: [libvirt] [PATCHv2 2/5] hyperv: Add driver skeleton

2011-08-19 Thread Eric Blake
On 08/03/2011 09:00 AM, Matthias Bolte wrote: --- v2: - move libvirt.spec.in change to 1/5 22 files changed, 867 insertions(+), 0 deletions(-) ACK. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org -- libvir-list mailing list

[libvirt] status of ocaml for libvirt

2011-08-19 Thread Jason Helfman
Hello All, I was looking at porting virt-top to FreeBSD, and noticed that it needed ocaml-libvirt, and I know that isn't ported. What is the status of this library, and it is up-to-date? Thanks, Jason -- Jason Helfman System Administrator experts-exchange.com

Re: [libvirt] [PATCHv2 3/5] hyperv: Add OpenWSMAN based client for the Hyper-V WMI API

2011-08-19 Thread Eric Blake
On 08/03/2011 09:00 AM, Matthias Bolte wrote: Add a generator script to generate the structs and serialization information for OpenWSMAN. openwsman.h collects workarounds for problems in OpenWSMAN= 2.2.6. There are also disabled sections that would use ws_serializer_free_mem but can't because

Re: [libvirt] [PATCHv2 4/5] hyperv: Add basic driver for Microsoft Hyper-V

2011-08-19 Thread Eric Blake
On 08/03/2011 09:00 AM, Matthias Bolte wrote: Domain listing, basic information retrieval and domain life cycle management is implemented. But currently the domian XML output s/domian/domain/ lacks the complete devices section. The driver uses OpenWSMAN to directly communicate with an

Re: [libvirt] [PATCHv2 5/5] hyperv: Add basic documentation

2011-08-19 Thread Eric Blake
On 08/03/2011 09:00 AM, Matthias Bolte wrote: --- v2: - move microsoft.com link to drvhyperv.html.in docs/drivers.html.in |1 + docs/drvhyperv.html.in | 112 docs/index.html.in |3 + docs/sitemap.html.in |4 ++

Re: [libvirt] [PATCHv2 0/5] Add basic driver for Microsoft Hyper-V

2011-08-19 Thread Eric Blake
On 08/03/2011 09:00 AM, Matthias Bolte wrote: Version 2 of the Hyper-V driver. See the individual patches for the changes from version 1. Complete version 1 can be found here https://www.redhat.com/archives/libvir-list/2011-July/msg00766.html This series adds the basic driver and supports

Re: [libvirt] [PATCH 34/26] snapshot: add disks to snapshot xml

2011-08-19 Thread Eric Blake
On 08/19/2011 03:58 PM, Eric Blake wrote: Adds an optional element todomainsnapshot, which will be used to give user control over external snapshot filenames on input, and specify generated filenames on output. +/* Double check requested disks. */ +for (i = 0; i def-ndisks; i++) { +

[libvirt] [PATCH 35/26] snapshot: also support disks by path

2011-08-19 Thread Eric Blake
I got confused when 'virsh domblkinfo dom disk' required the path to a disk (which can be ambiguous, since a single file can back multiple disks), rather than the unambiguous target device name that I was using in disk snapshots. So, in true developer fashion, I went for the best of both worlds -