Re: [libvirt] [PATCH] lxc: drop sys_admin caps by default

On Wed, Nov 25, 2015 at 03:40:36PM +0100, Cédric Bosdonnat wrote: > To make sure the container user doesn't play with mounts, like > changing them from ro to rw, drop the sys_admin capability by default. > If user really needs to play with those, it can be enabled in the > configuration. > --- >

[libvirt] [PATCH] Enhance documentation of virDomainDetachDevice

Link it to virDomainDetachDeviceFlags. https://bugzilla.redhat.com/show_bug.cgi?id=1257280 Signed-off-by: Jiri Denemark --- src/libvirt-domain.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c

Re: [libvirt] [PATCH v3 02/11] virt-admin: Introduce first working skeleton

>> + * You should have received a copy of the GNU Lesser General Public >> + * License along with this library. If not, see >> + * . >> + * >> + * Erik Skultety > > We usually prepend this line with "Authors: ". > How can I keep forgetting

Re: [libvirt] [virt-tools-list] ANNOUNCE: virt-manager 1.3.0 released

Congrats ! And Big Thanks Cole ~ On 2015年11月25日 11:11, Cole Robinson wrote: I'm happy to announce the release of virt-manager 1.3.0! virt-manager is a desktop application for managing KVM, Xen, and LXC virtualization via libvirt. The release can be downloaded from:

Re: [libvirt] [PATCH] logging: inhibit virtlogd shutdown while log files are open

On 11/24/2015 08:10 AM, Daniel P. Berrange wrote: > The virtlogd daemon is launched with a 30 second timeout for > unprivileged users. Unfortunately the timeout is only inhibited > while RPC clients are connected, and they only connect for a > short while to open the log file descriptor. We need

[libvirt] [PATCH 6/6] virsh: Add build flags to pool-create[-as] and pool-start

https://bugzilla.redhat.com/show_bug.cgi?id=830056 Utilize recently added VIR_STORAGE_POOL_CREATE_WITH_BUILD* flags in order to pass the flags along to the virStoragePoolCreateXML and virStoragePoolCreate API's. This affects the 'virsh pool-create', 'virsh pool-create-as', and 'virsh pool-start'

[libvirt] [PATCH 1/6] storage: Add flags to allow building pool during create processing

https://bugzilla.redhat.com/show_bug.cgi?id=830056 Add flags handling to the virStoragePoolCreate and virStoragePoolCreateXML API's which will allow the caller to provide the capability for the storage pool create API's to also perform a pool build during creation rather than requiring the

[libvirt] [PATCH 2/6] virsh: Create macro for "pool" option

Rather than continually cut/paste the "pool" option for pool command option structures, generate a macro which will commonly define it for any command. Then of course use that macro. Signed-off-by: John Ferlan --- tools/virsh-pool.c | 91

[libvirt] [PATCH 3/6] virsh: Create macro for "file" option

Rather than continually cut/paste the "file" option for pool command option structures, generate a macro which will commonly define it for any command. Then of course use that macro. Signed-off-by: John Ferlan --- tools/virsh-pool.c | 21 +++-- 1 file

[libvirt] [PATCH 5/6] virsh: Create a macro for pool-define-as and pool-create-as options

Although they both are the same now, a future patch will add new options to pool-create-as. So create a common macro to capture commonality, then use that in the command specific structure. Signed-off-by: John Ferlan --- tools/virsh-pool.c | 151

[libvirt] [PATCH 0/6] Add build options to pool create[-as] and start

https://bugzilla.redhat.com/show_bug.cgi?id=830056 Add the capability to build the pool during pool creation or startup NOTE: If patches 2-4 regarding usage of #define for repeated command options are acceptible, I can start doing the same for other virsh commands. I just found it easier and I

[libvirt] [PATCH 4/6] virsh: Create macro for "overwrite" and no-overwrite" options

Although not currently used in more than one command, it soon will be so create a common macro to be used in the new command location. Additionally, add the ".flags = 0," for both to match the expections of the structure being predefined. Signed-off-by: John Ferlan ---

Re: [libvirt] [PATCH] virtlockd: fix misc memory leaks and other bugs

On 11/24/2015 08:17 AM, Daniel P. Berrange wrote: > Fix memory leaks, failure to restore umask and missing man > page docs. > > Signed-off-by: Daniel P. Berrange > --- > src/locking/lock_daemon.c| 6 +- > src/locking/virtlockd.pod.in | 7 ++- > 2 files

[libvirt] [libvirt-glib v5] gobject: Port to GTask API

Drop usage of deprecated GSimpleAsyncResult API. --- v5: * Plug some GError leaks. * Drop StoragePoolBuildData in favour of GUINT_TO_POINTER/GPOINTER_TO_UINT. * Don't unref GTask before using it later in idle callback. libvirt-gobject/libvirt-gobject-domain.c| 290

Re: [libvirt] [libvirt-glib v4] gobject: Port to GTask API

Hey, On Tue, Nov 24, 2015 at 04:23:12PM +, Zeeshan Ali (Khattak) wrote: > Drop usage of deprecated GSimpleAsyncResult API. > --- > libvirt-gobject/libvirt-gobject-domain.c| 290 > +--- > libvirt-gobject/libvirt-gobject-input-stream.c | 77 +++ >

Re: [libvirt] [PATCH v3 02/11] virt-admin: Introduce first working skeleton

On 06.11.2015 12:46, Erik Skultety wrote: > This patch introduces virt-admin client which is based on virsh client, > but had to reimplement several methods to meet virt-admin specific needs > or remove unnecessary virsh specific logic. > --- > .gitignore | 1 + > po/POTFILES.in |

Re: [libvirt] [PATCH v3 11/11] virt-admin: Provide a man page for virt-admin

On 06.11.2015 12:46, Erik Skultety wrote: > --- > tools/Makefile.am| 12 +-- > tools/virt-admin.pod | 255 > +++ > 2 files changed, 259 insertions(+), 8 deletions(-) > create mode 100644 tools/virt-admin.pod > > diff --git

Re: [libvirt] ANNOUNCE: virt-manager 1.3.0 released

On Tue, Nov 24, 2015 at 10:11:04PM -0500, Cole Robinson wrote: I'm happy to announce the release of virt-manager 1.3.0! Yay! \o/ So are we synchronizing virt-manager and libvirt version numbers now? =) virt-manager is a desktop application for managing KVM, Xen, and LXC virtualization via

[libvirt] [PATCH v3 0/7] qemu: Add support for -incoming defer

Traditionally, we pass incoming migration URI on QEMU command line, which has some drawbacks. Depending on the URI QEMU may initialize its migration state immediately without giving us a chance to set any additional migration parameters (this applies mainly for fd: URIs). For some URIs the monitor

[libvirt] [PATCH v3 7/7] qemu: Use qemuProcessLaunch in migration Prepare phase

Using qemuProcess{Init,Launch,FinishStartup} allows us to run pre-migration commands on destination before asking QEMU to wait for incoming migration data. Signed-off-by: Jiri Denemark --- Notes: Version 3: - adapt to changes in 1/7 and 3/7 Version 2: -

[libvirt] [PATCH v3 2/7] qemu: Introduce qemuProcessLaunch

Once qemuProcessInit was called, qemuProcessLaunch will launch a new QEMU process with stopped virtual CPUs. Signed-off-by: Jiri Denemark --- Notes: ACKed in version 2 Version 3: - no change Version 2: - save status before running

[libvirt] [PATCH v3 6/7] qemu: Skip starting NBD servers for offline migration

NBD storage migration will not work with offline migration anyway and we already checked that the user did not ask for it. Thus it doesn't make sense to keep the code after 'done' label where we jump in case of offline migration. Signed-off-by: Jiri Denemark --- Notes:

[libvirt] [PATCH v3 3/7] qemu: Introduce qemuProcessFinishStartup

Finishes starting a new domain launched by qemuProcessLaunch. Signed-off-by: Jiri Denemark --- Notes: Version 3: - propagate asyncJob into qemuProcessFinishStartup to avoid effectively reverting 668a0fe fix from Jan Version 2: - save status before

[libvirt] [PATCH v3 4/7] qemu: Separate incoming URI generation from qemuMigrationPrepareAny

Signed-off-by: Jiri Denemark --- Notes: ACKed in version 1 Version 3: - no change Version 2: - no change src/qemu/qemu_migration.c | 154 +- 1 file changed, 85 insertions(+), 69 deletions(-) diff

[libvirt] [PATCH v3 5/7] qemu: Kill QEMU process if Prepare phase fails

Some failure paths in qemuMigrationPrepareAny forgot to kill the just started QEMU process. This patch fixes this by combining 'stop' and 'endjob' label into a new label 'stopjob'. This name was chosen to avoid confusion with the most common semantics of 'endjob'. Normally, 'endjob' is always

[libvirt] [PATCH v3 1/7] qemu: Introduce qemuProcessInit

qemuProcessStart is going to be split in three parts: qemuProcessInit, qemuProcessLaunch, and qemuProcessFinish so that migration Prepare phase can insert additional code in the process. qemuProcessStart will be a small wrapper for all other callers. qemuProcessInit prepares the domain up to the

Re: [libvirt] [PATCH 4/8] perf: implement the remote protocol for perf event

On Wed, Nov 25, 2015 at 01:22:22 +, Ren, Qiaowei wrote: > > > -Original Message- > > From: Jiri Denemark [mailto:jdene...@redhat.com] > > Sent: Tuesday, November 24, 2015 5:43 PM > > To: Ren, Qiaowei > > Cc: libvir-list@redhat.com > > Subject: Re: [libvirt] [PATCH 4/8] perf: implement

[libvirt] [PATCH v2 3/5] qemu: add virtio video device

qemu 2.5 provides virtio video device. It can be used with -device virtio-vga for primary devices, or -device virtio-gpu for non-vga devices. However, only the primary device (VGA) is supported with this patch. Reference: https://bugzilla.redhat.com/show_bug.cgi?id=1195176 Signed-off-by:

[libvirt] [PATCH v2 5/5] RFC qemu: add spice opengl support

Add Spice graphics gl attribute. qemu 2.6 should have -spice gl=on argument to enable opengl rendering context. This is necessary to actually enable virgl rendering. Add a qemuxml2argv test for virtio-gpu + spice with virgl. Signed-off-by: Marc-André Lureau ---

[libvirt] [PATCH v2 1/5] Replace support{2d,3d} with accel{2d,3d}

Following the domain XML naming Signed-off-by: Marc-André Lureau --- src/conf/domain_conf.c | 44 ++-- src/conf/domain_conf.h | 4 ++-- src/vbox/vbox_common.c | 8 src/vz/vz_sdk.c| 2 +- 4 files changed, 29

[libvirt] [PATCH v2 2/5] domain: replace bool accel{2d, 3d} with a tristate

Allowing to have the extra undefined/default state. Signed-off-by: Marc-André Lureau --- src/conf/domain_conf.c | 41 ++--- src/conf/domain_conf.h | 4 ++-- src/vbox/vbox_common.c | 18 -- 3 files changed, 40

[libvirt] [PATCH v2 4/5] qemu: add virtio-gpu virgl support

Check if virtio-gpu provides virgl option, and add qemu command line formatter. It is enabled with the existing accel3d attribute: Signed-off-by: Marc-André Lureau --- src/qemu/qemu_capabilities.c | 7 ++ src/qemu/qemu_capabilities.h

[libvirt] [PATCH v2 0/5] Add virtio-gpu & virgl support

The following series allow using virtio-gpu and virgl if qemu support it. Ths Spice bits are not yet in qemu 2.5, but should make it in 2.6 and I added the RFC patches that are expected to not change much. v1->v2: addressing Ján Tomko review - update accel2d/accel3d to be tristate and fix its

Re: [libvirt] [PATCH v2 5/7] qemu: Kill QEMU process if Prepare phase fails

On Tue, Nov 24, 2015 at 10:39:20 +0100, Pavel Hrdina wrote: > On Thu, Nov 19, 2015 at 01:09:19PM +0100, Jiri Denemark wrote: > > Some failure paths in qemuMigrationPrepareAny forgot to kill the just > > started QEMU process. This patch fixes this by combining 'stop' and > > 'endjob' label into a

Re: [libvirt] "migration_address must not be the address of the local machine: 127.0.0.1"

On 11/25/15 12:00, Daniel P. Berrange wrote: > On Wed, Nov 25, 2015 at 11:52:21AM +0100, Laszlo Ersek wrote: >> I recently upgraded my laptop from RHEL-7.1 to RHEL-7.2. >> >> I always pay attention to *.rpmnew config files, and I manually diff and >> merge them with the ones I have in place. >> >>

Re: [libvirt] "migration_address must not be the address of the local machine: 127.0.0.1"

On Wed, Nov 25, 2015 at 12:07:00 +0100, Laszlo Ersek wrote: > On 11/25/15 12:00, Daniel P. Berrange wrote: > > On Wed, Nov 25, 2015 at 11:52:21AM +0100, Laszlo Ersek wrote: > >> I recently upgraded my laptop from RHEL-7.1 to RHEL-7.2. > >> > >> I always pay attention to *.rpmnew config files, and

Re: [libvirt] "migration_address must not be the address of the local machine: 127.0.0.1"

On 11/25/15 12:10, Daniel P. Berrange wrote: > On Wed, Nov 25, 2015 at 12:07:00PM +0100, Laszlo Ersek wrote: >> On 11/25/15 12:00, Daniel P. Berrange wrote: >>> On Wed, Nov 25, 2015 at 11:52:21AM +0100, Laszlo Ersek wrote: I recently upgraded my laptop from RHEL-7.1 to RHEL-7.2. I

[libvirt] "migration_address must not be the address of the local machine: 127.0.0.1"

I recently upgraded my laptop from RHEL-7.1 to RHEL-7.2. I always pay attention to *.rpmnew config files, and I manually diff and merge them with the ones I have in place. I did the same with "/etc/libvirt/qemu.conf" this time. Now libvirtd doesn't start for me. Systemd doesn't actually notice

Re: [libvirt] "migration_address must not be the address of the local machine: 127.0.0.1"

On Wed, Nov 25, 2015 at 11:52:21AM +0100, Laszlo Ersek wrote: > I recently upgraded my laptop from RHEL-7.1 to RHEL-7.2. > > I always pay attention to *.rpmnew config files, and I manually diff and > merge them with the ones I have in place. > > I did the same with "/etc/libvirt/qemu.conf" this

Re: [libvirt] "migration_address must not be the address of the local machine: 127.0.0.1"

On Wed, Nov 25, 2015 at 12:07:00PM +0100, Laszlo Ersek wrote: > On 11/25/15 12:00, Daniel P. Berrange wrote: > > On Wed, Nov 25, 2015 at 11:52:21AM +0100, Laszlo Ersek wrote: > >> I recently upgraded my laptop from RHEL-7.1 to RHEL-7.2. > >> > >> I always pay attention to *.rpmnew config files,

Re: [libvirt] [PATCH 0/8] Add perf and Intel CMT feature support

> -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Tuesday, November 24, 2015 9:29 PM > To: Ren, Qiaowei; libvir-list@redhat.com > Subject: Re: [libvirt] [PATCH 0/8] Add perf and Intel CMT feature support > > On Tue, Nov 24, 2015 at 02:24:22PM +0100,

Re: [libvirt] [PATCH] hypervisor driver for Jailhouse

The suggestions in your review should all be implemented now. -- Christian Loehle diff --git a/configure.ac b/configure.ac index 4b7c9ed..02db58e 100644 --- a/configure.ac +++ b/configure.ac @@ -1087,6 +1087,12 @@ dnl LIBVIRT_DRIVER_CHECK_BHYVE dnl +dnl Checks for Jailhouse driver +dnl +

[libvirt] [PATCH v2] Allow building lxc without virt-login-shell

Add a configure option to disable virt-login-shell build even if lxc is enabled. --- Diff to V1: * moved the configure.ac code into m4/virt-login-shell.m4 * allow building virt-login-shell without lxc * Introduce WITH_SETUID_RPC_CLIENT to have it built if either lxc or virt-login-shell is

Re: [libvirt] [PATCHv5 3/9] tests: add tests for the new panic device attribute - 'model'

On Tue, Nov 24, 2015 at 15:26:32 +0300, Dmitry Andreev wrote: > --- > v5: tests was moved from another patch > > .../qemuxml2argvdata/qemuxml2argv-hyperv-panic.xml | 25 + > tests/qemuxml2argvdata/qemuxml2argv-panic-isa.xml | 31 > ++ >

Re: [libvirt] [PATCHv5 6/9] tests: add tests for the new 'hyperv' panic device model

On Tue, Nov 24, 2015 at 15:26:35 +0300, Dmitry Andreev wrote: > --- > tests/qemuargv2xmltest.c| 1 + > .../qemuxml2argvdata/qemuxml2argv-hyperv-panic.args | 21 > + > tests/qemuxml2argvtest.c| 1 + > 3 files changed,

Re: [libvirt] [PATCHv5 0/9] Hyper-v crash feature support

On Tue, Nov 24, 2015 at 15:26:29 +0300, Dmitry Andreev wrote: > A new Hyper-V cpu feature 'hv_crash' was added to QEMU. The feature > will become available in v2.5.0. > > What is changed in v5: > * minor code fixes > * code was moved between patches > * patch sequence changed > > Dmitry Andreev

Re: [libvirt] [PATCHv5 1/9] conf: refactor code for checking ABI stability of panic device

On Tue, Nov 24, 2015 at 15:26:30 +0300, Dmitry Andreev wrote: > --- > v5: this code was moved from another patch > src/conf/domain_conf.c | 21 ++--- > 1 file changed, 2 insertions(+), 19 deletions(-) > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index

Re: [libvirt] [PATCHv5 7/9] Allow multiple panic devices

On Tue, Nov 24, 2015 at 15:26:36 +0300, Dmitry Andreev wrote: > 'model' attribute was added to a panic device but only one panic > device is allowed. This patch changes panic device presence > from 'optional' to 'zeroOrMore'. > --- > v5: part of the code was moved out from this commit > >

Re: [libvirt] [PATCHv5 5/9] tests: rework tests for panic devices

On Tue, Nov 24, 2015 at 15:26:34 +0300, Dmitry Andreev wrote: > Panic device model will be selected automatically if it is not > chosen by the user. Tests should cover this case. > --- > .../qemuxml2argv-panic-no-address.xml | 2 +- >

Re: [libvirt] [PATCHv5 2/9] conf: add 'model' attribute for panic device with values isa, pseries, hyperv

On Tue, Nov 24, 2015 at 15:26:31 +0300, Dmitry Andreev wrote: > Libvirt already has two types of panic devices - pvpanic and pSeries firmware. > This patch introduces the 'model' attribute and a new type of panic device. > > 'isa' model is for ISA pvpanic device. > 'pseries' model is a default

Re: [libvirt] [PATCHv5 8/9] tests: add tests for multiple panic devices

On Tue, Nov 24, 2015 at 15:26:37 +0300, Dmitry Andreev wrote: > --- > .../qemuxml2argv-panic-double.args | 21 > .../qemuxml2argvdata/qemuxml2argv-panic-double.xml | 28 > ++ > tests/qemuxml2argvtest.c | 2 ++ >

Re: [libvirt] [PATCH 0/8] Add perf and Intel CMT feature support

On Wed, Nov 25, 2015 at 13:16:34 +, Ren, Qiaowei wrote: > > > -Original Message- > > From: Daniel P. Berrange [mailto:berra...@redhat.com] > > Sent: Tuesday, November 24, 2015 9:29 PM > > To: Ren, Qiaowei; libvir-list@redhat.com > > Subject: Re: [libvirt] [PATCH 0/8] Add perf and

[libvirt] [PATCH] lxc: drop sys_admin caps by default

To make sure the container user doesn't play with mounts, like changing them from ro to rw, drop the sys_admin capability by default. If user really needs to play with those, it can be enabled in the configuration. --- Note: it seems that patch 3/3 or my last series never reached the list. Here

Re: [libvirt] [PATCHv5 4/9] qemu: add support for hv_crash feature as a panic device

On Tue, Nov 24, 2015 at 15:26:33 +0300, Dmitry Andreev wrote: > Panic device type used depends on 'model' attribute. > > If no model is specified then device type depends on hypervisor > and guest arch. 'pseries' model is used for pSeries guest and > 'isa' model is used in other cases. > > XML:

Re: [libvirt] [PATCHv5 9/9] conf: reject multiple panic devices of same model

On Tue, Nov 24, 2015 at 15:26:38 +0300, Dmitry Andreev wrote: > Only one panic device per model is allowed. > --- > v5: minor code fixes > > src/conf/domain_conf.c | 25 + > 1 file changed, 25 insertions(+) ACK Jirka -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH v3 0/7] qemu: Add support for -incoming defer

On Wed, Nov 25, 2015 at 10:29:32AM +0100, Jiri Denemark wrote: > Traditionally, we pass incoming migration URI on QEMU command line, > which has some drawbacks. Depending on the URI QEMU may initialize its > migration state immediately without giving us a chance to set any > additional migration

Re: [libvirt] [PATCH v3 0/7] qemu: Add support for -incoming defer

On Wed, Nov 25, 2015 at 15:22:08 +0100, Pavel Hrdina wrote: > On Wed, Nov 25, 2015 at 10:29:32AM +0100, Jiri Denemark wrote: > > Traditionally, we pass incoming migration URI on QEMU command line, > > which has some drawbacks. Depending on the URI QEMU may initialize its > > migration state