Re: [libvirt] [PATCH] network: log error when is requested for hostdev interfaces

On Wed, May 11, 2016 at 12:18:51 -0400, Laine Stump wrote: > This would previously be silently ignored. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1319044 > --- > src/network/bridge_driver.c | 25 + > src/qemu/qemu_domain.c | 21 - >

Re: [libvirt] [PATCH] util: Fix virGetLastErrorMessage to return proper error when 'err' is NULL

> ACK > > Thanks, > Cole > Pushed, thanks. Erik -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 06/12] graphics: introduce listen type=socket and use it for VNC

On Wed, May 11, 2016 at 08:13:37PM +0200, Marc-André Lureau wrote: > Hi > > On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina wrote: > > Introduce a new listen type that will be used to tell a graphics device > > to listen on unix socket and use it for VNC graphics instead of

Re: [libvirt] [PATCH v2 03/12] graphics: make address attribute for listen type='address' optional

On Wed, May 11, 2016 at 08:13:11PM +0200, Marc-André Lureau wrote: > Hi > > On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina wrote: > > We support omitting listen attribute of graphics element so we should > > also support omitting address attribute of listen element. This

Re: [libvirt] [PATCH v2 02/12] domain_conf: parse listen attribute while parsing listen elements

On Wed, May 11, 2016 at 08:12:59PM +0200, Marc-André Lureau wrote: > Hi > > On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina wrote: > > Move the compatibility code out of virDomainGraphicsListensParseXML() > > into virDomainGraphicsListenDefParseXML(). This also fixes a small >

Re: [libvirt] [PATCH v2 01/12] graphics: don't parse listens if socket attribute is present

On Wed, May 11, 2016 at 08:12:48PM +0200, Marc-André Lureau wrote: > Hi > > On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina wrote: > > If socket attribute is present we start VNC that listens only on that > > unix socket. This makes the parser behave the same way as we

Re: [libvirt] Introducing Fabian Freyer (GSoC 2016 student)

Hi, I'd also like to introduce myself. My name is Fabian Freyer, and I'm very happy to be accepted as a GSoC student this year. I currently study physics at the Technical University of Berlin, but am working as a sysadmin in the FreeBSD world. Since my project "Improving libvirt support for

Re: [libvirt] [Xen-devel] [PATCH 1/3] libxl: switch to using libxl_domain_create_restore from v4.4 API

On 05/11/2016 12:01 AM, Olaf Hering wrote: > On Mon, May 02, Jim Fehlig wrote: > >> In LIBXL_API_VERSION 0x040400, the libxl_domain_create_restore API >> gained a parameter for specifying restore parameters. Switch to >> using version 0x040400, which will be useful in a subsequent commit >> to

Re: [libvirt] [PATCH 1/2] xenFormatNet: correct `type=netfront' to 'type=vif' to match libxl

On 04/21/2016 05:10 AM, Chunyan Liu wrote: > According to current xl.cfg docs and xl codes, it uses type=vif > instead of type=netfront. > > Currently after domxml-to-native, libvirt xml model=netfront will be > converted to xl type=netfront. This has no problem before, xen codes > for a long time

Re: [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

On Wed, May 11, 2016 at 03:50:39PM +0200, Igor Mammedov wrote: > On Tue, 10 May 2016 17:24:14 -0300 > Eduardo Habkost wrote: > > > On Mon, May 02, 2016 at 02:33:21PM +0200, Igor Mammedov wrote: > > > on old machine types CPU hotplug was uncondtionally > > > enabled since it

Re: [libvirt] [PATCH] libxl: fix default vram setting for implicit video device

On 05/11/2016 05:22 AM, Joao Martins wrote: > On 05/11/2016 06:01 AM, Jim Fehlig wrote: >> Commit 6879be48 moved adding of an implicit video device after XML >> parsing. As a result, libxlDomainDeviceDefPostParse() is no longer >> called to set the default vram when adding an implicit device. >>

Re: [libvirt] [PATCH 0/3] Fix default vram setting for libxl

On 05/11/2016 04:57 AM, Ján Tomko wrote: > An alternative to > https://www.redhat.com/archives/libvir-list/2016-May/msg00700.html > 1462942877-31516-1-git-send-email-jfeh...@suse.com > > This series adds a call to DeviceDefPostParse for the implicit video > which is being in the DomainDefPostParse

Re: [libvirt] [PATCH v3 2/2] qemu: Utilize qemu secret objects for RBD auth/secret

On 05/11/2016 08:21 AM, Peter Krempa wrote: > On Thu, May 05, 2016 at 15:00:41 -0400, John Ferlan wrote: >> Partial fix for: >> https://bugzilla.redhat.com/show_bug.cgi?id=1182074 >> >> If they're available and we need to pass secrets to qemu, then use the >> qemu domain secret object in order

Re: [libvirt] [PATCH] util: Fix virGetLastErrorMessage to return proper error when 'err' is NULL

On 05/11/2016 02:27 PM, Erik Skultety wrote: > Both virGetLastError and virGetLastErrorMessage call virLastErrorObject method > that returns a thread-local error object. However, if a direct call to malloc > or pthread_setspecific (probably also due to malloc, since it sets ENOMEM) > fail,

Re: [libvirt] [PATCH v3 1/2] qemu: Introduce new Secret IV API's

On Wed, May 11, 2016 at 13:09:27 -0400, John Ferlan wrote: > On 05/11/2016 08:47 AM, Peter Krempa wrote: > > On Thu, May 05, 2016 at 15:00:40 -0400, John Ferlan wrote: > >> New APIs: [...] > >> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c > >> index cae356c..b174caa 100644 > >>

Re: [libvirt] [PATCH] tests: qemu: mock master key generation

On Wed, May 11, 2016 at 11:42:28 -0400, John Ferlan wrote: > > > On 05/11/2016 08:49 AM, Peter Krempa wrote: > > On Wed, May 11, 2016 at 07:53:07 -0400, John Ferlan wrote: > >> > >> > >> On 05/11/2016 07:36 AM, Peter Krempa wrote: > >>> The master key generation is using host state to get the

Re: [libvirt] [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

On Wed, May 11, 2016 at 09:11:33AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Tue, May 10, 2016 at 10:23:16AM +0200, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >> > On Mon, May 09, 2016 at 09:20:15AM -0600,

[libvirt] [PATCH] util: Fix virGetLastErrorMessage to return proper error when 'err' is NULL

Both virGetLastError and virGetLastErrorMessage call virLastErrorObject method that returns a thread-local error object. However, if a direct call to malloc or pthread_setspecific (probably also due to malloc, since it sets ENOMEM) fail, virLastErrorObject returns NULL which, although incorrectly

Re: [libvirt] [PATCH v2 08/12] spice: add support for listen type socket

Hi On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > docs/formatdomain.html.in | 2 +- > src/conf/domain_conf.c | 33 +++-- > src/qemu/qemu_command.c

Re: [libvirt] [PATCH v2 06/12] graphics: introduce listen type=socket and use it for VNC

Hi On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina wrote: > Introduce a new listen type that will be used to tell a graphics device > to listen on unix socket and use it for VNC graphics instead of socket > attribute. The socket attribute will remain in the XML for backward >

Re: [libvirt] [PATCH v2 09/12] qemu_process: separate graphics socket and address generation

On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu_process.c | 123 > ++-- > 1 file changed, 77 insertions(+), 46 deletions(-) > Reviewed-by: Marc-André

Re: [libvirt] [PATCH v2 10/12] tests: cleanup vnc auto socket test

Hi On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina wrote: > Commit 55320c23 introduced a new test for VNC to test if > vnc_auto_unix_socket is set in qemu.conf, but forget to enable it in > qemuxml2argvtest.c. This patch also moves the code in qemuxml2xmltest.c > next to other

Re: [libvirt] [PATCH v2 12/12] spice: introduce listen type none

Hi On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina wrote: > This new listen type is currently supported only by spice graphics. > It's introduced to make it easier and clearer specify to not listen > anywhere in order to start a guest with OpenGL support. > > The old way to do

Re: [libvirt] [PATCH v2 11/12] spice: introduce spice_auto_unix_socket config option

Hi On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- make check fails : test_libvirtd_qemu.aug:68.3-145.28:exception thrown in test test_libvirtd_qemu.aug:68.8-.34:exception: Iterated lens matched less than it

Re: [libvirt] [PATCH v2 07/12] qemu_capabilites: add QEMU_CAPS_SPICE_UNIX

Hi On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina wrote: > Add a new capability to detect support of unix sockets for spice > graphics. > > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu_capabilities.c | 2 ++ > src/qemu/qemu_capabilities.h | 1 + > 2

Re: [libvirt] [PATCH v2 04/12] domain_conf: cleanup virDomainGraphicsListenDefParseXML

On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/conf/domain_conf.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index

Re: [libvirt] [PATCH v2 05/12] graphics: move port definition to listen element

Hi On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina wrote: > So far we have only two listen types that supports only address:port > method, but in the future we may want to add a new different listen > type, for example socket. > > This patch moves the ports values out of

Re: [libvirt] [PATCH v2 03/12] graphics: make address attribute for listen type='address' optional

Hi On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina wrote: > We support omitting listen attribute of graphics element so we should > also support omitting address attribute of listen element. This patch > also updates libvirt to always add a listen element into domain XML >

Re: [libvirt] [PATCH v2 02/12] domain_conf: parse listen attribute while parsing listen elements

Hi On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina wrote: > Move the compatibility code out of virDomainGraphicsListensParseXML() > into virDomainGraphicsListenDefParseXML(). This also fixes a small > inconsistency between the code and error message itself. > > Before this

Re: [libvirt] [PATCH v2 01/12] graphics: don't parse listens if socket attribute is present

Hi On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina wrote: > If socket attribute is present we start VNC that listens only on that > unix socket. This makes the parser behave the same way as we actually > use the socket attribute. > > Signed-off-by: Pavel Hrdina

[libvirt] [PATCH] spec: Fix broken indentation reported by syntax-check

syntax-check complained about broken indentation in libvirt.spec.in which was broken by commit 3694e038 Signed-off-by: Erik Skultety --- Pushed under trivial rule. Erik libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in

Re: [libvirt] [PATCH REPOST 4/5] admin: Introduce virAdmServerSetClientProcessingControls

>> diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c >> index 2cd1765..4c4b144 100644 >> --- a/src/rpc/virnetserver.c >> +++ b/src/rpc/virnetserver.c >> @@ -1044,3 +1044,37 @@ virNetServerGetClient(virNetServerPtr srv, >> _("No client with matching ID '%llu'"),

[libvirt] [PATCH v2 1/5] virnetserver: Introduce server's client-related limits getters

Add some trivial getters for client related attributes to virnetserver before any admin method can be introduced. Signed-off-by: Erik Skultety --- src/libvirt_remote.syms | 4 src/rpc/virnetserver.c | 49 +

[libvirt] [PATCH v2 0/5] admin: Introduce APIs to get/set client-related limits

since v1: - symbols added to libvirt_remote.syms - APIs renamed - dropped some unwanted client-side flags checks - dropped unnecessary ifs before calling virAdmServerFree (because it handles NULL gracefully) - a man page entry virt-admin's commands created Erik Skultety (5): virnetserver:

[libvirt] [PATCH v2 3/5] admin: Introduce virAdmServerGetClientLimits

Enable retrieval of the number of maximum clients connected to all sockets combined, as well as the number of maximum clients waiting for authentication, in order to be successfully connected. These are the attributes configurable through libvirtd.conf, however, it could be handy to not only know

[libvirt] [PATCH v2 4/5] admin: Introduce virAdmServerSetClientLimits

Opposite operation to virAdmServerGetClientLimits. Understandably though, setting values for current number of clients connected or still waiting for authentication does not make sense, since changes to these values are event dependent, i.e. a client connects - counter is increased. Thus only the

[libvirt] [PATCH v2 5/5] virt-admin: Introduce commands srv-clients-info and srv-clients-set

Finally wire-up virAdmServer{Get,Set}ClientLimits APIs into virt-admin client. Update the virt-admin's man page accordingly. Signed-off-by: Erik Skultety --- tools/virt-admin.c | 174 +++ tools/virt-admin.pod | 38

[libvirt] [PATCH v2 2/5] admin: Introduce some public constants related to server's client limits

In order for typed params validation to pass on daemon side, we should encourage users to use our exported constants with typed params to diminish to avoid any potential problems related to argument validity. Signed-off-by: Erik Skultety --- include/libvirt/libvirt-admin.h

Re: [libvirt] [PATCH v3 1/2] qemu: Introduce new Secret IV API's

On 05/11/2016 08:47 AM, Peter Krempa wrote: > On Thu, May 05, 2016 at 15:00:40 -0400, John Ferlan wrote: >> New APIs: >> >> qemuDomainGetIVKeyAlias: >> Generate/return the secret object alias for an initialization >> vector (IV) secret info type. This will be saved in the secret >>

Re: [libvirt] docs: Change or update the hacking page

On 05/11/2016 12:22 PM, Nishith Shah wrote: > On Wed, May 11, 2016 at 7:51 PM, Michal Privoznik > wrote: > >> On 11.05.2016 16:01, Cole Robinson wrote: >>> I've thought a bit about this too. I don't think the HACKING page is a >> good >>> landing page for new contributors.

Re: [libvirt] docs: Change or update the hacking page

On Wed, May 11, 2016 at 7:51 PM, Michal Privoznik wrote: > On 11.05.2016 16:01, Cole Robinson wrote: > > I've thought a bit about this too. I don't think the HACKING page is a > good > > landing page for new contributors. It _is_ useful document _everything_ > that a > >

[libvirt] [PATCH] network: log error when is requested for hostdev interfaces

This would previously be silently ignored. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1319044 --- src/network/bridge_driver.c | 25 + src/qemu/qemu_domain.c | 21 - 2 files changed, 41 insertions(+), 5 deletions(-) diff --git

[libvirt] Need to re-work final "peer address" patches and re-push them

I reverted these three patches that introduced and enabled a "peer" attribute for type='ethernet' interface elements prior to the release of 1.3.4 with the intent of fixing/re-posting them after release, but forgot until today:

Re: [libvirt] [PATCH] tests: qemu: mock master key generation

On 05/11/2016 08:49 AM, Peter Krempa wrote: > On Wed, May 11, 2016 at 07:53:07 -0400, John Ferlan wrote: >> >> >> On 05/11/2016 07:36 AM, Peter Krempa wrote: >>> The master key generation is using host state to get the random bytes. >>> Currently it's not used so it doesn't break any tests, but

Re: [libvirt] [PATCH 3/5] domaincaps: Report graphics spiceGL

On Wed, May 11, 2016 at 11:25:50AM -0400, Cole Robinson wrote: > On 05/11/2016 04:49 AM, Daniel P. Berrange wrote: > > On Tue, May 10, 2016 at 07:15:01PM -0400, Cole Robinson wrote: > >> On 05/10/2016 11:50 AM, Daniel P. Berrange wrote: > >>> On Tue, May 10, 2016 at 11:26:29AM -0400, Cole Robinson

Re: [libvirt] [PATCH 3/5] domaincaps: Report graphics spiceGL

On 05/11/2016 04:49 AM, Daniel P. Berrange wrote: > On Tue, May 10, 2016 at 07:15:01PM -0400, Cole Robinson wrote: >> On 05/10/2016 11:50 AM, Daniel P. Berrange wrote: >>> On Tue, May 10, 2016 at 11:26:29AM -0400, Cole Robinson wrote: On 05/10/2016 05:10 AM, Daniel P. Berrange wrote: > On

[libvirt] [PATCH v2 12/12] spice: introduce listen type none

This new listen type is currently supported only by spice graphics. It's introduced to make it easier and clearer specify to not listen anywhere in order to start a guest with OpenGL support. The old way to do this was set spice graphics autoport='no' and don't specify any ports. The new way is

Re: [libvirt] [PATCH v2 2/3] virtestmock: Print invalid file accesses into a file

On Tue, May 10, 2016 at 17:24:13 +0200, Michal Privoznik wrote: > All the accesses to files outside our build or source directories > are now identified and appended into a file for later processing. > The location of the file that contains all the records can be > controlled via

[libvirt] [PATCH v2 04/12] domain_conf: cleanup virDomainGraphicsListenDefParseXML

Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e70456d..cd06384 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10708,10

[libvirt] [PATCH v2 09/12] qemu_process: separate graphics socket and address generation

Signed-off-by: Pavel Hrdina --- src/qemu/qemu_process.c | 123 ++-- 1 file changed, 77 insertions(+), 46 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 3d78455..21c2db2 100644 ---

[libvirt] [PATCH v2 02/12] domain_conf: parse listen attribute while parsing listen elements

Move the compatibility code out of virDomainGraphicsListensParseXML() into virDomainGraphicsListenDefParseXML(). This also fixes a small inconsistency between the code and error message itself. Before this patch we would search first listen element that is type='address' to validate listen and

[libvirt] [PATCH v2 00/12] improve graphics listen configuration

This patch series improves the way how different listen types can be specified and also introduce a new listen types for graphics devices. First improvement is to move ports out of graphics element into listen element with type address or network. This is a first step to make the code

[libvirt] [PATCH v2 11/12] spice: introduce spice_auto_unix_socket config option

Signed-off-by: Pavel Hrdina --- src/qemu/qemu.conf | 11 +++ src/qemu/qemu_conf.c | 1 + src/qemu/qemu_conf.h | 1 + src/qemu/qemu_process.c| 4 +++

[libvirt] [PATCH v2 01/12] graphics: don't parse listens if socket attribute is present

If socket attribute is present we start VNC that listens only on that unix socket. This makes the parser behave the same way as we actually use the socket attribute. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c| 8

[libvirt] [PATCH v2 07/12] qemu_capabilites: add QEMU_CAPS_SPICE_UNIX

Add a new capability to detect support of unix sockets for spice graphics. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/qemu/qemu_capabilities.c

[libvirt] [PATCH v2 03/12] graphics: make address attribute for listen type='address' optional

We support omitting listen attribute of graphics element so we should also support omitting address attribute of listen element. This patch also updates libvirt to always add a listen element into domain XML except for VNC graphics if socket attribute is specified. Signed-off-by: Pavel Hrdina

[libvirt] [PATCH v2 08/12] spice: add support for listen type socket

Signed-off-by: Pavel Hrdina --- docs/formatdomain.html.in | 2 +- src/conf/domain_conf.c | 33 +++-- src/qemu/qemu_command.c| 157 +++-- src/qemu/qemu_migration.c

[libvirt] [PATCH v2 10/12] tests: cleanup vnc auto socket test

Commit 55320c23 introduced a new test for VNC to test if vnc_auto_unix_socket is set in qemu.conf, but forget to enable it in qemuxml2argvtest.c. This patch also moves the code in qemuxml2xmltest.c next to other VNC tests. Signed-off-by: Pavel Hrdina ---

[libvirt] [PATCH v2 06/12] graphics: introduce listen type=socket and use it for VNC

Introduce a new listen type that will be used to tell a graphics device to listen on unix socket and use it for VNC graphics instead of socket attribute. The socket attribute will remain in the XML for backward compatibility. Since old libvirt supports 'socket' attribute inside 'graphics'

[libvirt] [PATCH 4/4] conf: permit auto-assignment of controller indexes

Hand-entering indexes for 20 PCI controllers is not as tedious as manually determining and entering their PCI addresses, but it's still annoying, and the algorithm for determining the proper index is incredibly simple (in all cases except one) - just pick the lowest unused index. The one

Re: [libvirt] [PATCH v2 1/3] tests: Introduce global mock library

On Tue, May 10, 2016 at 17:24:12 +0200, Michal Privoznik wrote: > The intent is that this library is going to be called every time > to check if we are not touching anything outside srcdir or > builddir. > > Signed-off-by: Michal Privoznik > --- > cfg.mk|

[libvirt] [PATCH 3/4] conf: make virDomainControllerFindUnusedIndex() more generally usable

This patch declares virDomainControllerFindUnusedIndex() near the top of its file so that it can be used by other functions higher up in the file, as well as making the DomainDef a const* so that functions which only have a const* to the domain can use it. --- src/conf/domain_conf.c | 3 ++- 1

[libvirt] [PATCH 0/4] auto-assign controller indexes

The purpose of this series is just to eliminate the need to "count indexes" when adding controllers. Patch 4/4 is the meat of this series. 2/4 and 3/4 are code movement to enable 4/4, and 1/4 is a small code simplification that I noticed while testing the rest. Laine Stump (4): qemu: simplify

[libvirt] [PATCH 2/4] conf/qemu: make IS_USB2_CONTROLLER globally available

IS_USB2_CONTROLLER() is useful in more places aside from just when assigning PCI addresses in QEMU, and is checking for enum values that are all defined in conf/domain_conf.h anyway, so define it there too. --- src/conf/domain_conf.h | 7 +++ src/qemu/qemu_domain_address.c | 7 ---

[libvirt] [PATCH 1/4] qemu: simplify addition of USB controller in qemuParseCommandLine

virDomainDefAddUSBController() does everything that the multiple lines of code were doing. --- src/qemu/qemu_parse_command.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/qemu/qemu_parse_command.c b/src/qemu/qemu_parse_command.c index 7ce90f9..23b0159 100644 ---

Re: [libvirt] NFS over AF_VSOCK in

On Mon, May 9, 2016 at 4:57 PM, Stefan Hajnoczi wrote: > virtio-vsock support has been added to the nfs-ganesha NFS server. I'm > currently working on upstreaming virtio-vsock into Linux and QEMU. I > also have patches for the Linux NFS client and server. > > Users wishing

Re: [libvirt] [PATCH] logging: remove concept of default log priority

On Wed, May 11, 2016 at 15:12:27 +0100, Daniel P. Berrange wrote: > The logging framework has categories which can be selectively > enabled/disabled by setting a suitable LIBVIRT_LOG_FILTERS > environment variable or config file setting. > > Along side that we also have the LIBVIRT_DEBUG

Re: [libvirt] NFS over AF_VSOCK in

On Tue, May 10, 2016 at 01:03:48PM +0100, Stefan Hajnoczi wrote: > On Mon, May 09, 2016 at 05:18:42PM +0100, Daniel P. Berrange wrote: > > On Mon, May 09, 2016 at 04:57:17PM +0100, Stefan Hajnoczi wrote: > > > virtio-vsock support has been added to the nfs-ganesha NFS server. I'm > > > currently

Re: [libvirt] docs: Change or update the hacking page

On 11.05.2016 16:01, Cole Robinson wrote: > On 05/11/2016 02:04 AM, Nishith Shah wrote: >> Hi everyone, sorry about the empty message above, I was typing and I pressed >> the wrong set of keys. >> >> So, I was going through the contributor guidelines page[1], and after >> discussing with Michal

Re: [libvirt] [PATCH REPOST 3/5] admin: Introduce virAdmServerGetClientProcessingControls

On 11.05.2016 15:39, Erik Skultety wrote: >>> diff --git a/daemon/admin_server.c b/daemon/admin_server.c >>> index 9f40688..79437a1 100644 >>> --- a/daemon/admin_server.c >>> +++ b/daemon/admin_server.c >>> @@ -311,3 +311,44 @@ int adminClientClose(virNetServerClientPtr client, >>>

[libvirt] [PATCH] logging: remove concept of default log priority

The logging framework has categories which can be selectively enabled/disabled by setting a suitable LIBVIRT_LOG_FILTERS environment variable or config file setting. Along side that we also have the LIBVIRT_DEBUG environment variable which unconditionally enables every single category at DEBUG

Re: [libvirt] docs: Change or update the hacking page

On 05/11/2016 02:04 AM, Nishith Shah wrote: > Hi everyone, sorry about the empty message above, I was typing and I pressed > the wrong set of keys. > > So, I was going through the contributor guidelines page[1], and after > discussing with Michal Privoznik, I think there are some things that need

Re: [libvirt] [PATCH] qemu.conf: spaces correction

On 05/11/2016 04:16 AM, Michal Privoznik wrote: > On 10.05.2016 17:58, Cole Robinson wrote: >> On 05/10/2016 11:56 AM, Michal Privoznik wrote: >>> On 10.05.2016 17:23, Ján Tomko wrote: On Mon, May 09, 2016 at 02:21:53PM +0200, poma wrote: > > libvirt/qemu.conf: spaces correction >

Re: [libvirt] [PATCH REPOST 00/38] Introduce APIs to change daemon's logging settings

On Wed, May 04, 2016 at 04:30:11PM +0200, Erik Skultety wrote: > Basically the same series as > https://www.redhat.com/archives/libvir-list/2016-March/msg01534.html, just > rebased onto the current HEAD. > > Daniel pointed out in 31/38 maybe we do not want to expose an API to set > logging level.

Re: [libvirt] [PATCH 0/2] *** use virGetLastErrorMessage ***

On 05/11/2016 07:45 AM, Erik Skultety wrote: > On 10/05/16 18:51, Cole Robinson wrote: >> On 05/10/2016 11:44 AM, Erik Skultety wrote: >>> On 10/05/16 14:16, Jovanka Gulicoska wrote: *** BLURB HERE *** >>> >>> Hi, thank you for patches :), just a small advice to the future, we tend >>>

Re: [libvirt] [PATCH REPOST 3/5] admin: Introduce virAdmServerGetClientProcessingControls

>> diff --git a/daemon/admin_server.c b/daemon/admin_server.c >> index 9f40688..79437a1 100644 >> --- a/daemon/admin_server.c >> +++ b/daemon/admin_server.c >> @@ -311,3 +311,44 @@ int adminClientClose(virNetServerClientPtr client, >> virNetServerClientClose(client); >> return 0; >> }

Re: [libvirt] [PATCH 1/3] storage: Need to clear pool prior to calling the refreshPool

[...] > > While there's nothing wrong with this patch, after it we have this pair > of ClearVols() + refreshPool() occurring all over the place. Should we > create a wrapper function over it so we not miss anything similar in the > future? > I've thrashed that idea around a few times as

Re: [libvirt] [PATCH REPOST 2/5] admin: Introduce some public constants related to client processing controls

On 11/05/16 14:35, Michal Privoznik wrote: > On 11.05.2016 12:20, Erik Skultety wrote: >> In order for typed params validation to pass on daemon side, we should >> encourage users to use our exported constants with typed params to diminish >> to avoid any potential problems related to argument

Re: [libvirt] [PATCH] libxl: fix vm lock overwritten bug

On 2016/5/11 13:31, Jim Fehlig wrote: > On 05/10/2016 12:18 AM, Wang Yufei wrote: >> In libxl driver we do virObjectRef in libxlDomainObjBeginJob, >> If virCondWaitUntil failed, it goes to error, do virObjectUnref, >> There's a chance that someone undefine the vm at the same time, >> and refs

[libvirt] [PATCH] conf: Allow all volume modes for disk type='lun' sources

Commit 82ba41108acd0f3f made possible to use direct mapped iSCSI volumes in qemu as disk sources but didn't remove the define time check. Rework the check by simplifying the condition and allow any volumes to be used with disk type='lun'. --- src/conf/domain_conf.c | 32

Re: [libvirt] [PATCH v2] storage: Fix regression cloning volume into a logical pool

On 05/11/2016 07:26 AM, Ján Tomko wrote: > On Tue, May 10, 2016 at 01:28:48PM -0400, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1318993 >> >> Commit id 'dd519a294' caused a regression cloning a volume into a >> logical pool by removing just the 'allocation' adjustment

Re: [libvirt] [PATCH v3 1/2] qemu: Introduce new Secret IV API's

On Wed, May 11, 2016 at 02:47:21PM +0200, Peter Krempa wrote: > On Thu, May 05, 2016 at 15:00:40 -0400, John Ferlan wrote: > > New APIs: > > > > qemuDomainGetIVKeyAlias: > > Generate/return the secret object alias for an initialization > > vector (IV) secret info type. This will be

Re: [libvirt] [PATCH] tests: qemu: mock master key generation

On Wed, May 11, 2016 at 07:53:07 -0400, John Ferlan wrote: > > > On 05/11/2016 07:36 AM, Peter Krempa wrote: > > The master key generation is using host state to get the random bytes. > > Currently it's not used so it doesn't break any tests, but it may become > > a problem in the future. > > >

Re: [libvirt] [PATCH v3 1/2] qemu: Introduce new Secret IV API's

On Thu, May 05, 2016 at 15:00:40 -0400, John Ferlan wrote: > New APIs: > > qemuDomainGetIVKeyAlias: > Generate/return the secret object alias for an initialization > vector (IV) secret info type. This will be saved in the secret > info block. This will be called from

Re: [libvirt] [PATCH REPOST 1/5] virnetserver: Introduce client processing controls getters

On 11.05.2016 12:20, Erik Skultety wrote: > Add some trivial getters for client related attributes to virnetserver before > any admin method can be introduced. > > Signed-off-by: Erik Skultety > --- > src/rpc/virnetserver.c | 49

Re: [libvirt] [PATCH REPOST 2/5] admin: Introduce some public constants related to client processing controls

On 11.05.2016 12:20, Erik Skultety wrote: > In order for typed params validation to pass on daemon side, we should > encourage users to use our exported constants with typed params to diminish > to avoid any potential problems related to argument validity. > > Signed-off-by: Erik Skultety

Re: [libvirt] [PATCH REPOST 5/5] virt-admin: Introduce commands srv-clients-info and srv-clients-set

On 11.05.2016 12:20, Erik Skultety wrote: > Finally wire-up the client processing controls APIs into virt-admin client. > > Signed-off-by: Erik Skultety > --- > tools/virt-admin.c | 177 > + > 1 file changed, 177

Re: [libvirt] [PATCH REPOST 3/5] admin: Introduce virAdmServerGetClientProcessingControls

On 11.05.2016 12:20, Erik Skultety wrote: > Enable retrieval of the number of maximum clients connected to all sockets > combined as well as the number of maximum clients waiting for authentication, > in order to be successfully connected. These are the attributes configurable > through

Re: [libvirt] [PATCH REPOST 4/5] admin: Introduce virAdmServerSetClientProcessingControls

On 11.05.2016 12:20, Erik Skultety wrote: > Opposite operation to virAdmServerGetClientProcessingControls. Understandably > though, setting values for current number of clients connected or still > waiting > for authentication does not make sense, since changes to these values are > event >

Re: [libvirt] [PATCH REPOST 0/5] admin: Introduce APIs to get/set client processing

On 11.05.2016 12:20, Erik Skultety wrote: > This is just a rebased version of > https://www.redhat.com/archives/libvir-list/2016-April/msg00466.html. > Patches 1/7 and 2/7 of the original series were already pushed with another > series. > > Erik Skultety (5): > virnetserver: Introduce client

Re: [libvirt] [PATCH v3 2/2] qemu: Utilize qemu secret objects for RBD auth/secret

On Thu, May 05, 2016 at 15:00:41 -0400, John Ferlan wrote: > Partial fix for: > https://bugzilla.redhat.com/show_bug.cgi?id=1182074 > > If they're available and we need to pass secrets to qemu, then use the > qemu domain secret object in order to pass the secrets for RBD volumes > instead of

Re: [libvirt] [PATCH] tests: qemu: mock master key generation

On 05/11/2016 07:36 AM, Peter Krempa wrote: > The master key generation is using host state to get the random bytes. > Currently it's not used so it doesn't break any tests, but it may become > a problem in the future. > > Fix it by mocking qemuDomainGenerateRandomKey. This is possible after >

Re: [libvirt] [PATCH 0/2] *** use virGetLastErrorMessage ***

On 10/05/16 18:51, Cole Robinson wrote: > On 05/10/2016 11:44 AM, Erik Skultety wrote: >> On 10/05/16 14:16, Jovanka Gulicoska wrote: >>> *** BLURB HERE *** >>> >> >> Hi, thank you for patches :), just a small advice to the future, we tend >> to write a couple of words/sentences, instead of the

Re: [libvirt] [PATCH REPOST 20/38] virlog: Split output parsing and output defining to separate operations

On 10/05/16 03:11, Cole Robinson wrote: > On 05/04/2016 10:30 AM, Erik Skultety wrote: >> Everything has been prepared to successfully split parsing and defining logic >> to separate operations. >> --- >> src/util/virlog.c | 160 >> + >>

[libvirt] [PATCH] tests: qemu: mock master key generation

The master key generation is using host state to get the random bytes. Currently it's not used so it doesn't break any tests, but it may become a problem in the future. Fix it by mocking qemuDomainGenerateRandomKey. This is possible after exporting it and switching to the dynamically linked qemu

Re: [libvirt] [PATCH v2] storage: Fix regression cloning volume into a logical pool

On Tue, May 10, 2016 at 01:28:48PM -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1318993 > > Commit id 'dd519a294' caused a regression cloning a volume into a > logical pool by removing just the 'allocation' adjustment during > storageVolCreateXMLFrom. Combined with the

Re: [libvirt] [PATCH] libxl: fix default vram setting for implicit video device

On 05/11/2016 06:01 AM, Jim Fehlig wrote: > Commit 6879be48 moved adding of an implicit video device after XML > parsing. As a result, libxlDomainDeviceDefPostParse() is no longer > called to set the default vram when adding an implicit device. > Commit 6879be48 assumes virDomainVideoDefaultRAM()

Re: [libvirt] [PATCH] libxl: fix default vram setting for implicit video device

On Tue, May 10, 2016 at 11:01:17PM -0600, Jim Fehlig wrote: > Commit 6879be48 moved adding of an implicit video device after XML > parsing. As a result, libxlDomainDeviceDefPostParse() is no longer > called to set the default vram when adding an implicit device. > Commit 6879be48 assumes

[libvirt] [PATCH 3/3] Fill out default vram in DeviceDefPostParse

Move filling out the default video (v)ram to DeviceDefPostParse. This means it can be removed from virDomainVideoDefParseXML and qemuParseCommandLine. Also, we no longer need to special case VIR_DOMAIN_VIRT_XEN, since the per-driver callback gets called before the generic one. ---

[libvirt] [PATCH 1/3] Move virDomainDefPostParseInternal after virDomainDeviceDefPostParse

Future commit will call DeviceDefPostParse on a device auto-added in DomainDefPostParse. --- src/conf/domain_conf.c | 78 +- 1 file changed, 39 insertions(+), 39 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

  1   2   >