Re: [libvirt] [PATCH] libxl: fix leaking of allocated migration ports

On 10/21/2016 04:41 AM, Pavel Hrdina wrote: > On Fri, Oct 14, 2016 at 12:19:19PM -0600, Jim Fehlig wrote: >> Although the migration port is immediately released in the >> finish phase of migration, it was never set in the domain >> private object when allocated in the prepare phase. So >>

Re: [libvirt] [PATCH 1/1] qemu: host NUMA hugepage policy without guest NUMA

On Tue, Oct 18, 2016 at 10:43:31PM +0200, Martin Kletzander wrote: > On Mon, Oct 17, 2016 at 03:45:09PM +1100, Sam Bobroff wrote: > >On Fri, Oct 14, 2016 at 10:19:42AM +0200, Martin Kletzander wrote: > >>On Fri, Oct 14, 2016 at 11:52:22AM +1100, Sam Bobroff wrote: > >>>I did look at the libnuma

Re: [libvirt] [RFC PATCH v2] qemu: Use virtio-pci by default for mach-virt guests

On 10/24/2016 11:28 AM, Andrea Bolognani wrote: virtio-pci is the way forward for aarch64 guests: it's faster and less alien to people coming from other architectures. Now that guest support is finally getting there, we'd like to start using it by default instead of virtio-mmio. Users and

Re: [libvirt] [PATCH] qemu_driver: unlink new domain cfg file when rollbak

At 2016-10-19 17:25:29, "Chen Hanxiao" wrote: >At 2016-10-14 17:35:26, "Chen Hanxiao" wrote: >>From: Chen Hanxiao >> >>If we failed to unlink old dom cfg file, we goto rollback. >>But inside rollback, we fogot to unlink the

Re: [libvirt] [PATCH 0/4] Add VCPU halted to domain statistics

On 10/24/2016 11:24 AM, Viktor Mihajlovski wrote: > On 24.10.2016 16:29, John Ferlan wrote: > [...] >> >> The series looks good to me - do you think it's worthwhile to mention >> anywhere in virsh.pod that the "halted" could mean "really halted" or >> "not scheduled" or "not actively processing"

[libvirt] [PATCH v11 3/5] qemu: Need to remove TLS object in RemoveRNGDevice

Commit id '6e6b4bfc' added the object, but forgot the other end. Signed-off-by: John Ferlan --- src/qemu/qemu_hotplug.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index e287aaf..f401b48

[libvirt] [PATCH v11 5/5] qemu: Add secret object hotplug for TCP chardev TLS

https://bugzilla.redhat.com/show_bug.cgi?id=1300776 Complete the implementation of support for TLS encryption on chardev TCP transports by adding the hotplug ability of a secret to generate the passwordid for the TLS object for chrdev, RNG, and redirdev. Likewise, add the ability to hot unplug

[libvirt] [PATCH v11 0/5] Add native TLS encrypted chardev TCP support

v10: http://www.redhat.com/archives/libvir-list/2016-October/msg00866.html Changes since v10... This is essentially the adding the secret to/for the TLS chardev TCP. Lots of messy stuff. Patches 1-3 are new... In particular, I kept looking at the RNG removal code and kept thinking, something

[libvirt] [PATCH v11 4/5] qemu: Add a secret object to/for a char source dev

Add the secret object so the 'passwordid=' can be added if the command line if there's a secret defined in/on the host for TCP chardev TLS objects. Preparation for the secret involves adding the secinfo to the char source device prior to command line processing. There are multiple possibilities

[libvirt] [PATCH v11 2/5] qemu: Swap order of RNG hot unplug removal

Rather than remove the frontend first and then the backend, let's swap the order. The order of addition is add the chardev backend if EGD being used, then add the RNG object. So there's a dependency there. When we remove, unplug the backend first, then remove the object would seem to be a more

[libvirt] [PATCH v11 1/5] qemu: Move TLS object remove from DetachChr to RemoveChr

Commit id '2c32237' added the TLS object removal to the DetachChrDevice all when it should have been added to the RemoveChrDevice since that's the norm for similar processing (e.g. disk) Signed-off-by: John Ferlan --- src/qemu/qemu_hotplug.c | 44

[libvirt] [PATCH 11/11] conf: eliminate virDomainPCIAddressReleaseSlot() in favor of ...Addr()

Surprisingly there was a virDomainPCIAddressReleaseAddr() function already, but it was completely unused. Since we don't reserve entire slots at once any more, there is no need to release entire slots either, so we just replace the single call to virDomainPCIAddressReleaseSlot() with a call to

[libvirt] [PATCH 09/11] qemu: remove qemuDomainPCIAddressReserveNextAddr()

This function is only called in two places, and the function itself is just adding a single argument and calling virDomainPCIAddressReserveNextAddr(), so we can remove it and instead call virDomainPCIAddressReserveNextAddr() directly. (The main motivation for doing this is to free up the name so

[libvirt] [PATCH 04/11] conf: eliminate virDomainPCIAddressReserveNextSlot()

Since we don't actually reserve an entire slot at a time anymore, the name of this function is just confusing, and it's almost identical in operation to virDomainPCIAddressReserveNextAddr() anyway, so remove the *Slot() function and replace calls to it with calls to *Addr(..., -1). ---

[libvirt] [PATCH 06/11] conf: make virDomainPCIAddressReserveAddr() a static function

It is now only used in domain_addr.c. --- src/conf/domain_addr.c | 2 +- src/conf/domain_addr.h | 6 -- src/libvirt_private.syms | 1 - 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index 8f64bef..07a4312 100644 ---

[libvirt] [PATCH 07/11] conf: rename virDomainPCIAddressReserveAddr() to ...Internal()

This is in preparation for renaming virDomainPCIAddressReserveSlot() to virDomainPCIAddressReserveAddr(), which is a better description of what it does. --- src/conf/domain_addr.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/conf/domain_addr.c

[libvirt] [PATCH 05/11] qemu: replace virDomainPCIAddressReserveAddr with virDomainPCIAddressReserveSlot

All occurences of the former use fromConfig=true, and that's exactly how virDomainPCIAddressReserveSlot() calls virDomainPCIaddressReserveAddr(), so just use *Slot() so that *Addr() can be made static to conf/domain_addr.c (both functions will be renamed in upcoming patches). ---

[libvirt] [PATCH 01/11] conf: fix fromConfig argument to virDomainPCIAddressReserveAddr()

Although setting virDomainPCIAddressReserveAddr()'s fromConfig=true is correct when a PCI addres is coming from a domain's config, the *true* purpose of the fromConfig argument is to lower restrictions on what kind of device can plug into what kind of controller - if fromConfig is true, then a

[libvirt] [PATCH 00/11] clean up after "slot sharing" patches

Some of the patches that enabled sharing PCI slots by multiple pcie-root-ports made the idea of reserving an entire slot obsolete. To reduce confusion and misunderstandings, this patch series gets rid of the name "Slot" in all of the functions that reserve and release PCI addresses. None of these

[libvirt] [PATCH 08/11] conf: rename virDomainPCIAddressReserveSlot() to ...Addr()

This function doesn't actually reserve an entire slot any more, it reserves a single PCI address, so this name is more appropriate. --- src/bhyve/bhyve_device.c | 8 ++-- src/conf/domain_addr.c | 2 +- src/conf/domain_addr.h | 2 +- src/libvirt_private.syms | 2

[libvirt] [PATCH 10/11] qemu: rename qemuDomainPCIAddressReserveNextSlot() to ...Addr()

This function doesn't actually reserve an entire slot any more, it reserves a single PCI address, so this name is more appropriate. --- src/qemu/qemu_domain_address.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git

[libvirt] [PATCH 03/11] conf: rename virDomainPCIAddressGetNextSlot() to ...GetNextAddr()

With the advent of VIR_PCI_CONNECT_AGGREGATE_SLOT, the new name is more appropriate, since the address contained may be another address on the same slot as last time, not necessarily a new slot. --- src/conf/domain_addr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH 02/11] conf: fix fromConfig argument to virDomainPCIAddressValidate()

fromConfig should be true if the caller want virDomainPCIAddressValidate() to loosen restrictions on its interpretation of the pciConnectFlags. In particular, either PCI_DEVICE or PCIE_DEVICE will be counted as equivalent to both, and HOTPLUG will be ignored. In a few cases where libvirt was

[libvirt] [PATCH 4/8] conf: start search for next unused PCI address at same slot as previous find

There is a very slight time advantage to beginning the search for the next unused PCI address at the slot *after* the previous find (which is now used), but if we do that, we will miss allocating the other functions of the same slot (when we implement a VIR_PCI_CONNECT_AGGREGATE_SLOT flag to

[libvirt] [PATCH 8/8] conf: aggregate multiple pcie-root-ports onto a single slot

Set the VIR_PCI_CONNECT_AGGREGATE_SLOT flag for pcie-root-ports so that they will be assigned to all the functions on a slot. Some qemu test case outputs had to be adjusted due to the pcie-root-ports now being put on multiple functions. --- src/conf/domain_addr.c | 2

[libvirt] [PATCH 7/8] conf: aggregate multiple devices on a slot when assigning PCI addresses

If a PCI device has VIR_PCI_CONNECT_AGGREGATE_SLOT set in its pciConnectFlags, then during address assignment we allow multiple instances of this type of device to be auto-assigned to multiple functions on the same device. A slot is used for aggregating multiple devices only if the first device

[libvirt] [PATCH 5/8] conf: new function virDomainPCIAddressIsMulti()

This function iterates through all the devices in a domain to determine if the address it has been given is part of a "multifunction device" (i.e. multiple devices connected to different functions of the same slot). This implementation may seem a bit inefficient because it has to iterate through

[libvirt] [PATCH 3/8] conf: eliminate repetitive code in virDomainPCIAddressGetNextSlot()

virDomainPCIAddressGetNextSlot() starts searching from the last allocated address and goes to the end of all the buses, then goes back to the first bus and searchs from there up to the starting point (in case any address has been freed since the last time an address was allocated. The loops for

[libvirt] [PATCH 6/8] qemu: use virDomainPCIAddressIsMulti() to determine multifunction setting

If the multifunction attribute isn't set in the config for the device at function 0 of a slot used for multifunction, it would previously have been an error. This patch will instead automatically correct the omission (but only if it hasn't been set at all - if someone explicitly has

[libvirt] [PATCH 1/8] conf: use struct instead of int for each slot in virDomainPCIAddressBus

When keeping track of which functions of which slots are allocated, we will need to have more information than just the current bitmap with a bit for each function that is currently stored for each slot in a virDomainPCIAddressBus. To prepare for adding more per-slot info, this patch changes "int

[libvirt] [PATCH 0/8] aggregate multiple pcie-root-ports onto a single slot

These patches implement a reccomendation from Gerd Hoffman during discussion of Marcel Apfelbaum's proposed "PCIe devices placement guidelines" document on qemu-devel: https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg01381.html The basic idea is to put up to 8 pcie-root-ports on each

[libvirt] [PATCH 2/8] conf: eliminate concept of "reserveEntireSlot"

setting reserveEntireSlot really accomplishes nothing - instead of going to the trouble of computing the value for reserveEntireSlot and then possibly setting *all* functions of the slot as in-use, we can just set the in-use bit only for the specific function being used by a device. Later we will

Re: [libvirt] [PATCH] virQEMUCapsReset: also clear out hostCPUModel

On Mon, Oct 24, 2016 at 17:55:06 +0200, Ján Tomko wrote: > After succesfully reading an outdated caps cache from disk, > calling virQEMUCapsReset did not properly clear out the host > CPU model. This lead to a memory leak when the host CPU model > pointer was overwritten later in

Re: [libvirt] [RFC] qemu: Use virtio-pci by default for mach-virt guests

On Mon, 2016-10-24 at 17:47 +0200, Pavel Hrdina wrote: > > > I like that this makes pci truly the default in a simple manner, but  > > > still allows switching back to mmio if necessary. On the other hand, it  > > > puts the potential "switch" to decide whether or not to use mmio for all  > > >

Re: [libvirt] [RFC] qemu: Use virtio-pci by default for mach-virt guests

On 10/24/2016 02:43 AM, Martin Kletzander wrote: On Sat, Oct 22, 2016 at 11:07:39PM -0400, Laine Stump wrote: (When I first saw your mail I didn't realize it was a patch, because it didn't have "PATCH" in the subject) On 10/22/2016 05:50 PM, Martin Kletzander wrote: On Fri, Oct 21, 2016 at

[libvirt] [PATCH] virQEMUCapsReset: also clear out hostCPUModel

After succesfully reading an outdated caps cache from disk, calling virQEMUCapsReset did not properly clear out the host CPU model. This lead to a memory leak when the host CPU model pointer was overwritten later in virQEMUCapsNewForBinaryInternal. Introduced by commit 68c70118. ---

Re: [libvirt] [RFC] qemu: Use virtio-pci by default for mach-virt guests

On Mon, Oct 24, 2016 at 05:17:07PM +0200, Andrea Bolognani wrote: > On Sat, 2016-10-22 at 23:07 -0400, Laine Stump wrote: > > (When I first saw your mail I didn't realize it was a patch, because it  > > didn't have "PATCH" in the subject) > > Fair enough, will send the next iteration as [RFC

[libvirt] [RFC PATCH v2] qemu: Use virtio-pci by default for mach-virt guests

virtio-pci is the way forward for aarch64 guests: it's faster and less alien to people coming from other architectures. Now that guest support is finally getting there, we'd like to start using it by default instead of virtio-mmio. Users and applications can already opt-in by explicitly using

Re: [libvirt] [PATCH 0/4] Add VCPU halted to domain statistics

On 24.10.2016 16:29, John Ferlan wrote: [...] > > The series looks good to me - do you think it's worthwhile to mention > anywhere in virsh.pod that the "halted" could mean "really halted" or > "not scheduled" or "not actively processing" depending on architecture? > (and how best to say it). As

Re: [libvirt] [PATCH v2 06/12] include: Add new definitions for duration for bps/iops throttling

On Thu, Oct 06, 2016 at 06:38:54PM -0400, John Ferlan wrote: > Add new options to allow proving a duration/length in seconds to allow the > bps/iops (and friends) to occur: > > total_bytes_sec_max_length > write_bytes_sec_max_length > read_bytes_sec_max_length >

Re: [libvirt] [RFC] qemu: Use virtio-pci by default for mach-virt guests

On Sat, 2016-10-22 at 23:07 -0400, Laine Stump wrote: > (When I first saw your mail I didn't realize it was a patch, because it  > didn't have "PATCH" in the subject) Fair enough, will send the next iteration as [RFC PATCH v2] :) > I like that this makes pci truly the default in a simple manner,

Re: [libvirt] [PATCH v2 03/12] qemu: Move setting of conf_disk in qemuDomainSetBlockIoTune

On Thu, Oct 06, 2016 at 06:38:51PM -0400, John Ferlan wrote: > Since persistent_def is the only place that uses it, let's just keep > it closer to where it's used. > > Signed-off-by: John Ferlan > --- > src/qemu/qemu_driver.c | 15 ++- > 1 file changed, 6

[libvirt] 转发: Re: How libvirt address qemu command line args

zhun...@gmail.com 发件人： zhun...@gmail.com 发送时间： 2016-10-23 17:42 收件人： berrange 主题： Re: Re: [libvirt] How libvirt address qemu command line args Thanks，However,I have to use this method.Now I wander how get the VM xml contents in Libvirt source code,I try output some message in

Re: [libvirt] [PATCH 3/3] domain: fix migration to older libvirt

On Mon, Oct 24, 2016 at 10:31:42AM -0400, John Ferlan wrote: > > > On 10/24/2016 10:28 AM, Pavel Hrdina wrote: > > On Mon, Oct 24, 2016 at 10:11:53AM -0400, John Ferlan wrote: > >> > >> > >> On 10/24/2016 08:41 AM, Pavel Hrdina wrote: > >>> Since TLS feature was introduced in libvirt 2.3.0 we

Re: [libvirt] [PATCH v2 02/12] qemu: Return real error message for block_set_io_throttle

On Thu, Oct 06, 2016 at 06:38:50PM -0400, John Ferlan wrote: > This patch will also adjust the qemuMonitorJSONSetBlockIoThrottle error > procession so that rather than returning/displaying: > > "error: internal error: Unexpected error" > > Fetch the actual error message from qemu and display

Re: [libvirt] [PATCH v2 01/12] qemu: Create a macro to handle setting bytes/iops iotune values

On Thu, Oct 06, 2016 at 06:38:49PM -0400, John Ferlan wrote: > Create a macros to hide all the comparisons for each of the fields. > > Add a 'continue;' for a compiler hint that we only need to find one > this should be similar enough to the if - elseif - elseif logic. > > Signed-off-by: John

Re: [libvirt] [PATCH 3/3] domain: fix migration to older libvirt

On 10/24/2016 10:28 AM, Pavel Hrdina wrote: > On Mon, Oct 24, 2016 at 10:11:53AM -0400, John Ferlan wrote: >> >> >> On 10/24/2016 08:41 AM, Pavel Hrdina wrote: >>> Since TLS feature was introduced in libvirt 2.3.0 we have to modify >> >> Since TLS was introduced hostwide for libvirt 2.3.0 and a

Re: [libvirt] [PATCH 0/4] Add VCPU halted to domain statistics

On 10/13/2016 07:42 AM, Viktor Mihajlovski wrote: > As a result of the discussions on > https://www.redhat.com/archives/libvir-list/2016-October/msg00531.html: > > In order to be able to report the per VCPU halted condition as returned > by the QEMU monitor this series extends the VCPU-specific

Re: [libvirt] [PATCH 3/3] domain: fix migration to older libvirt

On Mon, Oct 24, 2016 at 10:11:53AM -0400, John Ferlan wrote: > > > On 10/24/2016 08:41 AM, Pavel Hrdina wrote: > > Since TLS feature was introduced in libvirt 2.3.0 we have to modify > > Since TLS was introduced hostwide for libvirt 2.3.0 and a domain > configurable haveTLS was implemented for

Re: [libvirt] [PATCH 3/3] domain: fix migration to older libvirt

On 10/24/2016 08:41 AM, Pavel Hrdina wrote: > Since TLS feature was introduced in libvirt 2.3.0 we have to modify Since TLS was introduced hostwide for libvirt 2.3.0 and a domain configurable haveTLS was implemented for libvirt 2.4.0, we have to modify the > migratable XML for specific case

Re: [libvirt] [PATCH 1/3] qemu_hotplug: remove union for one member

On 10/24/2016 08:41 AM, Pavel Hrdina wrote: > Currently the union has only one member so remove that union. If there > is a need to add a new type of source for new bus in the future this > will force the author to add a union and properly check bus type before > any access to union member. >

Re: [libvirt] [PATCH 2/3] domain: Add optional 'tls' attribute for TCP chardev

On 10/24/2016 08:41 AM, Pavel Hrdina wrote: > Add an optional "tls='yes|no'" attribute for a TCP chardev. > > For QEMU, this will allow for disabling the host config setting of the > 'chardev_tls' for a domain chardev channel by setting the value to "no" or > to attempt to use a host TLS

Re: [libvirt] [PATCH] doc: Describe the VCPU states returned by virsh vcpuinfo

On 21.10.2016 17:08, John Ferlan wrote: > > > On 10/13/2016 07:08 AM, Viktor Mihajlovski wrote: >> Added a brief description of the VCPU states. >> >> Signed-off-by: Viktor Mihajlovski >> --- >> tools/virsh.pod | 49 +

[libvirt] [PATCH 2/3] domain: Add optional 'tls' attribute for TCP chardev

Add an optional "tls='yes|no'" attribute for a TCP chardev. For QEMU, this will allow for disabling the host config setting of the 'chardev_tls' for a domain chardev channel by setting the value to "no" or to attempt to use a host TLS environment when setting the value to "yes" when the host

[libvirt] [PATCH 0/3] last part of TLS encryption for char devices

Pavel Hrdina (3): qemu_hotplug: remove union for one member domain: Add optional 'tls' attribute for TCP chardev domain: fix migration to older libvirt docs/formatdomain.html.in | 28 + docs/schemas/domaincommon.rng | 5 ++

[libvirt] [PATCH 1/3] qemu_hotplug: remove union for one member

Currently the union has only one member so remove that union. If there is a need to add a new type of source for new bus in the future this will force the author to add a union and properly check bus type before any access to union member. Signed-off-by: Pavel Hrdina ---

[libvirt] [PATCH 3/3] domain: fix migration to older libvirt

Since TLS feature was introduced in libvirt 2.3.0 we have to modify migratable XML for specific case where 'tls' attribute is based on setting from qemu.conf. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 24 +++- src/conf/domain_conf.h | 1 +

Re: [libvirt] [PATCH] domain_conf: fix memory leak in virDomainDefAddConsoleCompat

On 10/24/2016 03:02 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/conf/domain_conf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > ACK John -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH v2 00/12] Add length (duration) params for iotune throttling

ping^2? Thanks - John On 10/06/2016 06:38 PM, John Ferlan wrote: > v1: http://www.redhat.com/archives/libvir-list/2016-September/msg01090.html > > Differences since v1: > > Patches 1-5 are new... >Patch 1 is essentially the former patch 8.5 added after initial review > based on a

[libvirt] Race in log manager causes segfault

Hello, I am currently investigating a rare segfault in libvirt. I have attached a backtrace, the coredump is for s390x. I am currently trying to reproduce the segfault on x86 but it did not occur yet (timespan to short). This can be triggered by rapidly performing domain start/stop cycles in a

Re: [libvirt] [PATCH] virt-wireshark.m4: Defer $(prefix) substitution

On Thu, Oct 20, 2016 at 03:54:13PM +0800, Michal Privoznik wrote: > The problem with evaluating $(prefix) in configure phase is that > autoconf does a lot of magic with this variable. Firstly, if the > --prefix argument is not set for the configure script, the > variable will have value "NONE".

[libvirt] [PATCH 2/2] m4/virt-gnutls: remove code for gnutls < 2.2.0

Commit d8a8af3492 changed the minimal required version of gnutls so it's safe to remove the code for older versions. Signed-off-by: Pavel Hrdina --- m4/virt-gnutls.m4 | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/m4/virt-gnutls.m4

[libvirt] [PATCH 0/2] configure gnutls cleanup

Pavel Hrdina (2): configure: move gnutls check into virt-gnutls.m4 m4/virt-gnutls: remove code for gnutls < 2.2.0 configure.ac | 109 +- m4/virt-gnutls.m4 | 62 +++ 2 files changed, 64 insertions(+), 107

[libvirt] [PATCH 1/2] configure: move gnutls check into virt-gnutls.m4

Signed-off-by: Pavel Hrdina --- configure.ac | 109 +- m4/virt-gnutls.m4 | 64 2 files changed, 66 insertions(+), 107 deletions(-) create mode 100644 m4/virt-gnutls.m4 diff --git

[libvirt] Plans for next release 2.4.0

I will be in vacation this week, but should be able to make the release candidate on Thursday, which means that if I can make a CR2 release on the week-end, we should be able to push 2.4.0 around Nov 1st if everything looks good. There is a few tests who went red in

Re: [libvirt] [PATCH 4/4] conf: Add iterators for RNG and Redirdev

On Fri, Oct 21, 2016 at 07:25:40PM -0400, John Ferlan wrote: > Add the virDomainRNGDefForeach and +virDomainRedirdevDefForeach iterators > to traverse all the RNG and Redirdevs just like the Smartcard's and Chr's Those are simple for loops over one array and I don't see any benefit of those

Re: [libvirt] [PATCH 2/4] conf: Use virDomainChrSourceDefPtr for _virDomainRedirdevDef 'source.chr'

On Fri, Oct 21, 2016 at 07:25:38PM -0400, John Ferlan wrote: > Use a pointer and the virDomainChrSourceDefNew() function in order to > allocate the structure for _virDomainRedirdevDef. > > Signed-off-by: John Ferlan > --- ACK Pavel signature.asc Description: Digital

Re: [libvirt] [PATCH 3/4] conf: Use virDomainChrSourceDefNew for virDomainRNGDef allocation

On Fri, Oct 21, 2016 at 07:25:39PM -0400, John Ferlan wrote: > Rather than VIR_ALLOC() the data, use virDomainChrSourceDefNew in order > to get the private data if necessary. > > Signed-off-by: John Ferlan > --- ACK Pavel signature.asc Description: Digital signature --

Re: [libvirt] [PATCH 1/4] conf: Use virDomainChrSourceDefPtr for _virDomainSmartcardDef 'passthru'

On Fri, Oct 21, 2016 at 07:25:37PM -0400, John Ferlan wrote: > Use a pointer and the virDomainChrSourceDefNew() function in order to > allocate the structure for _virDomainSmartcardDef. > > Signed-off-by: John Ferlan > --- ACK Pavel signature.asc Description: Digital

Re: [libvirt] [PATCH 4/4] qemu: Add TLS hotplug for qemuDomainAttachRNGDevice

On Fri, Oct 21, 2016 at 10:22:31AM -0400, John Ferlan wrote: > Commit id '2c322378' missed the nuance that the rng backend could be > using a TCP chardev and if TLS is enabled on the host, thus will need > to have the TLS object added. > > Signed-off-by: John Ferlan > --- >

Re: [libvirt] [PATCH 3/4] qemu: Add TLS hotplug for qemuDomainAttachRedirdevDevice

On Fri, Oct 21, 2016 at 10:22:30AM -0400, John Ferlan wrote: > Commit id '2c322378' missed the nuance that the redirdev backend could > be using a TCP chardev and if TLS is enabled on the host, thus will need > to have the TLS object added. > > Signed-off-by: John Ferlan >

Re: [libvirt] [PATCH 2/4] qemu: Clean up error path in qemuDomainAttachRedirdevDevice

On Fri, Oct 21, 2016 at 10:22:29AM -0400, John Ferlan wrote: > It's about to get more complicated - let's alter the logic to handle > various failures. Adds saving of the error as well. > > Signed-off-by: John Ferlan > --- ACK Pavel signature.asc Description: Digital

Re: [libvirt] [PATCH 1/4] qemu: Introduce qemuDomainGetChardevTLSObjects for hotplug

On Fri, Oct 21, 2016 at 10:22:28AM -0400, John Ferlan wrote: > As it turns out more than one place will need these objects, so rather > than cut-copy-paste in each, make a helper > > Signed-off-by: John Ferlan > --- > src/qemu/qemu_hotplug.c | 41

[libvirt] [PATCH] domain_conf: fix memory leak in virDomainDefAddConsoleCompat

Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 748ffd5..6100c3d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -3895,7

Re: [libvirt] [PATCH 1/3] vz: support type=bridge network interface type correctly

On 21.10.2016 18:20, Maxim Nestratov wrote: > 07-Sep-16 14:00, Nikolay Shirokovskiy пишет: > >> >> On 05.09.2016 19:39, Maxim Nestratov wrote: >>> Recently, libprlsdk got a separate flag PNA_BRIDGE corresponding to >>> type=bridge libvirt network interfaces. Let's use it and get rid of >>> all

Re: [libvirt] [RFC] qemu: Use virtio-pci by default for mach-virt guests

On Sat, Oct 22, 2016 at 11:07:39PM -0400, Laine Stump wrote: (When I first saw your mail I didn't realize it was a patch, because it didn't have "PATCH" in the subject) On 10/22/2016 05:50 PM, Martin Kletzander wrote: On Fri, Oct 21, 2016 at 07:24:28PM +0200, Andrea Bolognani wrote: