[libvirt] libvirt failed to spawn with namespace

2017-01-04 Thread Qiao, Liyong
Hi Michal Build with the latest libvirt source code, I found failed to spawn a qemu process, not sure if something wrong with my environment, can you please help to take a look at it? After build the latest (3.0.0) libvirt, found failed to start an existed domain.

[libvirt] [PATCH] qemu: snapshot: restart CPUs when recover from interrupted snapshot job

2017-01-04 Thread Wang King
If we restart libvirtd while VM was doing external memory snapshot, VM's state be updated to paused as a result of running a migration-to-file operation, and then VM will be left as paused state. In this case we must restart the VM's CPUs to resume it. Signed-off-by: Wang King

[libvirt] [PATCH] docs: Reword virsh manpage for --uuid --name --table options

2017-01-04 Thread Nitesh Konkar
The virsh manpage lists options --uuid and --name as mutually exclusive along option --table when actually the optoin --table is mutually exclusive and can't go with options --uuid and/or --name. This patch rewords the virsh manpage to state the correct meaning. Signed-off-by: Nitesh Konkar

[libvirt] Proposal PCI/PCIe device placement on PAPR guests

2017-01-04 Thread David Gibson
There was a discussion back in November on the qemu list which spilled onto the libvirt list about how to add support for PCIe devices to POWER VMs, specifically 'pseries' machine type PAPR guests. Here's a more concrete proposal for how to handle part of this in future from the libvirt side.

[libvirt] [PATCH] virsh: pool-list: introduce --uuid

2017-01-04 Thread Chen Hanxiao
From: Chen Hanxiao This patch will introduce option [--uuid]. If specified, UUID of pools will be printed out. virsh # pool-list --all Name State Autostart --- default active yes root

Re: [libvirt] TSC frequency configuration & invtsc migration (was Re: [PATCH 4/4] kvm: Allow migration with invtsc)

2017-01-04 Thread Eduardo Habkost
On Wed, Jan 04, 2017 at 08:26:27PM -0200, Marcelo Tosatti wrote: > On Wed, Jan 04, 2017 at 05:59:17PM -0200, Eduardo Habkost wrote: > > On Wed, Jan 04, 2017 at 11:39:16AM -0200, Eduardo Habkost wrote: > > > On Wed, Jan 04, 2017 at 09:56:56AM -0200, Marcelo Tosatti wrote: > > > > On Tue, Dec 27,

Re: [libvirt] [PATCH] util: fix domain object leaks on closecallbacks

2017-01-04 Thread John Ferlan
Going through some older on list patches with no activity... There were two which appeared to be the same thing, so I chose the later one. Pardon the delay in processing this... On 11/23/2016 11:29 PM, Wang King wrote: > From: wangjing > > The virCloseCallbacksSet

Re: [libvirt] [PATCH] Changes to support Veritas HyperScale (VxHS) block device protocol with qemu-kvm

2017-01-04 Thread ashish mittal
On Wed, Jan 4, 2017 at 7:00 AM, John Ferlan wrote: > > [...] > We don't anticipate a need for this. > 4. There's no VxHS Storage Pool support in this patch (OK actually an > additional set of patches in order to support). That would be expected >

[libvirt] [PATCH v2 2/4] conf: Add more fchost search fields for storage pool vHBA creation

2017-01-04 Thread John Ferlan
Add new fields to the fchost structure to allow creation of a vHBA via the storage pool when a parent_wwnn/parent_wwpn or parent_fabric_wwn is supplied in the storage pool XML. Signed-off-by: John Ferlan --- docs/schemas/basictypes.rng | 15 +++

[libvirt] [PATCH v2 4/4] iscsi: Add parent wwnn/wwpn or fabric capability for createVport

2017-01-04 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1349696 As it turns out using only the 'parent' to achieve the goal of a consistent vHBA parent has issues with reboots where the scsi_hostX parent could change to scsi_hostY causing either failure to create the vHBA or usage of the wrong HBA for our

[libvirt] [PATCH v2 0/4] Allow creation of vHBA by parent_wwnn/wwpn or fabric_name

2017-01-04 Thread John Ferlan
v1: http://www.redhat.com/archives/libvir-list/2016-November/msg00866.html Based on ACKs some of the v1 changes were pushed to make this series appear shorter. Changes since v1 - Patch 1 (formerly patch 4) Rather than separate XML elements, use the existing and just make attributes for

[libvirt] [PATCH v2 3/4] util: Introduce virGetFCHostNameByFabricWWN

2017-01-04 Thread John Ferlan
Create a utility routine in order to read the scsi_host fabric_name files looking for a match to a passed fabric_name Signed-off-by: John Ferlan --- src/libvirt_private.syms | 1 + src/util/virutil.c | 141 +++

Re: [libvirt] TSC frequency configuration & invtsc migration (was Re: [PATCH 4/4] kvm: Allow migration with invtsc)

2017-01-04 Thread Marcelo Tosatti
On Wed, Jan 04, 2017 at 05:59:17PM -0200, Eduardo Habkost wrote: > On Wed, Jan 04, 2017 at 11:39:16AM -0200, Eduardo Habkost wrote: > > On Wed, Jan 04, 2017 at 09:56:56AM -0200, Marcelo Tosatti wrote: > > > On Tue, Dec 27, 2016 at 05:21:20PM -0200, Eduardo Habkost wrote: > > > > Instead of

[libvirt] TSC frequency configuration & invtsc migration (was Re: [PATCH 4/4] kvm: Allow migration with invtsc)

2017-01-04 Thread Eduardo Habkost
On Wed, Jan 04, 2017 at 11:39:16AM -0200, Eduardo Habkost wrote: > On Wed, Jan 04, 2017 at 09:56:56AM -0200, Marcelo Tosatti wrote: > > On Tue, Dec 27, 2016 at 05:21:20PM -0200, Eduardo Habkost wrote: > > > Instead of blocking migration on the source when invtsc is > > > enabled, rely on the

[libvirt] [PATCH] NEWS: Remove spurious period

2017-01-04 Thread Andrea Bolognani
All other entries in the release notes omit the leading period, and so should this one in order to maintain consistency. --- Pushed as trivial. docs/news.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/news.html.in b/docs/news.html.in index e544cfa..c222075

Re: [libvirt] [PATCH] NEWS: Update after qemu namespace fix

2017-01-04 Thread Andrea Bolognani
On Mon, 2016-12-26 at 20:40 +0100, Martin Kletzander wrote: > On Sat, Dec 24, 2016 at 05:48:30PM -0500, John Ferlan wrote: > > Das commandant will be disturbed over your (proper) usage of a period I'm going to go out on a limb and assume you were referring to me? :) I don't actually care that

[libvirt] [PATCH 2/3] NEWS: Reformat at generation time

2017-01-04 Thread Andrea Bolognani
Instead of encoding formatting information inside the corresponding XSLT stylesheet, use a Python script to reformat the text appropriately based on a few simple markers. Splitting the task between the XSLT stylesheet and the Python script allows us to keep both parts very simple. --- Yeah, I'm

[libvirt] [PATCH 1/3] NEWS: Improve building pipeline

2017-01-04 Thread Andrea Bolognani
Currently, building the NEWS file involves using a XSLT stylesheet to extract information from the same HTML file that's used on the libvirt website. The process works, but it's quite fiddly in that it requires the source HTML to be formatted in a very precise way, and a single missing newline

[libvirt] [PATCH 3/3] docs: Document the release notes process for contributors

2017-01-04 Thread Andrea Bolognani
Now that we have built a fairly solid process for dealing with release notes, we should start pushing for contributors to provide the relevant information along with their code: documenting the process is clearly a requirement for this to happen. --- docs/hacking.html.in | 8 1 file

[libvirt] [PATCH 0/3] Improve release notes process

2017-01-04 Thread Andrea Bolognani
The release note process we have had in place since v2.5.0 was never meant to be anything more than a stop-gap measure until a better solution was devised. I believe this series implements exactly that better solution :) Andrea Bolognani (3): NEWS: Improve building pipeline NEWS: Reformat at

Re: [libvirt] [PATCH] qemu: snapshot: Resume VM after live snapshot

2017-01-04 Thread Pavel Hrdina
On Wed, Jan 04, 2017 at 02:15:51PM +0100, Peter Krempa wrote: > Commit 4b951d1e38259ff5d03e9eedb65095eead8099e1 missed the fact that the > VM needs to be resumed after a live external checkpoint (memory > snapshot) where the cpus would be paused by the migration rather than > libvirt. > --- >

Re: [libvirt] Issue with libvirtd

2017-01-04 Thread Michal Privoznik
On 12/30/2016 04:53 AM, Faysal Ali wrote: > Hi > > I have a CentOS 7.3 server where I am running KVM with few virtual machines. > > I noticed this being repeated regularly in /var/log/messages > > > *libvirtd[1956]: End of file while reading data: Input/output error* Looks like your guests

Re: [libvirt] [PATCH] HACKING: Reduce vertical whitespace

2017-01-04 Thread Andrea Bolognani
On Wed, 2017-01-04 at 15:50 +0100, Martin Kletzander wrote: > ACK to how it looks, not talking about the way it's done, neither about > the XSLT stylesheet =) The first rule of XSLT stylesheet is: you do not talk about XSLT stylesheet. Pushed, thanks :) --  Andrea Bolognani / Red Hat /

Re: [libvirt] [PATCH] Changes to support Veritas HyperScale (VxHS) block device protocol with qemu-kvm

2017-01-04 Thread John Ferlan
[...] >>> We don't anticipate a need for this. >>> 4. There's no VxHS Storage Pool support in this patch (OK actually an additional set of patches in order to support). That would be expected especially for a networked storage environment. You'll note there are

Re: [libvirt] [PATCH] HACKING: Reduce vertical whitespace

2017-01-04 Thread Martin Kletzander
On Wed, Jan 04, 2017 at 03:05:40PM +0100, Andrea Bolognani wrote: When generating the plain text version of the contributor guidelines we add a ludicrous amount of vertical whitespace in some spots. Tweak the XSLT stylesheet and regenerate the now much better looking file. --- I still think the

Re: [libvirt] [PATCH 2/3] qemuDomainAttachDeviceMknodHelper: unlink() not so often

2017-01-04 Thread Martin Kletzander
On Wed, Jan 04, 2017 at 03:23:45PM +0100, Martin Kletzander wrote: On Wed, Jan 04, 2017 at 03:13:56PM +0100, Michal Privoznik wrote: Not that I'd encounter any bug here, but the code doesn't look 100% correct. Imagine, somebody is trying to attach a device to a domain, and the device's /dev

Re: [libvirt] [PATCH 3/3] qemuDomainCreateDevice: Be more careful about device path

2017-01-04 Thread Martin Kletzander
On Wed, Jan 04, 2017 at 03:13:57PM +0100, Michal Privoznik wrote: Again, not something that I'd hit, but there is a chance in theory that this might bite us. Currently the way we decide whether or not to create /dev entry for a device is by marching first four characters of path with "/dev".

Re: [libvirt] [PATCH 2/3] qemuDomainAttachDeviceMknodHelper: unlink() not so often

2017-01-04 Thread Martin Kletzander
On Wed, Jan 04, 2017 at 03:13:56PM +0100, Michal Privoznik wrote: Not that I'd encounter any bug here, but the code doesn't look 100% correct. Imagine, somebody is trying to attach a device to a domain, and the device's /dev entry already exists in the qemu namespace. This is handled gracefully

Re: [libvirt] [PATCH 1/3] qemu: Handle EEXIST gracefully in qemuDomainCreateDevice

2017-01-04 Thread Martin Kletzander
On Wed, Jan 04, 2017 at 03:13:55PM +0100, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1406837 Imagine you have a domain configured in such way that you are assigning two PCI devices that fall into the same IOMMU group. With mount namespace enabled what happens is that

[libvirt] [PATCH 0/3] qemu: Couple of namespace fixes

2017-01-04 Thread Michal Privoznik
*** BLURB HERE *** Michal Privoznik (3): qemu: Handle EEXIST gracefully in qemuDomainCreateDevice qemuDomainAttachDeviceMknodHelper: unlink() not so often qemuDomainCreateDevice: Be more careful about device path src/qemu/qemu_domain.c | 25 - 1 file changed, 16

[libvirt] [PATCH 1/3] qemu: Handle EEXIST gracefully in qemuDomainCreateDevice

2017-01-04 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1406837 Imagine you have a domain configured in such way that you are assigning two PCI devices that fall into the same IOMMU group. With mount namespace enabled what happens is that for the first PCI device corresponding /dev/vfio/X entry is created

[libvirt] [PATCH 3/3] qemuDomainCreateDevice: Be more careful about device path

2017-01-04 Thread Michal Privoznik
Again, not something that I'd hit, but there is a chance in theory that this might bite us. Currently the way we decide whether or not to create /dev entry for a device is by marching first four characters of path with "/dev". This might be not enough. Just imagine somebody has a disk image stored

[libvirt] [PATCH 2/3] qemuDomainAttachDeviceMknodHelper: unlink() not so often

2017-01-04 Thread Michal Privoznik
Not that I'd encounter any bug here, but the code doesn't look 100% correct. Imagine, somebody is trying to attach a device to a domain, and the device's /dev entry already exists in the qemu namespace. This is handled gracefully and the control continues with setting up ACLs and calling security

[libvirt] [PATCH] HACKING: Reduce vertical whitespace

2017-01-04 Thread Andrea Bolognani
When generating the plain text version of the contributor guidelines we add a ludicrous amount of vertical whitespace in some spots. Tweak the XSLT stylesheet and regenerate the now much better looking file. --- I still think the plain text HACKING file should just be a very minimal stub

[libvirt] [PATCH] HACKING: Regenerate

2017-01-04 Thread Andrea Bolognani
When updating the source file in commit bd4f4d168660, I forgot that we also store the generated plain text version in git and didn't regenerate it. I also missed one spot that required an additional tag, so fix both mistakes in one go. --- Pushed as trivial. This is the second time I have to

[libvirt] [PATCH v2] libxl: define a per-domain logger.

2017-01-04 Thread Cédric Bosdonnat
libxl doesn't provide a way to write one log for each domain. Thus we need to demux the messages. If our logger doesn't know to which domain to attribute a message, then it will write it to the default log file. Starting with Xen 4.9 (commit f9858025 and following), libxl will write the domain ID

[libvirt] [PATCH] qemu: snapshot: Resume VM after live snapshot

2017-01-04 Thread Peter Krempa
Commit 4b951d1e38259ff5d03e9eedb65095eead8099e1 missed the fact that the VM needs to be resumed after a live external checkpoint (memory snapshot) where the cpus would be paused by the migration rather than libvirt. --- src/qemu/qemu_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [libvirt] [PATCH 0/9] Qemu: s390: Cpu Model Support

2017-01-04 Thread Jason J. Herne
On 12/18/2016 02:22 PM, Jason J. Herne wrote: This patch set enables cpu model support for s390. The user can now set exact cpu models, query supported models via virsh domcapabilities, and use host-model and host-passthrough modes. The end result is that migration is safer because Qemu will

[libvirt] [PATCH] docs: Add missing elements

2017-01-04 Thread Andrea Bolognani
Some of the elements in the "General tips for contributing patches" section were missing the corresponding inner element, so they ended up all lumped together. --- Pushed as trivial. docs/hacking.html.in | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff

Re: [libvirt] [PATCH] docs: fix list of domain states in virsh manpage

2017-01-04 Thread Erik Skultety
On Tue, Jan 03, 2017 at 02:49:52PM -0500, Laine Stump wrote: > The virsh manpage lists "shutdown" and "dying" as two of the possible > domain states that could be listed in the output of the "virsh list" > command. However, a domain that is being shutdown will be listed as > "in shutdown", and the

Re: [libvirt] [PATCH] Changes to support Veritas HyperScale (VxHS) block device protocol with qemu-kvm

2017-01-04 Thread Daniel P. Berrange
On Tue, Jan 03, 2017 at 05:37:22PM -0800, ashish mittal wrote: > On Mon, Dec 19, 2016 at 4:13 PM, John Ferlan wrote: > > > > > > On 12/16/2016 10:26 PM, ashish mittal wrote: > >> Hi John, > >> > >> Thanks for the review and your comments. Sorry about the delay in > >> reply.

[libvirt] GSoC 2017

2017-01-04 Thread Michal Privoznik
Hey, so we are approaching opening date for submitting orgnaization applications [1]. In order to have perfect application we need to show Google a list of ideas that students can work on (like they couldn't google it up, right? ;-)). You can find the list here [2]. Let me ask you kindly to go