[libvirt] [PATCH v2 5/8] libxl: add support for PVH

Since this is something between PV and HVM, it makes sense to put the setting in place where domain type is specified. To enable it, use It is also included in capabilities.xml, for every supported HVM guest type - it doesn't seems to be any other requirement (besides new enough Xen).

[libvirt] [PATCH v2 7/8] xenconfig: add support for parsing type= xl config entry

builder="hvm" is deprecated since Xen 4.10, new syntax is type="hvm" (or type="pv", which is default). Since the old one is still supported, still use it when writing native config, so the config will work on older Xen too (and will also not complicate tests). Signed-off-by: Marek

[libvirt] [PATCH v2 4/8] libxl: reorder libxlMakeDomBuildInfo for upcoming PVH support

Make it easier to share HVM and PVH code where relevant. No functional change. Signed-off-by: Marek Marczykowski-Górecki --- src/libxl/libxl_conf.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c

[libvirt] [PATCH v2 3/8] libxl: prefer new location of nested_hvm in libxl_domain_build_info

If available, use b_info->nested_hvm instead of b_info->u.hvm.nested_hvm. This will make nested HVM config available also for PVH domains. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jim Fehlig --- src/libxl/libxl_conf.c | 13 -

[libvirt] [PATCH v2 0/8] libxl: PVHv2 support

This is a respin of my old PVHv1 patch[1], converted to PVHv2. Should the code use "PVH" name (as libxl does internally), or "PVHv2" as in many places in Xen documentation? I've chosen the former, but want to confirm it. Also, not sure about VIR_DOMAIN_OSTYPE_XENPVH (as discussed on PVHv1 patch)

[libvirt] [PATCH v2 6/8] tests: add basic Xen PVH test

Signed-off-by: Marek Marczykowski-Górecki --- tests/libxlxml2domconfigdata/basic-pvh.json | 49 ++- tests/libxlxml2domconfigdata/basic-pvh.xml | 28 +- tests/libxlxml2domconfigtest.c | 1 +- 3 files changed, 78 insertions(+) create mode 100644

[libvirt] [PATCH v2 2/8] libxl: set shadow memory for any guest type, not only HVM

Otherwise starting PVH guest will result in "arch_setup_bootlate: mapping shared_info failed (pfn=..., rc=-1, errno: 12): Internal error". After this change the behavior is the same as in `xl`. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jim Fehlig --- src/libxl/libxl_conf.c

[libvirt] [PATCH v2 1/8] docs: add documentation of arch element of capabilities.xml

Specifically, list sub-elements and where they can be used. In addition, describe supported machine types for Xen. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v2: - clarify type@domain description, add a link to domain xml there --- docs/formatcaps.html.in | 22

[libvirt] [PATCH v2 8/8] xenconfig: add support for type="pvh"

Handle PVH domain type in both directions (xen-xl->xml, xml->xen-xl). And add a test for it. Signed-off-by: Marek Marczykowski-Górecki --- src/xenconfig/xen_common.c | 11 +-- src/xenconfig/xen_xl.c | 5 + tests/testutilsxen.c | 3 ++-

Re: [libvirt] [PATCH] conf: fix starting a domain with cpuset=""

> On Mon, Sep 17, 2018 at 06:53:13PM +0800, wang.y...@zte.com.cn wrote: > > > On Sat, Sep 15, 2018 at 04:29:24PM +0800, Yi Wang wrote: > > > > Domain fails to start when its config xml including: > > > > 64 > > > > > > > > # virsh create vm.xml > > > > error: Failed to create domain from

Re: [libvirt] [PATCH] qemu: Fix error reporting in qemuDomainSaveImageStartVM

On 09/18/2018 03:59 AM, Jiri Denemark wrote: > When restoring a domain from a compressed image, we launch an > intermediate process for decompressing the saved data. If QEMU fails to > load the data for some reason, we force close the stdin/stdout file > descriptors of the intermediate process

Re: [libvirt] [PATCH v2 3/3] qemu: add memfd source type

On 09/17/2018 09:14 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add a new memoryBacking source type "memfd", supported by QEMU (when > the apability is available). *capability > > A memfd is a specialized anonymous memory kind. As such, an anonymous > source type

Re: [libvirt] [PATCHv2 4/4] conf: Introduce RDT monitor host capability

ca On 09/14/2018 09:30 PM, Wang Huaqiang wrote: > Cache monitoring technology(CMT) and memory bandwidth > monitoring technology(MBM) are resource monitoring > part of Intel resource director technology(RDT). > > This patch is introducing cache monitor(CMT) to cache and > memory bandwidth

Re: [libvirt] [PATCHv2 3/4] conf: Refactor memory bandwidth capability structure

On 09/14/2018 09:30 PM, Wang Huaqiang wrote: > Move memory bandwidth capability nodes into one data structure, > this allows us to add a monitor for memory bandwidth. > > Signed-off-by: Wang Huaqiang > --- > src/conf/capabilities.c | 22 ++ > src/conf/capabilities.h | 10

Re: [libvirt] [PATCHv2 2/4] conf: Refactor cache bank capability structure

On 09/14/2018 09:30 PM, Wang Huaqiang wrote: > Move all cache banks into one data structure, this allows > us to add other cache component, such as cache monitor. > > Signed-off-by: Wang Huaqiang > --- > src/conf/capabilities.c | 36 +--- >

Re: [libvirt] [PATCHv2 1/4] util: Introduce monitor capability interface

On 09/14/2018 09:30 PM, Wang Huaqiang wrote: > This patch introduces the resource monitor and creates the interface > for getting host capability of resource monitor from the system resource > control file system. > > The resource monitor take the role of RDT monitoring group, could be

[libvirt] [libvirt PATCH v6 04/15] xen_xl: Adapt xenParseCmdline due to changes in xenConfigGetString

xenConfigGetString returns a newly-allocated pointer and it has to be freed by the caller. Signed-off-by: Fabiano Fidêncio --- src/xenconfig/xen_xl.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c

[libvirt] [libvirt PATCH v6 02/15] xen_common: Change xenConfigGetUUID to using virConfGetValueString

Signed-off-by: Fabiano Fidêncio --- src/xenconfig/xen_common.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/src/xenconfig/xen_common.c b/src/xenconfig/xen_common.c index a35e1aff58..08fbfff44f 100644 --- a/src/xenconfig/xen_common.c +++

[libvirt] [libvirt PATCH v6 12/15] xen_xm: Adapt xenParseXMInputDevs due to changes in xenConfigGetString

xenConfigGetString returns a newly-allocated pointer and it has to be freed by the caller. Signed-off-by: Fabiano Fidêncio --- src/xenconfig/xen_xm.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/xenconfig/xen_xm.c b/src/xenconfig/xen_xm.c index

[libvirt] [libvirt PATCH v6 14/15] xen_common: Change xenParseVfbs to using virConfGetValueStringList

Signed-off-by: Fabiano Fidêncio --- src/xenconfig/xen_common.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/xenconfig/xen_common.c b/src/xenconfig/xen_common.c index 9ad081e56b..a6e77a9250 100644 --- a/src/xenconfig/xen_common.c +++

[libvirt] [libvirt PATCH v6 13/15] xen_common: Change xenParsePCIList to using virConfGetValueStringList

The `if (!list || list->type != VIR_CONF_LIST)` couldn't be written in a 100% similar way as `if (virConfGetValueStringList(conf, "pci", false, ) <= 0)` leads us to just ignore any error and return 0 in case of failure. However, for what's needed in this function, this is the closest to the

[libvirt] [libvirt PATCH v6 06/15] xen_xl: adapt xenParseXLCPUID due to changes in xenConfigGetString

xenConfigGetString returns a newly-allocated pointer and it has to be freed by the caller. Signed-off-by: Fabiano Fidêncio --- src/xenconfig/xen_xl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c index cb1cab8482..7d86849feb 100644 ---

[libvirt] [libvirt PATCH v6 10/15] xen_common: Adapt xenParseGeneralMeta due to changes in xenConfigGetString

xenConfigGetString returns a newly-allocated pointer and it has to be freed by the caller. Signed-off-by: Fabiano Fidêncio --- src/xenconfig/xen_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/xenconfig/xen_common.c b/src/xenconfig/xen_common.c index

[libvirt] [libvirt PATCH v6 08/15] xen_common: Adapt xenParseCPUFeatures due to changes in xenConfigGetString

xenConfigGetString returns a newly-allocated pointer and it has to be freed by the caller. Signed-off-by: Fabiano Fidêncio --- src/xenconfig/xen_common.c | 50 +- 1 file changed, 28 insertions(+), 22 deletions(-) diff --git a/src/xenconfig/xen_common.c

[libvirt] [libvirt PATCH v6 11/15] xen_xm: Adapt xenParseXMOS due to changes in xenConfigGetString

xenConfigGetString returns a newly-allocated pointer and it has to be freed by the caller. Signed-off-by: Fabiano Fidêncio --- src/xenconfig/xen_xm.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/src/xenconfig/xen_xm.c

[libvirt] [libvirt PATCH v6 15/15] xen_common: Change xenParseCharDev to using virConfGetValueStringList

Signed-off-by: Fabiano Fidêncio --- src/xenconfig/xen_common.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/src/xenconfig/xen_common.c b/src/xenconfig/xen_common.c index a6e77a9250..786c276c99 100644 --- a/src/xenconfig/xen_common.c +++

[libvirt] [libvirt PATCH v6 07/15] xen_common: Adapt xenParseEventsActions due to changes in xenConfigGetString

xenConfigGetString returns a newly-allocated pointer and it has to be freed by the caller. Signed-off-by: Fabiano Fidêncio --- src/xenconfig/xen_common.c | 41 ++ 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/src/xenconfig/xen_common.c

[libvirt] [libvirt PATCH v6 00/15] Finish the conversion to virConfGetValue* functions libvirt

This patchset finishes the conversion to virConfGetValue* functions, started by Daniel Berrange a few months ago. Please, mind that although we could make virConfGetValue* functions more generic in order to support numbers and booleans as strings, that doesn't seem the safest path to take. The

[libvirt] [libvirt PATCH v6 09/15] xen_common: Adapt xenParseEmulatedDevices due to changes in xenConfigGetString

xenConfigGetString returns a newly-allocated pointer and it has to be freed by the caller. Signed-off-by: Fabiano Fidêncio --- src/xenconfig/xen_common.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/xenconfig/xen_common.c b/src/xenconfig/xen_common.c index

[libvirt] [libvirt PATCH v6 05/15] xen_xl: Adapt xenParseXLOS due to changes in xenConfigGetString

xenConfigGetString returns a newly-allocated pointer and it has to be freed by the caller. Signed-off-by: Fabiano Fidêncio --- src/xenconfig/xen_xl.c | 45 -- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/src/xenconfig/xen_xl.c

[libvirt] [libvirt PATCH v6 01/15] xen_common: Change xenConfigCopyStringInternal to using virConfGetValueString

Signed-off-by: Fabiano Fidêncio --- src/xenconfig/xen_common.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/src/xenconfig/xen_common.c b/src/xenconfig/xen_common.c index 36a9d27c80..a35e1aff58 100644 --- a/src/xenconfig/xen_common.c +++

[libvirt] [libvirt PATCH v6 03/15] xen_common: Change xenConfigGetString to using virConfGetValueString

This change actually changes the behaviour of xenConfigGetString() as now it returns a newly-allocated string. Unfortunately, there's not much that can be done in order to avoid that and all the needed changes in callers in order to not leak the returned value are coming in the following patches.

[libvirt] [PATCH 45/47] vircgroup: extract virCgroupV1(Set|Get)CpusetCpus

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 10 ++ src/util/vircgroupbackend.h | 10 ++ src/util/vircgroupv1.c | 24 3 files changed, 36 insertions(+), 8 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index

[libvirt] [PATCH 30/47] vircgroup: extract virCgroupV1GetMemoryStat

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 67 +++--- src/util/vircgroupbackend.h | 10 ++ src/util/vircgroupv1.c | 71 + 3 files changed, 85 insertions(+), 63 deletions(-) diff --git

[libvirt] [PATCH 39/47] vircgroup: extract virCgroupV1SupportsCpuBW

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 13 + src/util/vircgroupbackend.h | 4 src/util/vircgroupv1.c | 19 +++ 3 files changed, 24 insertions(+), 12 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index

[libvirt] [PATCH 43/47] vircgroup: extract virCgroupV1(Set|Get)CpusetMems

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 10 ++ src/util/vircgroupbackend.h | 11 +++ src/util/vircgroupv1.c | 25 + 3 files changed, 38 insertions(+), 8 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index

[libvirt] [PATCH 44/47] vircgroup: extract virCgroupV1(Set|Get)CpusetMemoryMigrate

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 13 ++--- src/util/vircgroupbackend.h | 10 ++ src/util/vircgroupv1.c | 27 +++ 3 files changed, 39 insertions(+), 11 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c

[libvirt] [PATCH 42/47] vircgroup: extract virCgroupV1(Set|Get)FreezerState

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 8 ++-- src/util/vircgroupbackend.h | 11 +++ src/util/vircgroupv1.c | 23 +++ 3 files changed, 36 insertions(+), 6 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index

[libvirt] [PATCH 41/47] vircgroup: extract virCgroupV1GetCpuacctStat

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 39 +- src/util/vircgroupbackend.h | 6 + src/util/vircgroupv1.c | 47 + 3 files changed, 54 insertions(+), 38 deletions(-) diff --git a/src/util/vircgroup.c

[libvirt] [PATCH 47/47] vircgroup: rename controllers to legacy

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 6 +- src/util/vircgrouppriv.h | 2 +- src/util/vircgroupv1.c | 140 +++ tests/vircgrouptest.c| 14 ++-- 4 files changed, 81 insertions(+), 81 deletions(-) diff --git a/src/util/vircgroup.c

[libvirt] [PATCH 40/47] vircgroup: extract virCgroupV1GetCpuacct*Usage

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 7 ++- src/util/vircgroupbackend.h | 11 +++ src/util/vircgroupv1.c | 22 ++ 3 files changed, 35 insertions(+), 5 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index

[libvirt] [PATCH 46/47] vircgroup: rename virCgroupController into virCgroupV1Controller

Signed-off-by: Pavel Hrdina --- src/util/vircgrouppriv.h | 8 src/util/vircgroupv1.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/util/vircgrouppriv.h b/src/util/vircgrouppriv.h index 38c911e8ed..ee6aeedbb5 100644 --- a/src/util/vircgrouppriv.h +++

[libvirt] [PATCH 38/47] vircgroup: extract virCgroupV1(Set|Get)CpuCfsQuota

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 20 +++- src/util/vircgroupbackend.h | 10 ++ src/util/vircgrouppriv.h| 5 + src/util/vircgroupv1.c | 32 4 files changed, 50 insertions(+), 17 deletions(-) diff

[libvirt] [PATCH 36/47] vircgroup: extract virCgroupV1(Set|Get)CpuShares

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 8 ++-- src/util/vircgroupbackend.h | 11 +++ src/util/vircgroupv1.c | 23 +++ 3 files changed, 36 insertions(+), 6 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index

[libvirt] [PATCH 27/47] vircgroup: extract virCgroupV1(Set|Get)BlkioDeviceReadBps

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 34 ++--- src/util/vircgroupbackend.h | 12 + src/util/vircgroupv1.c | 50 + 3 files changed, 64 insertions(+), 32 deletions(-) diff --git a/src/util/vircgroup.c

[libvirt] [PATCH 18/47] vircgroup: extract virCgroupV1HasEmptyTasks

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 13 + src/util/vircgroupbackend.h | 5 + src/util/vircgroupv1.c | 20 3 files changed, 26 insertions(+), 12 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index

[libvirt] [PATCH 10/47] vircgroup: extract virCgroupV1GetPlacement

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 3 +-- src/util/vircgroupbackend.h | 4 src/util/vircgroupv1.c | 12 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 864dd876b0..ff102e2cb0

[libvirt] [PATCH 25/47] vircgroup: extract virCgroupV1(Set|Get)BlkioDeviceReadIops

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 34 ++--- src/util/vircgroupbackend.h | 12 + src/util/vircgroupv1.c | 50 + 3 files changed, 64 insertions(+), 32 deletions(-) diff --git a/src/util/vircgroup.c

[libvirt] [PATCH 09/47] vircgroup: extract virCgroupV1ValidatePlacement

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 32 +--- src/util/vircgroupbackend.h | 5 + src/util/vircgroupv1.c | 31 +++ 3 files changed, 37 insertions(+), 31 deletions(-) diff --git a/src/util/vircgroup.c

[libvirt] [PATCH 29/47] vircgroup: extract virCgroupV1SetMemory

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 20 +--- src/util/vircgroupbackend.h | 6 ++ src/util/vircgroupv1.c | 28 3 files changed, 35 insertions(+), 19 deletions(-) diff --git a/src/util/vircgroup.c

[libvirt] [PATCH 15/47] vircgroup: extract virCgroupV1MakeGroup

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 141 ++-- src/util/vircgroupbackend.h | 15 src/util/vircgrouppriv.h| 20 + src/util/vircgroupv1.c | 132 + 4 files changed, 174 insertions(+), 134

[libvirt] [PATCH 16/47] vircgroup: extract virCgroupV1Remove

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 35 ++--- src/util/vircgroupbackend.h | 4 src/util/vircgrouppriv.h| 2 ++ src/util/vircgroupv1.c | 39 + 4 files changed, 47 insertions(+), 33

[libvirt] [PATCH 19/47] vircgroup: extract virCgroupV1BindMount

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 102 +--- src/util/vircgroupbackend.h | 6 ++ src/util/vircgroupv1.c | 113 3 files changed, 120 insertions(+), 101 deletions(-) diff --git

[libvirt] [PATCH 21/47] vircgroup: extract virCgroupV1(Set|Get)BlkioWeight

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 14 ++ src/util/vircgroupbackend.h | 20 src/util/vircgroupv1.c | 29 + 3 files changed, 51 insertions(+), 12 deletions(-) diff --git a/src/util/vircgroup.c

[libvirt] [PATCH 07/47] vircgroup: extract v1 detect functions

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 138 ++- src/util/vircgroupbackend.h | 14 src/util/vircgroupv1.c | 158 3 files changed, 180 insertions(+), 130 deletions(-) diff --git

[libvirt] [PATCH 17/47] vircgroup: extract virCgroupV1AddTask

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 48 + src/util/vircgroupbackend.h | 12 ++ src/util/vircgrouppriv.h| 5 src/util/vircgroupv1.c | 31 4 files changed, 54 insertions(+), 42

[libvirt] [PATCH 33/47] vircgroup: extract virCgroupV1GetMemSwapUsage

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 9 + src/util/vircgroupbackend.h | 5 + src/util/vircgroupv1.c | 16 3 files changed, 22 insertions(+), 8 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index

[libvirt] [PATCH 37/47] vircgroup: extract virCgroupV1(Set|Get)CpuCfsPeriod

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 18 ++ src/util/vircgroupbackend.h | 10 ++ src/util/vircgroupv1.c | 32 3 files changed, 44 insertions(+), 16 deletions(-) diff --git a/src/util/vircgroup.c

[libvirt] [PATCH 28/47] vircgroup: extract virCgroupV1(Set|Get)BlkioDeviceWriteBps

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 34 ++--- src/util/vircgroupbackend.h | 12 + src/util/vircgroupv1.c | 50 + 3 files changed, 64 insertions(+), 32 deletions(-) diff --git a/src/util/vircgroup.c

[libvirt] [PATCH 35/47] vircgroup: extract virCgroupV1(Allow|Deny)AllDevices

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 18 ++ src/util/vircgroupbackend.h | 9 + src/util/vircgroupv1.c | 31 +++ 3 files changed, 42 insertions(+), 16 deletions(-) diff --git a/src/util/vircgroup.c

[libvirt] [PATCH 34/47] vircgroup: extract virCgroupV1(Allow|Deny)Device

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 68 +++- src/util/vircgroupbackend.h | 17 + src/util/vircgroupv1.c | 69 + 3 files changed, 98 insertions(+), 56 deletions(-) diff --git

[libvirt] [PATCH 31/47] vircgroup: extract virCgroupV1GetMemoryUsage

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 9 + src/util/vircgroupbackend.h | 5 + src/util/vircgroupv1.c | 16 3 files changed, 22 insertions(+), 8 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index

[libvirt] [PATCH 26/47] vircgroup: extract virCgroupV1(Set|Get)BlkioDeviceWriteIops

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 34 ++--- src/util/vircgroupbackend.h | 12 + src/util/vircgroupv1.c | 50 + 3 files changed, 64 insertions(+), 32 deletions(-) diff --git a/src/util/vircgroup.c

[libvirt] [PATCH 32/47] vircgroup: extract virCgroupV1(Set|Get)Memory*Limit

They all need virCgroupV1GetMemoryUnlimitedKB() so it's easier to move them in one commit. Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 128 ++- src/util/vircgroupbackend.h | 30 +++ src/util/vircgrouppriv.h| 6 ++ src/util/vircgroupv1.c

[libvirt] [PATCH 23/47] vircgroup: extract virCgroupV1GetBlkioIoDeviceServiced

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 83 ++ src/util/vircgroupbackend.h | 9 src/util/vircgrouppriv.h| 2 + src/util/vircgroupv1.c | 89 + 4 files changed, 104 insertions(+), 79

[libvirt] [PATCH 13/47] vircgroup: extract virCgroupV1GetAnyController

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 16 src/util/vircgroupbackend.h | 4 src/util/vircgroupv1.c | 22 ++ 3 files changed, 30 insertions(+), 12 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index

[libvirt] [PATCH 22/47] vircgroup: extract virCgroupV1GetBlkioIoServiced

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 87 ++ src/util/vircgroupbackend.h | 8 src/util/vircgroupv1.c | 94 + 3 files changed, 105 insertions(+), 84 deletions(-) diff --git

[libvirt] [PATCH 20/47] vircgroup: extract virCgroupV1SetOwner

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 54 +- src/util/vircgroupbackend.h | 7 src/util/vircgroupv1.c | 65 + 3 files changed, 73 insertions(+), 53 deletions(-) diff --git a/src/util/vircgroup.c

[libvirt] [PATCH 12/47] vircgroup: extract virCgroupV1HasController

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 3 ++- src/util/vircgroupbackend.h | 5 + src/util/vircgroupv1.c | 9 + 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 7822eec683..3d10ac2427 100644

[libvirt] [PATCH 24/47] vircgroup: extract virCgroupV1(Set|Get)BlkioDeviceWeight

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 36 +++--- src/util/vircgroupbackend.h | 12 + src/util/vircgrouppriv.h| 6 + src/util/vircgroupv1.c | 50 + 4 files changed, 71 insertions(+), 33

[libvirt] [PATCH 14/47] vircgroup: extract virCgroupV1PathOfController

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 22 +- src/util/vircgroupbackend.h | 7 +++ src/util/vircgroupv1.c | 31 +++ 3 files changed, 39 insertions(+), 21 deletions(-) diff --git a/src/util/vircgroup.c

[libvirt] [PATCH 02/47] vircgroup: introduce cgroup v1 backend files

Signed-off-by: Pavel Hrdina --- src/Makefile.am | 1 + src/libvirt_private.syms| 3 ++ src/util/Makefile.inc.am| 2 ++ src/util/vircgroupbackend.c | 2 ++ src/util/vircgroupv1.c | 55 + src/util/vircgroupv1.h | 27

[libvirt] [PATCH 06/47] vircgroup: extract virCgroupV1CopyMounts

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 23 +-- src/util/vircgroupbackend.h | 5 + src/util/vircgroupv1.c | 22 ++ 3 files changed, 28 insertions(+), 22 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c

[libvirt] [PATCH 04/47] vircgroup: detect available backend for cgroup

We need to update one test-case because now new cgroup object will be created only if there is any cgroup backend available. Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 18 ++ src/util/vircgrouppriv.h | 3 +++ tests/vircgrouptest.c| 38

[libvirt] [PATCH 11/47] vircgroup: extract virCgroupV1DetectControllers

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 66 + src/util/vircgroupbackend.h | 5 +++ src/util/vircgroupv1.c | 65 3 files changed, 71 insertions(+), 65 deletions(-) diff --git

[libvirt] [PATCH 08/47] vircgroup: extract virCgroupV1CopyPlacement

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 38 + src/util/vircgroupbackend.h | 6 ++ src/util/vircgroupv1.c | 37 3 files changed, 44 insertions(+), 37 deletions(-) diff --git

[libvirt] [PATCH 05/47] vircgroup: extract virCgroupV1ValidateMachineGroup

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 85 + src/util/vircgroupbackend.h | 7 +++ src/util/vircgrouppriv.h| 2 + src/util/vircgroupv1.c | 84 4 files changed, 95 insertions(+), 83

[libvirt] [PATCH 00/47] extract cgroup v1 code to separate backend

We will need to introduce cgroup v2 support which needs to co-exit with the current cgroup v1 implementation. In order to do that this patch series introduces virCgroupBackend structure and moves all cgroup v1 related code to separate file.

[libvirt] [PATCH 01/47] util: introduce vircgroupbackend files

We will need to extract current cgroup v1 implementation into separate backend because there will be new cgroup v2 implementation and both will have to co-exit. Signed-off-by: Pavel Hrdina --- src/Makefile.am | 1 + src/libvirt_private.syms| 3 ++ src/util/Makefile.inc.am|

[libvirt] [PATCH 03/47] vircgroup: extract virCgroupV1Available

Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c| 28 +--- src/util/vircgroupbackend.h | 7 +++ src/util/vircgroupv1.c | 35 +++ 3 files changed, 51 insertions(+), 19 deletions(-) diff --git a/src/util/vircgroup.c

Re: [libvirt] [PATCH v4 16/23] security_manager: Introduce metadata locking APIs

On 09/18/2018 12:12 AM, John Ferlan wrote: > [...] > >> + > > After seeing it in use in patch 19 and thinking about it for a very > short period of time, would it make more sense to store @lock somewhere > so that virSecurityManagerMetadataUnlock doesn't fail because the >

Re: [libvirt] [PATCH v4 12/23] lock_daemon_dispatch: Check for ownerPid rather than ownerId

On 09/17/2018 08:40 PM, John Ferlan wrote: > > > On 09/10/2018 05:36 AM, Michal Privoznik wrote: >> At the beginning of each dispatch function we check if owner >> attributes were registered (these consist of ID, UUID, PID and >> name). The check then consists of checking if ID is not zero. >>

Re: [libvirt] [PATCH v4 15/23] security_manager: Load lock plugin on init

On 09/17/2018 09:56 PM, John Ferlan wrote: > > > On 09/10/2018 05:36 AM, Michal Privoznik wrote: >> Now that we know what metadata lock manager user wishes to use we >> can load it when initializing security driver. This is achieved >> by adding new argument to virSecurityManagerNewDriver() and

Re: [libvirt] [PATCH v4 17/23] security_dac: Move transaction handling up one level

On 09/17/2018 11:47 PM, John Ferlan wrote: > > > On 09/10/2018 05:36 AM, Michal Privoznik wrote: >> So far the whole transaction handling is done >> virSecurityDACSetOwnershipInternal(). This needs to change for >> the sake of security label remembering and locking. Otherwise we >> would be

Re: [libvirt] [PATCH v4 08/23] lock_driver: Introduce new VIR_LOCK_MANAGER_OBJECT_TYPE_DAEMON

On 09/17/2018 06:17 PM, John Ferlan wrote: > > > On 09/10/2018 05:36 AM, Michal Privoznik wrote: >> We will want virtlockd to lock files on behalf of libvirtd and >> not qemu process, because it is libvirtd that needs an exclusive >> access not qemu. This requires new lock context. >> >>

Re: [libvirt] [PATCH v4 16/23] security_manager: Introduce metadata locking APIs

On 09/17/2018 11:14 PM, John Ferlan wrote: > > > On 09/10/2018 05:36 AM, Michal Privoznik wrote: >> Two new APIs are added so that security driver can lock and >> unlock paths it wishes to touch. These APIs are not for other >> drivers to call but security drivers (DAC and SELinux). That is >>

Re: [libvirt] [PATCH v4 22/23] security_selinux: Move transaction handling up one level

On 09/18/2018 12:25 AM, John Ferlan wrote: > > > On 09/10/2018 05:36 AM, Michal Privoznik wrote: >> So far the whole transaction handling is done >> virSecuritySELinuxSetFileconHelper(). This needs to change for >> the sake of security label remembering and locking. Otherwise we >> would be

Re: [libvirt] [PATCH v4 00/23] Introduce metadata locking

On 09/10/2018 11:36 AM, Michal Privoznik wrote: > Hopefully, fixed all the nits John found, and pushed. Thanks John for the review! Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 13/13] virt-admin: Implement vshTable API to server-list and client-list

Signed-off-by: Simon Kobyda --- tools/virt-admin.c | 46 -- 1 file changed, 36 insertions(+), 10 deletions(-) diff --git a/tools/virt-admin.c b/tools/virt-admin.c index 63822bc13e..ac4c72efec 100644 --- a/tools/virt-admin.c +++ b/tools/virt-admin.c @@

[libvirt] [PATCH 12/13] virsh: Implement vshTable API to vol-list

Local lengthy unicode-unreliable table formatting was replaced by new API. Great example of how new API saves space and time. Removed a lot of string lenght calculation used by the local table. Signed-off-by: Simon Kobyda --- tools/virsh-volume.c | 127

[libvirt] [PATCH 07/13] virsh: Implement vshTable API to domblkinfo

Signed-off-by: Simon Kobyda --- tools/virsh-domain-monitor.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index cb48f9a7be..05db825716 100644 --- a/tools/virsh-domain-monitor.c +++

[libvirt] [PATCH 11/13] virsh: Implement vshTable API to pool-list

Local lengthy unicode-unreliable table formatting was replaced by new API. Great example of how new API saves space and time. Removed a lot of string lenght canculation used by the local table. Signed-off-by: Simon Kobyda --- tools/virsh-pool.c | 160

[libvirt] [PATCH 04/13] virsh: Implement vshTable API to nwfilter-list and nwfilterbinding-list

Signed-off-by: Simon Kobyda --- tools/virsh-nwfilter.c | 47 +- 1 file changed, 33 insertions(+), 14 deletions(-) diff --git a/tools/virsh-nwfilter.c b/tools/virsh-nwfilter.c index 1cdbe5053a..91e9e78b8b 100644 --- a/tools/virsh-nwfilter.c +++

[libvirt] [PATCH 10/13] virsh: Implement vshTable API to vcpupin, iothreadinfo, domfsinfo

Signed-off-by: Simon Kobyda --- tools/virsh-domain.c | 95 +--- 1 file changed, 71 insertions(+), 24 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index c1cff9fe2d..c580be998c 100644 --- a/tools/virsh-domain.c +++

[libvirt] [PATCH 05/13] virsh: Implement vshTable API to snapshot-list.

Signed-off-by: Simon Kobyda --- tools/virsh-snapshot.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index a4ea959230..5a02d2c786 100644 --- a/tools/virsh-snapshot.c +++

[libvirt] [PATCH 06/13] virsh: Set up cmdDomblkinfo() and cmdDomblkinfoPrint() for vshTable API implementation

I've moved all the printing from cmdDomblkinfoPrint() to cmdDomblkinfo(), and renamed the cmdDomblkinfoPrint() to cmdDomblkinfoGet(), since nature of that function changed from gathering and printing informations only to gathering information. This I believe simplifies the functions and makes the

[libvirt] [PATCH 09/13] virsh: Implement vshTable API to domiflist

Signed-off-by: Simon Kobyda --- tools/virsh-domain-monitor.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index b9b6739287..d31f02e5e6 100644 --- a/tools/virsh-domain-monitor.c +++

[libvirt] [PATCH 08/13] virsh: Implement vshTable API to domblklist

Signed-off-by: Simon Kobyda --- tools/virsh-domain-monitor.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index 05db825716..b9b6739287 100644 --- a/tools/virsh-domain-monitor.c +++

[libvirt] [PATCH 03/13] virsh: Implement vshTable API to secret-list

Signed-off-by: Simon Kobyda --- tools/virsh-secret.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/tools/virsh-secret.c b/tools/virsh-secret.c index 670beea706..0ae248b4dd 100644 --- a/tools/virsh-secret.c +++ b/tools/virsh-secret.c @@ -35,6

[libvirt] [PATCH 02/13] virsh: Implement vshTable API to net-list and net-dhcp-leases

Signed-off-by: Simon Kobyda --- tools/virsh-network.c | 55 +-- 1 file changed, 37 insertions(+), 18 deletions(-) diff --git a/tools/virsh-network.c b/tools/virsh-network.c index ca07fb568f..0f975b8899 100644 --- a/tools/virsh-network.c +++

  1   2   >