On Fri, Oct 19, 2018 at 09:53:45PM +0200, Igor Mammedov wrote:
> On Fri, 19 Oct 2018 15:44:08 -0300
> Eduardo Habkost wrote:
>
> > On Fri, Oct 19, 2018 at 03:12:31PM +0100, Peter Maydell wrote:
> > > On 18 October 2018 at 21:03, Eduardo Habkost wrote:
> > > > The following changes since commit
On Fri, 19 Oct 2018 15:44:08 -0300
Eduardo Habkost wrote:
> On Fri, Oct 19, 2018 at 03:12:31PM +0100, Peter Maydell wrote:
> > On 18 October 2018 at 21:03, Eduardo Habkost wrote:
> > > The following changes since commit
> > > 09558375a634e17cea6cfbfec883ac2376d2dc7f:
> > >
> > > Merge
On Fri, Oct 19, 2018 at 03:12:31PM +0100, Peter Maydell wrote:
> On 18 October 2018 at 21:03, Eduardo Habkost wrote:
> > The following changes since commit 09558375a634e17cea6cfbfec883ac2376d2dc7f:
> >
> > Merge remote-tracking branch
> > 'remotes/pmaydell/tags/pull-target-arm-20181016-1' into
On 10/19/18 12:35 PM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> src/qemu/qemu_hotplug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Trivial ;-), but implemented that way, see commit cb6ea85b7
So, extra credit for fixing
On 10/18/18 3:32 AM, Jie Wang wrote:
> From fca1732c0e1f691fb25c614349d5486bbc73a109 Mon Sep 17 00:00:00 2001
> From: Jie Wang
> Date: Wed, 17 Oct 2018 22:55:51 +0800
> Subject: [PATCH] qemu: Fix IOThread pids lost after qemuProcessReconnect
Removed whatever this was (and it was in both
On 10/19/18 5:24 AM, Nikolay Shirokovskiy wrote:
>
>
> On 18.10.2018 18:30, John Ferlan wrote:
>>
>>
>> On 10/17/18 4:16 AM, Nikolay Shirokovskiy wrote:
>>>
>>>
>>> On 16.10.2018 15:48, John Ferlan wrote:
On 10/8/18 7:21 AM, Nikolay Shirokovskiy wrote:
> Let's introduce
On 10/19/18 9:25 AM, Marek Marczykowski-Górecki wrote:
On Fri, Oct 19, 2018 at 04:19:21PM +0100, Daniel P. Berrangé wrote:
On Fri, Oct 19, 2018 at 05:10:30PM +0200, Marek Marczykowski-Górecki wrote:
On Fri, Oct 19, 2018 at 03:59:03PM +0100, Daniel P. Berrangé wrote:
On Fri, Oct 19, 2018 at
Signed-off-by: Daniel P. Berrangé
---
src/qemu/qemu_hotplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 0a63741b9e..12bef16fd6 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -5814,7 +5814,7
On 10/12/18 9:02 AM, Peter Krempa wrote:
On Fri, Oct 12, 2018 at 00:10:09 -0500, Eric Blake wrote:
Introduce a few more new public APIs related to incremental backups.
This builds on the previous notion of a checkpoint (without an
existing checkpoint, the new API is a full backup, differing
On Fri, Oct 19, 2018 at 04:19:21PM +0100, Daniel P. Berrangé wrote:
> On Fri, Oct 19, 2018 at 05:10:30PM +0200, Marek Marczykowski-Górecki wrote:
> > On Fri, Oct 19, 2018 at 03:59:03PM +0100, Daniel P. Berrangé wrote:
> > > On Fri, Oct 19, 2018 at 08:53:15AM -0600, Jim Fehlig wrote:
> > > > own
On 10/18/18 2:49 AM, Nikolay Shirokovskiy wrote:
> For filter without references to other filters hash is just sha-256 of
> filter's
> xml. For filters with references hash is sha-256 of string consisting of
> filter's self hash and hashes of directly referenced filters.
I didn't read the
On Fri, Oct 19, 2018 at 05:10:30PM +0200, Marek Marczykowski-Górecki wrote:
> On Fri, Oct 19, 2018 at 03:59:03PM +0100, Daniel P. Berrangé wrote:
> > On Fri, Oct 19, 2018 at 08:53:15AM -0600, Jim Fehlig wrote:
> > > own head) for either of the two modeling approaches
> > >
> > >
https://bugzilla.redhat.com/show_bug.cgi?id=1545732
Implement the QEMU driver mechanism in order to set the polling
parameters for an IOThread within the bounds specified by the
QEMU qapi parameter passing.
Based heavily on patches originally posted by Pavel Hrdina
, but modified to only handle
Rather than passing an iothread_id, let's pass a qemuMonitorIOThreadInfo
structure so that a subsequent change to modify the iothread info can
just generate and pass one.
Signed-off-by: John Ferlan
ACKed-by: Michal Privoznik
---
src/qemu/qemu_driver.c | 26 +++---
1 file
Create a new API that will allow an adjustment of IOThread
polling parameters for the specified IOThread. These parameters
will not be saved in the guest XML. Currently the only parameters
supported will allow the hypervisor to adjust the parameters used
to limit and alter the scope of the polling
We're about to add a new state "modify" and thus the function
goes from just Add/Del. Use an enum to manage.
Extracted from code originally posted by Pavel Hrdina
, but placed into a separate patch.
Signed-off-by: John Ferlan
ACKed-by: Michal Privoznik
---
src/qemu/qemu_driver.c | 32
Add an --iothread qualifier to domstats and an explanation in
the man page. Describe the values in as generic terms as possible
allowing each hypervisor to provide a specific algorithm to utilize
the values as it sees fit.
Signed-off-by: John Ferlan
ACKed-by: Michal Privoznik
---
Process the IOThreads polling stats if available. Generate the
output params record to be returned to the caller with the three
values - poll-max-ns, poll-grow, and poll-shrink.
Signed-off-by: John Ferlan
---
include/libvirt/libvirt-domain.h | 1 +
src/libvirt-domain.c | 38
If there are IOThread polling values in the query-iothreads return
buffer, then fill them in and set a bool indicating their presence.
This will allow for displaying in a domain stats output eventually.
Note that the QEMU values are managed a bit differently (as int's
stored in int64_t's) than we
v1: https://www.redhat.com/archives/libvir-list/2018-October/msg00456.html
Changes since v1 (from code review)
Patch 2: Move the job back into qemuDomainGetIOThreadsLive
Patch 3: Add check for ActiveJob before allowing, use true for
*StatsWorker, and print 'iothread' in output not
Signed-off-by: John Ferlan
---
docs/news.xml | 13 +
1 file changed, 13 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index dc08c96352..b0e3eca5cd 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -35,6 +35,19 @@
+
+
+ Support changing
Add a command to allow for setting various dynamic IOThread polling
interval scope (poll-max-ns, poll-grow, and poll-shrink). Describe
the values in the virsh.pod in as generic terms as possible. The
more specific QEMU algorithm has been divulged in the previous patch.
Based heavily on code
Separate out the fetch of the IOThread monitor call into a separate
helper so that a subsequent domain statistics change can fetch the raw
IOThread data and parse it as it sees fit.
Signed-off-by: John Ferlan
---
src/qemu/qemu_driver.c | 48 ++
1 file
Add functions to set the IOThreadInfo param data for the live guest.
Modify the _qemuMonitorIOThreadInfo to have a flag to indicate when
a value was set so that we don't set a value unless it was desired
to be set.
Based on code originally posted by Pavel Hrdina ,
but extracted into a separate
Add a capability check for IOThread polling (all were added at the
same time, so only one check is necessary).
Based on code originally posted by Pavel Hrdina
with the only changes to include the more recent QEMU releases.
Signed-off-by: John Ferlan
ACKed-by: Michal Privoznik
---
On 10/19/18 8:59 AM, Daniel P. Berrangé wrote:
On Fri, Oct 19, 2018 at 08:53:15AM -0600, Jim Fehlig wrote:
On 10/19/18 8:14 AM, Daniel P. Berrangé wrote:
On Fri, Oct 19, 2018 at 08:06:18AM -0600, Jim Fehlig wrote:
On 10/19/18 3:11 AM, Daniel P. Berrangé wrote:
On Thu, Oct 18, 2018 at
On Fri, Oct 19, 2018 at 03:59:03PM +0100, Daniel P. Berrangé wrote:
> On Fri, Oct 19, 2018 at 08:53:15AM -0600, Jim Fehlig wrote:
> > On 10/19/18 8:14 AM, Daniel P. Berrangé wrote:
> > > On Fri, Oct 19, 2018 at 08:06:18AM -0600, Jim Fehlig wrote:
> > > > On 10/19/18 3:11 AM, Daniel P. Berrangé
On 10/19/18 8:14 AM, Daniel P. Berrangé wrote:
On Fri, Oct 19, 2018 at 08:06:18AM -0600, Jim Fehlig wrote:
On 10/19/18 3:11 AM, Daniel P. Berrangé wrote:
On Thu, Oct 18, 2018 at 11:08:34AM -0600, Jim Fehlig wrote:
On 10/17/18 12:59 PM, Marek Marczykowski-Górecki wrote:
On Sat, Oct 13, 2018
On Fri, Oct 19, 2018 at 08:53:15AM -0600, Jim Fehlig wrote:
> On 10/19/18 8:14 AM, Daniel P. Berrangé wrote:
> > On Fri, Oct 19, 2018 at 08:06:18AM -0600, Jim Fehlig wrote:
> > > On 10/19/18 3:11 AM, Daniel P. Berrangé wrote:
> > > > On Thu, Oct 18, 2018 at 11:08:34AM -0600, Jim Fehlig wrote:
> >
On Fri, Oct 19, 2018 at 08:06:18AM -0600, Jim Fehlig wrote:
> On 10/19/18 3:11 AM, Daniel P. Berrangé wrote:
> > On Thu, Oct 18, 2018 at 11:08:34AM -0600, Jim Fehlig wrote:
> > > On 10/17/18 12:59 PM, Marek Marczykowski-Górecki wrote:
> > > > On Sat, Oct 13, 2018 at 08:46:19AM -0600, Jim Fehlig
On 18 October 2018 at 21:03, Eduardo Habkost wrote:
> The following changes since commit 09558375a634e17cea6cfbfec883ac2376d2dc7f:
>
> Merge remote-tracking branch
> 'remotes/pmaydell/tags/pull-target-arm-20181016-1' into staging (2018-10-16
> 17:42:56 +0100)
>
> are available in the Git
On 10/19/18 7:06 AM, Michal Privoznik wrote:
> On 10/07/2018 03:00 PM, John Ferlan wrote:
>> Add functions to set the IOThreadInfo param data for the live guest.
>>
>> Based on code originally posted by Pavel Hrdina ,
>> but extracted into a separate patch. Note that qapi expects to receive
>>
On 10/19/18 3:11 AM, Daniel P. Berrangé wrote:
On Thu, Oct 18, 2018 at 11:08:34AM -0600, Jim Fehlig wrote:
On 10/17/18 12:59 PM, Marek Marczykowski-Górecki wrote:
On Sat, Oct 13, 2018 at 08:46:19AM -0600, Jim Fehlig wrote:
I had some couch time at the start of the weekend and was finally able
[...]
>> if (VIR_ALLOC_N(info_ret, niothreads) < 0)
>> -goto endjob;
>> +goto cleanup;
>>
>> for (i = 0; i < niothreads; i++) {
>> virBitmapPtr map = NULL;
>>
>> if (VIR_ALLOC(info_ret[i]) < 0)
>> -goto endjob;
>> +goto
On 2018-10-18 16:54, Boris Fiuczynski wrote:
> Signed-off-by: Boris Fiuczynski
> ---
> docs/news.xml | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/docs/news.xml b/docs/news.xml
> index dc08c96352..e5476a3332 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -35,6
On Thu, Oct 18, 2018 at 05:12:33PM +0200, Michal Privoznik wrote:
> The virFileInData() function should return to the caller if the
> current position the passed file is in is a data section or a
> hole (and also how long the current section is). At any rate,
> upon return from this function (be
Add details of the algorithm and why it was used to help future
readers understand the issues encountered. Based largely off a
description provided by Erik Skultety .
Signed-off-by: John Ferlan
---
see: https://www.redhat.com/archives/libvir-list/2018-October/msg00915.html
On 2018-10-18 16:54, Boris Fiuczynski wrote:
> Introduce vfio-ap capability.
>
> Signed-off-by: Boris Fiuczynski
> Reviewed-by: Bjoern Walk
> ---
> src/qemu/qemu_capabilities.c | 2 ++
> src/qemu/qemu_capabilities.h | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git
On 2018-10-18 16:54, Boris Fiuczynski wrote:
> Adjusting domain format documentation, adding device address
> support and adding command line generation for vfio-ap.
> Since only one mediated hostdev with model vfio-ap is supported a check
> disallows to define domains with more than one such
On Fri, 2018-10-19 at 10:37 +0100, Daniel P. Berrangé wrote:
> On Thu, Oct 11, 2018 at 11:19:54AM +0200, Pino Toscano wrote:
> > +jobs:
> > + - generic-build-job:
> > + parent_jobs: 'libvirt-build'
> > + command: |
> > +autoreconf -vfi
> > +
On Thu, 2018-10-11 at 11:19 +0200, Pino Toscano wrote:
> Now that the libvirt-ocaml repository is fixed, let's build it in CI.
>
> Pino Toscano (3):
> guests: add mappings for OCaml components
> guests: add libvirt-ocaml project
> projects: add libvirt-ocaml project
Sorry, I kinda forgot
On 10/07/2018 03:00 PM, John Ferlan wrote:
> Separate out the fetch of the IOThread monitor call into a separate
> helper so that a subsequent domain statistics change can fetch the raw
> IOThread data and parse it as it sees fit.
>
> Signed-off-by: John Ferlan
> ---
> src/qemu/qemu_driver.c |
On 10/07/2018 03:00 PM, John Ferlan wrote:
> Process the IOThreads polling stats if available. Generate the
> output params record to be returned to the caller with the three
> values - poll-max-ns, poll-grow, and poll-shrink.
>
> Signed-off-by: John Ferlan
> ---
>
On 10/07/2018 03:00 PM, John Ferlan wrote:
> Add a capability check for IOThread polling (all were added at the
> same time, so only one check is necessary).
>
> Based on code originally posted by Pavel Hrdina
> with the only changes to include the more recent QEMU releases.
>
> Signed-off-by:
On 10/07/2018 03:00 PM, John Ferlan wrote:
> If there are IOThread polling values in the query-iothreads return
> buffer, then fill them in and set a bool indicating their presence.
> This will allow for displaying in a domain stats output eventually.
>
> Note that the QEMU values are managed a
On 10/07/2018 03:00 PM, John Ferlan wrote:
> Add functions to set the IOThreadInfo param data for the live guest.
>
> Based on code originally posted by Pavel Hrdina ,
> but extracted into a separate patch. Note that qapi expects to receive
> integer parameters rather than unsigned long long or
On 10/07/2018 03:00 PM, John Ferlan wrote:
> Rather than passing an iothread_id, let's pass a qemuMonitorIOThreadInfo
> structure so that a subsequent change to modify the iothread info can
> just generate and pass one.
>
> Signed-off-by: John Ferlan
> ---
> src/qemu/qemu_driver.c | 26
On 10/07/2018 03:00 PM, John Ferlan wrote:
> Add an --iothread qualifier to domstats and an explanation in
> the man page. Describe the values in as generic terms as possible
> allowing each hypervisor to provide a specific algorithm to utilize
> the values as it sees fit.
>
> Signed-off-by: John
On 10/07/2018 03:00 PM, John Ferlan wrote:
> Create a new API that will allow an adjustment of IOThread
> polling parameters for the specified IOThread. These parameters
> will not be saved in the guest XML. Currently the only parameters
> supported will allow the hypervisor to adjust the
On Thu, Oct 18, 2018 at 05:12:33PM +0200, Michal Privoznik wrote:
The virFileInData() function should return to the caller if the
current position the passed file is in is a data section or a
hole (and also how long the current section is). At any rate,
upon return from this function (be it
On 10/07/2018 03:00 PM, John Ferlan wrote:
> We're about to add a new state "modify" and thus the function
> goes from just Add/Del. Use an enum to manage.
>
> Extracted from code originally posted by Pavel Hrdina
> , but placed into a separate patch.
>
> Signed-off-by: John Ferlan
> ---
>
On Thu, Oct 18, 2018 at 02:26:38PM +0200, Michal Privoznik wrote:
These are not pushed. I'll wait couple of moments if there is somebody
who has opinion. If not I will push them.
Except the libvirt-snmp internals this looks good. Few nits posted for
particular patches, really just nits.
On Thu, Oct 18, 2018 at 02:26:55PM +0200, Michal Privoznik wrote:
This function returns only a single value. It makes no sense to
have it return that. Make it return void.
Signed-off-by: Michal Privoznik
---
src/libvirtSnmp.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
On Thu, Oct 18, 2018 at 02:26:58PM +0200, Michal Privoznik wrote:
Signed-off-by: Michal Privoznik
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index ce79f12..dd930b7 100644
--- a/.gitignore
+++ b/.gitignore
@@ -16,6 +16,7 @@ ChangeLog
/INSTALL
On Thu, Oct 18, 2018 at 02:26:49PM +0200, Michal Privoznik wrote:
The threads are JOINABLE by default. No need to go through
pthread_attr_* circus to set what is default anyway.
Signed-off-by: Michal Privoznik
---
src/libvirtSnmp.c | 15 ++-
1 file changed, 6 insertions(+), 9
On Thu, Oct 18, 2018 at 05:04:37PM +0200, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1640465
>
> Weirdly enough, there can be symlinks in the path we are trying
> to fix. If it is the case our clever algorithm that finds matches
> against mount table won't work.
On Thu, Oct 11, 2018 at 11:19:54AM +0200, Pino Toscano wrote:
> Not built on Debian 8, as the version of OCaml is not new enough.
>
> Signed-off-by: Pino Toscano
> ---
> jobs/defaults.yaml | 2 ++
> projects/libvirt-ocaml.yaml | 23 +++
> 2 files changed, 25
On Fri, Oct 05, 2018 at 01:48:05PM +0200, Ján Tomko wrote:
> Also do not bother taking C++ style comments into account.
>
> Ján Tomko (2):
> syntax-check: revert indentation checks
> check-spacing: do not kill C++-style comments
>
Reviewed-by: Erik Skultety
--
libvir-list mailing list
On 18.10.2018 18:30, John Ferlan wrote:
>
>
> On 10/17/18 4:16 AM, Nikolay Shirokovskiy wrote:
>>
>>
>> On 16.10.2018 15:48, John Ferlan wrote:
>>>
>>>
>>> On 10/8/18 7:21 AM, Nikolay Shirokovskiy wrote:
Let's introduce shutdown reason "daemon" which means we have to
kill running
On Thu, Oct 18, 2018 at 03:20:43PM -0400, Laine Stump wrote:
> Laine Stump (3):
> reduce required libvirt version in rpm spec
> fix selinux/100-static-relabel-no test
> double timeout on nwfilter 060-concurrency test
>
> perl-Sys-Virt-TCK.spec.PL | 2 +-
>
On Thu, Oct 18, 2018 at 11:08:34AM -0600, Jim Fehlig wrote:
> On 10/17/18 12:59 PM, Marek Marczykowski-Górecki wrote:
> > On Sat, Oct 13, 2018 at 08:46:19AM -0600, Jim Fehlig wrote:
> > > I had some couch time at the start of the weekend and was finally able to
> > > try using this series with
On Fri, Oct 05, 2018 at 01:48:06PM +0200, Ján Tomko wrote:
> Recent patches added indentation checks that discovered some cosmetic
> issues at the cost of making this check last as long as the rest of
> syntax-check combined on my system. Also, they're moving closer
> to us implementing yet
On Thu, Oct 11, 2018 at 11:19:54AM +0200, Pino Toscano wrote:
> Not built on Debian 8, as the version of OCaml is not new enough.
>
> Signed-off-by: Pino Toscano
> ---
> jobs/defaults.yaml | 2 ++
> projects/libvirt-ocaml.yaml | 23 +++
> 2 files changed, 25
On 10/18/2018 10:42 PM, Eric Blake wrote:
> On 10/18/18 3:08 PM, Eric Blake wrote:
>> virXMLFormatElement() frees attrBuf on success, but not necessarily
>> on failure. Most other callers of this function take the time to
>> reset attrBuf afterwords, but qemuDomainObjPrivateXMLFOrmatBlockjobs()
>>
在 2018/10/19 下午3:54, Andrea Bolognani 写道:
On Fri, 2018-10-19 at 11:29 +0800, Yi Min Zhao wrote:
在 2018/10/18 下午11:44, Andrea Bolognani 写道:
There's still the question of whether Dan is now okay with the XML
structure as currently implemented; assuming that's the case, it
would be great if
On Fri, 2018-10-19 at 11:29 +0800, Yi Min Zhao wrote:
> 在 2018/10/18 下午11:44, Andrea Bolognani 写道:
> > There's still the question of whether Dan is now okay with the XML
> > structure as currently implemented; assuming that's the case, it
> > would be great if Laine could also take a quick look at
On Fri, Oct 19, 2018 at 10:05:21AM +0800, owen...@ucloud.cn wrote:
> Thanks for your detailed explanation, Maybe i can set udev_monitor to
> nonblocking on centos6.
>
Yeah, you should be able to use fcntl and set the O_NONBLOCK flag on the
socket, but that would be a custom downstream patch
On Thu, Oct 18, 2018 at 12:04:55PM -0400, John Ferlan wrote:
> [...]
>
> >>
> >> The one thing I have forgotten or perhaps I should say struck me -
> >> should this code use virCondWaitUntil or would it just not matter?
> >>
> >> Let's say 10 devices were added and on the 10th one we had this
68 matches
Mail list logo
