Re: [libvirt] [PATCH] news: Update for 5.6.0 release

2019-08-02 Thread Daniel Veillard
Sounds a good idea to put updates before Monday :-) tentative ACK Daniel On Fri, Aug 02, 2019 at 07:42:41PM +0200, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > docs/news.xml | 74 +++ > 1 file changed, 74 insertions(+) >

[libvirt] [PATCH] news: Update for 5.6.0 release

2019-08-02 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- docs/news.xml | 74 +++ 1 file changed, 74 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 9483172335..dbc72c7c66 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -85,6 +85,29 @@ option

[libvirt] Availability of libvirt 5.6.0 Release Candidate 2

2019-08-02 Thread Daniel Veillard
One day late, I blame jetlag, but the Release Candiate 2 is out, tagged in git and with signed source tarball and rpm at the usual place: https://libvirt.org/sources/ Seems okay in my very limited tests here, and Jenkins is all green :-) Please give is some testing, I will cut the GA on

Re: [libvirt] [PATCH v1 23/31] qemu_domain: Introduce NVMe path getting helpers

2019-08-02 Thread Michal Privoznik
On 7/16/19 4:30 PM, Peter Krempa wrote: On Thu, Jul 11, 2019 at 17:54:10 +0200, Michal Privoznik wrote: Couple of places in the QEMU driver will want to know what paths are associated with NVMe disks (for instance CGroup code or namespaces code). Introduce helpers which return desired paths (for

Re: [libvirt] [PATCH v1 24/31] qemu: Create NVMe disk in domain namespace

2019-08-02 Thread Michal Privoznik
On 7/16/19 4:37 PM, Peter Krempa wrote: On Thu, Jul 11, 2019 at 17:54:11 +0200, Michal Privoznik wrote: If a domain has an NVMe disk configured, then we need to create /dev/vfio/* paths in domain's namespace so that qemu can open them. Signed-off-by: Michal Privoznik --- src/qemu/qemu_domain

Re: [libvirt] [PATCH v1 29/31] qemu: Generate command line of NVMe disks

2019-08-02 Thread Michal Privoznik
On 7/16/19 5:35 PM, Peter Krempa wrote: On Thu, Jul 11, 2019 at 17:54:16 +0200, Michal Privoznik wrote: Now, that we have everything prepared, we can generate command line for NVMe disks. Signed-off-by: Michal Privoznik --- src/qemu/qemu_block.c | 25 - src/q

Re: [libvirt] [PATCH v1 12/31] util: Introduce virNVMeDevice module

2019-08-02 Thread Michal Privoznik
On 7/16/19 3:54 PM, Peter Krempa wrote: On Thu, Jul 11, 2019 at 17:53:59 +0200, Michal Privoznik wrote: This module will be used by virHostdevManager and it's inspired by virPCIDevice module. They are very similar except instead of what makes a NVMe device: PCI address AND namespace ID. This mea

Re: [libvirt] [PATCH 4/4] test_driver: implement virDomainFSTrim

2019-08-02 Thread Erik Skultety
On Tue, Jul 09, 2019 at 09:23:24PM +0200, Ilias Stamatis wrote: > Signed-off-by: Ilias Stamatis > --- Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 3/4] test_driver: implement virDomainFSThaw

2019-08-02 Thread Erik Skultety
On Tue, Jul 09, 2019 at 09:23:23PM +0200, Ilias Stamatis wrote: > Signed-off-by: Ilias Stamatis > --- > src/test/test_driver.c | 66 ++ > 1 file changed, 66 insertions(+) > > diff --git a/src/test/test_driver.c b/src/test/test_driver.c > index 8c25c679a5..0

Re: [libvirt] [PATCH 2/4] test_driver: implement virDomainFSFreeze

2019-08-02 Thread Erik Skultety
On Tue, Jul 09, 2019 at 09:23:22PM +0200, Ilias Stamatis wrote: > On success update the domain-private data. Consider / and /boot to be > the only mountpoints avaiable in order to be consistent with the other > FS-related calls. > > Signed-off-by: Ilias Stamatis > --- > src/test/test_driver.c | 5

Re: [libvirt] [PATCH] tests: Fix virsh-snapshot/checkpoint without libreadline-devel

2019-08-02 Thread Daniel Henrique Barboza
Tested this patch in a Power 8 host that doesn't have readline-devel installed. Both tests passed, all tests are green with make check. Tested-by: Daniel Henrique Barboza Thanks, DHB On 8/2/19 10:27 AM, Eric Blake wrote: libreadline-devel is an optional build dependency; when it is not

Re: [libvirt] [PATCH] qemu: support bootindex on vfio-ccw mdev device

2019-08-02 Thread Peter Krempa
On Fri, Aug 02, 2019 at 15:15:59 +0200, Boris Fiuczynski wrote: > Add support to specify a boot order on vfio-ccw passthrough devices. > > Signed-off-by: Boris Fiuczynski > Acked-by: Jason J. Herne > Reviewed-by: Marc Hartmayer > --- > src/qemu/qemu_command.c | 27 +++

Re: [libvirt] [PATCH 1/1] tests/virsh-checkpoint/snapshot: changing 'sed' out filtering

2019-08-02 Thread Eric Blake
On 8/1/19 3:36 PM, Daniel Henrique Barboza wrote: > > > On 8/1/19 11:24 AM, Daniel Henrique Barboza wrote: >> >> [...] >> So yeah. I am not sure what's different from the environments I use >> versus >> the one you're using (and probably the env of every other committer here, >> otherwise this te

[libvirt] [PATCH] tests: Fix virsh-snapshot/checkpoint without libreadline-devel

2019-08-02 Thread Eric Blake
libreadline-devel is an optional build dependency; when it is not present, the output of 'virsh < Signed-off-by: Eric Blake --- I'm tempted to push this as a fix to a build-breaker, but as I did not actually build without libreadline-devel, I'd appreciate an ACK from Daniel that this fixes the pr

[libvirt] [PATCH] qemu: support bootindex on vfio-ccw mdev device

2019-08-02 Thread Boris Fiuczynski
Add support to specify a boot order on vfio-ccw passthrough devices. Signed-off-by: Boris Fiuczynski Acked-by: Jason J. Herne Reviewed-by: Marc Hartmayer --- src/qemu/qemu_command.c | 27 + .../hostdev-subsys-mdev-vfio-ccw-boot.args| 29 +++

Re: [libvirt] [PATCH] RFC: security: Make sure to decrease ref count label value

2019-08-02 Thread Michal Privoznik
On 8/1/19 7:45 PM, Stefan Berger wrote: On 7/29/19 5:17 AM, Michal Privoznik wrote: On 7/26/19 8:38 PM, Stefan Berger wrote: I noticed that if a domain fails to restore, the ref count in the xattr 'trusted.libvirt.security.ref_selinux' keeps on increasing indefinitely and the VM will never rest

[libvirt] [PATCH] docs: formatdomain: explain host-model/host-passthrough requirements

2019-08-02 Thread Paolo Bonzini
host-passthrough documentation menions that the source and destination hosts are not identical in both hardware and configuration. Configuration actually includes microcode version and QEMU version, but this is not clear so make it explicit Signed-off-by: Paolo Bonzini --- docs/formatdomain.htm

Re: [libvirt] [PATCH 1/4] test_driver: introduce domain-private data

2019-08-02 Thread Ilias Stamatis
On Fri, Aug 2, 2019 at 1:23 PM Erik Skultety wrote: > > On Tue, Jul 09, 2019 at 09:23:21PM +0200, Ilias Stamatis wrote: > > --- > > Explaining that the private data will come handy to hold the information > whether filesystems have been frozen would be nice. Sure, just maybe let's not make it FS-

Re: [libvirt] [PATCH 1/4] test_driver: introduce domain-private data

2019-08-02 Thread Erik Skultety
On Tue, Jul 09, 2019 at 09:23:21PM +0200, Ilias Stamatis wrote: > --- Explaining that the private data will come handy to hold the information whether filesystems have been frozen would be nice. Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com

Re: [libvirt] [PATCH v3 0/2] test_driver: implement virDomainMemoryStats

2019-08-02 Thread Erik Skultety
On Fri, Aug 02, 2019 at 01:13:29PM +0200, Ilias Stamatis wrote: > Ilias Stamatis (2): > test_driver: add a memballoon device in the default config > test_driver: implement virDomainMemoryStats Reviewed-by: Erik Skultety -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com

Re: [libvirt] [PATCH v3 2/2] test_driver: implement virDomainMemoryStats

2019-08-02 Thread Erik Skultety
On Fri, Aug 02, 2019 at 01:13:31PM +0200, Ilias Stamatis wrote: > Signed-off-by: Ilias Stamatis > Reviewed-by: Erik Skultety > --- Actually, maybe a tiny commit message that explains the dependency of the values on cur_memory may be in fact helpful, I'll take care of that before merging. Erik

[libvirt] [PATCH v3 2/2] test_driver: implement virDomainMemoryStats

2019-08-02 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis Reviewed-by: Erik Skultety --- src/test/test_driver.c | 54 ++ 1 file changed, 54 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 83e2c0289f..2fbaf1c4ee 100755 --- a/src/test/test_driver.c +++

[libvirt] [PATCH v3 1/2] test_driver: add a memballoon device in the default config

2019-08-02 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index aae9875194..83e2c0289f 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -450,6 +450,9 @@ static const char *defa

[libvirt] [PATCH v3 0/2] test_driver: implement virDomainMemoryStats

2019-08-02 Thread Ilias Stamatis
Ilias Stamatis (2): test_driver: add a memballoon device in the default config test_driver: implement virDomainMemoryStats src/test/test_driver.c | 57 ++ 1 file changed, 57 insertions(+) -- 2.22.0 -- libvir-list mailing list libvir-list@redhat.com ht

Re: [libvirt] [PATCH v2] test_driver: implement virDomainMemoryStats

2019-08-02 Thread Erik Skultety
On Fri, Aug 02, 2019 at 12:07:19AM +0200, Ilias Stamatis wrote: > Signed-off-by: Ilias Stamatis > --- > src/test/test_driver.c | 54 ++ > 1 file changed, 54 insertions(+) > > diff --git a/src/test/test_driver.c b/src/test/test_driver.c > index aae9875194..0

[libvirt] [PATCH] test_driver: implement virDomainSetLifecycleAction

2019-08-02 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 58 ++ 1 file changed, 58 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index aae9875194..71d6baa3da 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@

[libvirt] [PATCH] vircgroup: fix partition creation for cgroups v2 without systemd

2019-08-02 Thread Pavel Hrdina
On hosts without systemd libvirt is responsible for creating cgroups topology. With cgroups v2 the logic changed a bit. If we need to create new directory the detection of controllers fails because the directory doesn't exists so there is no cgroup.controllers file. To fix that issue we need to h