Re: GSoC'20 Interested Student: Adding support to Jailhouse Hypervisor

Hi All, Gentle Reminder, Please have a look at my email below. It would be great if anyone can help me with this project. Thanks & Regards, Prakhar Bansal Graduate Student' 20, Computer Engineering Iowa State University, Ames, IA On Tue, Mar 24, 2020 at 11:36 PM PRAKHAR BANSAL wrote: > Hi

[PATCH] rng: Interleave elements in source

Signed-off-by: Han Han --- docs/schemas/domaincommon.rng | 350 ++ 1 file changed, 186 insertions(+), 164 deletions(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index d79dee65..96eccaad 100644 --- a/docs/schemas/domaincommon.rng

Re: [PATCH] docs: fix typo in domcaps host-model CPU description

On 3/24/20 3:44 AM, Jiri Denemark wrote: The situation on the first machine is a bit strange as there are no features disabled in host-model CPU definition, which makes it unclear why QEMU reports Cascadelake-Server as unusable (QEMU reports the reason, but we don't do so yet). I got back to

[jenkins-ci PATCH] guests: enable ccache on CentOS installs

Since we enabled use of EPEL in our CentOS installs, we should pull in the ccache package to speed up builds. Signed-off-by: Daniel P. Berrangé --- guests/vars/mappings.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index

Re: [PATCH 8/9] qemu: Make memory path generation embed driver aware

On Wed, 2020-03-25 at 11:18 +0100, Michal Privoznik wrote: [...] > void > -qemuGetMemoryBackingBasePath(virQEMUDriverConfigPtr cfg, > +qemuGetMemoryBackingBasePath(virQEMUDriverPtr driver, > char **path) > { > -*path = g_strdup_printf("%s/libvirt/qemu",

Re: [PATCH 6/9] Revert "qemu_conf: Track embed root dir"

On Wed, 2020-03-25 at 11:18 +0100, Michal Privoznik wrote: > This reverts commit 06a19921b6a522cd7b4d352c9320909752947de3. > > What I haven't realized when writing this ^^ commit is that the > virQEMUDriver structure already stores the root directory path. > And since the pointer is immutable it

Re: [PATCH 5/9] qemuDomainGetMachineName: Access embeddedRoot from driver rather than cfg

On Wed, 2020-03-25 at 11:18 +0100, Michal Privoznik wrote: > The cfg->root is going away, therefore get the info right from > the driver structure. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_domain.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Andrea

Re: [PATCH 4/9] qemu: Introduce virQEMUDriverGetEmbedRoot

On Wed, 2020-03-25 at 11:18 +0100, Michal Privoznik wrote: > This function returns embeddedRoot member of the driver > structure. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_conf.c | 12 > src/qemu/qemu_conf.h | 1 + > 2 files changed, 13 insertions(+) Reviewed-by:

Re: [PATCH 3/9] virDomainDriverGenerateMachineName: Factor out embed path hashing

On Wed, 2020-03-25 at 11:18 +0100, Michal Privoznik wrote: > The code that generates "qemu-embed-$hash" is going to be useful > in more places. Separate it out into a function. > > Signed-off-by: Michal Privoznik > --- > src/hypervisor/domain_driver.c | 42 ++ >

Re: [PATCH 2/9] conf: Move virDomainGenerateMachineName to hypervisor/

On Wed, 2020-03-25 at 11:18 +0100, Michal Privoznik wrote: > The virDomainGenerateMachineName() function doesn't belong in > src/conf/ really, because it has nothing to do with domain XML > parsing. It landed there because of lack of better place in the > past. But now that we have src/hypervisor/

Re: [PATCH 1/9] tests: Fix virQEMUDriverConfigNew() calling with respect to @root

On Wed, 2020-03-25 at 11:18 +0100, Michal Privoznik wrote: > The virQEMUDriverConfigNew() accepts path to root directory for > embed mode as an argument. If the argument is not NULL it uses > the passed value as prefix for some internal paths (e.g. > cfg->libDir). If it is NULL though, it looks if

Re: [PATCH 1/2] gobject: Fix typo in documentation of gvir_domain_save_to_file_async

On Wed, Mar 25, 2020 at 5:08 PM Fabiano Fidêncio wrote: > > On Wed, Mar 25, 2020 at 4:51 PM Felipe Borges wrote: > > > > Signed-off-by: Felipe Borges > > --- > > libvirt-gobject/libvirt-gobject-domain.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

Re: [PATCH 0/9] Another round of qemu:///embed fixes

On 3/25/20 7:18 AM, Michal Privoznik wrote: After my first round of patches got merged [1], some new problems arose. They are not as serious (except maybe for 7/9) but they are still problematic for sure. Mostly in scenarios where a mgmt application uses the embedded driver and has multiple

Re: [PATCH] qemu: capabilities: update qemu-4.2 capabilities for s390x

On 25.03.20 08:06, Bjoern Walk wrote: > Update s390x capabilities for QEMU 4.2 with the actual GA version for > QEMU and on the latest z15 machine. Maybe add: As these files were generated on a z15 and the previous data was taken on a z13 this now indicates, z15 (gen15a) AND z14 to be

Re: [PATCH 1/2] gobject: Fix typo in documentation of gvir_domain_save_to_file_async

On Wed, Mar 25, 2020 at 4:51 PM Felipe Borges wrote: > > Signed-off-by: Felipe Borges > --- > libvirt-gobject/libvirt-gobject-domain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libvirt-gobject/libvirt-gobject-domain.c > b/libvirt-gobject/libvirt-gobject-domain.c

[PATCH 1/2] qemuxml2xmltest: Wire up 'disk-network-http' case

Signed-off-by: Peter Krempa --- .../disk-network-http.x86_64-latest.xml | 71 +++ tests/qemuxml2xmltest.c | 2 + 2 files changed, 73 insertions(+) create mode 100644 tests/qemuxml2xmloutdata/disk-network-http.x86_64-latest.xml diff --git

[PATCH 2/2] virStorageSourceNetCookieValidate: Accept quoted cookie value

The quotes are forbidden only inside the value, but the value itself may be enclosed in quotes. Fix the RNG schema and validator and add a test case. https://bugzilla.redhat.com/show_bug.cgi?id=1804750 Signed-off-by: Peter Krempa --- docs/schemas/domaincommon.rng | 2 +-

[PATCH 0/2] Accept http cookies with quoted value

The validator didn't accept the quoted version of the cookie value. Add a test and fix the issue. Peter Krempa (2): qemuxml2xmltest: Wire up 'disk-network-http' case virStorageSourceNetCookieValidate: Accept quoted cookie value docs/schemas/domaincommon.rng | 2 +-

[PATCH 1/2] gobject: Fix typo in documentation of gvir_domain_save_to_file_async

Signed-off-by: Felipe Borges --- libvirt-gobject/libvirt-gobject-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-gobject/libvirt-gobject-domain.c b/libvirt-gobject/libvirt-gobject-domain.c index 399b118..0a16cb4 100644 ---

[PATCH 2/2] GVirDomain: Add GVIR_DOMAIN_DELETE_{REMOVE,KEEP}_NVRAM

These are mapped respectively to VIR_DOMAIN_UNDEFINE_NVRAM and VIR_DOMAIN_UNDEFINE_KEEP_NVRAM. Fixes issues such as https://bugzilla.redhat.com/1817031 Signed-off-by: Felipe Borges --- libvirt-gobject/libvirt-gobject-domain.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH 1/1] qemu_domain.c: remove unneeded size check in NVDIMM alignment

Commit 5540acb9a2b added a minimum size verification for the target size of ppc64 NVDIMMs but forgot to remove a MAX() size check that was being used in earlier reviews of that commit. The size verification makes this check unneeded since we're making sure that guestArea will always be at least

Re: [GSoC] Interested Student for the Project: 'Introducing job control to the storage driver'

On 23. 3. 2020 10:45, Prathamesh Chavan wrote: > Hi Everyone, Hey! It's nice to see somebody new interested in libvirt. > > I'm Prathamesh Chavan, a final year student at studying Computer > Science and Engineering at IIT Kharagpur. I've been part of GSoC'17 > under the Git Organization and

Re: [PATCH v2 4/4] qemu: allow PMU feature to be enabled for ppc64 guests

On Tue, 2020-03-24 at 14:33 -0300, Daniel Henrique Barboza wrote: > The PMU feature is enabled by default in ppc64 guests and can't > be disabled via Libvirt or QEMU [1]. The current PMU feature > implementation does not allow PMU to enabled or disabled in the > ppc64 guest. Declaring the PMU

Re: [PATCH v2 3/4] qemu: make Hyperv settings exclusive to x86 and aarch64

On Tue, 2020-03-24 at 14:33 -0300, Daniel Henrique Barboza wrote: > Hyperv features are supported by both x86 and aarch64. The > declaration in the XML by itself is benign to other architectures, > but any of its 14 current features will break QEMU with an error > like this (from ppc64): > >

Re: [PATCH v2 2/4] qemu: avoid launching non-x86 guests with 'pvspinlock' setting

On Tue, 2020-03-24 at 14:33 -0300, Daniel Henrique Barboza wrote: > The 'pvspinlock' feature is x86 only. The "" declaration > will always have a value 'on' or 'off', and both will break QEMU when > launching non-x86 guests. This is the error message for > "" when running a ppc64 guest: > >

Re: [PATCH v2 1/4] qemu: avoid launching non-x86 guests with APIC-EOI setting

On Tue, 2020-03-24 at 14:33 -0300, Daniel Henrique Barboza wrote: [...] > Suggested-by: Andrea Bolognani Merely providing review feedback is not usually considered enough to get Suggested-by credits, so I'll drop this. > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1236440 The consensus

Re: [libvirt PATCH v2 6/9] gitlab: add x86_64 native CI jobs

On Wed, 2020-03-25 at 12:19 +, Daniel P. Berrangé wrote: > On Wed, Mar 25, 2020 at 12:27:33PM +0100, Andrea Bolognani wrote: > > This kind of testing will still be limited by the fact that merge > > requests will not be able to use these dedicated runners. Compare > > this to something like

Re: [libvirt PATCH v2 6/9] gitlab: add x86_64 native CI jobs

On Wed, Mar 25, 2020 at 12:27:33PM +0100, Andrea Bolognani wrote: > On Wed, 2020-03-25 at 10:44 +, Daniel P. Berrangé wrote: > > On Wed, Mar 25, 2020 at 11:27:31AM +0100, Andrea Bolognani wrote: > > > On Wed, 2020-03-25 at 09:35 +0100, Erik Skultety wrote: > > > > Related to the availability

Re: [PATCH 12/12] qemuDomainGetGuestInfo: Suppress non-fatal errors

On a Monday in 2020, Peter Krempa wrote: Don't report cases when the guest information is not requested explicitly and not present either. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 45 +++--- 1 file changed, 20 insertions(+), 25 deletions(-)

Re: [PATCH 11/12] qemuAgentGetFSInfo: expose 'report_unsupported' argument

On a Monday in 2020, Peter Krempa wrote: Use qemuAgentCommandFull so that callers of qemuAgentGetFSInfo can suppress error reports if the function is not supported by the guest agent. Since this patch removes the last use of qemuAgentErrorCommandUnsupported the whole function is deleted as

Re: [PATCH 09/12] qemuAgentGetOSInfo: expose 'report_unsupported' argument

On a Monday in 2020, Peter Krempa wrote: Use qemuAgentCommandFull so that callers of qemuAgentGetOSInfo can suppress error reports if the function is not supported by the guest agent. Signed-off-by: Peter Krempa --- src/qemu/qemu_agent.c | 17 + src/qemu/qemu_agent.h | 3 ++-

Re: [PATCH 10/12] qemuAgentGetTimezone: expose 'report_unsupported' argument

On a Monday in 2020, Peter Krempa wrote: Use qemuAgentCommandFull so that callers of qemuAgentGetTimezone can suppress error reports if the function is not supported by the guest agent. Signed-off-by: Peter Krempa --- src/qemu/qemu_agent.c | 17 + src/qemu/qemu_agent.h | 3

Re: [PATCH 08/12] qemuAgentGetUsers: expose 'report_unsupported' argument

On a Monday in 2020, Peter Krempa wrote: Use qemuAgentCommandFull so that callers of qemuAgentGetUsers can suppress error reports if the function is not supported by the guest agent. Signed-off-by: Peter Krempa --- src/qemu/qemu_agent.c | 17 + src/qemu/qemu_agent.h | 3 ++-

Re: [PATCH 07/12] qemuAgentGetHostname: expose 'report_unsupported' argument

On a Monday in 2020, Peter Krempa wrote: Use qemuAgentCommandFull in qemuAgentGetHostname so that we can suppress error reports if the caller will not require them. Callers for now always require error reporting but will be fixed later. Signed-off-by: Peter Krempa --- src/qemu/qemu_agent.c |

Re: [libvirt PATCH v2 6/9] gitlab: add x86_64 native CI jobs

On Wed, Mar 25, 2020 at 12:27:33PM +0100, Andrea Bolognani wrote: > On Wed, 2020-03-25 at 10:44 +, Daniel P. Berrangé wrote: > > On Wed, Mar 25, 2020 at 11:27:31AM +0100, Andrea Bolognani wrote: > > Also, even with merge request testing, we'll still want to test everything > > post-merge, as

Re: [libvirt PATCH v2 6/9] gitlab: add x86_64 native CI jobs

On Wed, 2020-03-25 at 11:30 +, Daniel P. Berrangé wrote: > On Wed, Mar 25, 2020 at 12:18:00PM +0100, Andrea Bolognani wrote: > > On Wed, 2020-03-25 at 10:54 +, Daniel P. Berrangé wrote: > > > By default jobs in a stage get given a dependency > > > > > > "needs: [ jobs from prev

Re: [libvirt PATCH v2 6/9] gitlab: add x86_64 native CI jobs

On Wed, Mar 25, 2020 at 12:27:33PM +0100, Andrea Bolognani wrote: > On Wed, 2020-03-25 at 10:44 +, Daniel P. Berrangé wrote: > > On Wed, Mar 25, 2020 at 11:27:31AM +0100, Andrea Bolognani wrote: > > > On Wed, 2020-03-25 at 09:35 +0100, Erik Skultety wrote: > > > > Related to the availability

Re: [libvirt PATCH v2 6/9] gitlab: add x86_64 native CI jobs

On Wed, Mar 25, 2020 at 12:18:00PM +0100, Andrea Bolognani wrote: > On Wed, 2020-03-25 at 10:54 +, Daniel P. Berrangé wrote: > > On Wed, Mar 25, 2020 at 11:48:35AM +0100, Andrea Bolognani wrote: > > > Given the intentions, I think the current split can be improved > > > further: having

Re: [libvirt PATCH v2 6/9] gitlab: add x86_64 native CI jobs

On Wed, 2020-03-25 at 10:44 +, Daniel P. Berrangé wrote: > On Wed, Mar 25, 2020 at 11:27:31AM +0100, Andrea Bolognani wrote: > > On Wed, 2020-03-25 at 09:35 +0100, Erik Skultety wrote: > > > Related to the availability of shared runners, for > > > merge_requests/post_merge > > > builds only,

Re: [libvirt PATCH v2 6/9] gitlab: add x86_64 native CI jobs

On Wed, 2020-03-25 at 10:54 +, Daniel P. Berrangé wrote: > On Wed, Mar 25, 2020 at 11:48:35AM +0100, Andrea Bolognani wrote: > > Given the intentions, I think the current split can be improved > > further: having cross_build as a separate stage from native_build > > means that the former has

Re: [libvirt PATCH v2 6/9] gitlab: add x86_64 native CI jobs

On Wed, Mar 25, 2020 at 11:48:35AM +0100, Andrea Bolognani wrote: > On Tue, 2020-03-24 at 18:21 +, Daniel P. Berrangé wrote: > > On Tue, Mar 24, 2020 at 06:47:01PM +0100, Andrea Bolognani wrote: > > > I don't get the rationale behind the split. > > > > > > Right now we're not using merge

Re: [libvirt PATCH v2 9/9] gitlab: add job for building latest potfile

On Tue, 2020-03-24 at 18:23 +, Daniel P. Berrangé wrote: > On Tue, Mar 24, 2020 at 06:51:10PM +0100, Andrea Bolognani wrote: > > On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote: > > > +# This artifact published by this job is downloaded to push to Weblate > > > +# for translation

Re: [libvirt PATCH v2 6/9] gitlab: add x86_64 native CI jobs

On Tue, 2020-03-24 at 18:21 +, Daniel P. Berrangé wrote: > On Tue, Mar 24, 2020 at 06:47:01PM +0100, Andrea Bolognani wrote: > > I don't get the rationale behind the split. > > > > Right now we're not using merge requests, but we're limiting the > > number of jobs for the merge request case;

Re: [libvirt PATCH v2 6/9] gitlab: add x86_64 native CI jobs

On Wed, Mar 25, 2020 at 11:27:31AM +0100, Andrea Bolognani wrote: > On Wed, 2020-03-25 at 09:35 +0100, Erik Skultety wrote: > > On Tue, Mar 24, 2020 at 06:21:24PM +, Daniel P. Berrangé wrote: > > > On Tue, Mar 24, 2020 at 06:47:01PM +0100, Andrea Bolognani wrote: > > > > * pick a selection

Re: [libvirt PATCH v2 6/9] gitlab: add x86_64 native CI jobs

On Wed, 2020-03-25 at 09:35 +0100, Erik Skultety wrote: > On Tue, Mar 24, 2020 at 06:21:24PM +, Daniel P. Berrangé wrote: > > On Tue, Mar 24, 2020 at 06:47:01PM +0100, Andrea Bolognani wrote: > > > * pick a selection of jobs that includes both native and cross > > > build, across various

[PATCH 6/9] Revert "qemu_conf: Track embed root dir"

This reverts commit 06a19921b6a522cd7b4d352c9320909752947de3. What I haven't realized when writing this ^^ commit is that the virQEMUDriver structure already stores the root directory path. And since the pointer is immutable it can be accessed right from the structure and thus there is no need to

[PATCH 4/9] qemu: Introduce virQEMUDriverGetEmbedRoot

This function returns embeddedRoot member of the driver structure. Signed-off-by: Michal Privoznik --- src/qemu/qemu_conf.c | 12 src/qemu/qemu_conf.h | 1 + 2 files changed, 13 insertions(+) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 15837cece4..fb7c5a1a8a

[PATCH 8/9] qemu: Make memory path generation embed driver aware

So far, libvirt generates the following path for memory: $memoryBackingDir/libvirt/qemu/$id-$shortName/ram-nodeN where $memoryBackingDir is the path where QEMU mmaps() memory for the guest (e.g. /var/lib/libvirt/qemu/ram), $id is domain ID and $shortName is shortened version of domain name. So

[PATCH 9/9] qemu: Make auto dump path generation embed driver aware

So far, libvirt generates the following path for automatic dumps: $autoDumpPath/$id-$shortName-$timestamp where $autoDumpPath is where libvirt stores dumps of guests (e.g. /var/lib/libvirt/qemu/dump), $id is domain ID and $shortName is shortened version of domain name. So for instance, the

[PATCH 2/9] conf: Move virDomainGenerateMachineName to hypervisor/

The virDomainGenerateMachineName() function doesn't belong in src/conf/ really, because it has nothing to do with domain XML parsing. It landed there because of lack of better place in the past. But now that we have src/hypervisor/ the function should live there. At the same time, the function

[PATCH 7/9] qemu: Make hugepages path generation embed driver aware

So far, libvirt generates the following path for hugepages: $mnt/libvirt/qemu/$id-$shortName where $mnt is the mount point of hugetlbfs corresponding to hugepages of desired size (e.g. /dev/hugepages), $id is domain ID and $shortName is shortened version of domain name. So for instance, the

[PATCH 5/9] qemuDomainGetMachineName: Access embeddedRoot from driver rather than cfg

The cfg->root is going away, therefore get the info right from the driver structure. Signed-off-by: Michal Privoznik --- src/qemu/qemu_domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index b921126e1c..e0a2f3c695

[PATCH 3/9] virDomainDriverGenerateMachineName: Factor out embed path hashing

The code that generates "qemu-embed-$hash" is going to be useful in more places. Separate it out into a function. Signed-off-by: Michal Privoznik --- src/hypervisor/domain_driver.c | 42 ++ src/hypervisor/domain_driver.h | 4 src/libvirt_private.syms

[PATCH 0/9] Another round of qemu:///embed fixes

After my first round of patches got merged [1], some new problems arose. They are not as serious (except maybe for 7/9) but they are still problematic for sure. Mostly in scenarios where a mgmt application uses the embedded driver and has multiple forks/instances sharing essentially the same

[PATCH 1/9] tests: Fix virQEMUDriverConfigNew() calling with respect to @root

The virQEMUDriverConfigNew() accepts path to root directory for embed mode as an argument. If the argument is not NULL it uses the passed value as prefix for some internal paths (e.g. cfg->libDir). If it is NULL though, it looks if the other argument, @privileged is true or false and generates

Re: [libvirt PATCH v2 9/9] gitlab: add job for building latest potfile

On Tue, Mar 24, 2020 at 04:24:05PM +, Daniel P. Berrangé wrote: > Whenever there is a change to the translatable strings we need to push > a new libvirt.pot to weblate. This only needs to be done when code > merges into git master, so the job is restricted to that branch. > > Signed-off-by:

Re: [libvirt PATCH v2 9/9] gitlab: add job for building latest potfile

On Tue, Mar 24, 2020 at 06:23:19PM +, Daniel P. Berrangé wrote: > On Tue, Mar 24, 2020 at 06:51:10PM +0100, Andrea Bolognani wrote: > > On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote: > > > +# This artifact published by this job is downloaded to push to Weblate > > > +# for

Re: [libvirt PATCH v2 8/9] gitlab: restrict git history to 100 commits

On Tue, Mar 24, 2020 at 06:48:52PM +0100, Andrea Bolognani wrote: > On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote: > > We don't need the full git history when running CI jobs. From a code POV > > we only need the most recent commit, but we want to be able to run > > checks on the

Re: [PATCH 0/7] Move video default logic to individual drivers

On 24. 3. 2020 17:14, Rafael Fonseca wrote: > The logic setting a device default should be in the post parse function > of individual driver code, not in `src/conf/domain_conf.c`. > > Rafael Fonseca (7): > bhyve: move video default logic to driver > libxl: move video default logic to driver >

Re: [libvirt PATCH v2 7/9] gitlab: add variable for make command name

On Tue, Mar 24, 2020 at 06:47:50PM +0100, Andrea Bolognani wrote: > On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote: > > To facilitate future jobs that will use FreeBSD > > > > Signed-off-by: Daniel P. Berrangé > > --- > > .gitlab-ci.yml | 13 - > > 1 file changed, 8

Re: [libvirt PATCH v2 6/9] gitlab: add x86_64 native CI jobs

On Tue, Mar 24, 2020 at 06:21:24PM +, Daniel P. Berrangé wrote: > On Tue, Mar 24, 2020 at 06:47:01PM +0100, Andrea Bolognani wrote: > > On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote: > > > To control the total CI execution time, we split the native jobs into > > > two distinct

Re: [libvirt PATCH v2 6/9] gitlab: add x86_64 native CI jobs

On Tue, Mar 24, 2020 at 04:24:02PM +, Daniel P. Berrangé wrote: > This patch adds x86_64 native CI jobs for all distros that we currently > build container images for. This is a superset of the Linux jobs run on > current Jenkins and Travis platforms. > > The remaining missing platforms are

Re: [libvirt PATCH v2 5/9] gitlab: add mingw cross build CI jobs

On Tue, Mar 24, 2020 at 04:24:01PM +, Daniel P. Berrangé wrote: > This pulls in the mingw cross build jobs using Fedora 30 as a base, > matching what is done on Jenkins and Travis. > > Signed-off-by: Daniel P. Berrangé > --- Reviewed-by: Erik Skultety

Re: [libvirt PATCH] util: keep the pidfile locked

On 25. 3. 2020 0:58, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Unfortunately, advisory record locking lose the lock if any fd refering > to the file is closed. There doesn't seem to be a way to preserve the > lock atomically. We could eventually retake the lock if low

Re: [libvirt PATCH v2 2/9] gitlab: reduce number of cross-build CI jobs

On Tue, Mar 24, 2020 at 04:23:58PM +, Daniel P. Berrangé wrote: > We're going to add more build jobs to CI, and users have limited time > granted on the shared CI runners. The number of cross-build jobs > currently present is not sustainable, so cut it down to two interesting > jobs to cover

Re: [libvirt PATCH v2 1/9] gitlab: use CI for building website contents

On Tue, Mar 24, 2020 at 06:26:15PM +0100, Andrea Bolognani wrote: > On Tue, 2020-03-24 at 16:23 +, Daniel P. Berrangé wrote: > > Run the bare minimum build that is possible to create the docs. Ideally > > the '--without-remote' arg would be passed, but there are several bugs > > preventing a

Re: [PATCH] qemu: capabilities: update qemu-4.2 capabilities for s390x

On Wed, Mar 25, 2020 at 08:06:20 +0100, Bjoern Walk wrote: > Update s390x capabilities for QEMU 4.2 with the actual GA version for > QEMU and on the latest z15 machine. I'm not familiar with the machine so I don't want to review the CPU changes caused by using a different machine. > This picks

[RFC 22/29] conf: Replace virNetworkDNSForwarderParseXML(hardcoded) with namesake(generated)

Signed-off-by: Shi Lei --- docs/schemas/network.rng | 1 + src/conf/network_conf.c | 31 +-- 2 files changed, 2 insertions(+), 30 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index 20878a8..702018b 100644 ---

[RFC 18/29] conf: Replace virNetworkDNSSrvDefParseXML(hardcoded) with namesake(generated)

Signed-off-by: Shi Lei --- docs/schemas/network.rng | 1 + src/conf/network_conf.c | 100 ++- 2 files changed, 15 insertions(+), 86 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index 14561d9..4caea02 100644 ---

[RFC 13/29] conf: Replace virNetworkDNSDef(hardcoded) with namesake(generated)

Signed-off-by: Shi Lei --- docs/schemas/network.rng| 3 +++ src/conf/network_conf.c | 12 ++-- src/conf/network_conf.h | 15 --- src/network/bridge_driver.c | 2 +- 4 files changed, 10 insertions(+), 22 deletions(-) diff --git a/docs/schemas/network.rng

[RFC 28/29] conf: Apply virNetworkDNSHostDefFormatBuf(generated) in virNetworkDNSDefFormat

Signed-off-by: Shi Lei --- docs/schemas/network.rng | 1 + src/conf/network_conf.c | 15 +++ 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index b97510f..ba5db0b 100644 --- a/docs/schemas/network.rng +++

[RFC 16/29] conf: Replace virNetworkDNSHostDefParseXML(hardcoded) with namesake(generated)

Signed-off-by: Shi Lei --- docs/schemas/network.rng | 7 +++-- po/POTFILES.in | 1 + src/conf/network_conf.c | 66 +--- 3 files changed, 13 insertions(+), 61 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index

[PATCH] qemu: capabilities: update qemu-4.2 capabilities for s390x

Update s390x capabilities for QEMU 4.2 with the actual GA version for QEMU and on the latest z15 machine. This picks up the new blockdev capability, so we need to refresh a bunch of test cases as well. Reviewed-by: Boris Fiuczynski Signed-off-by: Bjoern Walk --- I have stripped the replies

[RFC 24/29] conf: Replace virNetworkDNSDefParseXML(hardcoded) with namesake(generated)

Signed-off-by: Shi Lei --- docs/schemas/network.rng | 1 + src/conf/network_conf.c | 150 +-- 2 files changed, 3 insertions(+), 148 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index 884cd64..7084248 100644 ---

[RFC 27/29] conf: Apply virNetworkDNSSrvDefFormatBuf(generated) in virNetworkDNSDefFormat

Signed-off-by: Shi Lei --- docs/schemas/network.rng | 1 + src/conf/network_conf.c | 20 ++-- 2 files changed, 3 insertions(+), 18 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index 1d7b854..b97510f 100644 --- a/docs/schemas/network.rng +++

[RFC 29/29] conf: Replace virNetworkDNSDefFormat(hardcoded) with virNetworkDNSDefFormatBuf(generated)

Signed-off-by: Shi Lei --- docs/schemas/network.rng | 3 +- src/conf/network_conf.c | 71 +--- 2 files changed, 3 insertions(+), 71 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index ba5db0b..db04b7c 100644 ---

[RFC 26/29] conf: Apply virNetworkDNSTxtDefFormatBuf(generated) in virNetworkDNSDefFormat

Signed-off-by: Shi Lei --- docs/schemas/network.rng | 1 + src/conf/network_conf.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index cd5be22..1d7b854 100644 --- a/docs/schemas/network.rng +++

[RFC 02/29] maint: Call RNG2C automatically when relax-ng files change

Let makefiles call RNG2C for generating codes automatically. Signed-off-by: Shi Lei --- src/Makefile.am | 16 +++- src/access/Makefile.inc.am | 2 +- src/conf/Makefile.inc.am| 10 +- src/esx/Makefile.inc.am | 2 +-

[RFC 23/29] conf: Extract error-checking code from virNetworkDNSDefParseXML

Signed-off-by: Shi Lei --- docs/schemas/network.rng | 6 +- src/conf/network_conf.c | 33 +++-- 2 files changed, 32 insertions(+), 7 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index 702018b..884cd64 100644 ---

[RFC 25/29] conf: Apply virNetworkDNSForwarderFormatBuf(generated) in virNetworkDNSDefFormat

Signed-off-by: Shi Lei --- docs/schemas/network.rng | 4 src/conf/network_conf.c | 17 ++--- 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index 7084248..cd5be22 100644 --- a/docs/schemas/network.rng +++

[RFC 00/29] RFC: Generate object-model code based on relax-ng files

Outline = In libvirt world, objects(like domain, network, etc.) are described with two representations: structures in c-language and XML specified by relax-ng. Since c-language-implementation and xml restricted by relax-ng are merely the different expressions of the same object-model, we

[RFC 08/29] util: Add a helper function virStrToLong_u8p

Meta 'U8' corresponds to 'uint8_t'. Add virStrToLong_u8p when parsing uint8_t. Signed-off-by: Shi Lei --- src/util/virstring.c | 15 +++ src/util/virstring.h | 5 + 2 files changed, 20 insertions(+) diff --git a/src/util/virstring.c b/src/util/virstring.c index

[RFC 03/29] util: Add two helper functions virXMLChildNode and virXMLChildNodeSet

When directive property 'args.noctxt" is set, there's no 'ctxt' argument for the parse function. So RNG2C uses virXMLChildNode, virXMLChildNodeSet and virXMLPropString to construct implementation of the parse function. Signed-off-by: Shi Lei --- src/util/virxml.c | 57

[RFC 10/29] conf: Replace virNetworkDNSSrvDef(hardcoded) with namesake(generated)

Signed-off-by: Shi Lei --- docs/schemas/network.rng | 3 +++ docs/schemas/networkcommon.rng | 2 +- src/conf/network_conf.h| 12 3 files changed, 4 insertions(+), 13 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index 4d23c8f..1747fc2

[RFC 04/29] util: Move VIR_ENUM_IMPL and VIR_ENUM_DECL from virenum.h to internal.h

Generated codes by RNG2C need to invoke VIR_ENUM_IMPL and VIR_ENUM_DECL. Move them from virenum.h to internal.h for convenience. This patch also prepares for next patch: replacing virTristateBool/virTristateSwitch(hardcoded) with namesakes. Signed-off-by: Shi Lei --- src/internal.h | 19

[RFC 01/29] rng2c: Add tool RNG2C to translate relax-ng into c-language-code.

RNG2C has three subcommands: 'list'/'show' for previewing directives and generated codes; 'generate' for Makefile to generate and output codes. Signed-off-by: Shi Lei --- po/POTFILES.in |1 + rng2c/directive.py | 1693 rng2c/generator.py |

[RFC 07/29] util: Add some helper functions for virSocketAddr

Add virSocketAddrParse, virSocketAddrFormat, virSocketAddrClear and virSocketAddrCheck. In generated codes by RNG2C, these functions are called for handling virSocketAddr. Signed-off-by: Shi Lei --- docs/schemas/basictypes.rng | 1 + src/util/virsocketaddr.c| 27 +++

[RFC 05/29] util: Replace virTristateBool|virTristateSwitch(hardcoded) with namesakes(generated)

Signed-off-by: Shi Lei --- docs/schemas/basictypes.rng | 14 ++ src/util/Makefile.inc.am| 2 ++ src/util/virenum.c | 15 --- src/util/virenum.h | 21 +++-- 4 files changed, 19 insertions(+), 33 deletions(-) diff --git

[RFC 15/29] conf: Extract error-checking code from virNetworkDNSHostDefParseXML

Signed-off-by: Shi Lei --- docs/schemas/network.rng | 8 ++ src/conf/network_conf.c | 58 +++- 2 files changed, 47 insertions(+), 19 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index 919464d..ee4487e 100644 ---

[RFC 06/29] util: Add a helper function virStringParseOnOff

When RNG2C generates codes for builtin 'Bool.on_off', it includes virStringParseOnOff in those codes. Signed-off-by: Shi Lei --- src/util/virstring.c | 22 ++ src/util/virstring.h | 5 + 2 files changed, 27 insertions(+) diff --git a/src/util/virstring.c

[RFC 20/29] conf: Replace virNetworkDNSTxtDefParseXML(hardcoded) with namesake(generated)

Signed-off-by: Shi Lei --- docs/schemas/network.rng | 1 + src/conf/network_conf.c | 37 + 2 files changed, 6 insertions(+), 32 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index b0f4a64..07fbd5b 100644 ---

[RFC 17/29] conf: Extract error-checking code from virNetworkDNSSrvDefParseXML

Signed-off-by: Shi Lei --- docs/schemas/network.rng | 13 ++- src/conf/network_conf.c | 218 +-- 2 files changed, 152 insertions(+), 79 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index c902f7e..14561d9 100644 ---

[RFC 14/29] conf: Replace virNetworkDNSDefClear(hardcoded) with namesake(generated)

Signed-off-by: Shi Lei --- docs/schemas/network.rng | 13 ++--- src/conf/Makefile.inc.am | 2 ++ src/conf/network_conf.c | 60 3 files changed, 11 insertions(+), 64 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index

[RFC 19/29] conf: Extract error-checking code from virNetworkDNSTxtDefParseXML

Signed-off-by: Shi Lei --- docs/schemas/network.rng | 13 - src/conf/network_conf.c | 60 +++- 2 files changed, 53 insertions(+), 20 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index 4caea02..b0f4a64 100644 ---

[RFC 11/29] conf: Replace virNetworkDNSHostDef(hardcoded) with namesake(generated)

Signed-off-by: Shi Lei --- docs/schemas/network.rng | 4 src/conf/network_conf.h | 9 - 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index 1747fc2..c83a796 100644 --- a/docs/schemas/network.rng +++

[RFC 09/29] conf: Replace virNetworkDNSTxtDef(hardcoded) with namesake(generated)

Signed-off-by: Shi Lei --- docs/schemas/network.rng | 3 +++ src/conf/network_conf.h | 8 +--- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index 6045322..4d23c8f 100644 --- a/docs/schemas/network.rng +++

[RFC 21/29] conf: Add virNetworkDNSForwarderParseXML and virNetworkDNSForwarderParseXMLPost

Signed-off-by: Shi Lei --- docs/schemas/network.rng | 7 +++- src/conf/network_conf.c | 69 +--- 2 files changed, 57 insertions(+), 19 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index 07fbd5b..20878a8 100644 ---

[RFC 12/29] conf: Replace virNetworkDNSForwarder(hardcoded) with namesake(generated)

Signed-off-by: Shi Lei --- docs/schemas/network.rng | 4 src/conf/network_conf.h | 7 --- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index c83a796..0034c4f 100644 --- a/docs/schemas/network.rng +++