Although we have nothing in make syntax-check to enforce this, and
apparently there are places where it isn't the case (according to
Dan), we should discourage the practice of defining new variables in
the middle of a block of code.
On Thu, Jul 9, 2020 at 2:44 AM Gerd Hoffmann wrote:
> (2) GUEST_MAXPHYADDR < HOST_MAXPHYADDR
>
> Mostly fine. Some edge cases, like different page fault errors for
> addresses above GUEST_MAXPHYADDR and below HOST_MAXPHYADDR. Which I
> think Mohammed fixed in the kernel recently.
From: Stefan Berger
Move setting the TPM default version out of the validation function into
the post parse function.
Signed-off-by: Stefan Berger
Reviewed-by: Peter Krempa
Reviewed-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 7 ---
src/qemu/qemu_validate.c | 4
2
From: Stefan Berger
This series of patches adds an additional check for the SPAPR device model
that prevents the choice of a TPM 1.2 backend and chooses a TPM 2 as default.
Also CRB now chooses a TPM 2 as default since TPM 1.2 wouldn't work with it,
either.
Stefan
v4->v5:
- Added R-b's
From: Stefan Berger
Choose a TPM 2 device for the backend as default for the CRB interface
since TPM 1.2 would not work.
This patch addresses BZ 1781913:
https://bugzilla.redhat.com/show_bug.cgi?id=1781913
Signed-off-by: Stefan Berger
Reviewed-by: Daniel Henrique Barboza
---
From: Stefan Berger
The firmware (SLOF) on QEMU for ppc64 does not support TPM 1.2, so
prevent the choice of TPM 1.2 when the SPAPR device model is chosen
and use a default of '2.0' (TPM 2) for the backend.
This patch addresses BZ 1781913:
https://bugzilla.redhat.com/show_bug.cgi?id=1781913
On Thu, Jul 9, 2020 at 12:27 PM Daniel P. Berrangé wrote:
>
> On Thu, Jul 09, 2020 at 08:30:14AM -0600, Chris Murphy wrote:
> > It's generally recommended by upstream Btrfs development to set
> > 'nodatacow' using 'chattr +C' on the containing directory for VM
> > images. By setting it on the
On Thu, Jul 09, 2020 at 10:00:59AM -0700, Jim Mattson wrote:
> On Thu, Jul 9, 2020 at 2:44 AM Gerd Hoffmann wrote:
>
> > (2) GUEST_MAXPHYADDR < HOST_MAXPHYADDR
> >
> > Mostly fine. Some edge cases, like different page fault errors for
> > addresses above GUEST_MAXPHYADDR and below
When accessing libvirtd over a SSH tunnel, the remote driver must spawn
the remote 'nc' process, pointing it to the libvirtd socket path. This
is problematic for a number of reasons:
- The socket path varies according to the --prefix chosen at build
time. The remote client is seeing the local
We'll shortly want to reuse code for determining whether to connect to
the system or session daemon from places outside the remote driver
client. Pulling it out into a self contained function facilitates reuse.
Signed-off-by: Daniel P. Berrangé
---
src/remote/remote_driver.c | 51
This wires up support for using the new virt-nc binary with the ssh,
libssh and libssh2 protocols.
The new binary will be used preferentially if it is available in $PATH,
otherwise we fall back to traditional netcat.
The "proxy" URI parameter can be used to force use of netcat e.g.
Three parts of the code all build up the same SSH shell script
snippet for remote tunneling the RPC protocol, but in slightly
different ways. Combine them all into one helper method in the
virNetClient code, since this logic doesn't really belong in
the virNetSocket code.
Note that the this
We delay converting the remote transport string to enum form until
fairly late. As a result we're doing string comparisons when we
could be just doing enum comparisons.
Signed-off-by: Daniel P. Berrangé
---
po/POTFILES.in | 1 +
src/remote/remote_driver.c | 51
The remoteSplitURISCheme method will be needed by source files beyond
the remote driver client.
Signed-off-by: Daniel P. Berrangé
---
src/remote/remote_driver.c | 25 -
src/remote/remote_sockets.c | 28
src/remote/remote_sockets.h | 6
We have long had a problem with use of netcat for ssh tunnelling because
there's no guarantee the UNIX socket path the client builds will match
the UNIX socket path the remote host uses. We don't even allow session
mode SSH tunnelling for this reason. We also can't easily auto-spawn
libvirtd in
Am Thu, 9 Jul 2020 19:00:18 +0200
schrieb Michal Privoznik :
> do you see an actual libvirt error? I think this may come from
> secdrivers trying to remember the original owner of kernel/initrd files.
Jul 09 16:10:42 libvirtd[5741]: internal error: child reported (status=125):
unable to open
Switch keyfile and netcat parameters, since the netcat path and
socket path are a logical pair that belong together. This patches
the other constructors.
Signed-off-by: Daniel P. Berrangé
---
src/remote/remote_driver.c | 2 +-
src/rpc/virnetclient.c | 2 +-
src/rpc/virnetclient.h | 4
The remoteGetUNIXSocketHelper method will be needed by source files
beyond the remote driver client.
Signed-off-by: Daniel P. Berrangé
---
src/remote/remote_driver.c | 129 +-
src/remote/remote_sockets.c | 134
The remoteDriverTransport and remoteDriverMode enums are going to be
needed by source files beyond the remote driver client.
Signed-off-by: Daniel P. Berrangé
---
src/remote/Makefile.inc.am | 2 ++
src/remote/remote_driver.c | 41 +-
src/remote/remote_sockets.c |
On Thu, Jul 09, 2020 at 08:30:14AM -0600, Chris Murphy wrote:
> It's generally recommended by upstream Btrfs development to set
> 'nodatacow' using 'chattr +C' on the containing directory for VM
> images. By setting it on the containing directory it means new VM
> images inherit the attribute,
Ack, Thanks!
On Thu, Jul 9, 2020 at 2:48 PM Daniel P. Berrangé wrote:
>
> On Thu, Jul 09, 2020 at 02:40:34PM -0300, Nicolás Brignone wrote:
> > On Thu, Jul 9, 2020 at 5:15 AM Daniel P. Berrangé
> > wrote:
> > >
> > > On Wed, Jul 08, 2020 at 11:15:27PM -0400, Laine Stump wrote:
> > > > On
On Thu, Jul 09, 2020 at 02:40:34PM -0300, Nicolás Brignone wrote:
> On Thu, Jul 9, 2020 at 5:15 AM Daniel P. Berrangé wrote:
> >
> > On Wed, Jul 08, 2020 at 11:15:27PM -0400, Laine Stump wrote:
> > > On 7/8/20 4:19 PM, Nicolas Brignone wrote:
> > > > All pointers to virXMLPropString() use
On Thu, Jul 9, 2020 at 5:15 AM Daniel P. Berrangé wrote:
>
> On Wed, Jul 08, 2020 at 11:15:27PM -0400, Laine Stump wrote:
> > On 7/8/20 4:19 PM, Nicolas Brignone wrote:
> > > All pointers to virXMLPropString() use g_autofree.
> >
> >
> > I changed the summary line like this, to be more precise:
On 7/9/20 4:32 PM, Olaf Hering wrote:
Is there a reason why libvirtd v6.5.0 opens kernel+initrd in mode RW?
'virsh start vm' fails of both are on a read-only filesystem.
Not sure if this ever worked before.
hvm
/path/to/kernel
/path/to/initrd
net.ifnames=0
On Thu, 2020-07-09 at 13:44 +0200, Martin Kletzander wrote:
> On Thu, Jul 09, 2020 at 12:50:38PM +0200, Andrea Bolognani wrote:
> > it seems to me that this change entirely flipped the semantics of
> > the lock.
>
> Yep, you're right. When you have a lock that has boolean as a parameter I
>
On a Wednesday in 2020, Erik Skultety wrote:
On Wed, Jul 08, 2020 at 01:28:49PM +0200, Ján Tomko wrote:
On a Wednesday in 2020, Erik Skultety wrote:
> I overlooked this typo during review of 2c3ffa37.
Please do not follow commit hashes directly by a period.
* rephrase the sentence
* just drop
On Tue, 2020-07-07 at 15:00 +0300, Nikolay Shirokovskiy wrote:
> Add headers with declarations of geteuid/getegid
> and virGetUserName/virGetGroupName.
Can you share the exact error message you're hitting? Our CI seems to
be perfectly happy with the current status quo. Specifically, the
On Thu, Jul 09, 2020 at 04:41:29PM +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 09, 2020 at 05:33:14PM +0200, Pavel Hrdina wrote:
> > On Thu, Jul 09, 2020 at 04:22:41PM +0100, Daniel P. Berrangé wrote:
> > > On Thu, Jul 02, 2020 at 02:25:29PM +0200, Pavel Hrdina wrote:
> > > > With meson
On 7/2/20 2:24 PM, Pavel Hrdina wrote:
While working on rewrite to Meson I discovered some parts of our
current build system that could be improved to help with the
transition to Meson. It will make the review of the Meson patches
a bit easier.
Pavel Hrdina (31):
build: use DLOPEN_LIBS
On Thu, Jul 09, 2020 at 05:33:14PM +0200, Pavel Hrdina wrote:
> On Thu, Jul 09, 2020 at 04:22:41PM +0100, Daniel P. Berrangé wrote:
> > On Thu, Jul 02, 2020 at 02:25:29PM +0200, Pavel Hrdina wrote:
> > > With meson introduction which is using the same CFLAGS for the whole
> > > project some
On Thu, Jul 09, 2020 at 04:22:41PM +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 02, 2020 at 02:25:29PM +0200, Pavel Hrdina wrote:
> > With meson introduction which is using the same CFLAGS for the whole
> > project some compilation errors were discovered.
> >
> > Signed-off-by: Pavel Hrdina
>
On a Thursday in 2020, Pavel Hrdina wrote:
With meson introduction which is using the same CFLAGS for the whole
project some compilation errors were discovered.
What were the errors?
Signed-off-by: Pavel Hrdina
---
tools/wireshark/src/packet-libvirt.c | 19 +--
1 file
On a Thursday in 2020, Pavel Hrdina wrote:
../tools/virsh-secret.c: In function ‘cmdSecretSetValue’:
../tools/virsh-secret.c:262:15: error: pointer targets in assignment from ‘char
*’ to ‘unsigned char *’ differ in signedness [-Werror=pointer-sign]
262 | value = g_steal_pointer(_buf);
On Thu, Jul 09, 2020 at 04:12:29PM +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 02, 2020 at 02:25:14PM +0200, Pavel Hrdina wrote:
> > The current code to check XDR support was obsolete and way to
> > complicated.
> >
> > On linux we can use pkg-config to check for libtirpc and have
> > the
On Thu, Jul 02, 2020 at 02:25:25PM +0200, Pavel Hrdina wrote:
> We have two functions to set that we want to override directory where to
> look for libvirt files, one checks the binary name and the other one
> checks env variable.
>
> This patch removes the binary name check to simplify code by
On Thu, Jul 02, 2020 at 02:25:29PM +0200, Pavel Hrdina wrote:
> With meson introduction which is using the same CFLAGS for the whole
> project some compilation errors were discovered.
>
> Signed-off-by: Pavel Hrdina
> ---
> tools/wireshark/src/packet-libvirt.c | 19 +--
> 1 file
On Thu, Jul 09, 2020 at 05:00:39PM +0200, Ján Tomko wrote:
> On a Thursday in 2020, Pavel Hrdina wrote:
> > All of the listed functions are available in libselinux version 2.2.
> > Our supported OSes start with version 2.5 so there is no need to check
> > it.
> >
> > Signed-off-by: Pavel Hrdina
On a Thursday in 2020, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
m4/virt-nss.m4 | 2 +-
tests/nssmock.c | 2 +-
tests/nsstest.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Thursday in 2020, Pavel Hrdina wrote:
We have two functions to set that we want to override directory where to
look for libvirt files, one checks the binary name and the other one
checks env variable.
This patch removes the binary name check to simplify code by using only
the env variable.
On a Thursday in 2020, Pavel Hrdina wrote:
Fixes inconsistency with macro names for external programs.
Signed-off-by: Pavel Hrdina
---
m4/virt-external-programs.m4| 8
src/util/virnetdevmidonet.c | 4 ++--
src/util/virnetdevopenvswitch.c | 16
3 files changed,
On a Thursday in 2020, Pavel Hrdina wrote:
Commit added check for
openpty function from util library using AC_CHECK_LIB(). However, that
macro doesn't define OPENPTY_LIBS, it only defines WITH_LIBUTIL and
prepends -lutil into LIBS for the whole project.
Signed-off-by: Pavel Hrdina
---
On a Thursday in 2020, Pavel Hrdina wrote:
Commit <5b816e16968ba02def56f067774ecd9a8c8d44d7> removed hard-coded
sysconfdir path from *.conf files but missed virtproxyd.
Signed-off-by: Pavel Hrdina
---
src/remote/Makefile.inc.am | 3 +++
1 file changed, 3 insertions(+)
Reviewed-by: Ján Tomko
On a Thursday in 2020, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina
---
src/remote/Makefile.inc.am | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am
index 8a40c96563c..893d6894e2f 100644
---
On a Thursday in 2020, Pavel Hrdina wrote:
Commit <0985a9597bb0348d46c0d18dc548a676bf0ad8e2> added unused variable
so remove it.
Signed-off-by: Pavel Hrdina
---
src/logging/Makefile.inc.am | 1 -
1 file changed, 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP
Michal Privoznik wrote:
> On 7/8/20 4:28 PM, Roman Bogorodskiy wrote:
> > - Add a check for asm/hwcap.h header presence,
> > - Add a check for getauxval() function that is used
> > on Linux, and for elf_aux_info() which is a FreeBSD
> > equivalent.
> >
> > This is based on a patch
On a Thursday in 2020, Pavel Hrdina wrote:
It was introduced by commit
as a gnulib ldexp module and later removed by commit
<09fe607b4de8eb883c966e90aaf5563299a22738>.
Signed-off-by: Pavel Hrdina
---
src/util/Makefile.inc.am | 1 -
1 file changed, 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
On Thu, Jul 09, 2020 at 05:13:47PM +0200, Michal Privoznik wrote:
> On 7/9/20 4:59 PM, Daniel P. Berrangé wrote:
> > On Thu, Jul 02, 2020 at 02:25:06PM +0200, Pavel Hrdina wrote:
> > > convert bin is part of ImageMagick package and uses uniconvertor to
> > > create png file from fig files.
> > >
On 7/9/20 4:59 PM, Daniel P. Berrangé wrote:
On Thu, Jul 02, 2020 at 02:25:06PM +0200, Pavel Hrdina wrote:
convert bin is part of ImageMagick package and uses uniconvertor to
create png file from fig files.
Unfortunately uniconvertor is python2 only and not available in most
recent
On Thu, Jul 02, 2020 at 02:25:14PM +0200, Pavel Hrdina wrote:
> The current code to check XDR support was obsolete and way to
> complicated.
>
> On linux we can use pkg-config to check for libtirpc and have
> the CFLAGS and LIBS configured by it as well.
Historically we've only used libtirpc for
On a Thursday in 2020, Pavel Hrdina wrote:
Commit <894556ca813ad3c4ebb01083b7971d73b4f53c8b> moved function
virSecretGetSecretString out of secret directory but forgot to update
CFLAGS in places where the include is no longer needed.
Signed-off-by: Pavel Hrdina
---
src/libxl/Makefile.inc.am
On a Thursday in 2020, Pavel Hrdina wrote:
Commit removed objectlocking
test but forgot to remove all of the usages of LOCK_CHECKING_CFLAGS.
Signed-off-by: Pavel Hrdina
---
src/Makefile.am | 1 -
1 file changed, 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP
On a Thursday in 2020, Pavel Hrdina wrote:
There is no need to provide relative paths to the current directory if
we provide search paths using --directory option for xgentext.
xgettext
In addition it will make libvirt.pot file look cleaner as it will not
contain relative paths to current
On Thu, Jul 02, 2020 at 02:25:06PM +0200, Pavel Hrdina wrote:
> convert bin is part of ImageMagick package and uses uniconvertor to
> create png file from fig files.
>
> Unfortunately uniconvertor is python2 only and not available in most
> recent distributions which makes the convert command
On a Thursday in 2020, Pavel Hrdina wrote:
The current code to check XDR support was obsolete and way to
complicated.
On linux we can use pkg-config to check for libtirpc and have
the CFLAGS and LIBS configured by it as well.
On MinGW there is portablexdr library which installs header files
On a Thursday in 2020, Pavel Hrdina wrote:
All of the listed functions are available in libselinux version 2.2.
Our supported OSes start with version 2.5 so there is no need to check
it.
Signed-off-by: Pavel Hrdina
---
m4/virt-secdriver-selinux.m4 | 24 ++--
1 file changed,
On a Thursday in 2020, Pavel Hrdina wrote:
All supported OSes have at least libselinux version 2.5 so it's safe
to drop this check.
Signed-off-by: Pavel Hrdina
---
m4/virt-selinux.m4| 17 -
tests/securityselinuxhelper.c | 5 ++---
2 files changed, 2 insertions(+), 20
On a Thursday in 2020, Pavel Hrdina wrote:
Function sanlock_write_lockspace() was introduced in 2.7 version which
is available in all supported OSes.
Signed-off-by: Pavel Hrdina
---
m4/virt-sanlock.m4| 11 ---
src/locking/lock_driver_sanlock.c | 19 ---
2
On a Thursday in 2020, Pavel Hrdina wrote:
Function sanlock_killpath() was introduced in 2.4 version and had
modified one of the arguments from `char *` into `const char *` in
version 2.7. All of this is available in all supported OSes.
Signed-off-by: Pavel Hrdina
---
m4/virt-sanlock.m4
On a Thursday in 2020, Pavel Hrdina wrote:
The last distribution supported by libvirt and lacking pkg-config file
for libsanlock_client was Ubuntu 16.04. It is no longer supported so
switch to pkg-config.
Signed-off-by: Pavel Hrdina
---
m4/virt-sanlock.m4 | 2 +-
1 file changed, 1 insertion(+),
On a Thursday in 2020, Pavel Hrdina wrote:
convert bin is part of ImageMagick package and uses uniconvertor to
create png file from fig files.
Unfortunately uniconvertor is python2 only and not available in most
recent distributions which makes the convert command fail with:
sh: uniconvertor:
On a Thursday in 2020, Pavel Hrdina wrote:
This check was introduced by commit
<96a02703daad4dc6663165adbc0feade9900cebd> to guard calling
sanlock_inq_lockspace() function but it used SANLK_INQ_WAIT as a
parameter which was introduced later. This was eventually fixed by
commit
On a Thursday in 2020, Pavel Hrdina wrote:
SANLK_INQ_WAIT was introduced in sanlock 2.4 which is available in all
supported OSes.
Signed-off-by: Pavel Hrdina
---
m4/virt-sanlock.m4| 9 -
src/locking/lock_driver_sanlock.c | 6 --
2 files changed, 15 deletions(-)
On Thu, Jul 9, 2020 at 12:15 AM Laine Stump wrote:
>
> On 7/8/20 4:19 PM, Nicolas Brignone wrote:
> > All pointers to virXMLPropString() use g_autofree.
>
>
> I changed the summary line like this, to be more precise:
>
>
> conf: use g_autofree for all pointers to virXMLPropString() in
On a Thursday in 2020, Pavel Hrdina wrote:
These files are generated by xsltproc as part of html/index.html and
html/index-%.html rules.
Signed-off-by: Pavel Hrdina
---
docs/Makefile.am | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
On Thu, Jul 02, 2020 at 02:24:58PM +0200, Pavel Hrdina wrote:
> While working on rewrite to Meson I discovered some parts of our
> current build system that could be improved to help with the
> transition to Meson. It will make the review of the Meson patches
> a bit easier.
>
> Pavel Hrdina
Is there a reason why libvirtd v6.5.0 opens kernel+initrd in mode RW?
'virsh start vm' fails of both are on a read-only filesystem.
Not sure if this ever worked before.
hvm
/path/to/kernel
/path/to/initrd
net.ifnames=0 console=ttyS0,115200 linemode=1 panic=9
start_shell
It's generally recommended by upstream Btrfs development to set
'nodatacow' using 'chattr +C' on the containing directory for VM
images. By setting it on the containing directory it means new VM
images inherit the attribute, including images copied to this
location.
But 'nodatacow' also implies
On Thu, Jul 09, 2020 at 01:58:33PM +0800, Jason Wang wrote:
> > > - If we care the performance, it's better to implement the MAP event for
> > > vhost, otherwise it could be a lot of IOTLB miss
> > I feel like these are two things.
> >
> > So far what we are talking about is whether vt-d should
On Thu, Jul 09, 2020 at 12:50:38PM +0200, Andrea Bolognani wrote:
On Thu, 2020-07-09 at 11:40 +0200, Martin Kletzander wrote:
static int
virResctrlLockWrite(void)
{
-int fd = open(SYSFS_RESCTRL_PATH, O_RDWR | O_CLOEXEC);
+int fd = open(SYSFS_RESCTRL_PATH, O_RDONLY | O_CLOEXEC);
I
On Thu, 2020-07-09 at 12:30 +0200, Bastien Orivel wrote:
> This was forgotten in 4bd375b6ce3a4c134bab19cd7c9a7a83609547c8
>
> Signed-off-by: Bastien Orivel
> ---
> NEWS.rst | 5 +
> 1 file changed, 5 insertions(+)
Looks good now!
Reviewed-by: Andrea Bolognani
and pushed. Thanks :)
--
On Thu, 2020-07-09 at 11:40 +0200, Martin Kletzander wrote:
> static int
> virResctrlLockWrite(void)
> {
> -int fd = open(SYSFS_RESCTRL_PATH, O_RDWR | O_CLOEXEC);
> +int fd = open(SYSFS_RESCTRL_PATH, O_RDONLY | O_CLOEXEC);
I got curious, so I did some digging.
The commit message for
On Thu, Jul 09, 2020 at 12:18:16 +0200, Bastien Orivel wrote:
>
>
> On 09/07/2020 12:10, Andrea Bolognani wrote:
> > On Thu, 2020-07-09 at 11:25 +0200, Bastien Orivel wrote:
> >> This was forgotten in 4bd375b6ce3a4c134bab19cd7c9a7a83609547c8
> > You're missing the Signed-off-by tag...
> Sorry,
This was forgotten in 4bd375b6ce3a4c134bab19cd7c9a7a83609547c8
Signed-off-by: Bastien Orivel
---
NEWS.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index cc35cb26b2..1928220854 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -20,6 +20,11 @@ v6.6.0 (unreleased)
*
On Thu, Jul 09, 2020 at 12:18:16 +0200, Bastien Orivel wrote:
>
>
> On 09/07/2020 12:10, Andrea Bolognani wrote:
> > On Thu, 2020-07-09 at 11:25 +0200, Bastien Orivel wrote:
> >> This was forgotten in 4bd375b6ce3a4c134bab19cd7c9a7a83609547c8
> > You're missing the Signed-off-by tag...
> Sorry,
On 09/07/2020 12:10, Andrea Bolognani wrote:
> On Thu, 2020-07-09 at 11:25 +0200, Bastien Orivel wrote:
>> This was forgotten in 4bd375b6ce3a4c134bab19cd7c9a7a83609547c8
> You're missing the Signed-off-by tag...
Sorry, not used to using that git feature.
>
>> * **Improvements**
>>
>> + *
On 09/07/20 11:55, Mohammed Gamal wrote:
>> Ideally we would simply outlaw (3), but it's hard for backward
>> compatibility reasons. Second best solution is a flag somewhere
>> (msr, cpuid, ...) telling the guest firmware "you can use
>> GUEST_MAXPHYADDR, we guarantee it is <= HOST_MAXPHYADDR".
>
On Thu, 2020-07-09 at 11:25 +0200, Bastien Orivel wrote:
> This was forgotten in 4bd375b6ce3a4c134bab19cd7c9a7a83609547c8
You're missing the Signed-off-by tag...
> * **Improvements**
>
> + * esx: Change the NIC limit for recent virtualHW versions
> +
> + Specifying a virtualHW version
On Thu, 2020-07-09 at 11:44 +0200, Gerd Hoffmann wrote:
> Hi,
>
> > > (CCing libvir-list, and people who were included in the OVMF
> > > thread[1])
> > >
> > > [1]
> > > https://lore.kernel.org/qemu-devel/99779e9c-f05f-501b-b4be-ff719f140...@canonical.com/
> > > Also, it's important that we
On a Thursday in 2020, Martin Kletzander wrote:
When preparing for the removal of GNULIB commit 18dca21a32e9 removed the
unneeded O_DIRECTORY, but unfortunately started opening the directory for
writing which fails every time for a directory. There is also no need for that
as flock() works on
Hi,
> > (CCing libvir-list, and people who were included in the OVMF
> > thread[1])
> >
> > [1]
> > https://lore.kernel.org/qemu-devel/99779e9c-f05f-501b-b4be-ff719f140...@canonical.com/
> > Also, it's important that we work with libvirt and management
> > software to ensure they have
When preparing for the removal of GNULIB commit 18dca21a32e9 removed the
unneeded O_DIRECTORY, but unfortunately started opening the directory for
writing which fails every time for a directory. There is also no need for that
as flock() works on O_RDONLY file descriptor as well, even for LOCK_EX.
This was forgotten in 4bd375b6ce3a4c134bab19cd7c9a7a83609547c8
---
NEWS.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index cc35cb26b2..ce5d227068 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -20,6 +20,11 @@ v6.6.0 (unreleased)
* **Improvements**
+ * esx:
On 7/8/20 8:33 PM, Prathamesh Chavan wrote:
It was seen that `qemu_domain.h` file depended upon
`qemu_migration_params.h` and `qmeu_monitor.h` as they
were required by some qemu_domainjob stuctures.
This dependency was removed by the introduction of
a `void *privateData` pointer. This
On Wed, Jul 08, 2020 at 11:15:27PM -0400, Laine Stump wrote:
> On 7/8/20 4:19 PM, Nicolas Brignone wrote:
> > All pointers to virXMLPropString() use g_autofree.
>
>
> I changed the summary line like this, to be more precise:
>
>
> conf: use g_autofree for all pointers to virXMLPropString()
On a Thursday in 2020, Fangge Jin wrote:
Signed-off-by: Fangge Jin
---
src/bhyve/libvirtd_bhyve.aug | 2 +-
src/cpu/cpu_arm.c | 4 ++--
src/esx/esx_vi.c | 2 +-
src/interface/interface_backend_udev.c | 4 ++--
src/internal.h
On a Thursday in 2020, Ján Tomko wrote:
From: Ryan Schmidt
Apple changed the operating system's name from "OS X" to "macOS" a few years
ago.
Signed-off-by: Ryan Schmidt
Reviewed-by: Ján Tomko
Signed-off-by: Ján Tomko
---
docs/index.html.in | 2 +-
1 file changed, 1 insertion(+), 1
From: Ryan Schmidt
Apple changed the operating system's name from "OS X" to "macOS" a few years
ago.
Signed-off-by: Ryan Schmidt
Reviewed-by: Ján Tomko
Signed-off-by: Ján Tomko
---
docs/index.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/index.html.in
On 2020/7/8 下午10:16, Peter Xu wrote:
On Wed, Jul 08, 2020 at 01:42:30PM +0800, Jason Wang wrote:
So it should be functional equivalent to vtd_as_has_notifier().
For example: in vtd_iommu_replay() we'll skip the replay if vhost has
registered the iommu notifier because
88 matches
Mail list logo
