Re: [PATCH] remote: Add libvirtd dependency to virt-guest-shutdown.target

2020-11-03 Thread Neal Gompa
On Tue, Nov 3, 2020 at 9:26 PM Jim Fehlig wrote: > > When restarting libvirt services and sockets *and* libvirt-guests.service > is running, the latter will sometimes hang when trying to connect to > libvirtd. Even though libvirt-guests has 'Wants=libvirtd.service' and > 'After=libvirtd.service',

[PATCH] remote: Add libvirtd dependency to virt-guest-shutdown.target

2020-11-03 Thread Jim Fehlig
When restarting libvirt services and sockets *and* libvirt-guests.service is running, the latter will sometimes hang when trying to connect to libvirtd. Even though libvirt-guests has 'Wants=libvirtd.service' and 'After=libvirtd.service', we can see via journalctl that it is not shutdown before

[PULL 6/6] target/mips: Add unaligned access support for MIPS64R6 and Loongson-3

2020-11-03 Thread Philippe Mathieu-Daudé
From: Huacai Chen MIPSR6 (not only MIPS32R6) processors support unaligned access in hardware, so set MO_UNALN in their default_tcg_memop_mask. Btw, new Loongson-3 (such as Loongson-3A4000) also support unaligned access, since both old and new Loongson-3 use the same binaries, we can simply set

[PULL 5/6] target/mips: Fix Lesser GPL version number

2020-11-03 Thread Philippe Mathieu-Daudé
From: Chetan Pant There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section. Signed-off-by: Chetan Pant Reviewed-by:

[PULL 3/6] hw/mips/boston: Fix Lesser GPL version number

2020-11-03 Thread Philippe Mathieu-Daudé
From: Chetan Pant There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section. Signed-off-by: Chetan Pant Reviewed-by:

[PULL 0/6] Mips fixes patches

2020-11-03 Thread Philippe Mathieu-Daudé
-20201103 for you to fetch changes up to 8a805609d126ff2be9ad9ec118185dfc52633d6f: target/mips: Add unaligned access support for MIPS64R6 and Loongson-3 (2020= -11-03 16:51:13 +0100) MIPS patches queue - Removal of the 'r4k' machine

[PULL 2/6] hw/mips: Fix Lesser GPL version number

2020-11-03 Thread Philippe Mathieu-Daudé
From: Chetan Pant There is no "version 2" of the "Lesser" General Public License. It is either "GPL version 2.0" or "Lesser GPL version 2.1". This patch replaces all occurrences of "Lesser GPL version 2" with "Lesser GPL version 2.1" in comment section. Signed-off-by: Chetan Pant Reviewed-by:

[PULL 1/6] hw/mips: Remove the 'r4k' machine

2020-11-03 Thread Philippe Mathieu-Daudé
We deprecated the support for the 'r4k' machine for the 5.0 release (commit d32dc61421), which means that our deprecation policy allows us to drop it in release 5.2. Remove the code. To repeat the rationale from the deprecation note: - this virtual machine has no specification - the Linux kernel

[PULL 4/6] hw/intc/loongson: Fix incorrect 'core' calculation in liointc_read/write

2020-11-03 Thread Philippe Mathieu-Daudé
From: AlexChen According to the loongson spec (http://www.loongson.cn/uploadfile/cpu/3B1500/Loongson_3B1500_cpu_user_1.pdf) and the macro definition(#define R_PERCORE_ISR(x) (0x40 + 0x8 * x)), we know that the ISR size per CORE is 8, so here we need to divide (addr - R_PERCORE_ISR(0)) by 8, not

Re: [libvirt PATCH v2 1/3] cpu_map: Unify apostrophe and quotation mark usage

2020-11-03 Thread Jiri Denemark
On Mon, Oct 19, 2020 at 10:58:38 +0200, Peter Krempa wrote: > On Mon, Oct 19, 2020 at 09:36:15 +0200, Tim Wiederhake wrote: > > Usage was mixed. > > > > Signed-off-by: Tim Wiederhake > > --- > > src/cpu_map/arm_vendors.xml| 24 ++--- > > src/cpu_map/index.xml | 140

Re: [libvirt PATCH v2 2/3] cpu_map: Add script to sync from QEMU i386 cpu models

2020-11-03 Thread Jiri Denemark
On Mon, Oct 19, 2020 at 09:36:16 +0200, Tim Wiederhake wrote: > This script is intended to help in synchronizing i386 QEMU cpu model > definitions with libvirt. > > As the QEMU cpu model definitions are post processed by QEMU and not > meant to be consumed by third parties directly, parsing this

Re: [PATCH] security: Use org namespace for xattrs on macOS

2020-11-03 Thread Roman Bolshakov
On Mon, Nov 02, 2020 at 06:12:34PM +0100, Andrea Bolognani wrote: > On Sun, 2020-11-01 at 14:38 +0300, Roman Bolshakov wrote: > > But I'm not sure if libvirt on macOS is going to > > be used from root, rather from a user account. > > So, it's just qemu:///session on macOS? Yes, that's what I had

[PATCH v2 06/10] qemu: rename: support renaming checkpoints directory

2020-11-03 Thread Nikolay Shirokovskiy
This is basically just saves checkpoints metadata on disk after name is changed in memory as path to domain checkpoints directory depends on name. After that old checkpoint directory is deleted with checkpoint metadata files. Signed-off-by: Nikolay Shirokovskiy --- src/qemu/qemu_checkpoint.c |

[PATCH v2 09/10] qemu: qemuDomainDefineXMLFlags: move cleanup logic to cleanup section

2020-11-03 Thread Nikolay Shirokovskiy
Let's move objlist restoring to cleanup section so that we can handle failure of actions between virDomainObjListAdd and virDomainDefSave. We are going to add such actions in next patch. Signed-off-by: Nikolay Shirokovskiy --- src/qemu/qemu_driver.c | 32 1 file

[PATCH v2 07/10] qemu: update name on reverting from snapshot

2020-11-03 Thread Nikolay Shirokovskiy
If domain name is changed since snapshot we need to update it to current in config taken from snapshot. Signed-off-by: Nikolay Shirokovskiy --- src/qemu/qemu_snapshot.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index

[PATCH v2 08/10] qemu: rename: remove snapshot/checkpoint restriction

2020-11-03 Thread Nikolay Shirokovskiy
Signed-off-by: Nikolay Shirokovskiy --- src/qemu/qemu_driver.c | 12 1 file changed, 12 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 4e0186b..86ff74f 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19284,18 +19284,6 @@ static

[PATCH v2 10/10] qemu: remove possible garbage left from previous rename/undefine

2020-11-03 Thread Nikolay Shirokovskiy
Due to failures to unlink on previous rename/undefine we can already have autolink etc files for the domain to be defined. Remove them. Signed-off-by: Nikolay Shirokovskiy --- src/qemu/qemu_driver.c| 6 ++ src/qemu/qemu_migration.c | 3 +++ 2 files changed, 9 insertions(+) diff --git

[PATCH v2 02/10] qemu: rename: send events only on success

2020-11-03 Thread Nikolay Shirokovskiy
We can simplify cleanup section by moving sending events to success path only because only on sucess path events are not NULL. Signed-off-by: Nikolay Shirokovskiy --- src/qemu/qemu_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c

[PATCH v2 00/10] qemu: support renaming domains with snapshots/checkpoints

2020-11-03 Thread Nikolay Shirokovskiy
This is basically just rebase of [1] as it was not get any attention at that time. [1] [PATCH 0/8] qemu: support renaming domains with snapshots/checkpoints https://www.redhat.com/archives/libvir-list/2020-March/msg00018.html Nikolay Shirokovskiy (10): qemu: qemuDomainRenameCallback: fix

[PATCH v2 05/10] qemu: rename: support renaming snapshots directory

2020-11-03 Thread Nikolay Shirokovskiy
This is basically just saves snapshots metadata on disk after name is changed in memory as path to domain snapshot directory depends on name. After that old snapshot directory is deleted with snapshot metadata files. Signed-off-by: Nikolay Shirokovskiy --- src/qemu/qemu_domain.c | 7 +++

[PATCH v2 01/10] qemu: qemuDomainRenameCallback: fix sending false undefined event

2020-11-03 Thread Nikolay Shirokovskiy
For example if saving config file with new name fails we send false undefine event currently. Signed-off-by: Nikolay Shirokovskiy --- src/qemu/qemu_driver.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[PATCH v2 03/10] qemu: rename: return instead of goto if no cleanup required

2020-11-03 Thread Nikolay Shirokovskiy
Going to cleanup label is mere return -1 thus let's just return instead of goto to this label. Signed-off-by: Nikolay Shirokovskiy --- src/qemu/qemu_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[PATCH v2 04/10] qemu: remove duplicate code for removing remnant files

2020-11-03 Thread Nikolay Shirokovskiy
This patch also changes functionality a bit. First if unlinking of old config file is failed we rollback and return error previously and now we return success. I don't think this makes much difference. I guess in both cases on libvirtd restart we have to deal with both new and old config existing

Re: [PATCH 1/4] security_util: Don't error on macOS when getting/setting/moving XATTRs

2020-11-03 Thread Roman Bolshakov
On Tue, Nov 03, 2020 at 02:13:26PM +0100, Michal Privoznik wrote: > There are three internal APIs implemented in this security_util > file: virSecurityGetRememberedLabel(), > virSecuritySetRememberedLabel() and > virSecurityMoveRememberedLabel() for getting, setting and moving > remembered

Re: [PATCH 4/4] qemu_conf: Don't even attempt to enable rememberOwner if unsupported

2020-11-03 Thread Roman Bolshakov
On Tue, Nov 03, 2020 at 02:13:29PM +0100, Michal Privoznik wrote: > The remember owner feature uses XATTRs to store original > seclabels. But that means we don't want a regular user to be able > to change what we stored and thus trick us into setting different > seclabel. Therefore, we use

Re: [PATCH 3/4] qemusecuritytest: Skip on non supported platforms

2020-11-03 Thread Roman Bolshakov
On Tue, Nov 03, 2020 at 02:13:28PM +0100, Michal Privoznik wrote: > For seclabel remembering we need to have XATTRs and a special > namespace that is accessibly to CAP_SYS_ADMIN only (we don't want > regular users to trick us into restoring to a different label). > And what qemusecuritytest does

Re: [PATCH 0/4] Couple of qemusecuritytest and security_util improvements

2020-11-03 Thread Roman Bolshakov
On Tue, Nov 03, 2020 at 02:13:25PM +0100, Michal Privoznik wrote: > These were sparked by a discussion on the list where the test is failing > on macOS. > Hi Michal, Thanks for helping with the issue. I have applied the series and qemusecuritytest doesn't fail anymore. So, for the series:

[PATCH v2 0/3] tests: Fix issues on macOS

2020-11-03 Thread Roman Bolshakov
The series continues effort of fixing libvirt test suite on macOS [1] and combines previous patches sent a week ago [2][3]. The tests have been fixed: qemuhotplugtest qemumemlocktest qemuxml2xmltest storagepoolxml2argvtest Number of failing tests has been reduced to two:

[PATCH v2 3/3] storagepoolxml2argvtest: Reorder gluster arguments

2020-11-03 Thread Roman Bolshakov
Commit f00cde7f1133 changed order of mount arguments in virStorageBackendFileSystemMountGlusterArgs() and introduced per-OS mount options and new test data. Old test data was left unmodified with prior order of arguments. That causes a test failure on all OSes but Linux and FreeBSD, i.e. on macOS:

[PATCH v2 1/3] virpcimock: Initialize real_close before using it

2020-11-03 Thread Roman Bolshakov
real_close() is not inialized by the first invocation of close(). That causes an issue when the mock is used before others and a call of real_close() results in a jump to NULL pointer. Signed-off-by: Roman Bolshakov --- tests/virpcimock.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v2 2/3] virpcimock: Enable on macOS

2020-11-03 Thread Roman Bolshakov
In general, it has little sense to use Linux pci mock on macOS but virPCIDeviceAddressGetIOMMUGroupNum() is relying on the filesystem layout mocked by virpcimock. And all tests that rely on correct execution of virPCIDeviceAddressGetIOMMUGroupNum() fail. The change fixes qemuhotplugtest,

Re: [libvirt PATCH 00/25] cgroup related fixes and cleanup

2020-11-03 Thread Michal Privoznik
On 11/3/20 1:41 PM, Pavel Hrdina wrote: Pavel Hrdina (25): qemu_cgroup: remove unused @empty variable qemu: remove dead code that setup cgroups for helper processes qemu_dbus: use emulator cgroup for dbus-daemon vircgroupv2: properly detect empty tasks vircgroupv2: properly detect

Re: [PATCH-for-5.2 v3] hw/mips: Remove the 'r4k' machine

2020-11-03 Thread Philippe Mathieu-Daudé
On 11/2/20 9:13 PM, Philippe Mathieu-Daudé wrote: > We deprecated the support for the 'r4k' machine for the 5.0 release > (commit d32dc61421), which means that our deprecation policy allows > us to drop it in release 5.2. Remove the code. > > To repeat the rationale from the deprecation note: > -

Re: Release of libvirt-6.9.0

2020-11-03 Thread Andrea Bolognani
On Tue, 2020-11-03 at 12:40 +0100, Jiri Denemark wrote: > On Tue, Nov 03, 2020 at 11:11:48 +0100, Andrea Bolognani wrote: > > Would it make sense to include the release script in the git > > repository? libosinfo and friends already have something along those > > lines, though I'm unclear on the

Re: [PATCH-for-5.2 v3] hw/mips: Remove the 'r4k' machine

2020-11-03 Thread Peter Krempa
On Mon, Nov 02, 2020 at 21:13:11 +0100, Philippe Mathieu-Daudé wrote: > We deprecated the support for the 'r4k' machine for the 5.0 release > (commit d32dc61421), which means that our deprecation policy allows > us to drop it in release 5.2. Remove the code. > > To repeat the rationale from the

[PATCH 4/4] qemu_conf: Don't even attempt to enable rememberOwner if unsupported

2020-11-03 Thread Michal Privoznik
The remember owner feature uses XATTRs to store original seclabels. But that means we don't want a regular user to be able to change what we stored and thus trick us into setting different seclabel. Therefore, we use namespaces that are reserved to CAP_SYS_ADMIN only. Such namespaces exist on

[PATCH 3/4] qemusecuritytest: Skip on non supported platforms

2020-11-03 Thread Michal Privoznik
For seclabel remembering we need to have XATTRs and a special namespace that is accessibly to CAP_SYS_ADMIN only (we don't want regular users to trick us into restoring to a different label). And what qemusecuritytest does is it checks whether we have not left any path behind with XATTRs or not

[PATCH 0/4] Couple of qemusecuritytest and security_util improvements

2020-11-03 Thread Michal Privoznik
These were sparked by a discussion on the list where the test is failing on macOS. Michal Prívozník (4): security_util: Don't error on macOS when getting/setting/moving XATTRs qemusecuritytest: Test SELinux too qemusecuritytest: Skip on non supported platforms qemu_conf: Don't even

[PATCH 2/4] qemusecuritytest: Test SELinux too

2020-11-03 Thread Michal Privoznik
The qemusecuritytest checks for random domain XMLs from qemuxml2argvdata/ whether set+restore seclabels leaves something behind. It can be an XATTR that we forgot to remove or a file that the owner was not restored on. But so far only DAC driver is checked. Implement missing pieces and enable

[PATCH 1/4] security_util: Don't error on macOS when getting/setting/moving XATTRs

2020-11-03 Thread Michal Privoznik
There are three internal APIs implemented in this security_util file: virSecurityGetRememberedLabel(), virSecuritySetRememberedLabel() and virSecurityMoveRememberedLabel() for getting, setting and moving remembered seclabel. All three have a special return value of -2 when XATTRs are not supported

[libvirt PATCH 20/25] vircgroup: introduce virCgroupSetPlacement

2020-11-03 Thread Pavel Hrdina
Currently this task is done by virCgroupCopyPlacement when the @path starts with "/". virCgroupNew is always called with @path starting with "/" and there is no parent to copy path from. To make it obvious what the code is doing introduce new helper. Signed-off-by: Pavel Hrdina ---

[libvirt PATCH 14/25] vircgroup: introduce virCgroupNewParent

2020-11-03 Thread Pavel Hrdina
The current code uses virCgroupNew() as a single point of entry and calls into virCgroupDetect() as well. Both have logic for several paths which is difficult to figure out. Extract the actually used code path from the two functions to make it obvious what's happening in this case.

[libvirt PATCH 15/25] vircgroup: drop @parent from virCgroupNew

2020-11-03 Thread Pavel Hrdina
Now it is always NULL. Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 40 +--- src/util/vircgrouppriv.h | 1 - src/util/vircgroupv1.c | 2 +- 3 files changed, 14 insertions(+), 29 deletions(-) diff --git a/src/util/vircgroup.c

[libvirt PATCH 04/25] vircgroupv2: properly detect empty tasks

2020-11-03 Thread Pavel Hrdina
With cgroups v2 the file cgroup.procs will never be empty if threading is enabled as it will always have ID of all processes even if all threads of the processes are moved to sub-cgroups. If that happens the file cgroup.threads will be empty. Signed-off-by: Pavel Hrdina ---

[libvirt PATCH 22/25] vircgroup: refactor virCgroupEnableMissingControllers

2020-11-03 Thread Pavel Hrdina
Use virStringSplit() to get the list of directories needed to be created. This improves readability of the code and stops passing absolute path to virCgroupNewFromParent(). Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 26 -- 1 file changed, 8 insertions(+), 18

[libvirt PATCH 07/25] vircgroup: remove useless cgroup->path variable

2020-11-03 Thread Pavel Hrdina
It is only used for debug and error purposes which can be easily replaced by @placement. Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 20 ++-- src/util/vircgrouppriv.h | 2 -- src/util/vircgroupv1.c | 8 +++- src/util/vircgroupv2.c | 4 +---

[libvirt PATCH 21/25] vircgroup: drop @create from virCgroupNewDomainPartition

2020-11-03 Thread Pavel Hrdina
All callers pass true. Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 5 + src/util/vircgrouppriv.h | 1 - tests/vircgrouptest.c| 4 ++-- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 00967ea5fa..1e18b84b54

[libvirt PATCH 17/25] vircgroup: expand virCgroupDetect into virCgroupNew

2020-11-03 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 52 +++- 1 file changed, 18 insertions(+), 34 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 794680d696..81aa3ee791 100644 --- a/src/util/vircgroup.c +++

[libvirt PATCH 23/25] vircgroup: move parentPath declaration

2020-11-03 Thread Pavel Hrdina
It's used only inside the if condition. Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index f4c1623567..6caeb2d7f4 100644 --- a/src/util/vircgroup.c +++

[libvirt PATCH 02/25] qemu: remove dead code that setup cgroups for helper processes

2020-11-03 Thread Pavel Hrdina
In both cases priv->cgroup will always be NULL because it is called before the QEMU process is started and cgroups are configured. In qemuProcessLaunch() the call order is following: qemuExtDevicesStart() ... virCommandRun() ... qemuSetupCgroup() where qemuDBusStart() is

[libvirt PATCH 06/25] vircgroupv2: detect controllers enabled in parent cgroup

2020-11-03 Thread Pavel Hrdina
With cgroups v2 working with controllers is a bit more complicated then with cgroups v1 where the controller had to be mounted. There are two files, cgroups.controllers and cgroup.subtree_control. The file cgroup.controllers lists all controllers enabled in the current cgroup and

[libvirt PATCH 13/25] vircgroup: extract virCgroupNewDetect from virCgroupNew

2020-11-03 Thread Pavel Hrdina
The current code uses virCgroupNew() as a single point of entry and calls into virCgroupDetect() as well. Both have logic for several paths which is difficult to figure out. Extract the actually used code path from the two functions to make it obvious what's happening in this case.

[libvirt PATCH 16/25] vircgroup: virCgroupNew is now always called with absolute path

2020-11-03 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 56aa9cc064..794680d696 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -457,10 +457,8 @@

[libvirt PATCH 00/25] cgroup related fixes and cleanup

2020-11-03 Thread Pavel Hrdina
Pavel Hrdina (25): qemu_cgroup: remove unused @empty variable qemu: remove dead code that setup cgroups for helper processes qemu_dbus: use emulator cgroup for dbus-daemon vircgroupv2: properly detect empty tasks vircgroupv2: properly detect placement of running VM vircgroupv2: detect

[libvirt PATCH 09/25] vircgroup: introduce virCgroupCopyMounts helper

2020-11-03 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 3db20ed262..a30aec4e5e 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -239,6

[libvirt PATCH 05/25] vircgroupv2: properly detect placement of running VM

2020-11-03 Thread Pavel Hrdina
When libvirtd starts a VM it internally stores a path to the main cgroup. When we restart libvirtd we should get to the same state. When we start a VM on host with systemd the cgroup is created for us and the process is already placed into that cgroup and we detect the path created by systemd

[libvirt PATCH 08/25] vircgroup: introduce virCgroupSetBackends helper

2020-11-03 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 44 1 file changed, 28 insertions(+), 16 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 7ff23e1218..3db20ed262 100644 --- a/src/util/vircgroup.c +++

[libvirt PATCH 25/25] vircgroup: drop condition for absolute path from copyPlacement callbacks

2020-11-03 Thread Pavel Hrdina
Now that every caller to copyPlacement doesn't pass absolute path there is no need to have a condition to handle that case. Signed-off-by: Pavel Hrdina --- src/util/vircgroupv1.c | 26 -- src/util/vircgroupv2.c | 25 +++-- 2 files changed, 23

[libvirt PATCH 18/25] vircgroup: no need to use PID in virCgroupEnableMissingControllers

2020-11-03 Thread Pavel Hrdina
This function is relevant only with cgroups v1 where it creates hierarchy for controllers that are not managed by systemd. PID is used to detect a placement of current process but in this situation we are building the hierarchy for already known placement. Signed-off-by: Pavel Hrdina ---

[libvirt PATCH 12/25] vircgroup: introduce virCgroupDetectControllers helper

2020-11-03 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 51 1 file changed, 33 insertions(+), 18 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 55fa49a398..f21a581946 100644 --- a/src/util/vircgroup.c +++

[libvirt PATCH 03/25] qemu_dbus: use emulator cgroup for dbus-daemon

2020-11-03 Thread Pavel Hrdina
All other helper processes are moved to cgroup with QEMU emulator thread as we keep the root VM cgroup without any processes. This assumption is validated in qemuRestoreCgroupState() which is called when libvirtd is restarted and reconnected to all running VMs. Signed-off-by: Pavel Hrdina ---

[libvirt PATCH 01/25] qemu_cgroup: remove unused @empty variable

2020-11-03 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/qemu/qemu_cgroup.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 210cac9866..10fdc7444d 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -988,7 +988,6 @@ static

[libvirt PATCH 11/25] vircgroup: introduce virCgroupValidatePlacement helper

2020-11-03 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index b5f38210fb..55fa49a398 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -393,6

[libvirt PATCH 24/25] vircgroup: refactor virCgroupNewPartition

2020-11-03 Thread Pavel Hrdina
The old code passed an absolute path to virCgroupNewFromParent() which is not necessary. The code can take the current placement of parent cgroup and append a relative path. Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 18 ++ 1 file changed, 14 insertions(+), 4

[libvirt PATCH 19/25] vircgroup: drop @pid argument from virCgroupNew

2020-11-03 Thread Pavel Hrdina
Now it is always -1. Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 16 +++- src/util/vircgrouppriv.h | 3 +-- src/util/vircgroupv1.c | 2 +- 3 files changed, 9 insertions(+), 12 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index

[libvirt PATCH 10/25] vircgroup: introduce virCgroupCopyPlacement helper

2020-11-03 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index a30aec4e5e..b5f38210fb 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -294,6

Re: Release of libvirt-6.9.0

2020-11-03 Thread Jiri Denemark
On Tue, Nov 03, 2020 at 11:11:48 +0100, Andrea Bolognani wrote: > On Mon, 2020-11-02 at 19:35 +0100, Jiri Denemark wrote: > > On Mon, Nov 02, 2020 at 12:09:13 +0100, Andrea Bolognani wrote: > > > On Mon, 2020-11-02 at 11:20 +0100, Jiri Denemark wrote: > > > [...] > > > > * Improvements > > > > >

[libvirt][PATCH v1 0/1] support system default memory policy with numatune

2020-11-03 Thread Luyao Zhong
Hi libvirt experts, -- what does this patch support -- This patch seeks the support of system default memory policy when numatune is configured. Before this patch, numatune only has three memory modes: static, interleave and prefered. These memory policies are ultimately set by

[libvirt][PATCH v1 1/1] support system default memory policy with numatune

2020-11-03 Thread Luyao Zhong
This patch seeks the support of system default memory policy when numatune is configured. Before this patch, numatune only has three memory modes: static, interleave and prefered. These memory policies are ultimately set by mbind() system call. Memory policy could be 'hard coded' into the kernel,

Re: [PATCH 0/8] more Hyper-V code cleanup

2020-11-03 Thread Michal Privoznik
On 11/3/20 1:22 AM, Matt Coleman wrote: Here's a draft GitLab MR if you'd prefer to review the changes there: https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/5 Matt Coleman (8): hyperv: g_autofree username and password in hypervConnectOpen() hyperv: remove spaces after

Re: Release of libvirt-6.9.0

2020-11-03 Thread Andrea Bolognani
On Mon, 2020-11-02 at 19:35 +0100, Jiri Denemark wrote: > On Mon, Nov 02, 2020 at 12:09:13 +0100, Andrea Bolognani wrote: > > On Mon, 2020-11-02 at 11:20 +0100, Jiri Denemark wrote: > > [...] > > > * Improvements > > > > > > * Bug fixes > > > > It would have been nice if you had removed the

Re: Libvirt Open Source Contribution

2020-11-03 Thread Michal Privoznik
On 11/3/20 12:47 AM, Barrett J Schonefeld wrote: Hey folks, We have started work on issue 11 , and we have some questions to ensure we tackle the issue properly. - What are the different use cases for g_autoptr vs g_autofree? We found

Re: Call for Volunteers: Summaries of a few KVMForum-2020 talks for an LWN article

2020-11-03 Thread Kashyap Chamarthy
On Thu, Oct 29, 2020 at 03:27:07PM +0100, Kashyap Chamarthy wrote: > Hi, folks > > Like last year[1], we're aiming to submit a KVM Forum 2020 "recap" > article for LWN. > > This won't be a comprehensive summary of a lot of talks — LWN normally > aims for 1500 words; they say "fewer can sometimes