[libvirt PATCH 2/5] meson: Use initconfdir

2023-05-02 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- docs/manpages/libvirt-guests.rst| 2 +- docs/manpages/meson.build | 1 + src/ch/virtchd.service.in | 2 +- src/interface/virtinterfaced.service.in | 2 +- src/libxl/virtxend.service.in | 2 +-

[libvirt PATCH 3/5] rpm: Set initconfdir explicitly

2023-05-02 Thread Andrea Bolognani
The default would already work fine for Fedora and RHEL, but it's better to be explicit. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index dae9c87aa4..c542ec3b2b 100644 --- a/libvirt.spec.in +++

[libvirt PATCH 5/5] meson: Improve initconfdir defaults

2023-05-02 Thread Andrea Bolognani
Keep /etc/sysconfig as the fallback, but pick more suitable values for various Linux distros. Signed-off-by: Andrea Bolognani --- meson.build | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 8848e58995..f04703b810 100644 ---

[libvirt PATCH 1/5] meson: Introduce initconfdir option

2023-05-02 Thread Andrea Bolognani
Right now we expect the configuration files for init scripts to live in /etc/sysconfig, but that location is only used by RHEL- and SUSE-derived distros. This means that packagers for other distros have to patch things as part of the build process, while people building from source will get wonky

[libvirt PATCH 4/5] meson: Move definition of os_release

2023-05-02 Thread Andrea Bolognani
We're about to introduce another user of the value in a different scope. Signed-off-by: Andrea Bolognani --- meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 8da987b1cb..8848e58995 100644 --- a/meson.build +++ b/meson.build @@

[libvirt PATCH 0/5] meson: Introduce initconfdir option

2023-05-02 Thread Andrea Bolognani
Makes things nicer for those using distros that are not derived from RHEL or SUSE. Andrea Bolognani (5): meson: Introduce initconfdir option meson: Use initconfdir rpm: Set initconfdir explicitly meson: Move definition of os_release meson: Improve initconfdir defaults

[libvirt PATCH] meson: Fix qemu_{user,group} defaults for Arch

2023-05-02 Thread Andrea Bolognani
The current values might have been accurate at the time when the logic was introduced, but these days Arch is using the same ones as Debian. Signed-off-by: Andrea Bolognani --- Proof that I'm not making this up:

Re: [libvirt PATCH 03/28] util: determine ignoreErrors value when creating rule, not when applying

2023-05-02 Thread Michal Prívozník
On 5/1/23 05:19, Laine Stump wrote: > We know at the time a virFirewallRule is created (with > virFirewallAddRule*()) whether or not we will later want to ignore > errors encountered when attempting to apply that rule - if > ignoreErrors is set in the AddRule or if the group has already had >

Re: [libvirt PATCH 05/28] util: move backend-agnostic virNetfilter*() functions to their own file

2023-05-02 Thread Michal Prívozník
On 5/1/23 05:19, Laine Stump wrote: > These function are all moved into virnetfilter.[ch]. The only > functions from viriptables.[ch] that are still called from the > consumer (network bridge driver) are iptablesSetupPrivateChains() > (which creates the private chains that all iptables rules will

Re: [libvirt PATCH 13/28] network: call backend agnostic function to init private filter chains

2023-05-02 Thread Michal Prívozník
On 5/1/23 05:19, Laine Stump wrote: > Instead of calling iptableSetupPrivateChains(), the network driver now > calls virNetfilterSetupPrivateChains() (which right now always calls > the iptables version of the function, but in the future might instead > call the nftables version). > >

Re: [PATCH v1] use libexecdir as location for qemu-bridge-helper

2023-05-02 Thread Olaf Hering
Tue, 2 May 2023 14:47:20 +0100 Andrea Bolognani : > I have patches for turning these build time lookups into runtime lookups > almost ready. I'm curious, and will wait for these changes to appear in #master. Olaf pgpIWg7XPw4Jf.pgp Description: Digitale Signatur von OpenPGP

Re: [PATCH v1] use libexecdir as location for qemu-bridge-helper

2023-05-02 Thread Andrea Bolognani
On Tue, May 02, 2023 at 02:37:03PM +0200, Olaf Hering wrote: > The current logic in meson.build assumes a fixed runtime path for > qemu-bridge-helper in case this binary is not available during build. > Since qemu-bridge-helper is not used during build it is not required to > have it installed at

[PATCH v3] vfio/pci: Propagate ACPI notifications to user-space via eventfd

2023-05-02 Thread Grzegorz Jaszczyk
From: Grzegorz Jaszczyk To allow pass-through devices receiving ACPI notifications, permit to register ACPI notify handler (via introduced new ioctl) for a given device. The handler role is to receive and propagate such ACPI notifications to the user-space through the user provided eventfd. This

[PATCH v1] use libexecdir as location for qemu-bridge-helper

2023-05-02 Thread Olaf Hering
The current logic in meson.build assumes a fixed runtime path for qemu-bridge-helper in case this binary is not available during build. Since qemu-bridge-helper is not used during build it is not required to have it installed at build time. It is likely that both qemu and libvirt are built with

Release of libvirt-9.3.0

2023-05-02 Thread Jiri Denemark
The 9.3.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing

Re: [PATCH] NEWS: Update news for the 9.3.0 release

2023-05-02 Thread Ján Tomko
On a Tuesday in 2023, Peter Krempa wrote: Update the news file mentioning important changes such as the change of translatable strings or the fix of inactive snapshots of VMs using uefi. Signed-off-by: Peter Krempa --- NEWS.rst | 53 + 1 file

[PATCH] NEWS: Update news for the 9.3.0 release

2023-05-02 Thread Peter Krempa
Update the news file mentioning important changes such as the change of translatable strings or the fix of inactive snapshots of VMs using uefi. Signed-off-by: Peter Krempa --- NEWS.rst | 53 + 1 file changed, 53 insertions(+) diff --git

Re: [PATCH v3 00/10] Deprecate/rename singlestep command line option, monitor interfaces

2023-05-02 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 17 Apr 2023 at 17:40, Peter Maydell wrote: >> >> The command line option '-singlestep' and its HMP equivalent >> the 'singlestep' command are very confusingly named, because >> they have nothing to do with single-stepping the guest (either >> via the gdb stub or

Re: [PATCH v3 00/10] Deprecate/rename singlestep command line option, monitor interfaces

2023-05-02 Thread Peter Maydell
On Mon, 17 Apr 2023 at 17:40, Peter Maydell wrote: > > The command line option '-singlestep' and its HMP equivalent > the 'singlestep' command are very confusingly named, because > they have nothing to do with single-stepping the guest (either > via the gdb stub or by emulation of guest CPU

Re: [PATCH] virpci: Resolve leak in virPCIVirtualFunctionList cleanup

2023-05-02 Thread Ján Tomko
On a Monday in 2023, Tim Shearer wrote: Repeatedly querying an SR-IOV PCI device's capabilities exposes a memory leak caused by a failure to free the virPCIVirtualFunction array within the parent struct's g_autoptr cleanup. Valgrind output after getting a single interface's XML description 1000