Signed-off-by: Jonathon Jongsma
---
I put this under 'Improvements' since it's not really intended to be a
user-visible feature, but it could be moved to 'New Features' instead...
NEWS.rst | 9 +
1 file changed, 9 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index
On 9/19/23 2:44 AM, Peter Krempa wrote:
On Thu, Aug 31, 2023 at 16:39:40 -0500, Jonathon Jongsma wrote:
[...]
Jonathon Jongsma (37):
schema: allow 'ssh' as a protocol for network disks
qemu: Add functions for determining nbdkit availability
qemu: expand nbdkit capabilities
util:
Signed-off-by: Jonathon Jongsma
---
NEWS.rst | 9 +
1 file changed, 9 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 926620b03f..b57ba5c7d1 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -23,6 +23,15 @@ v9.8.0 (unreleased)
* **New features**
+ * qemu: Add support for vDPA block
Jonathon Jongsma (2):
news: document support for vdpa block devices
news: document nbdkit support for network disks
NEWS.rst | 18 ++
1 file changed, 18 insertions(+)
--
2.41.0
On 9/19/23 06:50, Michal Prívozník wrote:
On 9/18/23 19:16, Jim Fehlig wrote:
When Domain-0 autoballooning is enabled, it's possible that memory may
need to be ballooned down in Domain-0 to accommodate the needs of another
virtual machine. libxlDomainFreeMemory handles this task, but due to a
On Tue, Sep 19, 2023 at 10:34:25AM -0400, Laine Stump wrote:
> On 9/18/23 3:20 PM, Praveen Paladugu wrote:
> >Folks,
> >
> >I am working on upstreaming network support for ch driver. Like qemu
> >driver,ch
> >driver invokes steps in qemuInterfaceEthernetConnect,
> >qemuInterfaceBridgeConnect
On 9/18/23 3:20 PM, Praveen Paladugu wrote:
Folks,
I am working on upstreaming network support for ch driver. Like qemu driver,ch
driver invokes steps in qemuInterfaceEthernetConnect,
qemuInterfaceBridgeConnect methods to connect tap devices to appropriate
host backends.
Current implementation
On 9/18/23 19:16, Jim Fehlig wrote:
> When Domain-0 autoballooning is enabled, it's possible that memory may
> need to be ballooned down in Domain-0 to accommodate the needs of another
> virtual machine. libxlDomainFreeMemory handles this task, but due to a
> logic bug is underflowing the variable
On 9/3/23 17:49, K Shiva Kiran wrote:
> Signed-off-by: K Shiva Kiran
> ---
> src/conf/nwfilter_conf.c | 30 ++
> src/conf/nwfilter_conf.h | 5 +
> 2 files changed, 35 insertions(+)
Here, I'd also expect a test case. Either introduce a new test case to
On 9/3/23 17:49, K Shiva Kiran wrote:
> Adds enum `virNWFilterMetadataType` to choose between ``,
> `` or ``.
>
> Signed-off-by: K Shiva Kiran
> ---
> include/libvirt/libvirt-nwfilter.h | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/include/libvirt/libvirt-nwfilter.h
On 9/3/23 17:49, K Shiva Kiran wrote:
> Signed-off-by: K Shiva Kiran
> ---
> include/libvirt/virterror.h | 1 +
> src/util/virerror.c | 3 +++
> 2 files changed, 4 insertions(+)
>
> diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h
> index 224eddc9e4..ffb47a3242
On 9/3/23 17:49, K Shiva Kiran wrote:
> Signed-off-by: K Shiva Kiran
> ---
> docs/formatnwfilter.rst | 31 +++
> src/conf/schemas/nwfilter.rng | 9 +
> 2 files changed, 40 insertions(+)
This patch alone does not make any sense. Merge it into 02/16.
On 9/3/23 17:49, K Shiva Kiran wrote:
> Signed-off-by: K Shiva Kiran
> ---
> src/remote/remote_driver.c | 2 ++
> src/remote/remote_protocol.x | 34 +-
> src/remote_protocol-structs | 19 +++
> 3 files changed, 54 insertions(+), 1 deletion(-)
On 9/3/23 17:49, K Shiva Kiran wrote:
> Introduces `virNWFilterGetMetadata()` to retrieve user defined
> metadata fields, i.e ``, `` and ``
>
> Signed-off-by: K Shiva Kiran
> ---
> include/libvirt/libvirt-nwfilter.h | 5 +++
> src/driver-nwfilter.h | 6 +++
>
On 9/3/23 17:49, K Shiva Kiran wrote:
> Signed-off-by: K Shiva Kiran
> ---
> tools/virsh-util.c | 25 +
> tools/virsh-util.h | 9 +
> 2 files changed, 34 insertions(+)
>
> diff --git a/tools/virsh-util.h b/tools/virsh-util.h
> index 2386847072..4cad3d7eb9
On 9/3/23 17:49, K Shiva Kiran wrote:
> This command can be used to view/modify the `` and
> `` fields of the NWFilter object.
>
> Signed-off-by: K Shiva Kiran
> ---
> tools/virsh-nwfilter.c | 209 +
> 1 file changed, 209 insertions(+)
The documentation
On 9/3/23 17:49, K Shiva Kiran wrote:
> This patchset adds support for the following user defined metadata
> fields for network filters.
>
> - title: A short description of the filter.
> - description: Any documentation that the user wants to store.
> - metadata: Other metadata in XML form.
>
>
On Tue, Sep 19, 2023 at 11:15:05AM +0200, Erik Skultety wrote:
> Unfortunately, once we go down the line of running our own scripts as
> part of GitLab CI jobs rather than open coding Shell in YAML, we lose
> the benefit of seeing each line the script executes. The downside of
> the default YAML
On Tue, Sep 19, 2023 at 11:15:04AM +0200, Erik Skultety wrote:
> We've started using the run_cmd helper function to log what kind of
> command is being executed as well as actually executing the command.
> The problem however is doing I/O redirections for commands which we
> don't wish to see any
send-email scans the commit messages to figure out the default set of
addresses to put into CC, Acked-by/Reviewed-by, etc-by being among
them. We're quite strict about CC-ing people on libvirt-list, since
most developers are subscribed to the list anyway. Respect the rule by
avoiding CCing people
We needed v98.0 in commit c9a65eb8 due to a bug in Avocado in the past
and have been installing the latest Avocado for a while since commit
91774931, yet we kept the comment by a mistake.
Besides, looks like v98.0 ignores the avocado.config file in the TCK
repo instructing it to run the test
Unfortunately, once we go down the line of running our own scripts as
part of GitLab CI jobs rather than open coding Shell in YAML, we lose
the benefit of seeing each line the script executes. The downside of
the default YAML however is that we have to maintain the same piece of
code on 2 places
All supported versions of Fedora and CentOS Stream 9 default to modular
setup, it's probably better if we cosmetically adjust the CentOS Stream
version check to make it explicit that monolithic daemon services ought
to be started only on Stream 8.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel
Neither '&>' nor 'source' are defined in POSIX.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
---
ci/jobs.sh | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/ci/jobs.sh b/ci/jobs.sh
index 37bca452fa..b52e45cc8c 100644
--- a/ci/jobs.sh
+++ b/ci/jobs.sh
Running outside of GitLab will likely not have the variable set and
hence the execution would fail. To make sure we always start with a
clean scratch dir (which may or may not be the best thing), create it
with 'mktemp'. The main reason for a temporary directory is to ensure a
clean environment
We've not been interested in any extra output from the command at all
since we always redirected both stdout and stderr to /dev/null. Future
patch will change that slightly, so --quiet will start making sense.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
---
ci/jobs.sh | 2 +-
We've started using the run_cmd helper function to log what kind of
command is being executed as well as actually executing the command.
The problem however is doing I/O redirections for commands which we
don't wish to see any output for whatever reason. Now, if the
redirection is applied at
Since the section now only consists of a single command, we can happily
move the command to the main integration template job body.
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
---
ci/integration-template.yml | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff
One advantage that GitLab's YAML has with Shell commands is that every
single line is printed out as is, including control structures. In
order to see whether the logic did the same thing and the tests are
going to operate on the right set of daemons (monolithic vs modular),
lets print the DAEMONS
v1 here:
https://listman.redhat.com/archives/libvir-list/2023-September/242121.html
Since v1:
- introduced a new run_cmd_quiet helper function instead of using eval to deal
with Shell redirections
- added more info from the POSIX standard on test's -a,-o options
- added commit references to
Because of the nature of writing inline shell commands to YAML, most of
the commentaries where inlined with the command not to hinder YAML
readability any further. Since we moved the logic to a standalone
script, we can now do whatever formatting & readability adjustments we
want.
Signed-off-by:
Apparently we've only had it because the -[ao] options weren't portable
at the time, but according to
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html
both are defined in POSIX.1-2017 revision which is old enough for all
our supported platforms to have adopted it already, so
Follow what's been done to other jobs in .gitlab-ci.yml and extract the
shell logic from YAML to a function in ci/jobs.sh
Signed-off-by: Erik Skultety
Reviewed-by: Daniel P. Berrangé
---
ci/integration-template.yml | 36 ++--
ci/jobs.sh | 32
On Thu, Aug 31, 2023 at 16:39:40 -0500, Jonathon Jongsma wrote:
[...]
> Jonathon Jongsma (37):
> schema: allow 'ssh' as a protocol for network disks
> qemu: Add functions for determining nbdkit availability
> qemu: expand nbdkit capabilities
> util: Allow virFileCache data to be any
As can be seen from previous commits, it's fairly easy to pass a
different type to virReportEnumRangeError() than the actual
variable is of. So far, we have a sizeof() hack to check if some
nonsensical types are not passed, e.g. it catches cases where a
function name is passed instead of an enum.
This allows us to declare variables without using 'enum
virNetDev' and will become more useful in the near future
(when virReportEnumRangeError() is fixed).
Signed-off-by: Michal Privoznik
---
src/util/virnetdevvportprofile.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
The @virtPortOp variable inside of virNetDevVPortProfileOp8021Qbh
is of type virNetDevVPortProfileLinkOp. Pass the proper type to
virReportEnumRangeError().
Signed-off-by: Michal Privoznik
---
src/util/virnetdevvportprofile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The @backend member of _virDomainVideoDef struct is of type
virDomainVideoBackendType. Pass the proper type to
virReportEnumRangeError().
Signed-off-by: Michal Privoznik
---
src/conf/domain_validate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/domain_validate.c
There are few cases where virReportEnumRangeError() is passed to a
mismatching enum. With patch 4/4 we can check for this at compile time
(assuming -Wenum-compare is available).
For instance with clang I get:
FAILED: src/conf/libvirt_conf.a.p/domain_validate.c.o
clang ...
39 matches
Mail list logo
